> +/**
quoted text > + * rol16 - rotate a 16-bit value left
> + * @word: value to rotate
> + * @shift: bits to roll
> + */
> +static inline __u16 rol16(__u16 word, unsigned int shift)
> +{
> + return (word << shift) | (word >> (16 - shift));
> +}
This doesn't work for shift values of 0: you get word >> 16, and
shifts greater than or equal to the word size aren't valid C. GCC
will warn about this, too.
Segher
--
unsubscribe notice To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to
majordomo@vger.kernel.org
More majordomo info at
http://vger.kernel.org/majordomo-info.html
Please read the FAQ at
http://www.tux.org/lkml/
Messages in current thread:
Re: [PATCH] bitops: add 8-bit and 16-bit rotation functions , Segher Boessenkool , (Tue Mar 11, 1:45 pm)