login
Login
/
Register
Search
Search this site:
Forums
News
Blogs
Features
Site
Home
»
Mailing list archives
»
linux-kernel
»
2008
»
March
»
11
Re: [PATCH] [2/3] add WARN_ON_SECS macro
view
thread
Previous message: [
thread
] [
date
] [
author
]
Next message: [
thread
] [
date
] [
author
]
[view in full thread]
From: Marcin Slusarz
Subject:
Re: [PATCH] [2/3] add WARN_ON_SECS macro
Date: Tuesday, March 11, 2008 - 12:20 pm
On Mon, Mar 10, 2008 at 02:34:37PM +0800, Dave Young wrote:
quoted text
> Add WARN_ON_SECS macro for some serious case which need repeat the > warnings, but with some ratelimit. > > Signed-off-by: Dave Young <hidave.darkstar@gmail.com> > > --- > include/asm-generic/bug.h | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff -upr linux/include/asm-generic/bug.h linux.new/include/asm-generic/bug.h > --- linux/include/asm-generic/bug.h 2008-03-10 13:27:03.000000000 +0800 > +++ linux.new/include/asm-generic/bug.h 2008-03-10 13:27:14.000000000 +0800 > @@ -3,6 +3,7 @@ > > #include <linux/compiler.h> > > + > #ifdef CONFIG_BUG > > #ifdef CONFIG_GENERIC_BUG > @@ -75,6 +76,13 @@ extern void warn_on_slowpath(const char > unlikely(__ret_warn_once); \ > }) > > +#define WARN_ON_SECS(condition, secs) ({ \ > + int __ret_warn_on = !!(condition); \ > + if (unlikely(__ret_warn_on)) \ > + if (__ratelimit(secs * HZ, 1)) \ > + WARN_ON(condition); \ > +}) > + > #ifdef CONFIG_SMP > # define WARN_ON_SMP(x) WARN_ON(x) > #else
Do you really want to check the condition twice? Marcin --
unsubscribe notice
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to
majordomo@vger.kernel.org
More majordomo info at
http://vger.kernel.org/majordomo-info.html
Please read the FAQ at
http://www.tux.org/lkml/
Previous message: [
thread
] [
date
] [
author
]
Next message: [
thread
] [
date
] [
author
]
Messages in current thread:
[PATCH] [2/3] add WARN_ON_SECS macro
, Dave Young
, (Sun Mar 9, 11:34 pm)
Re: [PATCH] [2/3] add WARN_ON_SECS macro
, Marcin Slusarz
, (Tue Mar 11, 12:20 pm)
Re: [PATCH] [2/3] add WARN_ON_SECS macro
, Dave Young
, (Tue Mar 11, 5:37 pm)
Navigation
Mailing list archives
Recent posts
Popular discussions
linux-kernel
:
Ken Chen
[patch] sched: fix inconsistency when redistribute per-cpu tg->cfs_rq shares.
Ingo Molnar
Re: [PATCH v3] x86: merge the simple bitops and move them to bitops.h
Jan Engelhardt
Re: [PATCH] Allow Kconfig to set default mmap_min_addr protection
Dmitry Torokhov
Re: [2.6 patch] input/serio/hp_sdc.c section fix
Rafael J. Wysocki
[Bug #16380] Loop devices act strangely in 2.6.35
git
:
Steven Grimm
Using git as a general backup mechanism (was Re: Using GIT to store /etc)
Jeff King
Re: [PATCH] git-reset: allow --soft in a bare repo
Johannes Sixt
Re: [PATCH 01/14] msvc: Fix compilation errors in compat/win32/sys/poll.c
Johannes Schindelin
Re: [PATCH] Uninstall rule for top level Makefile
Shawn O. Pearce
Re: [PATCH v2] Speed up bash completion loading
git-commits-head
:
Linux Kernel Mailing List
cgroups: clean up cgroup_pidlist_find() a bit
Linux Kernel Mailing List
sony-laptop: Add support for extended hotkeys
Linux Kernel Mailing List
IB/core: Add support for masked atomic operations
Linux Kernel Mailing List
V4L/DVB (8939): cx18: fix sparse warnings
Linux Kernel Mailing List
ipv6 mcast: Check address family of gf_group in getsockopt(MS_FILTER).
linux-netdev
:
Inaky Perez-Gonzalez
[PATCH 40/40] wimax/i2400m: add CREDITS and MAINTAINERS entries
Karsten Keil
[mISDN PATCH v2 05/19] Reduce stack size in dsp_cmx_send()
linux
Re: 2.6.23-rc8 network problem. Mem leak? ip1000a?
David Miller
Re: tun: Use netif_receive_skb instead of netif_rx
David Miller
Re: [net-next PATCH v2] llc enhancements
freebsd-current
:
Matthew Fleming
Re: [RFC] Outline of USB process integration in the kernel taskqueue system
illoai@gmail.com
Re: OT: 2d password
Hartmut Brandt
Re: problem with nss_ldap
Andrew Reilly
Re: FreeBSD's problems as seen by the BSDForen.de community
Max Laier
Re: Upcoming ABI Breakage in RELENG_7
Colocation donated by:
Syndicate