login
Header Space

 
 

[PATCH 2/2] SVCRDMA: Fix erroneous BUG_ON in send_write

Score:
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: Linus Torvalds <torvalds@...>
Cc: <linux-nfs@...>, <linux-kernel@...>, Tom Tucker <tom@...>, J. Bruce Fields <bfields@...>
Date: Tuesday, March 11, 2008 - 2:31 pm

From: Tom Tucker <tom@opengridcomputing.com>

The assertion that checks for sge context overflow is
incorrectly hard-coded to 32. This causes a kernel bug
check when using big-data mounts. Changed the BUG_ON to
use the computed value RPCSVC_MAXPAGES.

Signed-off-by: Tom Tucker <tom@opengridcomputing.com>
Signed-off-by: J. Bruce Fields <bfields@citi.umich.edu>
---
 net/sunrpc/xprtrdma/svc_rdma_sendto.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/net/sunrpc/xprtrdma/svc_rdma_sendto.c b/net/sunrpc/xprtrdma/svc_rdma_sendto.c
index 0598b22..981f190 100644
--- a/net/sunrpc/xprtrdma/svc_rdma_sendto.c
+++ b/net/sunrpc/xprtrdma/svc_rdma_sendto.c
@@ -156,7 +156,7 @@ static int send_write(struct svcxprt_rdma *xprt, struct svc_rqst *rqstp,
 	struct svc_rdma_op_ctxt *ctxt;
 	int ret = 0;
 
-	BUG_ON(sge_count >= 32);
+	BUG_ON(sge_count > RPCSVC_MAXPAGES);
 	dprintk("svcrdma: RDMA_WRITE rmr=%x, to=%llx, xdr_off=%d, "
 		"write_len=%d, xdr_sge=%p, sge_count=%d\n",
 		rmr, (unsigned long long)to, xdr_off,
-- 
1.5.4.rc2.60.gb2e62

--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
2 nfsd rdma bugfixes for 2.6.25, J. Bruce Fields, (Tue Mar 11, 2:31 pm)
[PATCH 2/2] SVCRDMA: Fix erroneous BUG_ON in send_write, J. Bruce Fields, (Tue Mar 11, 2:31 pm)
speck-geostationary