Re: [linux-pm] [PATCH] cpuidle: avoid singing capacitors

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: LKML <linux-kernel@...>, <linux-pm@...>, Pallipadi, Venkatesh <venkatesh.pallipadi@...>
Cc: Dave Jones <davej@...>, Andi Kleen <andi@...>, Alan Stern <stern@...>, Adam Belay <abelay@...>, Lee Revell <rlrevell@...>, Pavel Machek <pavel@...>
Date: Tuesday, March 11, 2008 - 3:51 am

I had a sudden surge of inspiration and decided to follow up on this
one a bit: 


I have now found a very hacky workaround that is slightly better than
disabling C3 altogether; making C3 exclusive to one core at a time. It
seems to kill the noise and the system now spends 50% in C3, instead of
0%.

I read somewhere that the Intel Duo:s have an extra low power mode that
is entered if both cores are suspended at the same time (disabling the
shared cache or something like that I guess). So perhaps that mode is
the culprit. I'm hoping there's a way to disable just that feature. Do
any of you know a way? Venkatesh perhaps?

Here's the patch I'm currently running at least:

diff --git a/drivers/cpuidle/governors/menu.c b/drivers/cpuidle/governors/menu.c
index 78d77c5..9a859fb 100644
--- a/drivers/cpuidle/governors/menu.c
+++ b/drivers/cpuidle/governors/menu.c
@@ -16,6 +16,8 @@
 
 #define BREAK_FUZZ     4       /* 4 us */
 
+static atomic_t cur_deep_cpu = ATOMIC_INIT(-1);
+
 struct menu_device {
        int             last_state_idx;
 
@@ -50,6 +52,13 @@ static int menu_select(struct cpuidle_device *dev)
                        break;
                if (s->exit_latency > pm_qos_requirement(PM_QOS_CPU_DMA_LATENCY))
                        break;
+
+               if (s->flags & CPUIDLE_FLAG_DEEP) {
+                       rmb();
+                       if (atomic_cmpxchg(&cur_deep_cpu, -1, dev->cpu) != -1)
+                               break;
+                       wmb();
+               }
        }
 
        data->last_state_idx = i - 1;
@@ -80,6 +89,11 @@ static void menu_reflect(struct cpuidle_device *dev)
        if (!(target->flags & CPUIDLE_FLAG_TIME_VALID))
                measured_us = USEC_PER_SEC / HZ;
 
+       if (atomic_read(&cur_deep_cpu) == dev->cpu) {
+               atomic_set(&cur_deep_cpu, -1);
+               wmb();
+       }
+
        /* Predict time remaining until next break event */
        if (measured_us + BREAK_FUZZ < data->expected_us - target->exit_latency) {
                data->predicted_us = max(measured_us, data->last_measured_us);


-- 
     -- Pierre Ossman

  Linux kernel, MMC maintainer        http://www.kernel.org
  PulseAudio, core developer          http://pulseaudio.org
  rdesktop, core developer          http://www.rdesktop.org
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[RFC][PATCH] cpuidle: avoid singing capacitors, Pierre Ossman, (Fri Feb 29, 2:38 pm)
[PATCH] cpuidle: avoid singing capacitors, Pierre Ossman, (Mon Mar 3, 4:18 pm)
Re: [PATCH] cpuidle: avoid singing capacitors, Pavel Machek, (Mon Mar 3, 4:46 pm)
Re: [PATCH] cpuidle: avoid singing capacitors, Pierre Ossman, (Mon Mar 3, 5:03 pm)
Re: [PATCH] cpuidle: avoid singing capacitors, Pavel Machek, (Mon Mar 3, 5:08 pm)
RE: [PATCH] cpuidle: avoid singing capacitors, Pallipadi, Venkatesh, (Mon Mar 3, 5:14 pm)
Re: [PATCH] cpuidle: avoid singing capacitors, Pierre Ossman, (Mon Mar 3, 5:17 pm)
RE: [PATCH] cpuidle: avoid singing capacitors, Pallipadi, Venkatesh, (Mon Mar 3, 6:04 pm)
Re: [PATCH] cpuidle: avoid singing capacitors, Andi Kleen, (Mon Mar 3, 7:09 pm)
RE: [linux-pm] [PATCH] cpuidle: avoid singing capacitors, Pallipadi, Venkatesh, (Tue Mar 4, 3:01 pm)
Re: [linux-pm] [PATCH] cpuidle: avoid singing capacitors, Pierre Ossman, (Sun Mar 9, 10:16 am)
Re: [linux-pm] [PATCH] cpuidle: avoid singing capacitors, Pierre Ossman, (Tue Mar 11, 3:51 am)
Re: [linux-pm] [PATCH] cpuidle: avoid singing capacitors, Pierre Ossman, (Tue Mar 11, 11:20 am)
Re: [linux-pm] [PATCH] cpuidle: avoid singing capacitors, Pierre Ossman, (Tue Mar 11, 1:31 pm)
Re: [linux-pm] [PATCH] cpuidle: avoid singing capacitors, Pierre Ossman, (Mon Mar 10, 8:49 am)
Re: [linux-pm] [PATCH] cpuidle: avoid singing capacitors, Pierre Ossman, (Thu Mar 13, 12:34 pm)
Re: [linux-pm] [PATCH] cpuidle: avoid singing capacitors, Pierre Ossman, (Fri Mar 14, 3:40 pm)
RE: [linux-pm] [PATCH] cpuidle: avoid singing capacitors, Pallipadi, Venkatesh, (Fri Mar 14, 5:15 pm)
Re: [linux-pm] [PATCH] cpuidle: avoid singing capacitors, Pierre Ossman, (Fri Mar 14, 8:41 pm)
Re: [linux-pm] [PATCH] cpuidle: avoid singing capacitors, Pierre Ossman, (Thu Mar 13, 1:49 pm)
RE: [linux-pm] [PATCH] cpuidle: avoid singing capacitors, Pallipadi, Venkatesh, (Thu Mar 13, 12:47 pm)
Re: [linux-pm] [PATCH] cpuidle: avoid singing capacitors, Pierre Ossman, (Thu Mar 13, 1:44 pm)
Re: [linux-pm] [PATCH] cpuidle: avoid singing capacitors, Pierre Ossman, (Mon Mar 10, 9:29 am)
Re: [linux-pm] [PATCH] cpuidle: avoid singing capacitors, Henrique de Moraes Holschuh..., (Sun Mar 9, 3:30 pm)
Re: [linux-pm] [PATCH] cpuidle: avoid singing capacitors, Henrique de Moraes Holschuh..., (Sun Mar 9, 4:41 pm)
Re: [linux-pm] [PATCH] cpuidle: avoid singing capacitors, Henrique de Moraes Holschuh..., (Sun Mar 9, 4:54 pm)
Re: [linux-pm] [PATCH] cpuidle: avoid singing capacitors, Rafael J. Wysocki, (Sun Mar 9, 2:19 pm)
Re: [linux-pm] [PATCH] cpuidle: avoid singing capacitors, Pierre Ossman, (Wed Mar 5, 12:53 pm)
Re: [RFC][PATCH] cpuidle: avoid singing capacitors, Andi Kleen, (Mon Mar 3, 8:36 am)
Re: [RFC][PATCH] cpuidle: avoid singing capacitors, Lee Revell, (Sat Mar 1, 10:27 pm)
Re: [RFC][PATCH] cpuidle: avoid singing capacitors, Pierre Ossman, (Sun Mar 2, 10:17 am)
Re: [RFC][PATCH] cpuidle: avoid singing capacitors, Pierre Ossman, (Sat Mar 1, 9:40 am)
Re: [RFC][PATCH] cpuidle: avoid singing capacitors, Lennart Sorensen, (Fri Feb 29, 5:44 pm)
Re: [RFC][PATCH] cpuidle: avoid singing capacitors, Pierre Ossman, (Sat Mar 1, 8:31 am)