login
Header Space

 
 

[PATCH] signals: cleanup the usage of print_fatal_signal()

Score:
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: Andrew Morton <akpm@...>
Cc: Ingo Molnar <mingo@...>, Roland McGrath <roland@...>, <linux-kernel@...>
Date: Monday, March 10, 2008 - 5:17 pm

Move the callsite of print_fatal_signal() down, under
"if (sig_kernel_coredump(signr))", so we don't need to check signr != SIGKILL.

We are only interested in the sig_kernel_coredump() signals anyway, and due to
the previous changes we almost never can see other fatal signals here except
SIGKILL.

Signed-off-by: Oleg Nesterov <oleg@tv-sign.ru>

--- 25/kernel/signal.c~PFS_CLEANUP	2008-03-10 00:47:21.000000000 +0300
+++ 25/kernel/signal.c	2008-03-10 23:55:07.000000000 +0300
@@ -1766,9 +1766,10 @@ relock:
 		 * Anything else is fatal, maybe with a core dump.
 		 */
 		current->flags |= PF_SIGNALED;
-		if ((signr != SIGKILL) && print_fatal_signals)
-			print_fatal_signal(regs, signr);
+
 		if (sig_kernel_coredump(signr)) {
+			if (print_fatal_signals)
+				print_fatal_signal(regs, signr);
 			/*
 			 * If it was able to dump core, this kills all
 			 * other threads in the group and synchronizes with

--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[PATCH] signals: cleanup the usage of print_fatal_signal(), Oleg Nesterov, (Mon Mar 10, 5:17 pm)
speck-geostationary