linux-kernel mailing list

FromSubjectsort iconDate
Sven Wegener
[RFC] ipvs: Cleanup sync daemon code
Hi all, I'd like to get your feedback on this: - Use kthread_run instead of doing a double-fork via kernel_thread() - Return proper error codes to user-space on failures Currently ipvsadm --start-daemon with an invalid --mcast-interface will silently suceed. With these changes we get an appropriate "No such device" error. - Use wait queues for both master and backup thread Instead of doing an endless loop with sleeping for one second, we now use wait queues. The master sync daemon ha...
Feb 9, 7:38 pm 2008
Thomas Gleixner
[git pull] x86 updates
Linus, please pull the pending x86 updates from: ssh://master.kernel.org/pub/scm/linux/kernel/git/x86/linux-2.6-x86.git master The update contains: - a couple of bugfixes - CPA and DEBUG_PAGEALLOC improvements - x86 power management consolidation - GEODE updates - 32bit boot time page table construction rework - sparse and compile warning fixes - trivial cleanups There are two patches out of x86 scope as well: - lguest bugfix: x86 broke it, fix is o...
Feb 9, 7:24 pm 2008
Larry Finger
Query about set_pages_* API
Is the set_pages_* API that replaces change_page_attr described somewhere? I have been unable to find it with Google. I'm trying to modify the VirtualBox kernel module to work with 2.6.24-git (and 2.6.25) on x86_64 architecture. The current code has a value of the third argument of the call (prot) with 3 variants. All variations have the following bits set: _PAGE_PRESENT, _PAGE_RW, _PAGE_DIRTY, and _PAGE_ACCESSED. Number 2 adds _PAGE_NX to the above, and number 3 adds _PAGE_GLOBAL to the bits in ...
Feb 9, 6:40 pm 2008
Arjan van de Ven
Re: Query about set_pages_* API
On Sat, 09 Feb 2008 15:40:12 -0700 it depends on what the code is trying to achieve. (this makes it not a trivial 1:1 scripted replacement ;-) Which attribute is the code trying to change? Is it trying to make a piece of code (non) cachable? or executable? You need to figure out what the intent is.. --
Feb 9, 7:57 pm 2008
Robert P. J. Day
[PATCH][RFC] Remove "obsolete" digiepca content.
Remove the Digi Intl. epca driver for Linux, which is marked as "obsolete." Signed-off-by: Robert P. J. Day <rpjday@crashcourse.ca> --- this is a quick, first pass at a removal. feel free to suggest tweaks. Documentation/00-INDEX | 2 Documentation/digiepca.txt | 98 Documentation/ioctl-number.txt | 2 Documentation/kernel-parameters.txt | 4 Documentation/magic-number.txt | 1 MAINTAINERS | 7 drivers/c...
Feb 9, 5:45 pm 2008
Dave Hansen
[PATCH] make KVM selectable again
Current git for me (b1d0e4f535e10775cffde922208b49629169aeaa) doesn't let me build KVM. In fact, I don't seem to have *ANY* kvm-related symbols in my .config at all. I've verified that arch/x86/kvm/Kconfig was getting run by putting some comments in it. It seems to me like just putting: config HAVE_KVM bool isn't letting anything come into my .config at all. I'm not sure why we do that, and then have: select HAVE_KVM in arch/x86/Kconfig. This patch just defines HAVE_KVM i...
Feb 9, 4:59 pm 2008
Ingo Molnar
Re: [PATCH] make KVM selectable again
i think it might be better to just move the select to after the "config X86" option. (this is a legitimate use of select) Sam, do you concur? (but, your current fix should go in ASAP, so no objections from me.) Ingo --
Feb 9, 5:24 pm 2008
michael
jffs2 summary buffer
Hi, The summary is allocated using the vmalloc c->summary->sum_buf = vmalloc(c->sector_size); The same buffer is using and passed to the under layer in the jffs2_sum_write_data: vecs[0].iov_base = &isum; vecs[0].iov_len = sizeof(isum); vecs[1].iov_base = c->summary->sum_buf; vecs[1].iov_len = datasize; sum_ofs = jeb->offset + c->sector_size - jeb->free_size; dbg_summary("JFFS2: writing out data to flash to pos : 0x...
Feb 9, 4:46 pm 2008
Ingo Molnar
[git pull] kgdb light
Linus, while this is probably one of the last days of the merge window, please still consider pulling the "kgdb light" git tree from: git://git.kernel.org/pub/scm/linux/kernel/git/mingo/linux-2.6-kgdb.git See the shortlog below. This is a slimmed-down and cleaned up version of KGDB that i've created out of the original patches that we submitted two weeks ago. I went over the kgdb patches with Thomas and we cut out everything that we did not like, and cleaned up the result. KGDB is ...
Feb 9, 4:42 pm 2008
Martin Rogge
Re: Fwd: Re: e1000 1sec latency problem
Just for the records, I googled the following solution for the Lenovo T60: (a) use the e1000 driver (b) if compiling as a module, add the following parameter to modprobe.conf: options e1000 RxIntDelay=5 (c) if compiling a static driver, use the following patch (based on 2.6.24): --- e1000_param.c.orig 2008-01-24 23:58:37.000000000 +0100 +++ e1000_param.c 2008-02-09 20:42:23.000000000 +0100 @@ -158,7 +158,7 @@ * Valid Range: 0-65535 */ E1000_PARAM(RxIntDelay, "Receive Interrupt Delay"...
Feb 9, 4:00 pm 2008
Kok, Auke
Re: Fwd: Re: e1000 1sec latency problem
correct, this was a workaround which improved things for most people, but did not *fix* it. the real fix is to disable L1 ASPM alltogether at the cost of more power consumption, which is what is in e1000e in 2.6.25-git. Cheers, Auke --
Feb 9, 5:51 pm 2008
Ray Lee
Re: Fwd: Re: e1000 1sec latency problem
e1000e doesn't recognize his NIC. Will you be adding this to the e1000 driver as well? --
Feb 9, 6:01 pm 2008
Kok, Auke
Re: Fwd: Re: e1000 1sec latency problem
no, from 2.6.25 onwards e1000e will support 82573 nics, so you'll have to migrate drivers, and you will get the fix automatically that way. after 2.6.25 releases, support for all pci-e nics will be removed from the e1000 driver. Cheers Auke --
Feb 9, 7:38 pm 2008
Frederik Deweerdt
[patch] crypto test build failure
Hello Herbert, Building latest git fails with the following error: ERROR: "crypto_alloc_ablkcipher" [crypto/tcrypt.ko] undefined! This appears to happen because CONFIG_CRYPTO_TEST is set while CONFIG_CRYPTO_BLKCIPHER is not. The following patch fixes the problem for me. Regards, Frederik Signed-off-by: Frederik Deweerdt <frederik.deweerdt@gmail.com> diff --git a/crypto/Kconfig b/crypto/Kconfig index c3166a1..d0287ce 100644 --- a/crypto/Kconfig +++ b/crypto/Kconfig @@ -567,6 +567,...
Feb 9, 3:52 pm 2008
Robert P. J. Day
some questions about generated headers
just a few observations about the generated headers and whether there's some cleanup to be done there. 1) the generated header linux/tty.h consists solely of: ===== #ifndef _LINUX_TTY_H #define _LINUX_TTY_H /* * 'tty.h' defines some structures used by tty_io.c and some defines. */ #endif ===== i once submitted a patch that, if this header were included from userspace, would print, "Don't include me from user space, I'm empty." or something to that effect. is that worth d...
Feb 9, 3:07 pm 2008
Bartlomiej Zolnierki...
Re: some questions about generated headers
On Saturday 09 February 2008, Robert P. J. Day wrote: These hdsmart.h goofups are my doings. 8) [ I must have been half-asleep while making these changes but no harm for kernel side was done (this file is not used by kernel anymore) and yes, I didn't have motivation to look up for answer to 3) so I've just put fdefs there. ] Thanks, Bart --
Feb 9, 3:48 pm 2008
Miles Lane Feb 9, 3:03 pm 2008
Bartlomiej Zolnierki...
[PATCH] ide: remove ->hold field from ide_hwif_t (take 2)
->hold is write-only now, remove it. v2: * v1 missed bast-ide, palm_bk3710, ide-cs and delkin_cb host drivers. Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com> --- drivers/ide/arm/bast-ide.c | 2 +- drivers/ide/arm/palm_bk3710.c | 2 +- drivers/ide/legacy/ide-cs.c | 2 +- drivers/ide/mips/au1xxx-ide.c | 3 --- drivers/ide/pci/delkin_cb.c | 2 +- drivers/ide/ppc/pmac.c | 1 - include/linux/ide.h | 1 - 7 files changed, 4 in...
Feb 9, 1:54 pm 2008
Sergei Shtylyov
Re: [PATCH] ide: remove ->hold field from ide_hwif_t (take 2)
Acked-by: Sergei Shtylyov <sshtylyov@ru.mvista.com> MBR, Sergei --
Feb 9, 1:48 pm 2008
Vegard Nossum
mm/slub.c warnings
Hi, I get these warnings when compiling mm/slub.c in linux-2.6.git: mm/slub.c: In function 'slab_alloc': mm/slub.c:1637: warning: assignment makes pointer from integer without a cast mm/slub.c:1637: warning: assignment makes pointer from integer without a cast mm/slub.c: In function 'slab_free': mm/slub.c:1796: warning: assignment makes pointer from integer without a cast mm/slub.c:1796: warning: assignment makes pointer from integer without a cast The actual lines are calls to cmpxchg_local()...
Feb 9, 1:13 pm 2008
Alessandro Suardi
2.6.24-git2: Oracle 11g VKTM process enters R state on start...
I finally had a bit of time to try out different kernel versions to find out where this began... and it's in 2.6.24-git2. What happens: Oracle 11g starts up and forks a number of so called background processes. Starting in 2.6.24-git2 the VKTM process never fully completes its initialization but gets in R state, never accumulating CPU, and can't be straced/gdb'd/killed. Sysrq-T reports for VKTM looks like this Feb 9 16:10:46 sandman kernel: ======================= Feb 9 16:10:46 sandma...
Feb 9, 1:10 pm 2008
Robert P. J. Day
[PATCH][RFC] Remove manual definition and subsequent testing...
Remove the explicit definition, and subsequent superfluous testing, of BUILD CRAMDISK. Signed-off-by: Robert P. J. Day <rpjday@crashcourse.ca> --- is there any point to this brute-force setting anymore? just curious. diff --git a/init/do_mounts_rd.c b/init/do_mounts_rd.c index ed652f4..54156e9 100644 --- a/init/do_mounts_rd.c +++ b/init/do_mounts_rd.c @@ -10,8 +10,6 @@ #include "do_mounts.h" -#define BUILD_CRAMDISK - int __initdata rd_prompt = 1;/* 1 = prompt for RAM d...
Feb 9, 12:59 pm 2008
Robert P. J. Day
digi driver removable?
from a discussion once upon a time, it isn't clear whether or not this (and everything that goes with it) is deletable: Documentation/digiepca.txt. thoughts? i have a list of this stuff around here somewhere, i should update it and put it on the wiki one of these days. rday -- ======================================================================== Robert P. J. Day Linux Consulting, Training and Annoying Kernel Pedantry Waterloo, Ontario, CANADA Home page: ...
Feb 9, 12:39 pm 2008
Jiri Slaby
Re: digi driver removable?
http://lkml.org/lkml/2006/10/26/231 Maybe the time has come. If I was you I would create a patch to see if somebody will complain at all... --
Feb 9, 5:23 pm 2008
Michael
Two comments on menuconfig usability
Hi all, [please to CC me] There's two things I want to comment on regarding menuconfig: 1) I know of the purpose of oldconfig, but I prefer using menuconfig for upgrading to newer kernel versions, because most of the time, I would select the standard options for new features anyway. menuconfig has the "(NEW)" string at the end of a feature's description. However, I find that hard to see among all the names of various lenghts. My proposal would be to have an "N" or a "NEW" appear to the _left...
Feb 9, 11:23 am 2008
Bartlomiej Zolnierki...
[PATCH 3/3] ide: remove IDE_*_REG macros
* Add IDE_{ALTSTATUS,IREASON,BCOUNTL,BCOUNTH}_OFFSET defines. * Remove IDE_*_REG macros - this results in more readable and slightly smaller code. There should be no functional changes caused by this patch. Cc: Borislav Petkov <petkovbb@gmail.com> Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com> --- drivers/ide/cris/ide-cris.c | 18 +++++++-- drivers/ide/ide-cd.c | 10 +++-- drivers/ide/ide-floppy.c | 14 ++++--- drivers/ide/ide-io.c |...
Feb 9, 11:24 am 2008
Bartlomiej Zolnierki...
[PATCH 1/3] ide-tape: remove never executed code
rq->cmd[0] is never set to REQ_IDETAPE_READ_BUFFER so remove REQ_IDETAPE_READ_BUFFER handling from idetape_create_write_cmd() and the define itself. Then remove no longer used idetape_create_read_buffer_cmd() and IDETAPE_RETRIEVE_FAULTY_BLOCK define. There should be no functional changes caused by this patch. Cc: Borislav Petkov <petkovbb@gmail.com> Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com> --- drivers/ide/ide-tape.c | 34 -------------------------------...
Feb 9, 11:23 am 2008
Sergei Shtylyov
Re: [PATCH 1/3] ide-tape: remove never executed code
Acked-by: Sergei Shtylyov <sshtylyov@ru.mvista.com> MBR, Sergei --
Feb 9, 1:54 pm 2008
Bartlomiej Zolnierki...
[PATCH 2/3] ide: add ide_atapi_{discard_data,write_zeros} in...
Add ide_atapi_{discard_data,write_zeros} inline helpers to <linux/ide.h> and use them instead of home-brewn helpers in ide-{floppy,tape,scsi}. There should be no functional changes caused by this patch. Cc: Borislav Petkov <petkovbb@gmail.com> Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com> --- drivers/ide/ide-floppy.c | 24 +++--------------------- drivers/ide/ide-tape.c | 14 ++------------ drivers/scsi/ide-scsi.c | 18 +++--------------- include/li...
Feb 9, 11:23 am 2008
KOSAKI Motohiro
[sample] mem_notify v6: usage example
this is usage example of /dev/mem_notify. Daniel Spang create original version. kosaki add fasync related code. Signed-off-by: Daniel Spang <daniel.spang@gmail.com> Signed-off-by: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com> --- Documentation/mem_notify.c | 120 +++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 120 insertions(+) Index: b/Documentation/mem_notify.c =================================================================== --- /dev/null 1970-01-01 00...
Feb 9, 11:55 am 2008
Jon Masters
Re: [sample] mem_notify v6: usage example
This really needs to be triggered via a generic kernel event in the final version - I picture glibc having a reservation API and having generic support for freeing such reservations. Jon On Feb 9, 2008, at 10:55, "KOSAKI Motohiro" <kosaki.motohiro@jp.fujitsu.com --
Feb 9, 12:07 pm 2008
KOSAKI Motohiro
Re: [sample] mem_notify v6: usage example
to be honest, I doubt idea of generic reservation framework. end up, we hope drop the application cache, not also dataless memory. but, automatically drop mechanism only able to drop dataless memory. and, many application have own memory management subsystem. I afraid to nobody use too complex framework. What do you think it? I hope see your API. please post it. Thanks! --
Feb 9, 12:46 pm 2008
Eugene Teo
[PATCH] lguest: make sure cpu is initialized before accessin...
If req is LHREQ_INITIALIZE, and the guest has been initialized before (unlikely), it will attempt to access cpu->tsk even though cpu is not yet initialized. Signed-off-by: Eugene Teo <eugeneteo@kernel.sg> --- drivers/lguest/lguest_user.c | 14 +++++++------- 1 files changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/lguest/lguest_user.c b/drivers/lguest/lguest_user.c index 85d42d3..9cbb285 100644 --- a/drivers/lguest/lguest_user.c +++ b/drivers/lguest/lguest_user.c @@ -...
Feb 9, 11:53 am 2008
KOSAKI Motohiro
[PATCH 8/8][for -mm] mem_notify v6: support fasync feature
implement FASYNC capability to /dev/mem_notify. <usage example> fd = open("/dev/mem_notify", O_RDONLY); fcntl(fd, F_SETOWN, getpid()); fcntl(fd, F_SETSIG, SIGUSR1); flags = fcntl(fd, F_GETFL); fcntl(fd, F_SETFL, flags|FASYNC); /* when low memory, receive SIGUSR1 */ </usage example> ChangeLog v5 -> v6: o rewrite usage example o cleanups number of wakeup tasks calculation. v5: new Signed-off-by: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.c...
Feb 9, 11:28 am 2008
KOSAKI Motohiro
[PATCH 7/8][for -mm] mem_notify v6: ignore very small zone f...
on X86, ZONE_DMA is very very small. it cause undesirable low mem notification. It should ignored. but on other some architecture, ZONE_DMA have 4GB. 4GB is large as it is not possible to ignored. therefore, ignore or not is decided by zone size. ChangeLog: v5: new Signed-off-by: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com> --- include/linux/mem_notify.h | 3 +++ mm/page_alloc.c | 6 +++++- 2 files changed, 8 insertions(+), 1 deletion(-) Index: b/inclu...
Feb 9, 11:26 am 2008
KOSAKI Motohiro
[PATCH 6/8][for -mm] mem_notify v6: (optional) fixed incorre...
on X86, ZONE_DMA is very very small. It is often no used at all. Unfortunately, when NR_ACTIVE==0, NR_INACTIVE==0, shrink_zone() try to reclaim 1 page. because zone->nr_scan_active += (zone_page_state(zone, NR_ACTIVE) >> priority) + 1; ^^^^^ it cause unnecessary low memory notify ;-) I fixed it. ChangeLog v5: new Signed-off-by: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com> --- mm/vmscan.c | ...
Feb 9, 11:26 am 2008
KOSAKI Motohiro
[PATCH 5/8][for -mm] mem_notify v6: add new mem_notify field...
show new member of zone struct by /proc/zoneinfo. ChangeLog: v5: change display order to at last. Signed-off-by: Marcelo Tosatti <marcelo@kvack.org> Signed-off-by: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com> --- mm/vmstat.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) Index: b/mm/vmstat.c =================================================================== --- a/mm/vmstat.c 2008-01-23 22:06:05.000000000 +0900 +++ b/mm/vmstat.c 2008-01-23 22:08:00.00...
Feb 9, 11:25 am 2008
KOSAKI Motohiro
[PATCH 4/8][for -mm] mem_notify v6: memory_pressure_notify()...
the notification point to happen whenever the VM moves an anonymous page to the inactive list - this is a pretty good indication that there are unused anonymous pages present which will be very likely swapped out soon. and, It is judged out of trouble at the fllowing situations. o memory pressure decrease and stop moves an anonymous page to the inactive list. o free pages increase than (pages_high+lowmem_reserve)*2. ChangeLog: v5: add out of trouble notify to exit of balance_pgdat(). ...
Feb 9, 11:24 am 2008
KOSAKI Motohiro
[PATCH 3/8][for -mm] mem_notify v6: introduce /dev/mem_notif...
the core of this patch series. add /dev/mem_notify device for notification low memory to user process. <usage examle> fd = open("/dev/mem_notify", O_RDONLY); if (fd < 0) { exit(1); } pollfds.fd = fd; pollfds.events = POLLIN; pollfds.revents = 0; err = poll(&pollfds, 1, -1); // wake up at low memory ... </usage example> ChangeLog v5 -> v6: o improve number of wakeup tasks fomula...
Feb 9, 11:23 am 2008
KOSAKI Motohiro
[PATCH 2/8][for -mm] mem_notify v6: introduce wake_up_locked...
introduce new API wake_up_locked_nr() and wake_up_locked_all(). it it similar as wake_up_nr() and wake_up_all(), but it doesn't lock. Signed-off-by: Marcelo Tosatti <marcelo@kvack.org> Signed-off-by: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com> --- include/linux/wait.h | 12 ++++++++---- kernel/sched.c | 5 +++-- 2 files changed, 11 insertions(+), 6 deletions(-) Index: b/include/linux/wait.h =================================================================== --- a...
Feb 9, 11:21 am 2008
KOSAKI Motohiro
[PATCH 1/8][for -mm] mem_notify v6: introduce poll_wait_excl...
There are 2 way of adding item to wait_queue, 1. add_wait_queue() 2. add_wait_queue_exclusive() and add_wait_queue_exclusive() is very useful API. unforunately, poll_wait_exclusive() against poll_wait() doesn't exist. it means there is no way that wake up only 1 process where polled. wake_up() is wake up all sleeping process by poll_wait(), not 1 process. this patch introduce poll_wait_exclusive() new API for allow wake up only 1 process. <usage example> unsigned int kosaki_poll(st...
Feb 9, 11:21 am 2008
KOSAKI Motohiro
[PATCH 0/8][for -mm] mem_notify v6
Hi The /dev/mem_notify is low memory notification device. it can avoid swappness and oom by cooperationg with the user process. the Linux Today article is very nice description. (great works by Jake Edge) http://www.linuxworld.com/news/2008/020508-kernel.html <quoted> When memory gets tight, it is quite possible that applications have memory allocated—often caches for better performance—that they could free. After all, it is generally better to lose some performance than to face the ...
Feb 9, 11:19 am 2008
Jon Masters
Re: [PATCH 0/8][for -mm] mem_notify v6
Yo, Interesting patch series (I am being yuppie and reading this thread from my iPhone on a treadmill at the gym - so further comments later). I think that this is broadly along the lines that I was thinking, but this should be an RFC only patch series for now. Some initial questions: Where is the netlink interface? Polling an FD is so last century :) What testing have you done? Still, it is good to start with some code - eventually we might just have a full reservation API create...
Feb 9, 12:02 pm 2008
KOSAKI Motohiro
Re: [PATCH 0/8][for -mm] mem_notify v6
Thank you. to be honest, I don't know anyone use netlink and why hope receive low memory notify by netlink. poll() is old way, but it works good enough. and, netlink have a bit weak point. end up, netlink philosophy is read/write model. I afraid to many low-mem message queued in netlink buffer at under heavy pressure. Great. Welcome to any idea and any discussion. --
Feb 9, 12:33 pm 2008
Rik van Riel
Re: [PATCH 0/8][for -mm] mem_notify v6
On Sun, 10 Feb 2008 01:33:49 +0900 More importantly, all gtk+ programs, as well as most databases and other system daemons have a poll() loop as their main loop. A file descriptor fits that main loop perfectly. -- All rights reversed. --
Feb 9, 12:43 pm 2008
KOSAKI Motohiro
Re: [PATCH 0/8][for -mm] mem_notify v6
not only gtk+, may be all modern GUI program :) --
Feb 9, 12:49 pm 2008
Andi Kleen
[PATCH] [1/5] Only do century BCD conversion when we know th...
Minor logic fix. The century change was previously always BCD, even when the CMOS data would report itself not being BCD. Signed-off-by: Andi Kleen <ak@suse.de> --- arch/x86/kernel/rtc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Index: linux/arch/x86/kernel/rtc.c =================================================================== --- linux.orig/arch/x86/kernel/rtc.c +++ linux/arch/x86/kernel/rtc.c @@ -130,10 +130,10 @@ unsigned long mach_get_cmos_time(void) BCD_TO...
Feb 9, 11:16 am 2008
Andi Kleen
[PATCH] [5/5] Enable ACPI extended century handling for 32bi...
Not that it matters much, see comment in the code. v2: Fix compilation on !ACPI, pointed out by tglx Signed-off-by: Andi Kleen <ak@suse.de> --- arch/x86/kernel/rtc.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) Index: linux/arch/x86/kernel/rtc.c =================================================================== --- linux.orig/arch/x86/kernel/rtc.c +++ linux/arch/x86/kernel/rtc.c @@ -112,8 +112,11 @@ unsigned long mach_get_cmos_time(void) mon = CMOS_READ(RTC_...
Feb 9, 11:17 am 2008
Andi Kleen
[PATCH] [4/5] Fix wrong comment
It should operate in BCD mode. Signed-off-by: Andi Kleen <ak@suse.de> Index: linux/include/asm-x86/mc146818rtc.h =================================================================== --- linux.orig/include/asm-x86/mc146818rtc.h +++ linux/include/asm-x86/mc146818rtc.h @@ -11,7 +11,7 @@ #ifndef RTC_PORT #define RTC_PORT(x) (0x70 + (x)) -#define RTC_ALWAYS_BCD 1 /* RTC operates in binary mode */ +#define RTC_ALWAYS_BCD 1 /* RTC operates in BCD mode */ #endif #if defined(CONFIG_X86...
Feb 9, 11:17 am 2008
Andi Kleen
[PATCH] [3/5] Add warning when RTC clock reports binary
We tend to assume the RTC clock is BCD, so print a warning if it claims to be binary. Signed-off-by: Andi Kleen <ak@suse.de> Index: linux/arch/x86/kernel/rtc.c =================================================================== --- linux.orig/arch/x86/kernel/rtc.c +++ linux/arch/x86/kernel/rtc.c @@ -94,6 +94,8 @@ int mach_set_rtc_mmss(unsigned long nowt unsigned long mach_get_cmos_time(void) { + unsigned status; + static int warned; unsigned int year, mon, day, hour, min, sec,...
Feb 9, 11:16 am 2008
previous daytodaynext day
February 8, 2008February 9, 2008February 10, 2008