Home » Mailing list archives » linux-kernel » 2008 » February » 9

[PATCH] [5/5] Enable ACPI extended century handling for 32bit too v2

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: Andi Kleen
Subject: [PATCH] [5/5] Enable ACPI extended century handling for 32bit too v2
Date: Saturday, February 9, 2008 - 8:17 am

Not that it matters much, see comment in the code.

v2: Fix compilation on !ACPI, pointed out by tglx

Signed-off-by: Andi Kleen <ak@suse.de>

---
 arch/x86/kernel/rtc.c |    7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

Index: linux/arch/x86/kernel/rtc.c
===================================================================
--- linux.orig/arch/x86/kernel/rtc.c
+++ linux/arch/x86/kernel/rtc.c
@@ -112,8 +112,11 @@ unsigned long mach_get_cmos_time(void)
 	mon = CMOS_READ(RTC_MONTH);
 	year = CMOS_READ(RTC_YEAR);
 
-#if defined(CONFIG_ACPI) && defined(CONFIG_X86_64)
-	/* CHECKME: Is this really 64bit only ??? */
+#ifdef CONFIG_ACPI
+	/*
+	 * On 32bit not strictly needed because the world ends in 2038
+	 * and the code can handle that with the 2 digit heuristics.
+	 */
 	if (acpi_gbl_FADT.header.revision >= FADT2_REVISION_ID &&
 	    acpi_gbl_FADT.century)
 		century = CMOS_READ(acpi_gbl_FADT.century);
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
[PATCH] [1/5] Only do century BCD conversion when we know ..., Andi Kleen, (Sat Feb 9, 8:16 am)
[PATCH] [2/5] Use 2000 offset for 32bit kernels, Andi Kleen, (Sat Feb 9, 8:16 am)
[PATCH] [3/5] Add warning when RTC clock reports binary , Andi Kleen, (Sat Feb 9, 8:16 am)
[PATCH] [4/5] Fix wrong comment, Andi Kleen, (Sat Feb 9, 8:17 am)
[PATCH] [5/5] Enable ACPI extended century handling for 32 ..., Andi Kleen, (Sat Feb 9, 8:17 am)
Re: [PATCH] [1/5] Only do century BCD conversion when we k ..., Thomas Gleixner, (Mon Feb 11, 1:30 am)
Re: [PATCH] [1/5] Only do century BCD conversion when we k ..., Andi Kleen, (Mon Feb 11, 1:56 am)
Re: [PATCH] [1/5] Only do century BCD conversion when we k ..., Thomas Gleixner, (Mon Feb 11, 3:08 pm)
Re: [PATCH] [1/5] Only do century BCD conversion when we k ..., Andi Kleen, (Mon Feb 11, 3:15 pm)
Re: [PATCH] [1/5] Only do century BCD conversion when we k ..., Thomas Gleixner, (Tue Feb 12, 1:36 pm)
Re: [PATCH] [1/5] Only do century BCD conversion when we k ..., Andi Kleen, (Wed Feb 13, 6:49 am)
Re: [PATCH] [2/5] Use 2000 offset for 32bit kernels, Thomas Gleixner, (Sat Feb 16, 12:24 pm)
Re: [PATCH] [3/5] Add warning when RTC clock reports binary , Thomas Gleixner, (Sat Feb 16, 12:38 pm)
Re: [PATCH] [5/5] Enable ACPI extended century handling fo ..., Thomas Gleixner, (Sat Feb 16, 12:38 pm)
Re: [PATCH] [2/5] Use 2000 offset for 32bit kernels, Thomas Gleixner, (Wed Feb 20, 3:07 am)
Re: [PATCH] [2/5] Use 2000 offset for 32bit kernels, Andi Kleen, (Wed Feb 20, 3:23 am)