Re: [PATCH 11/9] firewire: fw-sbp2: enforce a retry of __scsi_add_device if bus generation changed

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: Jarod Wilson <jwilson@...>
Cc: <linux1394-devel@...>, <linux-kernel@...>, <linux-scsi@...>
Date: Friday, February 8, 2008 - 3:58 pm

(Adding Cc: LSML)

Jarod Wilson wrote:

Or so did I guess, and...


...my guess was wrong then.

Either I misunderstood the semantics of the various hostbyte codes in
the command completion return (and then these semantics are
insufficient) --- or SCSI mid layer or high-level implements them wrong.

But before we dive into the SCSI stack or implement parellelism of SBP-2
reconnect and SCSI probing in fw-sbp2, there is another simple and in
hindsight obvious trick we can try.  Stay tuned.

Background for LSML:

In case of unrecoverable transport failures during the execution of
__scsi_add_device, I would like to send appropriate error indicators
from the LLD up to SCSI midlayer so that __scsi_add_device ends in
failure (i.e. returns an error pointer rather than a scsi_device pointer).

Sometimes SCSI core decides to let __scsi_add_device fail, sometimes it
takes the scsi_device offline, sometimes it doesn't do either but
pretends to the LLD that __scsi_add_device was an utter success.  Except
that userspace can't do anything with the scsi_device because e.g. READ
CAPACITY couldn't be executed.
-- 
Stefan Richter
-=====-==--- --=- -=---
http://arcgraph.de/sr/
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[PATCH 0/9] firewire-sbp2: misc hotplug related patches, Stefan Richter, (Sun Feb 3, 6:00 pm)
[PATCH 10/9] firewire: fw-sbp2: preemptively block sdev, Stefan Richter, (Wed Feb 6, 5:07 pm)
Re: [PATCH 11/9] firewire: fw-sbp2: enforce a retry of __scs..., Stefan Richter, (Fri Feb 8, 3:58 pm)
[PATCH 8/9] firewire: fw-sbp2: sort includes, Stefan Richter, (Sun Feb 3, 6:12 pm)
[PATCH 3/9] ieee1394: sbp2: add INQUIRY delay workaround, Stefan Richter, (Sun Feb 3, 6:07 pm)
[PATCH 1/9] firewire: log GUID of new devices, Stefan Richter, (Sun Feb 3, 6:03 pm)
Re: [PATCH 1/9] firewire: log GUID of new devices, Jarod Wilson, (Mon Feb 11, 12:53 pm)
Re: [PATCH 1/9] firewire: log GUID of new devices, Stefan Richter, (Mon Feb 4, 4:14 am)