Home » Mailing list archives » linux-kernel » 2008 » February » 8

Re: [PATCH] reduce large do_mount stack usage with noinlines

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: Al Viro <viro@...>
To: Eric Sandeen <sandeen@...>
Cc: Andi Kleen <andi@...>, Andrew Morton <akpm@...>, <linux-kernel@...>, <rth@...>
Subject: Re: [PATCH] reduce large do_mount stack usage with noinlines
Date: Friday, February 8, 2008 - 1:23 pm

On Fri, Feb 08, 2008 at 10:54:09AM -0600, Eric Sandeen wrote:


Frankly, a wrapper for path_lookup() that would take struct path *,
refuse to do LOOKUP_PARENT (i.e. guaranteed to have nothing stored
in nameidata other than ->mnt and ->dentry) and copied result of
lookup into passed struct path * would help a lot more.

Taking it to fs/namei.c would prevent inlining just fine and we'd
be left with pair of pointers in caller's stack frame instead of
full struct nameidata.  All users in fs/namespace.c can be trivially
converted to that and AFAICS it would save a lot more than we would
get from making everything in there not inlined.

I'll do that in fs/namei.c sanitizing series (opens as soon as ro-bind
stuff goes in).
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
[PATCH] reduce large do_mount stack usage with noinlines, Eric Sandeen, (Wed Feb 6, 6:13 pm)
Re: [PATCH] reduce large do_mount stack usage with noinlines, Andrew Morton, (Wed Feb 6, 6:34 pm)
Re: [PATCH] reduce large do_mount stack usage with noinlines, Eric Sandeen, (Wed Feb 6, 7:11 pm)
Re: [PATCH] reduce large do_mount stack usage with noinlines, Andrew Morton, (Wed Feb 6, 7:22 pm)
Re: [PATCH] reduce large do_mount stack usage with noinlines, Andi Kleen, (Fri Feb 8, 12:50 pm)
Re: [PATCH] reduce large do_mount stack usage with noinlines, Eric Sandeen, (Fri Feb 8, 12:54 pm)
Re: [PATCH] reduce large do_mount stack usage with noinlines, Al Viro, (Fri Feb 8, 1:23 pm)
Re: [PATCH] reduce large do_mount stack usage with noinlines, Eric Sandeen, (Thu Feb 7, 7:08 pm)
Re: [PATCH] reduce large do_mount stack usage with noinlines, Andrew Morton, (Thu Feb 7, 7:26 pm)
Re: [PATCH] reduce large do_mount stack usage with noinlines, Arjan van de Ven, (Thu Feb 7, 7:23 pm)
Re: [PATCH] reduce large do_mount stack usage with noinlines, Eric Sandeen, (Wed Feb 6, 7:34 pm)
Re: [PATCH] reduce large do_mount stack usage with noinlines, Andrew Morton, (Wed Feb 6, 7:46 pm)
Re: [PATCH] reduce large do_mount stack usage with noinlines, Eric Sandeen, (Wed Feb 6, 6:55 pm)
Re: [PATCH] reduce large do_mount stack usage with noinlines, Arjan van de Ven, (Wed Feb 6, 6:54 pm)
Re: [PATCH] reduce large do_mount stack usage with noinlines, Eric Sandeen, (Wed Feb 6, 7:01 pm)