Home » Mailing list archives » linux-kernel » 2008 » February » 8

[PATCH] [3/3] Enable ACPI extended century handling for 32bit too

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: Andi Kleen <ak@...>
To: <mingo@...>, <tglx@...>, <linux-kernel@...>
Subject: [PATCH] [3/3] Enable ACPI extended century handling for 32bit too
Date: Friday, February 8, 2008 - 8:14 am

Not that it matters much, see comment in the code.

Signed-off-by: Andi Kleen <ak@suse.de>

---
 arch/x86/kernel/rtc.c |    7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

Index: linux/arch/x86/kernel/rtc.c
===================================================================
--- linux.orig/arch/x86/kernel/rtc.c
+++ linux/arch/x86/kernel/rtc.c
@@ -112,12 +112,13 @@ unsigned long mach_get_cmos_time(void)
 	mon = CMOS_READ(RTC_MONTH);
 	year = CMOS_READ(RTC_YEAR);
 
-#if defined(CONFIG_ACPI) && defined(CONFIG_X86_64)
-	/* CHECKME: Is this really 64bit only ??? */
+	/*
+	 * On 32bit not strictly needed because the world ends in 2038
+	 * and the code can handle that with the 2 digit heuristics.
+	 */
 	if (acpi_gbl_FADT.header.revision >= FADT2_REVISION_ID &&
 	    acpi_gbl_FADT.century)
 		century = CMOS_READ(acpi_gbl_FADT.century);
-#endif
 
 	if (RTC_ALWAYS_BCD || !(CMOS_READ(RTC_CONTROL) & RTC_DM_BINARY)) {
 		BCD_TO_BIN(sec);
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
[PATCH] [1/3] Only do century BCD conversion when we know th..., Andi Kleen, (Fri Feb 8, 8:14 am)
Re: [PATCH] [1/3] Only do century BCD conversion when we kno..., Thomas Gleixner, (Sat Feb 9, 6:28 am)
Re: [PATCH] [1/3] Only do century BCD conversion when we kno..., Andi Kleen, (Sat Feb 9, 10:55 am)
[PATCH] [3/3] Enable ACPI extended century handling for 32bi..., Andi Kleen, (Fri Feb 8, 8:14 am)
Re: [PATCH] [3/3] Enable ACPI extended century handling for ..., Thomas Gleixner, (Sat Feb 9, 6:39 am)
[PATCH] [2/3] Use 2000 offset for 32bit kernels, Andi Kleen, (Fri Feb 8, 8:14 am)