On Fri, 2008-02-08 at 09:45 +0000, Russell King - ARM Linux wrote:
quoted text
> If we are serious about allowing ARM to use drivers/Kconfig, then let's
> not get distracted by perfection - by trying to do too many changes in
> one go.
> 
> If, today, we conditionalise MTD or IDE on a certain set of symbols,
> then those conditions should be preserved in the first step - it should
> be a 1:1 translation.

That makes some sense. Currently you have:

	if ALIGNMENT_TRAP || !CPU_CP15_MMU
	source "drivers/mtd/Kconfig"
	endif

quoted text
> Later, if there's a need to improve it (as you're suggesting) that should
> be a *separate* change.

We can certainly improve the behaviour later, it's true -- it's not the
end of the world if we continue to have the whole of the MTD layer
turned off on platforms with alignment problems for now.

But still, it's HAVE_UNALIGNED_ACCESS which we want to depend on, not a
newly-invented HAVE_MTD. And there are other places we really ought to
be depending on HAVE_UNALIGNED_ACCESS too.

-- 
dwmw2

--
unsubscribe notice
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/