Hi,

hope this is last round. Latest changes were mostly in coding style,
one minor bugfix.

Please apply.

David Sterba
---
From: David Sterba <dsterba@suse.cz>

ipwireless: driver for PC Card, 3G internet connection

The driver is manufactured by IPWireless.

Rewieved-by: Jiri Slaby <jslaby@suse.cz>
Signed-off-by: Ben Martel <benm@symmetric.co.nz>
Signed-off-by: Stephen Blackheath <stephen@symmetric.co.nz>
Signed-off-by: David Sterba <dsterba@suse.cz>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>
---
 MAINTAINERS                                     |    8 
 drivers/char/pcmcia/Kconfig                     |    9 
 drivers/char/pcmcia/Makefile                    |    2 
 drivers/char/pcmcia/ipwireless/Makefile         |   10 
 drivers/char/pcmcia/ipwireless/hardware.c       | 1787 ++++++++++++++++++++++++
 drivers/char/pcmcia/ipwireless/hardware.h       |   64 
 drivers/char/pcmcia/ipwireless/main.c           |  506 ++++++
 drivers/char/pcmcia/ipwireless/main.h           |   70 
 drivers/char/pcmcia/ipwireless/network.c        |  512 ++++++
 drivers/char/pcmcia/ipwireless/network.h        |   55 
 drivers/char/pcmcia/ipwireless/setup_protocol.h |  108 +
 drivers/char/pcmcia/ipwireless/tty.c            |  688 +++++++++
 drivers/char/pcmcia/ipwireless/tty.h            |   48 
 13 files changed, 3867 insertions(+)
---
diff --git a/MAINTAINERS b/MAINTAINERS
index df40a4e..fc01a22 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -2007,6 +2007,14 @@ M:	acme@ghostprotocols.net
 L:	netdev@vger.kernel.org
 S:	Maintained
 
+IPWIRELES DRIVER
+P:	Jiri Kosina
+M:	jkosina@suse.cz
+P:	David Sterba
+M:	dsterba@suse.cz
+S:	Maintained
+T:	git://git.kernel.org/pub/scm/linux/kernel/git/jikos/ipwireless_cs.git
+
 IRDA SUBSYSTEM
 P:	Samuel Ortiz
 M:	samuel@sortiz.org
diff --git a/drivers/char/pcmcia/Kconfig b/drivers/char/pcmcia/Kconfig
index f25facd..00b8a84 100644
--- a/drivers/char/pcmcia/Kconfig
+++ b/drivers/char/pcmcia/Kconfig
@@ -43,5 +43,14 @@ config CARDMAN_4040
 	  ...
[ message continues ]

why is this not static? I think the interrupt routine should be in the


Why is allowing to change the major still needed. I think we passed the

This looks useless to. Do we need that?

Regards

Marcel


--

[ message continues ]

This is due to current separation into files. hardware.c has many functions 
for handler bodies, while main.c registers the pcmcia structs in module init 
(and takes address of ipwireless_interrupt()). Long ago, the driver was one 
large file, and I don't want to merge the files back just to make some funcs 

Same reason, the macro would be used in a file where the struct is not yet 

Sounds reasonable. I personally haven't used this param (besides testing the 

Removed. Used only in one place.

Thanks for comments. Updated version 5 will follow.

Dave
--

[ message continues ]

Linus, as there is no PCMCIA maintainer and akpm apparently wants you to 
merge this directly [1] -- what is your position on this one please? As 
far as I can see all the major issues that were raised during review were 
fixed by David, so there shouldn't be any obstacles to merging it. It 
would be nice if this driver will make it for 2.6.25 merge window.

Thanks,

[1] http://lkml.org/lkml/2007/12/17/302

-- 
Jiri Kosina
--

[ message continues ]

I had some minor additional questions, but in general, I second that
this driver should be merged for 2.6.25.

The question of the PCMCIA maintainership came up on a different mailing
list. Personally I think that PCMCIA is a dead technology, but in some
industrial environments this will live longer than expected. I would
simply propose that LKML is used for PCMCIA related review and -mm for
testing.

Regards

Marcel


--

[ message continues ]

Well, in the case of this particular driver, I think it's not so much a 
PCMCIA thing as a "network driver" thing. It's not like the driver 
actually needs any extra PCMCIA support or anything like that, and as such 
I think in this case it's really more of a regular network driver than 
anything else.

And especially with wireless, I think the impact for any future changes 
are about the wireless infrastructure, not PCMCIA. There's little reason 
to believe that we'll ever make any big PCMCIA overhauls exctly because 
PCMCIA is so dead.

So I'd happily merge it, but I would be even happier if I got ack's from 
the wireless people or if it was simply merged that way too.

			Linus
--

[ message continues ]

Unfortunately the device has quite confusing name (and the driver of 
course follows). It has 'wireless' in its name, but it has literally 
nothing to do with "wireless" networking, as long as 802.11<anything> is 
involved.

It is in fact a PCMCIA card, that acts as a GPRS/EDGE/UMTS modem. So its 
This has been already discussed, please see 
http://www.ussg.iu.edu/hypermail/linux/kernel/0711.3/2198.html

Thanks,

-- 
Jiri Kosina
SUSE Labs
--

[ message continues ]

Baa Baa (a Kiwi greeting :) ),

I have to second Jiri on this one. The card is used as a 'WAN'
technology not a 'LAN' technology platform and hence does not really fit
into the 'wireless 802.11<anything>' space. I think that it should be
merged in where it currently sits. 

   ~benm

-----Original Message-----
From: Jiri Kosina [mailto:jkosina@suse.cz] 
Sent: Wednesday, 6 February 2008 1:15 p.m.
To: Linus Torvalds
Cc: Marcel Holtmann; David Sterba; linux-kernel@vger.kernel.org; Ben
Martel; stephen@symmetric.co.nz
Subject: Re: [PATCH][v4] ipwireless: driver for 3G PC Card


Unfortunately the device has quite confusing name (and the driver of 
course follows). It has 'wireless' in its name, but it has literally 
nothing to do with "wireless" networking, as long as 802.11<anything> is

involved.

It is in fact a PCMCIA card, that acts as a GPRS/EDGE/UMTS modem. So its

This has been already discussed, please see 
http://www.ussg.iu.edu/hypermail/linux/kernel/0711.3/2198.html

Thanks,

-- 
Jiri Kosina
SUSE Labs

Internal Virus Database is out-of-date.
Checked by AVG Free Edition. 
Version: 7.5.503 / Virus Database: 269.16.4/1147 - Release Date:
23/11/2007 9:19 a.m.
 
--

[ message continues ]

Hi,

updated to v5.

Changes:
- minor cleanups
- removed modparam for static tty major assignment

Please apply.

David Sterba
---
From: David Sterba <dsterba@suse.cz>

ipwireless: driver for PC Card, 3G internet connection

The device is manufactured by IPWireless.

Rewieved-by: Jiri Slaby <jslaby@suse.cz>
Signed-off-by: Ben Martel <benm@symmetric.co.nz>
Signed-off-by: Stephen Blackheath <stephen@symmetric.co.nz>
Signed-off-by: David Sterba <dsterba@suse.cz>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>
---
 MAINTAINERS                                     |    8 
 drivers/char/pcmcia/Kconfig                     |    9 
 drivers/char/pcmcia/Makefile                    |    2 
 drivers/char/pcmcia/ipwireless/Makefile         |   10 
 drivers/char/pcmcia/ipwireless/hardware.c       | 1787 ++++++++++++++++++++++++
 drivers/char/pcmcia/ipwireless/hardware.h       |   64 
 drivers/char/pcmcia/ipwireless/main.c           |  501 ++++++
 drivers/char/pcmcia/ipwireless/main.h           |   70 
 drivers/char/pcmcia/ipwireless/network.c        |  512 ++++++
 drivers/char/pcmcia/ipwireless/network.h        |   55 
 drivers/char/pcmcia/ipwireless/setup_protocol.h |  108 +
 drivers/char/pcmcia/ipwireless/tty.c            |  688 +++++++++
 drivers/char/pcmcia/ipwireless/tty.h            |   48 
 13 files changed, 3862 insertions(+)
---
diff --git a/MAINTAINERS b/MAINTAINERS
index df40a4e..fc01a22 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -2007,6 +2007,14 @@ M:	acme@ghostprotocols.net
 L:	netdev@vger.kernel.org
 S:	Maintained
 
+IPWIRELES DRIVER
+P:	Jiri Kosina
+M:	jkosina@suse.cz
+P:	David Sterba
+M:	dsterba@suse.cz
+S:	Maintained
+T:	git://git.kernel.org/pub/scm/linux/kernel/git/jikos/ipwireless_cs.git
+
 IRDA SUBSYSTEM
 P:	Samuel Ortiz
 M:	samuel@sortiz.org
diff --git a/drivers/char/pcmcia/Kconfig b/drivers/char/pcmcia/Kconfig
index f25facd..00b8a84 100644
--- a/drivers/char/pcmcia/Kconfig
+++ b/drivers/char/pcmcia/Kconfig
@@ -43,5 +43,14 @@ config ...
[ message continues ]

Linus -- as there are no other pending objections to the code so far, and 
I think we agreed that this has nothing to do neither with wireless tree, 
nor with networking drivers in general (it is basically a PCMCIA serial 
driver, and thus there is no relevant maintainer alive), would you please 
consider merging it for 2.6.25?

David, thanks a lot for taking care of another respin.

Thanks,

-- 
Jiri Kosina
--

[ message continues ]