login
Header Space

 
 

Re: out-of-bounds array index

Score:
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: Jens Axboe <jens.axboe@...>
Cc: <linux-kernel@...>, <torvalds@...>
Date: Thursday, February 7, 2008 - 3:15 pm

On Thursday, February 07, 2008 10:56 am Jens Axboe wrote:

Just a silly off by one, don't know why I didn't catch it earlier.  I'll push 
the fix to the drm tree.  Linus, you may want to take it in parallel.

Jesse

Make sure we have enough room for all the GR registers or we'll end up 
clobbering the AR index register (which should actually be harmless unless 
the BIOS is making an assumption about it).

Signed-off-by:  Jesse Barnes <jesse.barnes@intel.com>

diff --git a/drivers/char/drm/i915_drv.h b/drivers/char/drm/i915_drv.h
index 37bbf67..f8308bf 100644
--- a/drivers/char/drm/i915_drv.h
+++ b/drivers/char/drm/i915_drv.h
@@ -187,7 +187,7 @@ typedef struct drm_i915_private {
 	u32 saveSWF2[3];
 	u8 saveMSR;
 	u8 saveSR[8];
-	u8 saveGR[24];
+	u8 saveGR[25];
 	u8 saveAR_INDEX;
 	u8 saveAR[20];
 	u8 saveDACMASK;
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
out-of-bounds array index, Jens Axboe, (Thu Feb 7, 2:56 pm)
Re: out-of-bounds array index, Jan Engelhardt, (Thu Feb 7, 3:21 pm)
Re: out-of-bounds array index, Jesse Barnes, (Thu Feb 7, 3:28 pm)
Re: out-of-bounds array index, Jens Axboe, (Thu Feb 7, 4:01 pm)
Re: out-of-bounds array index, Jesse Barnes, (Thu Feb 7, 3:15 pm)
Re: out-of-bounds array index, Jesse Barnes, (Thu Feb 7, 3:03 pm)
speck-geostationary