[PATCH -mm] apanel: fix kconfig dependencies

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: lkml <linux-kernel@...>
Cc: <khali@...>, <shemminger@...>, akpm <akpm@...>
Date: Wednesday, February 6, 2008 - 8:27 pm

From: Randy Dunlap <randy.dunlap@oracle.com>

Add I2C to config since the driver makes several i2c*() calls.

Add PCI to config because the config selects I2C_I801, which depends
on PCI, but currently config* does not follow dependency chains,
so randconfig can enable INPUT_APANEL even when PCI is not enabled,
which leads to these warnings:
linux-2.6.24-mm1/drivers/i2c/busses/i2c-i801.c:641: error: implicit declaration of function 'pci_request_region'
/linux-2.6.24-mm1/drivers/i2c/busses/i2c-i801.c:681: error: implicit declaration of function 'pci_release_region'

Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
---
 drivers/input/misc/Kconfig |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- linux-2.6.24-mm1.orig/drivers/input/misc/Kconfig
+++ linux-2.6.24-mm1/drivers/input/misc/Kconfig
@@ -42,7 +42,7 @@ config INPUT_M68K_BEEP
 
 config INPUT_APANEL
 	tristate "Fujitsu Lifebook Application Panel buttons"
-	depends on X86
+	depends on X86 && I2C && PCI
 	select I2C_I801
 	select INPUT_POLLDEV
 	select CHECK_SIGNATURE
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[PATCH -mm] apanel: fix kconfig dependencies, Randy Dunlap, (Wed Feb 6, 8:27 pm)
Re: [PATCH -mm] apanel: fix kconfig dependencies, Jean Delvare, (Thu Feb 7, 12:42 pm)
Re: [PATCH -mm] apanel: fix kconfig dependencies, Randy Dunlap, (Thu Feb 7, 3:04 pm)
Re: [PATCH -mm] apanel: fix kconfig dependencies, Jean Delvare, (Thu Feb 7, 5:46 pm)
Re: [PATCH -mm] apanel: fix kconfig dependencies, Stephen Hemminger, (Thu Feb 7, 3:12 pm)