Home » Mailing list archives » linux-kernel » 2008 » February » 6

Re: [PATCH], issue EOI to APIC prior to calling crash_kexec in die_nmi path

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: Ingo Molnar
Subject: Re: [PATCH], issue EOI to APIC prior to calling crash_kexec in die_nmi path
Date: Wednesday, February 6, 2008 - 3:00 pm

* Neil Horman <nhorman@tuxdriver.com> wrote:


looks good to me, but please move the local_irq_enable() to within 
crash_kexec() instead - probably inside the "got the kexec lock" 
section. That makes crash_kexec() use generally safer too i guess: right 
it seems that die() too can call crash_kexec() with irqs disabled - and 
can thus hang in smp_send_stop() [or wherever it hung before].

	Ingo
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
[PATCH], issue EOI to APIC prior to calling crash_kexec in ..., Neil Horman, (Wed Feb 6, 12:25 pm)
Re: [PATCH], issue EOI to APIC prior to calling crash_kexe ..., Vivek Goyal, (Wed Feb 6, 12:40 pm)
Re: [PATCH], issue EOI to APIC prior to calling crash_kexe ..., Neil Horman, (Wed Feb 6, 1:12 pm)
Re: [PATCH], issue EOI to APIC prior to calling crash_kexe ..., H. Peter Anvin, (Wed Feb 6, 1:21 pm)
Re: [PATCH], issue EOI to APIC prior to calling crash_kexe ..., Vivek Goyal, (Wed Feb 6, 1:35 pm)
Re: [PATCH], issue EOI to APIC prior to calling crash_kexe ..., Neil Horman, (Wed Feb 6, 2:04 pm)
Re: [PATCH], issue EOI to APIC prior to calling crash_kexe ..., Ingo Molnar, (Wed Feb 6, 3:00 pm)
Re: [PATCH], issue EOI to APIC prior to calling crash_kexe ..., Vivek Goyal, (Wed Feb 6, 3:48 pm)
Re: [PATCH], issue EOI to APIC prior to calling crash_kexe ..., Ingo Molnar, (Wed Feb 6, 3:53 pm)
Re: [PATCH], issue EOI to APIC prior to calling crash_kexe ..., H. Peter Anvin, (Wed Feb 6, 3:56 pm)
Re: [PATCH], issue EOI to APIC prior to calling crash_kexe ..., Ingo Molnar, (Wed Feb 6, 4:36 pm)
Re: [PATCH], issue EOI to APIC prior to calling crash_kexe ..., Vivek Goyal, (Wed Feb 6, 4:50 pm)
Re: [PATCH], issue EOI to APIC prior to calling crash_kexe ..., Eric W. Biederman, (Wed Feb 6, 5:31 pm)
Re: [PATCH], issue EOI to APIC prior to calling crash_kexe ..., Ingo Molnar, (Wed Feb 6, 5:39 pm)
Re: [PATCH], issue EOI to APIC prior to calling crash_kexe ..., Eric W. Biederman, (Wed Feb 6, 6:30 pm)
Re: [PATCH], issue EOI to APIC prior to calling crash_kexe ..., Neil Horman, (Thu Feb 7, 5:17 am)
Re: [PATCH], issue EOI to APIC prior to calling crash_kexe ..., Ingo Molnar, (Thu Feb 7, 5:24 am)
Re: [PATCH], issue EOI to APIC prior to calling crash_kexe ..., Neil Horman, (Thu Feb 7, 1:37 pm)
Re: [PATCH], issue EOI to APIC prior to calling crash_kexe ..., Neil Horman, (Fri Feb 8, 9:14 am)
Re: [PATCH], issue EOI to APIC prior to calling crash_kexe ..., Vivek Goyal, (Fri Feb 8, 9:45 am)
Re: [PATCH], issue EOI to APIC prior to calling crash_kexe ..., Andi Kleen, (Fri Feb 8, 9:54 am)
Re: [PATCH], issue EOI to APIC prior to calling crash_kexe ..., Neil Horman, (Fri Feb 8, 10:26 am)
Re: [PATCH], issue EOI to APIC prior to calling crash_kexe ..., Neil Horman, (Tue Feb 12, 2:08 pm)
Re: [PATCH], issue EOI to APIC prior to calling crash_kexe ..., Eric W. Biederman, (Fri Feb 15, 7:02 am)
Re: [PATCH], issue EOI to APIC prior to calling crash_kexe ..., Neil Horman, (Wed Feb 20, 7:57 am)