[PATCH 10/9] firewire: fw-sbp2: preemptively block sdev

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Stefan Richter
Date: Wednesday, February 6, 2008 - 2:07 pm

Since "fw-sbp2: fix I/O errors during reconnect", a Scsi_Host will be
blocked as soon as a command failed due to bus generation change.  Now
we also block it when fw-core signalled a bus reset via sbp2_update.
This will avoid some command failures and retries (but not all because
commands are injected from tasklet context while sbp2_update runs from
workqueue thread context).

Signed-off-by: Stefan Richter <stefanr@s5r6.in-berlin.de>
---
 drivers/firewire/fw-sbp2.c |    1 +
 1 file changed, 1 insertion(+)

Index: linux/drivers/firewire/fw-sbp2.c
===================================================================
--- linux.orig/drivers/firewire/fw-sbp2.c
+++ linux/drivers/firewire/fw-sbp2.c
@@ -1135,6 +1135,7 @@ static void sbp2_update(struct fw_unit *
 	 * Iteration over tgt->lu_list is therefore safe here.
 	 */
 	list_for_each_entry(lu, &tgt->lu_list, link) {
+		sbp2_conditionally_block(lu);
 		lu->retries = 0;
 		sbp2_queue_work(lu, 0);
 	}

-- 
Stefan Richter
-=====-==--- --=- --==-
http://arcgraph.de/sr/

--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[PATCH 0/9] firewire-sbp2: misc hotplug related patches, Stefan Richter, (Sun Feb 3, 3:00 pm)
[PATCH 1/9] firewire: log GUID of new devices, Stefan Richter, (Sun Feb 3, 3:03 pm)
[PATCH 3/9] ieee1394: sbp2: add INQUIRY delay workaround, Stefan Richter, (Sun Feb 3, 3:07 pm)
[PATCH 8/9] firewire: fw-sbp2: sort includes, Stefan Richter, (Sun Feb 3, 3:12 pm)
Re: [PATCH 1/9] firewire: log GUID of new devices, Stefan Richter, (Mon Feb 4, 1:14 am)
[PATCH 10/9] firewire: fw-sbp2: preemptively block sdev, Stefan Richter, (Wed Feb 6, 2:07 pm)
Re: [PATCH 1/9] firewire: log GUID of new devices, Jarod Wilson, (Mon Feb 11, 9:53 am)