Re: [PATCH 5/6] Add OF-tree support to RapidIO controller driver.

view
thread

!MAILaRCHIVE_VOTE_RePLACE

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

[view in full thread]

From: Kumar Gala <galak@...>

To: Stephen Rothwell <sfr@...>

Cc: Zhang Wei <wei.zhang@...>, <mporter@...>, <linuxppc-dev@...>, <linux-kernel@...>

Subject: Re: [PATCH 5/6] Add OF-tree support to RapidIO controller driver.

Date: Tuesday, February 5, 2008 - 12:06 pm

On Feb 4, 2008, at 11:44 PM, Stephen Rothwell wrote:

quoted text>>
>> +	aw = *(u32 *)of_get_property(dev->node, "#address-cells", NULL);
>> +	sw = *(u32 *)of_get_property(dev->node, "#size-cells", NULL);
>
> What happens if either of these properties is missing?

Should we add __must_check to of_get_property?

- k
--
unsubscribe noticeTo unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:

[PATCH 1/6] Change RIO function mpc85xx_ to fsl_ ., Zhang Wei, (Wed Jan 30, 6:30 am)

Re: [PATCH 1/6] Change RIO function mpc85xx_ to fsl_ ., Kumar Gala, (Wed Jan 30, 10:43 am)

RE: [PATCH 1/6] Change RIO function mpc85xx_ to fsl_ ., Zhang Wei, (Thu Jan 31, 2:04 am)

Re: [PATCH 1/6] Change RIO function mpc85xx_ to fsl_ ., Kumar Gala, (Thu Jan 31, 2:15 am)

[PATCH 2/6] Add RapidIO option to kernel configuration., Zhang Wei, (Wed Jan 30, 6:30 am)

[PATCH 3/6] Move include/asm-ppc/rio.h to include/asm-powerp..., Zhang Wei, (Wed Jan 30, 6:30 am)

Re: [PATCH 3/6] Move include/asm-ppc/rio.h to include/asm-po..., Kumar Gala, (Wed Jan 30, 10:20 am)

RE: [PATCH 3/6] Move include/asm-ppc/rio.h to include/asm-po..., Zhang Wei, (Wed Jan 30, 11:36 pm)

[PATCH 4/6] Add multi mport support., Zhang Wei, (Wed Jan 30, 6:30 am)

Re: [PATCH 4/6] Add multi mport support., Kumar Gala, (Wed Jan 30, 10:27 am)

RE: [PATCH 4/6] Add multi mport support., Zhang Wei, (Thu Jan 31, 1:57 am)

Re: [PATCH 4/6] Add multi mport support., Matt Porter, (Tue Feb 5, 12:23 pm)

Re: [PATCH 4/6] Add multi mport support., Kumar Gala, (Thu Jan 31, 2:15 am)

Re: [PATCH 4/6] Add multi mport support., Kumar Gala, (Thu Jan 31, 2:20 am)

RE: [PATCH 4/6] Add multi mport support., Zhang Wei, (Thu Jan 31, 2:30 am)

Re: [PATCH 4/6] Add multi mport support., Matt Porter, (Tue Feb 5, 12:29 pm)

RE: [PATCH 4/6] Add multi mport support., Zhang Wei, (Mon Feb 18, 3:33 am)

RE: [PATCH 4/6] Add multi mport support., Phil Terry, (Thu Jan 31, 2:35 pm)

RE: [PATCH 4/6] Add multi mport support., Zhang Wei, (Fri Feb 1, 12:06 am)

[PATCH 5/6] Add OF-tree support to RapidIO controller driver., Zhang Wei, (Wed Jan 30, 6:30 am)

Re: [PATCH 5/6] Add OF-tree support to RapidIO controller dr..., Stephen Rothwell, (Tue Feb 5, 1:44 am)

Re: [PATCH 5/6] Add OF-tree support to RapidIO controller dr..., Kumar Gala, (Tue Feb 5, 12:06 pm)

RE: [PATCH 5/6] Add OF-tree support to RapidIO controller dr..., Zhang Wei, (Mon Feb 18, 3:24 am)

[PATCH 6/6] Change the kernel configurated RapidIO system si..., Zhang Wei, (Wed Jan 30, 6:30 am)

Re: [PATCH 6/6] Change the kernel configurated RapidIO syste..., Matt Porter, (Tue Feb 5, 12:43 pm)

Navigation

Popular discussions


linux-kernel:
Amit K. Arora	[RFC] Heads up on sys_fallocate()

Tarkan Erimer	Re: Dual-Licensing Linux Kernel with GPL V2 and GPL V3
Greg Kroah-Hartman	[PATCH 001/196] Chinese: Add the known_regression URI to the HOWTO
git:

openbsd-misc:

linux-netdev:
Gerrit Renker	[PATCH 27/37] dccp: Integration of dynamic feature activation - part 2 (server side)
Jarek Poplawski	Re: [PATCH] pkt_sched: Destroy gen estimators under rtnl_lock().
David Miller	[GIT]: Networking
Matheos Worku	2.6.24 BUG: soft lockup - CPU#X

Colocation donated by: