login
Login
/
Register
Search
Search this site:
Forums
News
Blogs
Features
Site
Home
»
Mailing list archives
»
linux-kernel
»
2008
»
February
»
5
Re: [PATCH 02/22] ide-tape: remove struct idetape_read_position_result_t
view
thread
Previous message: [
thread
] [
date
] [
author
]
Next message: [
thread
] [
date
] [
author
]
[view in full thread]
From: Bartlomiej Zolnierkiewicz
Subject:
Re: [PATCH 02/22] ide-tape: remove struct idetape_read_position_result_t
Date: Monday, February 4, 2008 - 6:23 pm
On Monday 04 February 2008, Borislav Petkov wrote:
quoted text
> There should be no functional changes resulting from this patch. > > Signed-off-by: Borislav Petkov <petkovbb@gmail.com> > --- > drivers/ide/ide-tape.c | 49 +++++++++++++++++------------------------------ > 1 files changed, 18 insertions(+), 31 deletions(-) > > diff --git a/drivers/ide/ide-tape.c b/drivers/ide/ide-tape.c > index 442d71c..c8c57ab 100644 > --- a/drivers/ide/ide-tape.c > +++ b/drivers/ide/ide-tape.c
[...]
quoted text
> if (!tape->pc->error) { > - result = (idetape_read_position_result_t *) tape->pc->buffer; > - debug_log(DBG_SENSE, "BOP - %s\n", result->bop ? "Yes" : "No"); > - debug_log(DBG_SENSE, "EOP - %s\n", result->eop ? "Yes" : "No"); > + debug_log(DBG_SENSE, "BOP - %s\n", > + !!(readpos[0] & 0x80) ? "Yes" : "No"); > + debug_log(DBG_SENSE, "EOP - %s\n", > + !!(readpos[0] & 0x40) ? "Yes" : "No"); > + > + if (!!(readpos[0] & 0x4)) { > + printk(KERN_INFO "ide-tape: Block location is unknown" > + "to the tape\n");
I removed needless "!!" while merging the patch. --
unsubscribe notice
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to
majordomo@vger.kernel.org
More majordomo info at
http://vger.kernel.org/majordomo-info.html
Please read the FAQ at
http://www.tux.org/lkml/
Previous message: [
thread
] [
date
] [
author
]
Next message: [
thread
] [
date
] [
author
]
Messages in current thread:
[No subject]
, Borislav Petkov
, (Mon Feb 4, 6:40 am)
[PATCH 01/22] ide-tape: refactor the debug logging facility
, Borislav Petkov
, (Mon Feb 4, 6:40 am)
[PATCH 02/22] ide-tape: remove struct idetape_read_positio ...
, Borislav Petkov
, (Mon Feb 4, 6:40 am)
[PATCH 03/22] ide-tape: remove unreachable code chunk
, Borislav Petkov
, (Mon Feb 4, 6:40 am)
[PATCH 04/22] ide-tape: simplify code branching in the int ...
, Borislav Petkov
, (Mon Feb 4, 6:40 am)
[PATCH 05/22] ide-tape: remove typedef idetape_chrdev_dire ...
, Borislav Petkov
, (Mon Feb 4, 6:40 am)
[PATCH 06/22] ide-tape: struct idetape_tape_t: remove unus ...
, Borislav Petkov
, (Mon Feb 4, 6:40 am)
[PATCH 07/22] ide-tape: struct idetape_tape_t: shorten mem ...
, Borislav Petkov
, (Mon Feb 4, 6:40 am)
[PATCH 08/22] ide-tape: remove packet command and struct r ...
, Borislav Petkov
, (Mon Feb 4, 6:40 am)
[PATCH 09/22] ide-tape: remove idetape_increase_max_pipeli ...
, Borislav Petkov
, (Mon Feb 4, 6:40 am)
[PATCH 10/22] ide-tape: shorten some function names
, Borislav Petkov
, (Mon Feb 4, 6:40 am)
[PATCH 11/22] ide-tape: remove atomic test/set macros
, Borislav Petkov
, (Mon Feb 4, 6:40 am)
[PATCH 12/22] ide-tape: dump gcw fields on error in idetap ...
, Borislav Petkov
, (Mon Feb 4, 6:40 am)
[PATCH 13/22] ide-tape: remove struct idetape_id_gcw
, Borislav Petkov
, (Mon Feb 4, 6:40 am)
[PATCH 14/22] ide-tape: cleanup and fix comments
, Borislav Petkov
, (Mon Feb 4, 6:40 am)
[PATCH 15/22] ide-tape: remove unused "length" arg from id ...
, Borislav Petkov
, (Mon Feb 4, 6:40 am)
[PATCH 16/22] ide-tape: include proper headers
, Borislav Petkov
, (Mon Feb 4, 6:40 am)
[PATCH 17/22] ide-tape: collect module-related macro calls ...
, Borislav Petkov
, (Mon Feb 4, 6:40 am)
[PATCH 18/22] ide-tape: remove leftover OnStream support w ...
, Borislav Petkov
, (Mon Feb 4, 6:40 am)
[PATCH 19/22] ide-tape: fix syntax error in idetape_identi ...
, Borislav Petkov
, (Mon Feb 4, 6:40 am)
[PATCH 20/22] ide-tape: cleanup the remaining codestyle issues
, Borislav Petkov
, (Mon Feb 4, 6:40 am)
[PATCH 21/22] ide-tape: bump minor driver version
, Borislav Petkov
, (Mon Feb 4, 6:40 am)
[PATCH 22/22] ide-tape: schedule driver for removal after ...
, Borislav Petkov
, (Mon Feb 4, 6:40 am)
ide-tape redux (was: Re:)
, Bartlomiej Zolnierki ...
, (Mon Feb 4, 6:20 pm)
Re: [PATCH 02/22] ide-tape: remove struct idetape_read_pos ...
, Bartlomiej Zolnierki ...
, (Mon Feb 4, 6:23 pm)
Re: [PATCH 07/22] ide-tape: struct idetape_tape_t: shorten ...
, Bartlomiej Zolnierki ...
, (Mon Feb 4, 6:23 pm)
Re: [PATCH 14/22] ide-tape: cleanup and fix comments
, Bartlomiej Zolnierki ...
, (Mon Feb 4, 6:27 pm)
Re: [PATCH 20/22] ide-tape: cleanup the remaining codestyl ...
, Bartlomiej Zolnierki ...
, (Mon Feb 4, 6:27 pm)
Re: [PATCH 07/22] ide-tape: struct idetape_tape_t: shorten ...
, Borislav Petkov
, (Mon Feb 4, 9:47 pm)
Re: ide-tape redux (was: Re:)
, Borislav Petkov
, (Tue Feb 5, 10:23 pm)
Re: ide-tape redux (was: Re:)
, Borislav Petkov
, (Tue Feb 5, 10:27 pm)
Re: ide-tape redux (was: Re:)
, Bartlomiej Zolnierki ...
, (Sat Feb 9, 9:25 am)
Re: ide-tape redux (was: Re:)
, Bartlomiej Zolnierki ...
, (Sat Feb 9, 9:25 am)
[PATCH 1/2] ide-tape: move all struct and other defs at th ...
, Borislav Petkov
, (Sat Feb 9, 12:42 pm)
[PATCH 2/2] ide-tape: remove atomic test/set macros for pa ...
, Borislav Petkov
, (Sat Feb 9, 12:43 pm)
Re: [PATCH 1/2] ide-tape: move all struct and other defs a ...
, Bartlomiej Zolnierki ...
, (Mon Feb 11, 3:12 pm)
Re: [PATCH 2/2] ide-tape: remove atomic test/set macros fo ...
, Bartlomiej Zolnierki ...
, (Mon Feb 11, 3:12 pm)
Re: [PATCH 06/22] ide-tape: struct idetape_tape_t: remove ...
, Sergei Shtylyov
, (Mon Sep 22, 6:25 am)
Re: [PATCH 06/22] ide-tape: struct idetape_tape_t: remove ...
, Boris Petkov
, (Mon Sep 22, 6:58 am)
Re: [PATCH 06/22] ide-tape: struct idetape_tape_t: remove ...
, Sergei Shtylyov
, (Mon Sep 22, 8:50 am)
Navigation
Mailing list archives
Recent posts
Popular discussions
linux-kernel
:
Ken Chen
[patch] sched: fix inconsistency when redistribute per-cpu tg->cfs_rq shares.
Ingo Molnar
Re: [PATCH v3] x86: merge the simple bitops and move them to bitops.h
Paul Turner
[tg_shares_up rewrite v4 11/11] sched: update tg->shares after cpu.shares write
Andi Kleen
Re: - romsignature-checksum-cleanup-2.patch removed from -mm tree
Stefano Stabellini
Re: [PATCH 09/22] xen: Find an unbound irq number in reverse order (high to low).
git
:
Junio C Hamano
Re: Teach "git checkout" to use git-show-ref
Christian Jaeger
Re: Problem with Git.pm bidi_pipe methods
Linus Torvalds
[PATCH 1/7] Make unpack_trees_options bit flags actual bitfields
Jon Smirl
stgit: managing signed-off-by lines
Junio C Hamano
GIT 1.4.3-rc2
git-commits-head
:
Linux Kernel Mailing List
MIPS: Bonito64: Make Loongson independent from Bonito64 code.
Linux Kernel Mailing List
iwlwifi: initialize spinlock before use
Linux Kernel Mailing List
i2c-i801: Add Intel Cougar Point device IDs
Linux Kernel Mailing List
drm/i915: Add information on pinning and fencing to the i915 list debug.
Linux Kernel Mailing List
cirrusfb: GD5434 (aka SD64) support fixed
linux-netdev
:
Gerrit Renker
v2 [PATCH 1/4] dccp: Limit feature negotiation to connection setup phase
Richard Cochran
Re: [PATCH v3 3/3] ptp: Added a clock that uses the eTSEC found on the MPC85xx.
Inaky Perez-Gonzalez
[PATCH 40/40] wimax/i2400m: add CREDITS and MAINTAINERS entries
Sathya Perla
[PATCH net-next-2.6] be2net: add multiple RX queue support
Changli Gao
Re: [PATCH 3/3] ifb: move tq from ifb_private
freebsd-current
:
Boris Samorodov
Re: twa + dump = sbwait
韓家標 Bill Hacker
Re: ZFS honesty
Bjoern A. Zeeb
Re: Can not boot 7.0-BETA3 with IPSEC
rmgls
man usb2_core(4)
Sam Leffler
Re: Lots of "ath0: bad series0 hwrate 0x1b" in 8.0-BETA2
Colocation donated by:
Syndicate