Home » Mailing list archives » linux-kernel » 2008 » February » 4

[PATCH][drivers/misc/thinkpad_acpi.c] duplicate test 'if (level & TP_EC_FAN_FULLSPEED)'

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: Roel kluin <rjckluin@...>
To: <ibm-acpi@...>, <len.brown@...>
Cc: <linux-acpi@...>, <ibm-acpi-devel@...>, lkml <linux-kernel@...>
Subject: [PATCH][drivers/misc/thinkpad_acpi.c] duplicate test 'if (level &amp; TP_EC_FAN_FULLSPEED)'
Date: Monday, February 4, 2008 - 5:59 pm

in drivers/misc/thinkpad_acpi.c, lines 4137-4142 it reads:

                /* safety net should the EC not support AUTO
                 * or FULLSPEED mode bits and just ignore them */
                if (level & TP_EC_FAN_FULLSPEED)
                        level |= 7;     /* safety min speed 7 */
                else if (level & TP_EC_FAN_FULLSPEED)
                        level |= 4;     /* safety min speed 4 */

note the nonsense duplicate test 'if (level & TP_EC_FAN_FULLSPEED)'.
should this be changed to:

                if (level & TP_EC_FAN_FULLSPEED)
                        level |= 7;     /* safety min speed 7 */
                else
                        level |= 4;     /* safety min speed 4 */

or maybe

                if (level & TP_EC_FAN_FULLSPEED)
                        level |= 7;     /* safety min speed 7 */
                if (level & TP_EC_FAN_FULLSPEED)
                        level |= 4;     /* safety min speed 4 */

?
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
[PATCH][drivers/misc/thinkpad_acpi.c] duplicate test 'if (le..., Roel kluin, (Mon Feb 4, 5:59 pm)