Home » Mailing list archives » linux-kernel » 2008 » February » 4

Re: [drivers/misc/thinkpad_acpi.c] duplicate test if (level & TP_EC_FAN_FULLSPEED)

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: Roland Dreier <rdreier@...>
To: Roel Kluin <12o3l@...>
Cc: <len.brown@...>, <ibm-acpi@...>, <ibm-acpi-devel@...>, <linux-acpi@...>, lkml <linux-kernel@...>
Subject: Re: [drivers/misc/thinkpad_acpi.c] duplicate test if (level &amp; TP_EC_FAN_FULLSPEED)
Date: Monday, February 4, 2008 - 6:13 pm

>                 /* safety net should the EC not support AUTO
 >                  * or FULLSPEED mode bits and just ignore them */
 >                 if (level & TP_EC_FAN_FULLSPEED)
 >                         level |= 7;     /* safety min speed 7 */
 >                 else if (level & TP_EC_FAN_FULLSPEED)
 >                         level |= 4;     /* safety min speed 4 */
 > 
 > Note the duplicate test 'if (level & TP_EC_FAN_FULLSPEED)'. should
 > this be replaced by

Actually I suspect one of the two tests should be against TP_EC_FAN_AUTO
(based on the comment).
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
[drivers/misc/thinkpad_acpi.c] duplicate test if (level &amp..., Roel Kluin, (Mon Feb 4, 6:07 pm)
Re: [drivers/misc/thinkpad_acpi.c] duplicate test if (level ..., Roland Dreier, (Mon Feb 4, 6:13 pm)
[PATCH][drivers/misc/thinkpad_acpi.c] duplicate test if (lev..., Roel Kluin, (Mon Feb 4, 7:24 pm)
Re: [PATCH][drivers/misc/thinkpad_acpi.c] duplicate test if ..., Len Brown, (Thu Feb 7, 2:17 am)
Re: [PATCH][drivers/misc/thinkpad_acpi.c] duplicate test if ..., Henrique de Moraes Holschuh..., (Tue Feb 5, 1:05 am)
Re: [PATCH][drivers/misc/thinkpad_acpi.c] duplicate test if ..., Roel Kluin, (Tue Feb 5, 4:34 am)
Re: [PATCH][drivers/misc/thinkpad_acpi.c] duplicate test if ..., Greg KH, (Wed Feb 6, 7:07 pm)
Re: [PATCH][drivers/misc/thinkpad_acpi.c] duplicate test if ..., Roel Kluin, (Wed Feb 6, 7:48 pm)
Re: [stable] [PATCH][drivers/misc/thinkpad_acpi.c] duplicate..., Greg KH, (Thu Feb 7, 1:55 am)
Re: [PATCH][drivers/misc/thinkpad_acpi.c] duplicate test if ..., Henrique de Moraes Holschuh..., (Wed Feb 6, 9:18 pm)
Re: [stable] [PATCH][drivers/misc/thinkpad_acpi.c] duplicate..., Greg KH, (Thu Feb 7, 3:28 am)