[drivers/misc/thinkpad_acpi.c] duplicate test if (level & TP_EC_FAN_FULLSPEED)

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: <len.brown@...>, <ibm-acpi@...>
Cc: <ibm-acpi-devel@...>, <linux-acpi@...>, lkml <linux-kernel@...>
Date: Monday, February 4, 2008 - 6:07 pm

in drivers/misc/thinkpad_acpi.c: 4137-4142 it reads:

                /* safety net should the EC not support AUTO
                 * or FULLSPEED mode bits and just ignore them */
                if (level & TP_EC_FAN_FULLSPEED)
                        level |= 7;     /* safety min speed 7 */
                else if (level & TP_EC_FAN_FULLSPEED)
                        level |= 4;     /* safety min speed 4 */

Note the duplicate test 'if (level & TP_EC_FAN_FULLSPEED)'. should
this be replaced by

                if (level & TP_EC_FAN_FULLSPEED)
                        level |= 7;     /* safety min speed 7 */
                else
                        level |= 4;     /* safety min speed 4 */

or 

                if (level & TP_EC_FAN_FULLSPEED)
                        level |= 7;     /* safety min speed 7 */
                if (level & TP_EC_FAN_FULLSPEED)
                        level |= 4;     /* safety min speed 4 */

?
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[drivers/misc/thinkpad_acpi.c] duplicate test if (level &..., Roel Kluin, (Mon Feb 4, 6:07 pm)
Re: [PATCH][drivers/misc/thinkpad_acpi.c] duplicate test if ..., Henrique de Moraes Holschuh..., (Tue Feb 5, 1:05 am)
Re: [PATCH][drivers/misc/thinkpad_acpi.c] duplicate test if ..., Henrique de Moraes Holschuh..., (Wed Feb 6, 9:18 pm)