[PATCH 1/1] iucv: Fix compilation with !CONFIG_SMP

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: <linux-s390@...>, <linux-kernel@...>
Cc: Josef 'Jeff' Sipek <jeffpc@...>, <ubraun@...>, <blaschka@...>
Date: Friday, February 29, 2008 - 6:30 pm

CC [M]  net/iucv/iucv.o
net/iucv/iucv.c: In function `iucv_cleanup_queue':
net/iucv/iucv.c:657: error: `__iucv_cleanup_queue' undeclared (first use in this function)

With !CONFIG_SMP the smp_call_function call turns into up_smp_call_function
call which is just a return 0. Unfortunately, since up_smp_call_function is
a static inline, the __iucv_cleanup_queue symbol is referenced.

Cc: ubraun@linux.vnet.ibm.com
Cc: blaschka@linux.vnet.ibm.com
Signed-off-by: Josef 'Jeff' Sipek <jeffpc@josefsipek.net>
---
 net/iucv/iucv.c |    2 --
 1 files changed, 0 insertions(+), 2 deletions(-)

diff --git a/net/iucv/iucv.c b/net/iucv/iucv.c
index 2753b0c..d764f4c 100644
--- a/net/iucv/iucv.c
+++ b/net/iucv/iucv.c
@@ -621,7 +621,6 @@ static int iucv_sever_pathid(u16 pathid, u8 userdata[16])
 	return iucv_call_b2f0(IUCV_SEVER, parm);
 }
 
-#ifdef CONFIG_SMP
 /**
  * __iucv_cleanup_queue
  * @dummy: unused dummy argument
@@ -632,7 +631,6 @@ static int iucv_sever_pathid(u16 pathid, u8 userdata[16])
 static void __iucv_cleanup_queue(void *dummy)
 {
 }
-#endif
 
 /**
  * iucv_cleanup_queue
-- 
1.5.4.2
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[PATCH 1/1] iucv: Fix compilation with !CONFIG_SMP, Josef 'Jeff' Sipek, (Fri Feb 29, 6:30 pm)
Re: [PATCH] CodingStyle: multiple updates, Bodo Eggert, (Fri Feb 29, 8:10 pm)