Re: [PATCH 01/11] Security: Add hook to get full maclabel xattr name

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: Trond Myklebust <trond.myklebust@...>, <casey@...>
Cc: Christoph Hellwig <hch@...>, Dave Quigley <dpquigl@...>, Stephen Smalley <sds@...>, <viro@...>, <bfields@...>, <linux-kernel@...>, <linux-fsdevel@...>, LSM List <linux-security-module@...>
Date: Friday, February 29, 2008 - 5:07 pm

--- Trond Myklebust <trond.myklebust@fys.uio.no> wrote:


Hum. Security metadata was one of the justifications for the
original implementation of the xattr interface for XFS at SGI.
The implementation was intended to be generic and allow for
storage of data that impacts system behavior. No, it is not
overloading at all, it is really supposed to be used that way.
That's how it works on CXFS, which I know is still proprietary,
but which could become an open peer of NFS someday.


Yes, I can see that having a specific interface reduces the
documentation required, and simplifies it as well. Unfortunately,
given the way that a secctx is defined for either SELinux or
Smack, and the fact that the relationships between secctx values
are defined independently on the server and client* it does not
appear that the interoperability issue has been addressed, or
even really acknowleged with the proposed scheme. Yes, the issue
of label translation has been acknowleged, but it appears to me
that a day one solution is required for the scheme to be useful.

So I suggest, again from a position of possible ignorance, that
the proposed scheme suffers from some of the same interoperability
and specification issues that a name/value pair scheme does, with
the only real improvement being that the name part is hard coded.
Perhaps that is sufficient improvement to justify the loss of
generality, but I personally wouldn't think so.

-----
* Identical SELinux policy or Smack rule specifications are not
  necessaily sufficient to ensure label transparency.


Casey Schaufler
casey@schaufler-ca.com
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
RFC Labeled NFS Initial Code Review, David P. Quigley, (Wed Feb 27, 6:11 pm)
Re: RFC Labeled NFS Initial Code Review, Dave Quigley, (Wed Feb 27, 9:23 pm)
Re: RFC Labeled NFS Initial Code Review, Dave Quigley, (Wed Feb 27, 8:48 pm)
[PATCH 06/11] SELinux: Add new labeling type native labels, David P. Quigley, (Wed Feb 27, 6:11 pm)
[PATCH 03/11] VFS: Add security label support to *notify, David P. Quigley, (Wed Feb 27, 6:11 pm)
Re: [PATCH 03/11] VFS: Add security label support to *notify, Christoph Hellwig, (Thu Feb 28, 7:54 pm)
Re: [PATCH 03/11] VFS: Add security label support to *notify, Christoph Hellwig, (Thu Feb 28, 8:23 pm)
Re: [PATCH 01/11] Security: Add hook to get full maclabel xa..., Christoph Hellwig, (Thu Feb 28, 7:48 pm)
Re: [PATCH 01/11] Security: Add hook to get full maclabel xa..., Christoph Hellwig, (Thu Feb 28, 8:39 pm)
Re: [PATCH 01/11] Security: Add hook to get full maclabel xa..., Christoph Hellwig, (Thu Feb 28, 9:00 pm)
Re: [PATCH 01/11] Security: Add hook to get full maclabel xa..., Christoph Hellwig, (Thu Feb 28, 8:51 pm)
Re: [PATCH 01/11] Security: Add hook to get full maclabel xa..., Casey Schaufler, (Fri Feb 29, 5:07 pm)
[PATCH 11/11] NFSD: Server implementation of MAC Labeling, David P. Quigley, (Wed Feb 27, 6:11 pm)
[PATCH 09/11] NFS: Client implementation of Labeled-NFS, David P. Quigley, (Wed Feb 27, 6:11 pm)