login
Header Space

 
 

Re: [PATCH] x86_64 ia32 syscall restart fix

Score:
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: Ingo Molnar <mingo@...>
Cc: Roland McGrath <roland@...>, Andrew Morton <akpm@...>, Thomas Gleixner <tglx@...>, <linux-kernel@...>
Date: Friday, February 29, 2008 - 1:03 pm

On Fri, 29 Feb 2008, Ingo Molnar wrote:

Heh, yeah. My percentage ends up being much lower, mostly because patches 
that come through Andrew are generally already cleaned-up (I edit those 
too, but it tends to be one or two per batch, not more than that).

I'm happy you do edit them, because not everybody does, and I do think 
it's part of being a subsystem maintainer, but I also end up occasionally 
sending emails to the parties involved to try to keep editing to a mimumum 
in the future - I personally suspect that it's to a large degree because 
people don't think about the effect in the logs..

(Some other projects also tend to have very different models for what a 
commit message should look like, so much of it is probably "cultural" too. 

I've seen projects that consistently had totally unreadable one-liner 
commit messages because (a) nobody ever read them anyway (because the log 
just isn't useful when it's per-file) and (b) people were encouraged to 
just use things like 'cvs ci -m"Fix bug"' to check in their stuff.

So the kernel is probably fairly odd in generally not asking for any 
fixed-format stuff at all (like the GNU changelogs do) but instead writing 
a small human-readable novella ;)

			Linus
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[PATCH] x86_64 ia32 syscall restart fix, Roland McGrath, (Thu Feb 28, 11:57 pm)
[PATCH] x86_64 ptrace orig_ax on ia32 task, Roland McGrath, (Fri Mar 7, 6:56 pm)
Re: [PATCH] x86_64 ptrace orig_ax on ia32 task, Chuck Ebbert, (Mon Mar 10, 3:19 pm)
Re: [PATCH] x86_64 ptrace orig_ax on ia32 task, Linus Torvalds, (Mon Mar 10, 3:48 pm)
Re: [PATCH] x86_64 ptrace orig_ax on ia32 task, Roland McGrath, (Mon Mar 10, 4:01 pm)
Re: [PATCH] x86_64 ptrace orig_ax on ia32 task, Ingo Molnar, (Tue Mar 11, 5:32 am)
Re: [PATCH] x86_64 ptrace orig_ax on ia32 task, Linus Torvalds, (Fri Mar 7, 7:18 pm)
Re: [PATCH] x86_64 ptrace orig_ax on ia32 task, Roland McGrath, (Fri Mar 7, 9:37 pm)
Re: [PATCH] x86_64 ia32 syscall restart fix, Ingo Molnar, (Fri Feb 29, 11:52 am)
Re: [PATCH] x86_64 ia32 syscall restart fix, Linus Torvalds, (Fri Feb 29, 12:26 pm)
Re: [PATCH] x86_64 ia32 syscall restart fix, Roland McGrath, (Fri Feb 29, 6:42 pm)
Re: [PATCH] x86_64 ia32 syscall restart fix, Linus Torvalds, (Fri Feb 29, 7:18 pm)
Re: [PATCH] x86_64 ia32 syscall restart fix, Ingo Molnar, (Fri Feb 29, 12:45 pm)
Re: [PATCH] x86_64 ia32 syscall restart fix, Linus Torvalds, (Fri Feb 29, 1:03 pm)
Re: [PATCH] x86_64 ia32 syscall restart fix, Ingo Molnar, (Fri Feb 29, 1:17 pm)
Re: [PATCH] x86_64 ia32 syscall restart fix, Ingo Molnar, (Fri Feb 29, 1:37 pm)
Re: [PATCH] x86_64 ia32 syscall restart fix, Andrew Morton, (Fri Feb 29, 5:02 pm)
Re: [PATCH] x86_64 ia32 syscall restart fix, Ingo Molnar, (Fri Feb 29, 5:20 pm)
speck-geostationary