A change after 2.6.24 broke ndiswrapper by accidentally removing its access to GPL-only symbols. Revert that change and add comments about the reasons why ndiswrapper and driverloader are treated in a special way. Signed-off-by: Pavel Roskin <proski@gnu.org> --- kernel/module.c | 9 ++++++++- 1 files changed, 8 insertions(+), 1 deletions(-) diff --git a/kernel/module.c b/kernel/module.c index 901cd6a..a11f523 100644 --- a/kernel/module.c +++ b/kernel/module.c @@ -1933,8 +1933,15 @@ static struct module *load_module(void __user *umod, /* Set up license info based on the info section */ set_license(mod, get_modinfo(sechdrs, infoindex, "license")); + /* + * ndiswrapper is under GPL by itself, but loads proprietary modules. + * Don't use add_taint_module(), as it would prevent ndiswrapper from + * using GPL-only symbols it needs. + */ if (strcmp(mod->name, "ndiswrapper") == 0) - add_taint_module(mod, TAINT_PROPRIETARY_MODULE); + add_taint(TAINT_PROPRIETARY_MODULE); + + /* driverloader was caught wrongly pretending to be under GPL */ if (strcmp(mod->name, "driverloader") == 0) add_taint_module(mod, TAINT_PROPRIETARY_MODULE); -- Regards, Pavel Roskin --
| David Miller | [GIT]: Networking |
| Fred . | Please add ZFS support (from GPL sources) |
| Pavel Roskin | [PATCH 2.6.25] module: allow ndiswrapper to use GPL-only symbols |
| David Howells | [PATCH 02/52] CRED: Give in_group_p() a cred pointer |
git: | |
| Dmitry Torokhov | Garbage in .git directories??? |
| Dan Farina | backup or mirror a repository |
| Sergei Organov | Newbie: report of first experience with git-rebase. |
| Richard Quirk | git-cherry-pick no longer detecting moved files in 1.5.3.4 |
| Kevin | uvm_mapent_alloc: out of static map entries on 4.3 i386 |
| GVG GVG | ssh_exchange_identification: Connection closed by remote host |
| Douglas A. Tutty | how get colour mutt when ssh from OBSD? |
| Brandon Lee | DELL PERC 5iR slow performance |
| Hubert Feyrer | Compressed vnd handling tested successfully |
| Jaromir Dolecek | Arch-specific maxproc limit? |
| YAMAMOTO Takashi | scheduler_wait_hook |
| David Laight | Re: Integrating securelevel and kauth(9) |
