login
Header Space

 
 

Re: [PATCH 01/11] Security: Add hook to get full maclabel xattr name

Score:
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: Stephen Smalley <sds@...>, <casey@...>
Cc: Dave Quigley <dpquigl@...>, <hch@...>, <viro@...>, <trond.myklebust@...>, <bfields@...>, <linux-kernel@...>, <linux-fsdevel@...>, LSM List <linux-security-module@...>
Date: Thursday, February 28, 2008 - 3:59 pm

--- Stephen Smalley <sds@tycho.nsa.gov> wrote:


I think that I am listening, and I appologize for doing
such a poor job of getting my view on the across.


Do you understand that if the functionality being proposed
is specific to a particular file system it ought to be contained
in that file system, not proposed as a part of the general
purpose interface?


The ACL funtionality over NFS could be done using general interfaces,
and there are examples (e.g. Irix) where it has been done. I
understand the rationale for the current implementation while
disagreeing with that rationale. Further, there is a major difference
between ACLs and a legitimate LSM (for MAC or DAC) in that ACLs
are a change to the Linux access control scheme (they interact with
the mode bits) whereas a legitimate LSM is strictly additional
restrictions.


I should hope then that your SELinux specific NFS server should
look at the name presented and treat it appropriately.


You're correct, you don't. You can propose anything you like.
Don't take my criticisms personally, but I think you're wrong
on this one. I don't like to see this unnecessary limitation,
the kind that could haunt the code base for years, when it seems
pretty obvious that it could be better.



Casey Schaufler
casey@schaufler-ca.com
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
RFC Labeled NFS Initial Code Review, David P. Quigley, (Wed Feb 27, 6:11 pm)
Re: RFC Labeled NFS Initial Code Review, Dave Quigley, (Wed Feb 27, 9:23 pm)
Re: RFC Labeled NFS Initial Code Review, Dave Quigley, (Wed Feb 27, 8:48 pm)
[PATCH 06/11] SELinux: Add new labeling type native labels, David P. Quigley, (Wed Feb 27, 6:11 pm)
[PATCH 03/11] VFS: Add security label support to *notify, David P. Quigley, (Wed Feb 27, 6:11 pm)
Re: [PATCH 03/11] VFS: Add security label support to *notify, Christoph Hellwig, (Thu Feb 28, 7:54 pm)
Re: [PATCH 03/11] VFS: Add security label support to *notify, Christoph Hellwig, (Thu Feb 28, 8:23 pm)
Re: [PATCH 01/11] Security: Add hook to get full maclabel xa..., Christoph Hellwig, (Thu Feb 28, 7:48 pm)
Re: [PATCH 01/11] Security: Add hook to get full maclabel xa..., Christoph Hellwig, (Thu Feb 28, 8:39 pm)
Re: [PATCH 01/11] Security: Add hook to get full maclabel xa..., Christoph Hellwig, (Thu Feb 28, 9:00 pm)
Re: [PATCH 01/11] Security: Add hook to get full maclabel xa..., Christoph Hellwig, (Thu Feb 28, 8:51 pm)
Re: [PATCH 01/11] Security: Add hook to get full maclabel xa..., Casey Schaufler, (Thu Feb 28, 3:59 pm)
[PATCH 11/11] NFSD: Server implementation of MAC Labeling, David P. Quigley, (Wed Feb 27, 6:11 pm)
[PATCH 09/11] NFS: Client implementation of Labeled-NFS, David P. Quigley, (Wed Feb 27, 6:11 pm)
speck-geostationary