login
Header Space

 
 

[PATCH] firewire: fw-ohci: add option for remote debugging

Previous thread: [PATCH 0/4] firewire: trivial fw-sbp2 updates by Stefan Richter on Thursday, February 28, 2008 - 3:50 pm. (5 messages)

Next thread: 'git gc' always run, on old kernel repo? by Jeff Garzik on Thursday, February 28, 2008 - 3:57 pm. (6 messages)
To: <linux1394-devel@...>
Cc: <linux-kernel@...>, Bernhard Kaindl <bk@...>
Date: Thursday, February 28, 2008 - 3:54 pm

This way firewire-ohci can be used for remote debugging like ohci1394.

Signed-off-by: Stefan Richter &lt;stefanr@s5r6.in-berlin.de&gt;
---
 Documentation/debugging-via-ohci1394.txt |   13 ++++++++-----
 drivers/firewire/fw-ohci.c               |    9 +++++++++
 lib/Kconfig.debug                        |   10 ++++++++++
 3 files changed, 27 insertions(+), 5 deletions(-)

Index: linux/Documentation/debugging-via-ohci1394.txt
===================================================================
--- linux.orig/Documentation/debugging-via-ohci1394.txt
+++ linux/Documentation/debugging-via-ohci1394.txt
@@ -41,11 +41,14 @@ to a working state and enables physical 
 This can be turned off by ohci1394's module parameter phys_dma=0.
 
 The alternative firewire-ohci driver in drivers/firewire uses filtered physical
-DMA, hence is not yet suitable for remote debugging.
-
-Because ohci1394 depends on the PCI enumeration to be completed, an
-initialization routine which runs pretty early (long before console_init()
-which makes the printk buffer appear on the console can be called) was written.
+DMA by default, which is more secure but not suitable for remote debugging.
+Compile the driver with CONFIG_FIREWIRE_OHCI_REMOTE_DMA to get unfiltered
+physical DMA.
+
+Because ohci1394 and firewire-ohci depend on the PCI enumeration to be
+completed, an initialization routine which runs pretty early has been
+implemented for x86.  This routine runs long before console_init() can be
+called, i.e. before the printk buffer appears on the console.
 
 To activate it, enable CONFIG_PROVIDE_OHCI1394_DMA_INIT (Kernel hacking menu:
 Provide code for enabling DMA over FireWire early on boot) and pass the
Index: linux/drivers/firewire/fw-ohci.c
===================================================================
--- linux.orig/drivers/firewire/fw-ohci.c
+++ linux/drivers/firewire/fw-ohci.c
@@ -1091,6 +1091,11 @@ static void bus_reset_tasklet(unsigned l
 		reg_write(ohci, OHCI1394_ConfigROMhdr, ohci-&gt;next_hea...
Previous thread: [PATCH 0/4] firewire: trivial fw-sbp2 updates by Stefan Richter on Thursday, February 28, 2008 - 3:50 pm. (5 messages)

Next thread: 'git gc' always run, on old kernel repo? by Jeff Garzik on Thursday, February 28, 2008 - 3:57 pm. (6 messages)
speck-geostationary