login
Header Space

 
 

Re: [RFC/PATCH 0/4] CPUSET driven CPU isolation

Score:
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: Paul Jackson <pj@...>
Cc: Ingo Molnar <mingo@...>, <a.p.zijlstra@...>, <tglx@...>, <oleg@...>, <rostedt@...>, <maxk@...>, <linux-kernel@...>
Date: Thursday, February 28, 2008 - 6:12 am

On Thu, 28 Feb 2008, David Rientjes wrote:


Something like this?
---
 include/linux/sched.h |    1 +
 kernel/cpuset.c       |    5 ++++-
 kernel/kthread.c      |    1 +
 kernel/sched.c        |    6 ++++++
 4 files changed, 12 insertions(+), 1 deletions(-)

diff --git a/include/linux/sched.h b/include/linux/sched.h
--- a/include/linux/sched.h
+++ b/include/linux/sched.h
@@ -1464,6 +1464,7 @@ static inline void put_task_struct(struct task_struct *t)
 #define PF_SWAPWRITE	0x00800000	/* Allowed to write to swap */
 #define PF_SPREAD_PAGE	0x01000000	/* Spread page cache over cpuset */
 #define PF_SPREAD_SLAB	0x02000000	/* Spread some slab caches over cpuset */
+#define PF_CPU_BOUND	0x04000000	/* Kthread bound to specific cpu */
 #define PF_MEMPOLICY	0x10000000	/* Non-default NUMA mempolicy */
 #define PF_MUTEX_TESTER	0x20000000	/* Thread belongs to the rt mutex tester */
 #define PF_FREEZER_SKIP	0x40000000	/* Freezer should not count it as freezeable */
diff --git a/kernel/cpuset.c b/kernel/cpuset.c
--- a/kernel/cpuset.c
+++ b/kernel/cpuset.c
@@ -1175,11 +1175,14 @@ static void cpuset_attach(struct cgroup_subsys *ss,
 	struct mm_struct *mm;
 	struct cpuset *cs = cgroup_cs(cont);
 	struct cpuset *oldcs = cgroup_cs(oldcont);
+	int ret;
 
 	mutex_lock(&callback_mutex);
 	guarantee_online_cpus(cs, &cpus);
-	set_cpus_allowed(tsk, cpus);
+	ret = set_cpus_allowed(tsk, cpus);
 	mutex_unlock(&callback_mutex);
+	if (ret < 0)
+		return;
 
 	from = oldcs->mems_allowed;
 	to = cs->mems_allowed;
diff --git a/kernel/kthread.c b/kernel/kthread.c
--- a/kernel/kthread.c
+++ b/kernel/kthread.c
@@ -180,6 +180,7 @@ void kthread_bind(struct task_struct *k, unsigned int cpu)
 	wait_task_inactive(k);
 	set_task_cpu(k, cpu);
 	k->cpus_allowed = cpumask_of_cpu(cpu);
+	k->flags |= PF_CPU_BOUND;
 }
 EXPORT_SYMBOL(kthread_bind);
 
diff --git a/kernel/sched.c b/kernel/sched.c
--- a/kernel/sched.c
+++ b/kernel/sched.c
@@ -5345,6 +5345,12 @@ int set_cpus_allowed(struct task_struct *p, cpumask_t new_mask)
 		goto out;
 	}
 
+	if (unlikely((p->flags & PF_CPU_BOUND) && p != current &&
+	    	     !cpus_equal(p->cpus_allowed, new_mask))) {
+		ret = -EINVAL;
+		goto out;
+	}
+
 	if (p->sched_class->set_cpus_allowed)
 		p->sched_class->set_cpus_allowed(p, &new_mask);
 	else {
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[RFC/PATCH 0/4] CPUSET driven CPU isolation, Peter Zijlstra, (Wed Feb 27, 6:21 pm)
[RFC/PATCH] cpuset: cpuset irq affinities, Peter Zijlstra, (Fri Feb 29, 2:55 pm)
Re: [RFC/PATCH] cpuset: cpuset irq affinities, Christoph Hellwig, (Sun Mar 2, 1:18 am)
Re: [RFC/PATCH] cpuset: cpuset irq affinities, Paul Jackson, (Fri Feb 29, 4:55 pm)
Re: [RFC/PATCH] cpuset: cpuset irq affinities, Peter Zijlstra, (Fri Feb 29, 5:14 pm)
Re: [RFC/PATCH] cpuset: cpuset irq affinities, Paul Jackson, (Fri Feb 29, 5:53 pm)
Re: [RFC/PATCH] cpuset: cpuset irq affinities, Max Krasnyanskiy, (Fri Feb 29, 5:42 pm)
Re: [RFC/PATCH] cpuset: cpuset irq affinities, Paul Jackson, (Fri Feb 29, 6:00 pm)
Re: [RFC/PATCH] cpuset: cpuset irq affinities, Ingo Molnar, (Fri Feb 29, 5:32 pm)
Re: [RFC/PATCH] cpuset: cpuset irq affinities, Ingo Molnar, (Fri Feb 29, 5:29 pm)
Re: [RFC/PATCH] cpuset: cpuset irq affinities, Ingo Molnar, (Fri Feb 29, 3:02 pm)
Re: [RFC/PATCH] cpuset: cpuset irq affinities, Max Krasnyanskiy, (Fri Feb 29, 4:52 pm)
Re: [RFC/PATCH] cpuset: cpuset irq affinities, Peter Zijlstra, (Fri Feb 29, 5:03 pm)
Re: [RFC/PATCH] cpuset: cpuset irq affinities, Max Krasnyanskiy, (Fri Feb 29, 5:20 pm)
Re: [RFC/PATCH] cpuset: cpuset irq affinities, Peter Zijlstra, (Mon Mar 3, 7:57 am)
Re: [RFC/PATCH] cpuset: cpuset irq affinities, Paul Jackson, (Mon Mar 3, 1:36 pm)
Re: [RFC/PATCH] cpuset: cpuset irq affinities, Peter Zijlstra, (Mon Mar 3, 1:57 pm)
Re: [RFC/PATCH] cpuset: cpuset irq affinities, Paul Jackson, (Mon Mar 3, 2:10 pm)
Re: [RFC/PATCH] cpuset: cpuset irq affinities, Paul Menage, (Mon Mar 3, 2:41 pm)
Re: [RFC/PATCH] cpuset: cpuset irq affinities, Paul Jackson, (Mon Mar 3, 2:52 pm)
Re: [RFC/PATCH] cpuset: cpuset irq affinities, Paul Menage, (Tue Mar 4, 1:26 am)
Re: [RFC/PATCH] cpuset: cpuset irq affinities, Paul Jackson, (Tue Mar 4, 2:15 am)
Re: [RFC/PATCH] cpuset: cpuset irq affinities, Paul Menage, (Tue Mar 4, 2:21 am)
Re: [RFC/PATCH] cpuset: cpuset irq affinities, Paul Jackson, (Tue Mar 4, 2:26 am)
Re: [RFC/PATCH] cpuset: cpuset irq affinities, Paul Menage, (Tue Mar 4, 2:34 am)
Re: [RFC/PATCH] cpuset: cpuset irq affinities, Paul Jackson, (Tue Mar 4, 2:51 am)
Re: [RFC/PATCH] cpuset: cpuset irq affinities, Peter Zijlstra, (Mon Mar 3, 2:18 pm)
Re: [RFC/PATCH] cpuset: cpuset irq affinities, Paul Jackson, (Tue Mar 4, 3:35 am)
Re: [RFC/PATCH] cpuset: cpuset irq affinities, Peter Zijlstra, (Tue Mar 4, 7:06 am)
Re: [RFC/PATCH] cpuset: cpuset irq affinities, Max Krasnyanskiy, (Tue Mar 4, 3:52 pm)
Re: [RFC/PATCH] cpuset: cpuset irq affinities, Paul Jackson, (Tue Mar 4, 9:11 pm)
Re: [RFC/PATCH] cpuset: cpuset irq affinities, Peter Zijlstra, (Wed Mar 5, 4:37 am)
Re: [RFC/PATCH] cpuset: cpuset irq affinities, Paul Jackson, (Thu Mar 6, 9:47 am)
Re: [RFC/PATCH] cpuset: cpuset irq affinities, Peter Zijlstra, (Thu Mar 6, 11:21 am)
Re: [RFC/PATCH] cpuset: cpuset irq affinities, Paul Jackson, (Thu Mar 6, 11:40 pm)
Re: [RFC/PATCH] cpuset: cpuset irq affinities, Paul Jackson, (Fri Mar 7, 2:39 am)
Re: [RFC/PATCH] cpuset: cpuset irq affinities, Paul Menage, (Fri Mar 7, 4:47 am)
Re: [RFC/PATCH] cpuset: cpuset irq affinities, Paul Jackson, (Fri Mar 7, 10:57 am)
Re: [RFC/PATCH] cpuset: cpuset irq affinities, Max Krasnyansky, (Wed Mar 5, 3:17 pm)
Re: [RFC/PATCH] cpuset: cpuset irq affinities, Ingo Molnar, (Wed Mar 5, 4:50 am)
Re: [RFC/PATCH] cpuset: cpuset irq affinities, Paul Jackson, (Wed Mar 5, 8:35 am)
Re: [RFC/PATCH] cpuset: cpuset irq affinities, Ingo Molnar, (Wed Mar 5, 8:43 am)
Re: [RFC/PATCH] cpuset: cpuset irq affinities, Paul Jackson, (Wed Mar 5, 1:44 pm)
Re: [RFC/PATCH 0/4] CPUSET driven CPU isolation, Mark Hounschell, (Thu Feb 28, 8:12 am)
Re: [RFC/PATCH 0/4] CPUSET driven CPU isolation, Max Krasnyansky, (Thu Feb 28, 3:57 pm)
Re: [RFC/PATCH 0/4] CPUSET driven CPU isolation, Ingo Molnar, (Thu Feb 28, 3:50 am)
Re: [RFC/PATCH 0/4] CPUSET driven CPU isolation, Andrew Morton, (Fri Feb 29, 4:31 am)
Re: [RFC/PATCH 0/4] CPUSET driven CPU isolation, Ingo Molnar, (Fri Feb 29, 5:10 am)
Re: [RFC/PATCH 0/4] CPUSET driven CPU isolation, Max Krasnyanskiy, (Fri Feb 29, 2:06 pm)
Re: [RFC/PATCH 0/4] CPUSET driven CPU isolation, Andrew Morton, (Fri Feb 29, 4:36 am)
Re: [RFC/PATCH 0/4] CPUSET driven CPU isolation, Max Krasnyanskiy, (Thu Feb 28, 1:48 pm)
Re: [RFC/PATCH 0/4] CPUSET driven CPU isolation, Paul Jackson, (Thu Feb 28, 4:08 am)
Re: [RFC/PATCH 0/4] CPUSET driven CPU isolation, Ingo Molnar, (Thu Feb 28, 5:08 am)
Re: [RFC/PATCH 0/4] CPUSET driven CPU isolation, Max Krasnyansky, (Thu Feb 28, 4:23 pm)
Re: [RFC/PATCH 0/4] CPUSET driven CPU isolation, Paul Jackson, (Thu Feb 28, 5:17 am)
Re: [RFC/PATCH 0/4] CPUSET driven CPU isolation, Ingo Molnar, (Thu Feb 28, 6:46 am)
Re: [RFC/PATCH 0/4] CPUSET driven CPU isolation, Max Krasnyansky, (Thu Feb 28, 4:11 pm)
Re: [RFC/PATCH 0/4] CPUSET driven CPU isolation, Paul Jackson, (Thu Feb 28, 4:13 pm)
Re: [RFC/PATCH 0/4] CPUSET driven CPU isolation, Max Krasnyansky, (Thu Feb 28, 4:26 pm)
Re: [RFC/PATCH 0/4] CPUSET driven CPU isolation, Paul Jackson, (Thu Feb 28, 4:27 pm)
Re: [RFC/PATCH 0/4] CPUSET driven CPU isolation, Max Krasnyansky, (Thu Feb 28, 4:45 pm)
Re: [RFC/PATCH 0/4] CPUSET driven CPU isolation, Paul Jackson, (Thu Feb 28, 1:47 pm)
Re: [RFC/PATCH 0/4] CPUSET driven CPU isolation, David Rientjes, (Thu Feb 28, 5:32 am)
Re: [RFC/PATCH 0/4] CPUSET driven CPU isolation, David Rientjes, (Thu Feb 28, 6:12 am)
Re: [RFC/PATCH 0/4] CPUSET driven CPU isolation, Paul Jackson, (Thu Feb 28, 1:37 pm)
Re: [RFC/PATCH 0/4] CPUSET driven CPU isolation, David Rientjes, (Thu Feb 28, 5:24 pm)
Re: [RFC/PATCH 0/4] CPUSET driven CPU isolation, Paul Jackson, (Thu Feb 28, 6:46 pm)
Re: [RFC/PATCH 0/4] CPUSET driven CPU isolation, David Rientjes, (Thu Feb 28, 7:00 pm)
Re: [RFC/PATCH 0/4] CPUSET driven CPU isolation, Paul Jackson, (Thu Feb 28, 8:16 pm)
Re: [RFC/PATCH 0/4] CPUSET driven CPU isolation, David Rientjes, (Thu Feb 28, 9:05 pm)
Re: [RFC/PATCH 0/4] CPUSET driven CPU isolation, Paul Jackson, (Thu Feb 28, 11:34 pm)
Re: [RFC/PATCH 0/4] CPUSET driven CPU isolation, David Rientjes, (Fri Feb 29, 12:00 am)
Re: [RFC/PATCH 0/4] CPUSET driven CPU isolation, Paul Jackson, (Fri Feb 29, 2:53 am)
Re: [RFC/PATCH 0/4] CPUSET driven CPU isolation, Peter Zijlstra, (Thu Feb 28, 6:26 am)
Re: [RFC/PATCH 0/4] CPUSET driven CPU isolation, Max Krasnyanskiy, (Wed Feb 27, 7:38 pm)
Re: [RFC/PATCH 0/4] CPUSET driven CPU isolation, Peter Zijlstra, (Thu Feb 28, 6:19 am)
Re: [RFC/PATCH 0/4] CPUSET driven CPU isolation, Max Krasnyanskiy, (Thu Feb 28, 1:33 pm)
speck-geostationary