login
Header Space

 
 

Re: [PATCH 1/2] firewire: endianess fix

Score:
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: <benh@...>
Cc: Kristian Hoegsberg <krh@...>, <linux-kernel@...>, <linuxppc-dev@...>, <sparclinux@...>, <linux1394-devel@...>, Sam Ravnborg <sam@...>, Harvey Harrison <harvey.harrison@...>
Date: Thursday, February 28, 2008 - 4:41 am

Benjamin Herrenschmidt wrote:

According to ohci1394.c, it selfIDs and headers of incoming packets are 
not byte-swapped by the old Apple Uninorth FireWire part.  And no, 
firewire-ohci doesn't have the workaround yet.

It should be trivial to copy'n'paste ohci1394's workaround into fw-ohci, 
but it would be good if someone could test before and after.

BTW, since that code is touched everytime a packet is received, we 
should enclose such a workaround in #ifdef CONFIG_PPC_PMAC && 
CONFIG_PPC32, shouldn't we?  (As a second step after adding the workaround.)
-- 
Stefan Richter
-=====-==--- --=- ===--
http://arcgraph.de/sr/
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
sparse - make __CHECK_ENDIAN__ default enabled?, Sam Ravnborg, (Wed Feb 20, 6:03 pm)
Re: sparse - make __CHECK_ENDIAN__ default enabled?, Harvey Harrison, (Wed Feb 20, 6:39 pm)
Re: sparse - make __CHECK_ENDIAN__ default enabled?, Sam Ravnborg, (Wed Feb 20, 6:51 pm)
Re: sparse - make __CHECK_ENDIAN__ default enabled?, Harvey Harrison, (Wed Feb 20, 6:18 pm)
[PATCH 2/2] firewire: endianess annotations, Stefan Richter, (Sat Feb 23, 7:24 am)
[PATCH 1/2] firewire: endianess fix, Stefan Richter, (Sat Feb 23, 7:24 am)
Re: [PATCH 1/2] firewire: endianess fix, Benjamin Herrenschmidt, (Wed Feb 27, 10:41 pm)
Re: [PATCH 1/2] firewire: endianess fix, Stefan Richter, (Thu Feb 28, 4:41 am)
Re: [PATCH 1/2] firewire: endianess fix, Jarod Wilson, (Wed Feb 27, 3:58 pm)
Re: [PATCH 1/2] firewire: endianess fix, Jarod Wilson, (Wed Feb 27, 11:33 pm)
Re: [PATCH 1/2] firewire: endianess fix, Benjamin Herrenschmidt, (Wed Feb 27, 10:40 pm)
Re: [PATCH 1/2] firewire: endianess fix, Jarod Wilson, (Wed Feb 27, 11:21 pm)
Re: [PATCH 1/2] firewire: endianess fix, Benjamin Herrenschmidt, (Thu Feb 28, 2:25 am)
Re: [PATCH 1/2] firewire: endianess fix, Jarod Wilson, (Thu Feb 28, 2:42 pm)
Re: [PATCH 1/2] firewire: endianess fix, Benjamin Herrenschmidt, (Thu Feb 28, 7:26 pm)
Re: [PATCH 1/2] firewire: endianess fix, Jarod Wilson, (Fri Feb 29, 1:48 am)
Re: [PATCH 1/2] firewire: endianess fix, Gabriel Paubert, (Mon Mar 3, 5:19 am)
Re: [PATCH 1/2] firewire: endianess fix, Stefan Richter, (Mon Mar 3, 10:35 am)
Re: [PATCH 1/2] firewire: endianess fix, Gabriel Paubert, (Wed Mar 5, 6:59 pm)
Re: [PATCH 1/2] firewire: endianess fix, Stefan Richter, (Wed Mar 5, 7:26 pm)
Re: [PATCH 1/2] firewire: endianess fix, Gabriel Paubert, (Thu Mar 6, 4:23 pm)
Re: [PATCH 1/2] firewire: endianess fix, Paul Mackerras, (Fri Feb 29, 7:26 am)
Re: [PATCH 1/2] firewire: endianess fix, Jarod Wilson, (Fri Feb 29, 11:34 am)
Re: [PATCH 1/2] firewire: endianess fix, Stefan Richter, (Fri Feb 29, 7:52 am)
Re: [PATCH 1/2] firewire: endianess fix, Benjamin Herrenschmidt, (Fri Feb 29, 5:49 pm)
Re: [PATCH 1/2] firewire: endianess fix, Benjamin Herrenschmidt, (Fri Feb 29, 2:00 am)
Re: [PATCH 1/2] firewire: endianess fix, Stefan Richter, (Wed Feb 27, 4:08 pm)
Re: [PATCH 1/2] firewire: endianess fix, Jarod Wilson, (Wed Feb 27, 4:21 pm)
Re: [PATCH 1/2] firewire: endianess fix, Stefan Richter, (Sat Feb 23, 8:12 am)
Re: [PATCH 1/2] firewire: endianess fix, Stefan Richter, (Sat Mar 1, 8:36 am)
Re: [PATCH 1/2] firewire: endianess fix, Stefan Richter, (Sat Feb 23, 7:36 am)
speck-geostationary