| From | Subject | Date |
|---|---|---|
| Randy Dunlap | Feb 27, 4:40 pm 2008 | |
| Luis Henriques | [PATCH] drivers/message/i2o/device.c warnings
Hi,
file drivers/message/i2o/device.c contains the following warnings:
drivers/message/i2o/device.c: In function ‘i2o_device_add’:
drivers/message/i2o/device.c:247: warning: ignoring return value of ‘sysfs_create_link’, declared with attribute warn_unused_result
drivers/message/i2o/device.c:254: warning: ignoring return value of ‘sysfs_create_link’, declared with attribute warn_unused_result
drivers/message/i2o/device.c:260: warning: ignoring return value of ‘sysfs_create_link’, declared with ...
| Feb 27, 4:14 pm 2008 |
| David P. Quigley | [PATCH 05/11] NFSv4: Add label recommended attribute and ...
This patch adds a new recommended attribute named label into the NFSv4 file
attribute structure. It also adds several new flags to allow the
NFS client and server to determine if this attribute is supported and if it is
being sent over the wire.
Signed-off-by: David P. Quigley <dpquigl@tycho.nsa.gov>
---
fs/nfs/nfs4proc.c | 3 +++
include/linux/nfs4.h | 2 ++
include/linux/nfs_fs_sb.h | 1 +
include/linux/nfs_xdr.h | 4 ++++
include/linux/nfsd/export.h | ...
| Feb 27, 1:39 pm 2008 |
| David P. Quigley | RFC Labeled NFS Initial Code Review
This patch set is the first submission to fs-devel and lkml for the purpose of
code review. To test the patch set you need patches to nfs-utils as well. Since
this is just a code review I haven't posted the patch to nfs-utils however if
you want to test the code feel free to e-mail me and I will send you the
necessary patch.
Out of all of the functionality we have prototyped I have narrowed it down to
these items which I believe is the solid base for initial kernel inclusion.
These patches ...
| Feb 27, 1:39 pm 2008 |
| David P. Quigley | [PATCH 08/11] NFS: Introduce lifecycle management for la ...
Two fields have been added to the nfs_fattr structure to carry the security
label and its length. This has raised the need to provide lifecycle management
for these values. This patch introduces two macros nfs_fattr_alloc and
nfs_fattr_fini which are used to allocate and destroy these fields inside the
nfs_fattr structure. These macros do not modify any other components of the
structure so nfs_fattr_init still has to be used on these structures. In the
event that CONFIG_SECURITY is not set these ...
| Feb 27, 1:39 pm 2008 |
| David P. Quigley | [PATCH 02/11] Security: Add hook to calculate context ba ...
There is a time where we need to calculate a context without the
inode having been created yet. To do this we take the negative dentry and
calculate a context based on the process and the parent directory contexts.
Signed-off-by: David P. Quigley <dpquigl@tycho.nsa.gov>
---
include/linux/security.h | 11 +++++++++++
security/dummy.c | 7 +++++++
security/security.c | 9 +++++++++
security/selinux/hooks.c | 38 ++++++++++++++++++++++++++++++++++++++
4 files changed, 65 ...
| Feb 27, 1:39 pm 2008 |
| David P. Quigley | [PATCH 03/11] VFS: Add security label support to *notify
This patch adds two new fields to the iattr structure. The first field holds a
security label while the second contains the length of this label. In addition
the patch adds a new helper function inode_setsecurity which calls the LSM to
set the security label on the inode. Finally the patch modifies the necessary
functions such that fsnotify_change can handle notification requests for
dnotify and inotify.
Signed-off-by: David P. Quigley <dpquigl@tycho.nsa.gov>
---
fs/attr.c | ...
| Feb 27, 1:39 pm 2008 |
| David P. Quigley | [PATCH 09/11] NFS: Client implementation of Labeled-NFS
There are several places where recommended attributes are implemented in the
NFSv4 client code. This patch adds two functions to encode and decode the secid
recommended attribute which makes use of the LSM hooks added earlier. It also
adds code to grab the label from the file attribute structures and encode the
label to be sent back to the server. Even though the code is there to encode a
label to be sent back to the server there does not appear to be an interface to
use it yet.
Signed-off-by: ...
| Feb 27, 1:39 pm 2008 |
| David P. Quigley | [PATCH 04/11] KConfig: Add KConfig entries for SELinux l ...
This patch adds two entries into the fs/KConfig file. The first entry
NFS_V4_SECURITY_LABEL enables security label support for the NFSv4 client while
the second entry NFSD_V4_SECURITY_LABEL enables security labeling support on
the server side. These entries are currently marked as EXPERIMENTAL to indicate
that at the moment they are only suitable for testing purposes and that the
functionality they provide may change before it is removed from experimental
status.
Signed-off-by: David P. Quigley ...
| Feb 27, 1:39 pm 2008 |
| David P. Quigley | [PATCH 07/11] NFS/SELinux: Add security_label text mount ...
The new method for pulling argument for NFS from mount is through a text
parsing system. This patch adds two new entries to the argument parsing code
"securlty_label" and "nosecurity_label". Even though we use text across the
user/kernel boundary internally we still pack a binary structure for mount info
to be passed around. We add a flag for use in the nfs{4,}_mount_data struct to
indicate that are using security labels. Finally we add the SELinux support to
mark the labeling method as ...
| Feb 27, 1:39 pm 2008 |
| David P. Quigley | [PATCH 01/11] Security: Add hook to get full maclabel xa ...
Before the inode_xattr_getsecurity call was removed the caller would
concatenate the security namespace prefix and the suffix provided by the lsm to
obtain the security xattr. This hook provides the functionality to obtain the full
LSM xattr name. The patch also provides implementations for the dummy security
module and SELinux. This method is used instead of restoring the old method
since it only requires an offset into the returned pointer to obtain the
suffix. This approach is more efficient ...
| Feb 27, 1:39 pm 2008 |
| David P. Quigley | [PATCH 06/11] SELinux: Add new labeling type native labels
There currently doesn't exist a labeling type that is adequate for use with
labeled nfs. Since NFS doesn't really support xattrs we can't use the use xattr
labeling behavior. For this we developed a new labeling type. The native
labeling type is used solely by NFS to ensure nfs inodes are labeled at runtime
by the NFS code instead of relying on the SELinux security server on the client
end.
Signed-off-by: David P. Quigley <dpquigl@tycho.nsa.gov>
---
security/selinux/hooks.c | 20 ...
| Feb 27, 1:39 pm 2008 |
| David P. Quigley | [PATCH 10/11] NFS: Extend nfs xattr handlers to accept t ...
The existing nfs4 xattr handlers do not accept xattr calls to the security
namespace. This patch extends these handlers to accept xattrs from the security
namespace in addition to the default nfsv4 acl namespace.
Signed-off-by: David P. Quigley <dpquigl@tycho.nsa.gov>
---
fs/nfs/nfs4proc.c | 54 +++++++++++++++++++++++++++++++++++++++++-----------
1 files changed, 42 insertions(+), 12 deletions(-)
diff --git a/fs/nfs/nfs4proc.c b/fs/nfs/nfs4proc.c
index a1a4051..d7193df 100644
--- ...
| Feb 27, 1:39 pm 2008 |
| David P. Quigley | [PATCH 11/11] NFSD: Server implementation of MAC Labeling
This patch implements the encoding of a MAC label on the server side to be
sent across the wire to the NFSv4 client. At this time there is no method of
receiving a label from the client to be set on the server.
Signed-off-by: David P. Quigley <dpquigl@tycho.nsa.gov>
---
fs/nfsd/nfs4xdr.c | 90 ++++++++++++++++++++++++++++++++++++++++++++++++++-
fs/nfsd/vfs.c | 7 ++++
security/security.c | 1 +
3 files changed, 97 insertions(+), 1 deletions(-)
diff --git a/fs/nfsd/nfs4xdr.c ...
| Feb 27, 1:39 pm 2008 |
| David P. Quigley | [PATCH 04/11] KConfig: Add KConfig entries for SELinux l ...
This patch adds two entries into the fs/KConfig file. The first entry
NFS_V4_SECURITY_LABEL enables security label support for the NFSv4 client while
the second entry NFSD_V4_SECURITY_LABEL enables security labeling support on
the server side. These entries are currently marked as EXPERIMENTAL to indicate
that at the moment they are only suitable for testing purposes and that the
functionality they provide may change before it is removed from experimental
status.
Signed-off-by: David P. Quigley ...
| Feb 27, 3:11 pm 2008 |
| David P. Quigley | [PATCH 03/11] VFS: Add security label support to *notify
This patch adds two new fields to the iattr structure. The first field holds a
security label while the second contains the length of this label. In addition
the patch adds a new helper function inode_setsecurity which calls the LSM to
set the security label on the inode. Finally the patch modifies the necessary
functions such that fsnotify_change can handle notification requests for
dnotify and inotify.
Signed-off-by: David P. Quigley <dpquigl@tycho.nsa.gov>
---
fs/attr.c | ...
| Feb 27, 3:11 pm 2008 |
| David P. Quigley | [PATCH 07/11] NFS/SELinux: Add security_label text mount ...
The new method for pulling argument for NFS from mount is through a text
parsing system. This patch adds two new entries to the argument parsing code
"securlty_label" and "nosecurity_label". Even though we use text across the
user/kernel boundary internally we still pack a binary structure for mount info
to be passed around. We add a flag for use in the nfs{4,}_mount_data struct to
indicate that are using security labels. Finally we add the SELinux support to
mark the labeling method as ...
| Feb 27, 3:11 pm 2008 |
| David P. Quigley | [PATCH 08/11] NFS: Introduce lifecycle management for la ...
Two fields have been added to the nfs_fattr structure to carry the security
label and its length. This has raised the need to provide lifecycle management
for these values. This patch introduces two macros nfs_fattr_alloc and
nfs_fattr_fini which are used to allocate and destroy these fields inside the
nfs_fattr structure. These macros do not modify any other components of the
structure so nfs_fattr_init still has to be used on these structures. In the
event that CONFIG_SECURITY is not set these ...
| Feb 27, 3:11 pm 2008 |
| David P. Quigley | [PATCH 09/11] NFS: Client implementation of Labeled-NFS
There are several places where recommended attributes are implemented in the
NFSv4 client code. This patch adds two functions to encode and decode the secid
recommended attribute which makes use of the LSM hooks added earlier. It also
adds code to grab the label from the file attribute structures and encode the
label to be sent back to the server. Even though the code is there to encode a
label to be sent back to the server there does not appear to be an interface to
use it yet.
Signed-off-by: ...
| Feb 27, 3:11 pm 2008 |
| David P. Quigley | [PATCH 02/11] Security: Add hook to calculate context ba ...
There is a time where we need to calculate a context without the
inode having been created yet. To do this we take the negative dentry and
calculate a context based on the process and the parent directory contexts.
Signed-off-by: David P. Quigley <dpquigl@tycho.nsa.gov>
---
include/linux/security.h | 11 +++++++++++
security/dummy.c | 7 +++++++
security/security.c | 9 +++++++++
security/selinux/hooks.c | 38 ++++++++++++++++++++++++++++++++++++++
4 files changed, 65 ...
| Feb 27, 3:11 pm 2008 |
| David P. Quigley | [PATCH 06/11] SELinux: Add new labeling type native labels
There currently doesn't exist a labeling type that is adequate for use with
labeled nfs. Since NFS doesn't really support xattrs we can't use the use xattr
labeling behavior. For this we developed a new labeling type. The native
labeling type is used solely by NFS to ensure nfs inodes are labeled at runtime
by the NFS code instead of relying on the SELinux security server on the client
end.
Signed-off-by: David P. Quigley <dpquigl@tycho.nsa.gov>
---
security/selinux/hooks.c | 20 ...
| Feb 27, 3:11 pm 2008 |
| David P. Quigley | [PATCH 05/11] NFSv4: Add label recommended attribute and ...
This patch adds a new recommended attribute named label into the NFSv4 file
attribute structure. It also adds several new flags to allow the
NFS client and server to determine if this attribute is supported and if it is
being sent over the wire.
Signed-off-by: David P. Quigley <dpquigl@tycho.nsa.gov>
---
fs/nfs/nfs4proc.c | 3 +++
include/linux/nfs4.h | 2 ++
include/linux/nfs_fs_sb.h | 1 +
include/linux/nfs_xdr.h | 4 ++++
include/linux/nfsd/export.h | ...
| Feb 27, 3:11 pm 2008 |
| David P. Quigley | [PATCH 10/11] NFS: Extend nfs xattr handlers to accept t ...
The existing nfs4 xattr handlers do not accept xattr calls to the security
namespace. This patch extends these handlers to accept xattrs from the security
namespace in addition to the default nfsv4 acl namespace.
Signed-off-by: David P. Quigley <dpquigl@tycho.nsa.gov>
---
fs/nfs/nfs4proc.c | 54 +++++++++++++++++++++++++++++++++++++++++-----------
1 files changed, 42 insertions(+), 12 deletions(-)
diff --git a/fs/nfs/nfs4proc.c b/fs/nfs/nfs4proc.c
index a1a4051..d7193df 100644
--- ...
| Feb 27, 3:11 pm 2008 |
| David P. Quigley | [PATCH 01/11] Security: Add hook to get full maclabel xa ...
Before the inode_xattr_getsecurity call was removed the caller would
concatenate the security namespace prefix and the suffix provided by the lsm to
obtain the security xattr. This hook provides the functionality to obtain the full
LSM xattr name. The patch also provides implementations for the dummy security
module and SELinux. This method is used instead of restoring the old method
since it only requires an offset into the returned pointer to obtain the
suffix. This approach is more efficient ...
| Feb 27, 3:11 pm 2008 |
| David P. Quigley | [PATCH 11/11] NFSD: Server implementation of MAC Labeling
This patch implements the encoding of a MAC label on the server side to be
sent across the wire to the NFSv4 client. At this time there is no method of
receiving a label from the client to be set on the server.
Signed-off-by: David P. Quigley <dpquigl@tycho.nsa.gov>
---
fs/nfsd/nfs4xdr.c | 90 ++++++++++++++++++++++++++++++++++++++++++++++++++-
fs/nfsd/vfs.c | 7 ++++
security/security.c | 1 +
3 files changed, 97 insertions(+), 1 deletions(-)
diff --git a/fs/nfsd/nfs4xdr.c ...
| Feb 27, 3:11 pm 2008 |
| Casey Schaufler | Re: [PATCH 01/11] Security: Add hook to get full maclabe ...
I think that calling this a maclabel is a really bad idea. For one
thing, it assumes that all interesting security attributes are for
Mandatory Access Control. Also, it assumes that they are stored as
xattrs. While these conditions are both met by the two current LSMs
I would suggest that this is not a fair assumption for the long
haul unless the intention is to lock the lSM into only supporting
xattr based label based MAC modules.
If you are only interested in supporting one LSM then the ...
| Feb 27, 4:42 pm 2008 |
| David P. Quigley | RFC Labeled NFS Initial Code Review
This patch set is the first submission to fs-devel and lkml for the purpose of
code review. To test the patch set you need patches to nfs-utils as well. Since
this is just a code review I haven't posted the patch to nfs-utils however if
you want to test the code feel free to e-mail me and I will send you the
necessary patch.
Out of all of the functionality we have prototyped I have narrowed it down to
these items which I believe is the solid base for initial kernel inclusion.
These patches ...
| Feb 27, 3:11 pm 2008 |
| Kei Tokunaga | A strange behavior of sched_fair
Hi Ingo,
I am playing around with sched_fair and cgroup, and it seems like
I hit a possible bug. Could you also check if that is a bug?
Description of behavior:
Start a cpu-bound task (t1), attach it to a cgroup (cgA), and let the
task to run for a while (e.g. several tens of seconds or a couple of
minutes would be adequate.) Then, start another cpu-bound task (t2)
and attach it to cgA in the way described in "Steps to Reproduce" section.
You will see t1 does not get run for ...
| Feb 27, 3:51 pm 2008 |
| Bartlomiej Zolnierki ... | [PATCH 2/3] ide-cs: manage I/O resources in driver
* Make idecs_register() return pointer to hwif structure instead of
hwif's index.
* Store pointer to hwif structure instead of hwif's index in ide_info_t
(fixes ide-cs for IDE[6-9]_MAJOR major numbers).
* Remove no longer needed ide_major[].
* Tell IDE layer to not manage resources by setting hwif->mmio flag.
* Use {request,release}_region() for resources management.
* Use driver name for resources management.
Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
---
...
| Feb 27, 4:03 pm 2008 |
| Bartlomiej Zolnierki ... | [PATCH 1/3] ide-pnp: manage I/O resources in driver
* Tell IDE layer to not manage resources by setting hwif->mmio flag.
* Use {request,release}_region() for resources management.
* Use driver name for resources management.
Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
---
drivers/ide/ide-pnp.c | 29 +++++++++++++++++++++++++++--
1 file changed, 27 insertions(+), 2 deletions(-)
Index: b/drivers/ide/ide-pnp.c
===================================================================
--- a/drivers/ide/ide-pnp.c
+++ ...
| Feb 27, 4:02 pm 2008 |
| Bartlomiej Zolnierki ... | [PATCH 3/3] ide: remove ide_hwif_release_regions()
All host drivers using ide_unregister()/module_exit() have been fixed
to manage resources themselves so this function can be removed now.
There should be no functional changes caused by this patch.
Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
---
drivers/ide/ide.c | 25 -------------------------
include/linux/ide.h | 1 -
2 files changed, 26 deletions(-)
Index: b/drivers/ide/ide.c
===================================================================
--- ...
| Feb 27, 4:04 pm 2008 |
| Peter Zijlstra | [RFC/PATCH 4/4] kthread: system set kthread affinities
Keep the affinities of unbound kthreads within the system set.
Signed-off-by: Peter Zijlstra <a.p.zijlstra@chello.nl>
---
kernel/kthread.c | 50 ++++++++++++++++++++++++++++++++++++++++++++++++--
1 file changed, 48 insertions(+), 2 deletions(-)
Index: linux-2.6/kernel/kthread.c
===================================================================
--- linux-2.6.orig/kernel/kthread.c
+++ linux-2.6/kernel/kthread.c
@@ -13,6 +13,8 @@
#include <linux/file.h>
#include <linux/module.h>
...
| Feb 27, 3:21 pm 2008 |
| Peter Zijlstra | [RFC/PATCH 0/4] CPUSET driven CPU isolation
My vision on the direction we should take wrt cpu isolation.
Next on the list would be figuring out a nice solution to the workqueue
flush issue.
--
| Feb 27, 3:21 pm 2008 |
| Max Krasnyanskiy | Re: [RFC/PATCH 0/4] CPUSET driven CPU isolation
General impressions:
- "cpu_system_map" is %100 identical to the "~cpu_isolated_map" as in my
patches. It's updated from different place but functionally wise it's very
much the same. I guess you did not like the 'isolated' name ;-). As I
mentioned before I'm not hung up on the name so it's cool :).
- Updating cpu_system_map from cpusets
There are a couple of things that I do not like about this approach:
1. We lost the ability to isolate CPUs at boot. Which means slower boot times
for me ...
| Feb 27, 4:38 pm 2008 |
| Peter Zijlstra | [RFC/PATCH 3/4] genirq: system set irq affinities
Keep the affinity of unbound IRQs within the system set.
Signed-off-by: Peter Zijlstra <a.p.zijlstra@chello.nl>
---
arch/alpha/kernel/irq.c | 2 -
include/linux/irq.h | 7 -----
kernel/irq/manage.c | 62 ++++++++++++++++++++++++++++++++++++++++++++++++
3 files changed, 63 insertions(+), 8 deletions(-)
Index: linux-2.6/arch/alpha/kernel/irq.c
===================================================================
--- linux-2.6.orig/arch/alpha/kernel/irq.c
+++ ...
| Feb 27, 3:21 pm 2008 |
| Max Krasnyanskiy | Re: [RFC/PATCH 1/4] sched: remove isolcpus
Works for me. That's what I suggested in my reply to your comments.
Max
--
| Feb 27, 4:57 pm 2008 |
| Peter Zijlstra | [RFC/PATCH 1/4] sched: remove isolcpus
cpu isolation doesn't offer anything over cpusets, hence remove it.
Signed-off-by: Peter Zijlstra <a.p.zijlstra@chello.nl>
---
kernel/sched.c | 24 +++---------------------
1 file changed, 3 insertions(+), 21 deletions(-)
Index: linux-2.6/kernel/sched.c
===================================================================
--- linux-2.6.orig/kernel/sched.c
+++ linux-2.6/kernel/sched.c
@@ -6217,24 +6217,6 @@ cpu_attach_domain(struct sched_domain *s
rcu_assign_pointer(rq->sd, sd);
}
...
| Feb 27, 3:21 pm 2008 |
| Max Krasnyanskiy | Re: [RFC/PATCH 2/4] cpuset: system sets
Hmm, shouldn't patches be sent inline ?
Otherwise I need to cut&paste in order to reply.
Anyway. cpu_system_map looks fine. It's identical in functionality (minus the
notifier) to the ~cpu_isolated_map. Different name works for me.
As I explained in the prev reply I suggest we use CPU hotplug instead of the
brand new notifier mechanism that requires changes to a bunch of things, and
at the end of the day ends up doing the same exact thing. ie Moving things out
I beleive those masks ...
| Feb 27, 4:52 pm 2008 |
| Paul Jackson | Re: [RFC/PATCH 2/4] cpuset: system sets
"one that caters the general purpose OS" ... a tad terse on the
documentation ;).
I guess what you have is a new cpumask_t cpu_system_map, which is the
union of the CPUs of all the cpusets marked 'system', where to a rough
approximation the CPUs -not- in that cpumask are what we would have
called the isolated CPUs by the old code?
In any case, if this patch survives its birth, it will need an added
change for some file in the Documentation directory.
Could we get the term 'cpu' in the ...
| Feb 27, 4:39 pm 2008 |
| Peter Zijlstra | [RFC/PATCH 2/4] cpuset: system sets
Introduce the notion of a System set. A system set will be one that caters the
general purpose OS. This patch provides the infrastructure, but doesn't
actually provide any new functionality.
Typical functionality would be setting the IRQ affinity of unbound IRQs to
within the system set. And setting the affinity of unbounded kernel threads to
within the system set.
Future patches will provide this.
Signed-off-by: Peter Zijlstra <a.p.zijlstra@chello.nl>
---
include/linux/cpumask.h | 5 ...
| Feb 27, 3:21 pm 2008 |
| Harvey Harrison | [PATCH] kernel: add clamp() and clamp_t() macros
Adds macros similar to min/max/min_t/max_t.
Also, change the variable names used in the min/max macros to
avoid shadowed variable warnings when min/max min_t/max_t are
nested.
Small formatting changes to make all the macros have a similar
form.
Signed-off-by: Harvey Harrison <harvey.harrison@gmail.com>
---
Andrew, here's a cleanup of the max/min macros and the introduction
of a clamp/clamp_t macro. There are users for this in libata (the
FIX macro you've already seen) and in ...
| Feb 27, 3:25 pm 2008 |
| Max Krasnyanskiy | 2.6.24.3-cpuisol2
Latest version of the CPU isolation extensions on top of the stable 2.6.24.y
series is available from:
git://git.kernel.org/pub/scm/linux/kernel/git/maxk/cpuisol-2.6.24.y.git
It's currently based on the 2.6.24.3 released by the stable team.
For those who prefer patches it's available here
http://kernel.org/pub/linux/kernel/people/maxk/v2.6.24.3-cpuisol2.patch
Enjoy
Max
--
| Feb 27, 3:18 pm 2008 |
| Rafael J. Wysocki | Re: Regression in 2.6.25-rc3: s2ram segfaults before sus ...
There's a known suspend problem with 2.6.25-rc3 that has been fixed already
in the Linus' tree. Can you test the current head of the Linus' tree, please?
Rafael
--
| Feb 27, 3:19 pm 2008 |
| Klaus S. Madsen | Regression in 2.6.25-rc3: s2ram segfaults before suspending
Hi all,
I have a Thinkpad T61p, which I'm able to suspend with s2ram on
Linux 2.6.24.3. However when I try to suspend it on 2.6.25-rc3, s2ram
dies after changing to vt1, with a segfault. I'm using s2ram from cvs,
and libx86 version 0.99 from http://www.codon.org.uk/~mjg59/libx86/.
Some details about the segfault:
$ sudo gdb ./s2ram
(gdb) run
Starting program: /home/ksm/downloads/suspend/s2ram
Switching from vt7 to vt1
Calling get_mode
Program received signal SIGSEGV, Segmentation ...
| Feb 27, 3:10 pm 2008 |
| Pavel Machek | Re: Regression in 2.6.25-rc3: s2ram segfaults before sus ...
This does not look like known problem, actually... s2ram segfaults
somewhere in emulator...?
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
--
| Feb 27, 3:40 pm 2008 |
| Bartlomiej Zolnierki ... | [PATCH 4/4] qd65xx: cleanup qd_probe()
* Replace 'if ()'-s by 'switch ()' block.
* Merge common code for QD6500/QD6580A/QD6580B.
There should be no functional changes caused by this patch.
Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
---
drivers/ide/legacy/qd65xx.c | 52 ++++++++++++++------------------------------
1 file changed, 17 insertions(+), 35 deletions(-)
Index: b/drivers/ide/legacy/qd65xx.c
===================================================================
--- a/drivers/ide/legacy/qd65xx.c
+++ ...
| Feb 27, 3:21 pm 2008 |
| Bartlomiej Zolnierki ... | [PATCH 2/4] ide: add ide_legacy_device_add() helper
Add ide_legacy_device_add() helper for use by legacy VLB host drivers
(+ convert them to use it).
There should be no functional changes caused by this patch.
Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
---
drivers/ide/ide-probe.c | 32 ++++++++++++++++++++++++++++++++
drivers/ide/legacy/ali14xx.c | 28 +---------------------------
drivers/ide/legacy/dtc2278.c | 27 +--------------------------
drivers/ide/legacy/ht6560b.c | 28 +---------------------------
...
| Feb 27, 3:20 pm 2008 |
| Bartlomiej Zolnierki ... | [PATCH 3/4] ide: use ide_legacy_device_add() for qd65xx
* Add 'unsigned long config' argument to ide_legacy_device_add()
for setting hwif->config_data.
* Use ide_find_port_slot() instead of ide_find_port() in
ide_legacy_device_add().
* Handle IDE_HFLAG_QD_2ND_PORT and IDE_HFLAG_SINGLE host flags in
ide_legacy_device_add().
* Convert qd65xx host driver to use ide_legacy_device_add().
There should be no functional changes caused by this patch.
Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
---
drivers/ide/ide-probe.c ...
| Feb 27, 3:21 pm 2008 |
| Bartlomiej Zolnierki ... | [PATCH 1/4] ide: remove ->noprobe field from ide_hwif_t
Update IDE PMAC host driver to use drive->noprobe instead of hwif->noprobe
and remove hwif->noprobe completely (it is always set to zero now).
There should be no functional changes caused by this patch.
Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
---
drivers/ide/arm/icside.c | 1 -
drivers/ide/ide-probe.c | 3 +--
drivers/ide/ide.c | 4 ----
drivers/ide/mips/swarm.c | 1 -
drivers/ide/ppc/pmac.c ...
| Feb 27, 3:19 pm 2008 |
| Bartlomiej Zolnierki ... | [PATCH] ide: use ide_find_port() in legacy VLB host driv ...
* Add IDE_HFLAG_QD_2ND_PORT host flag to indicate the need of skipping
first ide_hwifs[] slot for the second port of QD65xx controller.
* Handle this new host flag in ide_find_port_slot().
* Convert legacy VLB host drivers to use ide_find_port().
While at it:
* Fix couple of printk()-s in qd65xx host driver to not use hwif->name.
v2:
* Fix qd65xx.
Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
---
replacement patch
drivers/ide/ide-probe.c | 4 +-
...
| Feb 27, 3:18 pm 2008 |
| Adrian Bunk | cris: build creates links in the source directory
Especially when building with a separate object directory the following
part of arch/cris/Makefile is not so nice since it creates links in the
source directory:
<-- snip -->
# Create some links to make all tools happy
$(SRC_ARCH)/.links:
@rm -rf $(SRC_ARCH)/drivers
@ln -sfn $(SARCH)/drivers $(SRC_ARCH)/drivers
@rm -rf $(SRC_ARCH)/boot
@ln -sfn $(SARCH)/boot $(SRC_ARCH)/boot
@rm -rf $(SRC_ARCH)/lib
@ln -sfn $(SARCH)/lib $(SRC_ARCH)/lib
...
| Feb 27, 3:05 pm 2008 |
| James Morris | Re: [2.6 patch] selinux/netlabel.c should #include "netl ...
Applied to
git://git.kernel.org/pub/scm/linux/kernel/git/jmorris/selinux-2.6.git#next
--
James Morris
<jmorris@namei.org>
--
| Feb 27, 3:16 pm 2008 |
| Adrian Bunk | Re: [2.6 patch] selinux/netlabel.c should #include "netl ...
I'm not claiming it needs it.
But with this #include gcc can check that the prototypes in netlabel.h
match the functions in netlabel.c
The bugs this catches are rare, but when you have such a bug it can be
cu
Adrian
--
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed
--
| Feb 27, 2:55 pm 2008 |
| Paul Moore | Re: [2.6 patch] selinux/netlabel.c should #include "netl ...
--
paul moore
linux security @ hp
--
| Feb 27, 3:08 pm 2008 |
| Paul Moore | Re: [2.6 patch] selinux/netlabel.c should #include "netl ...
It doesn't _need_ the file in the strictest sense, the header file is
just there for the core SELinux code to call into the NetLabel/SELinux
glue code (what is in security/selinux/netlabel.c). However, if this
is to conform better to kernel coding policy (I assume that is the case
here?) then that is fine with me.
--
paul moore
linux security @ hp
--
| Feb 27, 2:42 pm 2008 |
| Adrian Bunk | [2.6 patch] selinux/netlabel.c should #include "netlabel.h"
Every file should include the headers containing the externs for its
global code.
Signed-off-by: Adrian Bunk <bunk@kernel.org>
---
1f65757bac3e82514b447822ab30ee10d33a59a2 foobar
diff --git a/security/selinux/netlabel.c b/security/selinux/netlabel.c
index 0fa2be4..6d22d76 100644
--- a/security/selinux/netlabel.c
+++ b/security/selinux/netlabel.c
@@ -34,6 +34,7 @@
#include "objsec.h"
#include "security.h"
+#include "netlabel.h"
/**
* selinux_netlbl_sidlookup_cached - Cache a ...
| Feb 27, 2:20 pm 2008 |
| Adrian Bunk | video/tda8290.c: possibly uninitialized variables used
drivers/media/video/tda8290.c contains the following code:
<-- snip -->
...
static void tda8290_set_params(struct dvb_frontend *fe,
struct analog_parameters *params)
{
...
unsigned char adc_sat, agc_stat,
pll_stat;
int i;
set_audio(fe, params);
if (priv->cfg.config)
tuner_dbg("tda827xa config is 0x%02x\n", *priv->cfg.config);
tuner_i2c_xfer_send(&priv->i2c_props, easy_mode, ...
| Feb 27, 2:21 pm 2008 |
| Adrian Bunk | [2.6 patch] dvb-usb/opera1.c: fix a memory leak
This patch fixes a memory leak in the "testval == 0x67" case spotted by
the Coverity checker.
Signed-off-by: Adrian Bunk <bunk@kernel.org>
---
drivers/media/dvb/dvb-usb/opera1.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- linux-2.6/drivers/media/dvb/dvb-usb/opera1.c.old 2008-02-27 22:27:03.000000000 +0200
+++ linux-2.6/drivers/media/dvb/dvb-usb/opera1.c 2008-02-27 22:27:23.000000000 +0200
@@ -450,65 +450,65 @@ static int opera1_xilinx_load_firmware(s
p = ...
| Feb 27, 2:21 pm 2008 |
| Adrian Bunk | [2.6 patch] i2c-amd756.c: fix off-by-one
This patch fixes an off-by-one error spotted by the Coverity checker.
Signed-off-by: Adrian Bunk <bunk@kernel.org>
---
f9829dd0d7dad9cbc08da3fceb105478e85c4137 foobar
diff --git a/drivers/i2c/busses/i2c-amd756.c b/drivers/i2c/busses/i2c-amd756.c
index 573abe4..2fa4318 100644
--- a/drivers/i2c/busses/i2c-amd756.c
+++ b/drivers/i2c/busses/i2c-amd756.c
@@ -335,7 +335,7 @@ static int __devinit amd756_probe(struct pci_dev *pdev,
u8 temp;
/* driver_data might come from user-space, so ...
| Feb 27, 2:21 pm 2008 |
| Adrian Bunk | [2.6 patch] crypto/digest.c should #include "internal.h"
Every file should include the headers containing the externs for its
global code (in this case for struct crypto_{init,exit}_digest_ops()).
Signed-off-by: Adrian Bunk <bunk@kernel.org>
---
8680cc7b83fdcef7fbb84f9eac3f26f3d3e16b45 foobar
diff --git a/crypto/digest.c b/crypto/digest.c
index 6fd43bd..b526cc3 100644
--- a/crypto/digest.c
+++ b/crypto/digest.c
@@ -21,6 +21,8 @@
#include <linux/module.h>
#include <linux/scatterlist.h>
+#include "internal.h"
+
static int init(struct ...
| Feb 27, 2:21 pm 2008 |
| Adrian Bunk | [RFC: 2.6 patch] minix: remove !NO_TRUNCATE code
This patch removes the !NO_TRUNCATE code that anyway required a manual
editing of the code for being used.
Signed-off-by: Adrian Bunk <bunk@kernel.org>
---
This patch has been sent on:
- 17 Feb 2008
fs/minix/inode.c | 3 ---
fs/minix/minix.h | 6 ------
fs/minix/namei.c | 24 ------------------------
3 files changed, 33 deletions(-)
baff7307cff10a969567e2c7b81af14259170906 diff --git a/fs/minix/inode.c b/fs/minix/inode.c
index 84f6242..523d737 100644
--- ...
| Feb 27, 2:21 pm 2008 |
| Adrian Bunk | [2.6 patch] make ext3_xattr_list() static
This patch makes the needlessly global ext3_xattr_list() static.
Signed-off-by: Adrian Bunk <bunk@kernel.org>
---
fs/ext3/xattr.c | 4 +++-
fs/ext3/xattr.h | 7 -------
2 files changed, 3 insertions(+), 8 deletions(-)
8fb5e610acafcbef4a9980042902c9269abf51b6 diff --git a/fs/ext3/xattr.c b/fs/ext3/xattr.c
index fb89c29..4f9f187 100644
--- a/fs/ext3/xattr.c
+++ b/fs/ext3/xattr.c
@@ -99,6 +99,8 @@ static struct buffer_head *ext3_xattr_cache_find(struct inode *,
struct ...
| Feb 27, 2:20 pm 2008 |
| Adrian Bunk | [RFC: 2.6 patch] fs/configfs/ cleanups
This patch contains the following cleanups:
- make the needlessly global file.c:configfs_add_file() static
- #if 0 the unused inode.c:configfs_hash_and_remove()
Signed-off-by: Adrian Bunk <bunk@kernel.org>
---
This patch has been sent on:
- 17 Feb 2008
fs/configfs/configfs_internal.h | 3 ---
fs/configfs/file.c | 3 ++-
fs/configfs/inode.c | 2 ++
3 files changed, 4 insertions(+), 4 deletions(-)
651b7a33c0dce1790230fe8ba9b7445cd69c8bde diff --git ...
| Feb 27, 2:20 pm 2008 |
| Joel Becker | Re: [RFC: 2.6 patch] fs/configfs/ cleanups
Acked-by: Joel Becker <joel.becker@oracle.com>
I'd also take a patch to remove configfs_hash_and_remove().
--
"Every day I get up and look through the Forbes list of the richest
people in America. If I'm not there, I go to work."
- Robert Orben
Joel Becker
Principal Software Developer
Oracle
E-mail: joel.becker@oracle.com
Phone: (650) 506-8127
--
| Feb 27, 3:36 pm 2008 |
| Adrian Bunk | [2.6 patch] selinux/ss/services.c should #include <linux ...
Every file should include the headers containing the externs for its
global code.
Signed-off-by: Adrian Bunk <bunk@kernel.org>
---
eaeb567e2ce03ef3a7c5ed33e35def212ce2899a foobar
diff --git a/security/selinux/ss/services.c b/security/selinux/ss/services.c
index f374186..29fb216 100644
--- a/security/selinux/ss/services.c
+++ b/security/selinux/ss/services.c
@@ -40,6 +40,7 @@
#include <linux/sched.h>
#include <linux/audit.h>
#include <linux/mutex.h>
+#include <linux/selinux.h>
...
| Feb 27, 2:20 pm 2008 |
| Adrian Bunk | [2.6 patch] fs/aio.c: make 3 functions static
This patch makes the following needlessly global functions static:
- __put_ioctx()
- lookup_ioctx()
- io_submit_one()
Signed-off-by: Adrian Bunk <bunk@kernel.org>
---
This patch has been sent on:
- 17 Feb 2008
fs/aio.c | 67 +++++++++++++++++++++++++-------------------
include/linux/aio.h | 19 ------------
2 files changed, 39 insertions(+), 47 deletions(-)
22e146f657e1ec7b223c1415e343f0880441e624 diff --git a/fs/aio.c b/fs/aio.c
index b74c567..777e27a 100644
--- ...
| Feb 27, 2:20 pm 2008 |
| Adrian Bunk | [2.6 patch] remove the v850 port
Trying to compile the v850 port brings many compile errors, one of
them exists since at least kernel 2.6.19.
There also seems to be noone willing to bring this port back into a
usable state.
This patch therefore removes the v850 port.
If anyone ever decides to revive the v850 port the code will still be
available from older kernels, and it wouldn't be impossible for the port
to reenter the kernel if it would become actively maintained again.
Signed-off-by: Adrian Bunk ...
| Feb 27, 2:20 pm 2008 |
| Adrian Bunk | [2.6 patch] drivers/pnp/manager.c cleanups
This patch contains the following cleanups that are now possible:
- remove the following unused functions:
- pnp_manual_config_dev()
- pnp_resource_change()
- remove the following unused EXPORT_SYMBOL's:
- pnp_start_dev
- pnp_stop_dev
- pnp_init_resource_table
Signed-off-by: Adrian Bunk <bunk@kernel.org>
---
This patch has been sent on:
- 13 Feb 2008
drivers/pnp/manager.c | 72 ------------------------------------------
include/linux/pnp.h | 3 -
2 files changed, ...
| Feb 27, 2:20 pm 2008 |
| Adrian Bunk | [2.6 patch] make scsi_end_bidi_request() static
This patch makes the needlessly global scsi_end_bidi_request() static.
Signed-off-by: Adrian Bunk <bunk@kernel.org>
---
This patch has been sent on:
- 13 Feb 2008
48e50a33ee11afb02eadc790ae2d9542b0805608
diff --git a/drivers/scsi/scsi_lib.c b/drivers/scsi/scsi_lib.c
index b12fb31..148c8b0 100644
--- a/drivers/scsi/scsi_lib.c
+++ b/drivers/scsi/scsi_lib.c
@@ -785,7 +785,7 @@ EXPORT_SYMBOL(scsi_release_buffers);
* in req->data_len and req->next_rq->data_len. The upper-layer driver ...
| Feb 27, 2:20 pm 2008 |
| Bernhard Walle | Re: [2.6 patch] drivers/char/rtc.c: make 2 functions static
Of course:
Acked-by: Bernhard Walle <bwalle@suse.de>
But I'm not the maintainer of RTC ...
--
| Feb 27, 2:40 pm 2008 |
| Adrian Bunk | [2.6 patch] drivers/char/rtc.c: make 2 functions static
The following functions can now become static:
- rtc_interrupt()
- rtc_get_rtc_time()
Signed-off-by: Adrian Bunk <bunk@kernel.org>
---
This patch has been sent on:
- 13 Feb 2008
drivers/char/rtc.c | 5 +++--
include/linux/rtc.h | 2 --
2 files changed, 3 insertions(+), 4 deletions(-)
e642155f0065ec03a83ed95eef2a78f272e73e01
diff --git a/drivers/char/rtc.c b/drivers/char/rtc.c
index 78b151c..39aba90 100644
--- a/drivers/char/rtc.c
+++ b/drivers/char/rtc.c
@@ -144,6 ...
| Feb 27, 2:20 pm 2008 |
| H. Peter Anvin | Re: [PATCH] x86: X86_HT always enable on X86_64 SMP
He does, and calls them SCHED_SMT and SCHED_MC respectively.
It's not particularly clear to me what X86_HT is meant to be used for
anymore at all.
-hpa
--
| Feb 27, 2:30 pm 2008 |
| Hiroshi Shimamoto | Re: [PATCH] x86: X86_HT always enable on X86_64 SMP
yes on 64-bit. On 32-bit MK8 doesn't affect X86_HT.
--
| Feb 27, 3:31 pm 2008 |
| Adrian Bunk | Re: [PATCH] x86: X86_HT always enable on X86_64 SMP
These are the already existing scheduler related variables that are
grep through the source code and you find it is sometimes used for
hyperthreading and sometimes for multicore.
I don't care whether X86_HT gets splitted or perhaps even removed, but
any change to it should remove the status quo of it having two different
cu
Adrian
--
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
...
| Feb 27, 2:58 pm 2008 |
| Hiroshi Shimamoto | Re: [PATCH] x86: X86_HT always enable on X86_64 SMP
OK, you say "Don't mix two different semantics into one variable X86_HT", right?
Thanks,
Hiroshi Shimamoto
--
| Feb 27, 3:16 pm 2008 |
| Adrian Bunk | Re: [PATCH] x86: X86_HT always enable on X86_64 SMP
Exactly.
This mixing is not your fault since it's an older problem, but instead
cu
Adrian
--
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed
--
| Feb 27, 3:37 pm 2008 |
| Yinghai Lu | Re: [PATCH] x86: X86_HT always enable on X86_64 SMP
he made X86_HT can be enabled when only Opteron supported is enabled.
it should be stated in the comments.
YH
--
| Feb 27, 3:00 pm 2008 |
| Adrian Bunk | Re: [PATCH] x86: X86_HT always enable on X86_64 SMP
Please fix it properly instead - fiddling around with it the way you do
only asks for trouble in the future.
What we need are two different variables for:
- hyperthreading and
And any proper fix should result in SCHED_SMT and SCHED_MC getting
different dependencies.
cu
Adrian
--
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
...
| Feb 27, 2:26 pm 2008 |
| Hiroshi Shimamoto | [PATCH] x86: X86_HT always enable on X86_64 SMP
From: Hiroshi Shimamoto <h-shimamoto@ct.jp.nec.com>
X86_HT is used for hyperthreading or multicore on 32-bit.
The X86_HT on 64-bit is different from 32-bit, it means hyperthreading only.
And X86_HT is not used on 64-bit except from cpu/initel_cacheinfo.c.
Unify X86_HT for hyperthreading or multicore.
Turn X86_HT on when X86_64 and SMP are enabled.
Signed-off-by: Hiroshi Shimamoto <h-shimamoto@ct.jp.nec.com>
---
arch/x86/Kconfig | 6 +++---
1 files changed, 3 insertions(+), 3 ...
| Feb 27, 2:16 pm 2008 |
| gorcunov | [RFC 02/10] m32r: vmlinux.lds.S cleanup - use PAGE_SIZE, ...
This patch modifies PAGE_SIZE definition to be able to
include it in vmlinux.lds.S script and use it then
Also THREAD_SIZE macro is used to replace numeric constant
Signed-off-by: Cyrill Gorcunov <gorcunov@gmail.com>
---
WARNING: COMPLETELY UNTESTED !!!
arch/m32r/kernel/vmlinux.lds.S | 19 ++++++++++---------
include/asm-m32r/page.h | 4 +++-
2 files changed, 13 insertions(+), 10 deletions(-)
Index: ...
| Feb 27, 1:58 pm 2008 |
| gorcunov | [RFC 08/10] um: dyn/uml.lds.S cleanup - use PAGE_SIZE macro
This patch includes page.h header into liker scripts that
allow us to use PAGE_SIZE macro instead of numeric constant.
To be able to include page.h into linker scripts page.h is
needed for some modification - i.e. we need to use __ASSEMBLY__
and _AC macro
Signed-off-by: Cyrill Gorcunov <gorcunov@gmail.com>
---
WARNING: COMPLETELY UNTESTED !!!
arch/um/kernel/dyn.lds.S | 7 ++++---
arch/um/kernel/uml.lds.S | 7 ++++---
include/asm-um/page.h | 17 +++++++++++------
3 files ...
| Feb 27, 1:58 pm 2008 |
| gorcunov | [RFC 09/10] alpha: vmlinux.lds cleanup - use THREAD_SIZE macro
This patch modifies thread_info.h header to be able to include it
into linker script and then we're able to use THREAD_SIZE in
vmlinux.lds
Signed-off-by: Cyrill Gorcunov <gorcunov@gmail.com>
Reviewed-by: Sam Ravnborg <sam@ravnborg.org>
---
arch/alpha/kernel/vmlinux.lds.S | 3 ++-
include/asm-alpha/thread_info.h | 9 ++++++---
2 files changed, 8 insertions(+), 4 deletions(-)
Index: ...
| Feb 27, 1:58 pm 2008 |
| gorcunov | [RFC 10/10] xtensa: vmlinux.lds.S - use PAGE_SIZE, THREA ...
This patch includes page.h and thread_info.h headers into the linker
script that allow us to use PAGE_SIZE and THREAD_SIZE macroses
instead of numeric constants
Also a few spaces removed
Signed-off-by: Cyrill Gorcunov <gorcunov@gmail.com>
---
WARNING: COMPLETELY UNTESTED !!!
vmlinux.lds.S | 19 ++++++++++---------
1 file changed, 10 insertions(+), 9 deletions(-)
Index: ...
| Feb 27, 1:58 pm 2008 |
| gorcunov | [RFC 07/10] ppc: vmlinux.lds.S cleanup - use PAGE_SIZE macro
This patch includes page.h header into liker script that
allow us to use PAGE_SIZE macro instead of numeric constant
Also a few tabs deleted to align braces
Signed-off-by: Cyrill Gorcunov <gorcunov@gmail.com>
---
WARNING: COMPLETELY UNTESTED !!!
vmlinux.lds.S | 33 +++++++++++++++++----------------
1 file changed, 17 insertions(+), 16 deletions(-)
Index: linux-2.6.git/arch/ppc/kernel/vmlinux.lds.S
===================================================================
--- ...
| Feb 27, 1:58 pm 2008 |
| gorcunov | [RFC 05/10] mn10300: vmlinux.lds.S cleanup - use PAGE_SI ...
This patch includes page.h header into liker script that
allow us to use PAGE_SIZE macro instead of numeric constant
Also PERCPU macro is used instead of explicit section definition
Signed-off-by: Cyrill Gorcunov <gorcunov@gmail.com>
---
WARNING: COMPLETELY UNTESTED !!!
vmlinux.lds.S | 22 ++++++++++------------
1 file changed, 10 insertions(+), 12 deletions(-)
Index: ...
| Feb 27, 1:58 pm 2008 |
| gorcunov | [RFC 06/10] powerpc: vmlinux.lds.S cleanup - use PERCPU, ...
This patch includes thread_info.h header into liker script that
allow us to use THREAD_SIZE macro instead of numeric constant
Also PERCPU macro is used instead of explicit section definition
Signed-off-by: Cyrill Gorcunov <gorcunov@gmail.com>
---
WARNING: COMPLETELY UNTESTED !!!
vmlinux.lds.S | 16 ++++------------
1 file changed, 4 insertions(+), 12 deletions(-)
Index: ...
| Feb 27, 1:58 pm 2008 |
| gorcunov | [RFC 03/10] m68k: vmlinux-std/sun3.lds.S cleanup - use P ...
This patch includes page.h header into liker script that
allow us to use PAGE_SIZE macro instead of numeric constant
Signed-off-by: Cyrill Gorcunov <gorcunov@gmail.com>
---
WARNING: COMPLETELY UNTESTED !!!
vmlinux-std.lds | 3 ++-
vmlinux-sun3.lds | 7 ++++---
2 files changed, 6 insertions(+), 4 deletions(-)
Index: linux-2.6.git/arch/m68k/kernel/vmlinux-std.lds
===================================================================
--- ...
| Feb 27, 1:58 pm 2008 |
| gorcunov | [RFC 01/10] arm: vmlinux.lds.S cleanup - use PERCPU, PAG ...
This patch modifies PAGE_SIZE definition to be able to
include it into vmlinux.lds.S script and use it then
Also PERCPU macros is used instead of explicit section
declaration
Signed-off-by: Cyrill Gorcunov <gorcunov@gmail.com>
---
WARNING: COMPLETELY UNTESTED !!!
arch/arm/kernel/vmlinux.lds.S | 21 ++++++++++-----------
include/asm-arm/page.h | 4 +++-
2 files changed, 13 insertions(+), 12 deletions(-)
Index: ...
| Feb 27, 1:58 pm 2008 |
| gorcunov | [RFC 04/10] m68knommu: vmlinux.lds cleanup - use PAGE_SI ...
This patch modifies page.h header to be able to include it
into linker script and then we're able to use PAGE_SIZE in
vmlinux.lds
Signed-off-by: Cyrill Gorcunov <gorcunov@gmail.com>
---
WARNING: COMPLETELY UNTESTED !!!
arch/m68knommu/kernel/vmlinux.lds.S | 5 +++--
include/asm-m68knommu/page.h | 6 ++++--
2 files changed, 7 insertions(+), 4 deletions(-)
Index: ...
| Feb 27, 1:58 pm 2008 |
| gorcunov | [RFC 00/10] vmlinux.lds cleanup
This series of patches is made in purpose to use PAGE_SIZE and THREAD_SIZE
macroses in vmlinux linker scripts as much as possible instead of numeric
constants. Please review.
WARNING: the patches are UNTESTED COMPLETELY - I've no access to
that architectures and errors is highly possible ;)
If you have an ability to test this patches - please do it.
What is most important on review - these macroses *must* be
placed into appropriate places - check it please.
ANY comments ...
| Feb 27, 1:58 pm 2008 |
| gorcunov | [RFC 0/0] vmlinux cleanup
This series of patches is made in purpose to use PAGE_SIZE and THREAD_SIZE
macroses in vmlinux linker scripts as much as possible instead of numeric
constants. Please review.
WARNING: the patches are UNTESTED COMPLETELY - I've no access to
that architectures and errors is highly possible ;)
If you have an ability to test this patches - please do it.
What is most important on review - these macroses *must* be
placed into appropriate places - check it please.
ANY comments are ...
| Feb 27, 1:48 pm 2008 |
| Quel Qun | Re: [PATCH] bluetooth: delete timer in l2cap_conn_del()
-------------- Original message ----------------------
As I said, it prevents the crash, but does not 'fix' my problem, in that I still cannot use the dongle.
--
kk1
--
| Feb 27, 1:21 pm 2008 |
| Thomas Gleixner | Re: [PATCH] bluetooth: delete timer in l2cap_conn_del()
The disfunctionality of your dongle is a separate problem and I hope
that the bluetooth wizards will help you to get this sucker running.
The timer which is not deactivated before the data structure
containing it is a simple bug, which needs to be addressed ASAP.
Thanks again for your patience in tracking this down,
tglx
--
| Feb 27, 1:31 pm 2008 |
| Randy Dunlap | [PATCH] arm: eliminate MODULE_PARM() usage
From: Randy Dunlap <randy.dunlap@oracle.com>
Convert debug-only (and removed) MODULE_PARM() to module_param().
Compiles cleanly (with DEBUG=1).
Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
---
arch/arm/mach-pxa/cpu-pxa.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- next-20080227.orig/arch/arm/mach-pxa/cpu-pxa.c
+++ next-20080227/arch/arm/mach-pxa/cpu-pxa.c
@@ -43,7 +43,7 @@
#ifdef DEBUG
static unsigned int freq_debug;
-MODULE_PARM(freq_debug, ...
| Feb 27, 1:11 pm 2008 |
| Roland McGrath | [PATCH] core dump: user_regset writeback
This makes the user_regset-based core dump code call user_regset
writeback hooks when available. This is necessary groundwork to
allow IA64 to set CORE_DUMP_USE_REGSET.
CC: Shaohua Li <shaohua.li@intel.com>
Signed-off-by: Roland McGrath <roland@redhat.com>
---
fs/binfmt_elf.c | 15 +++++++++++++++
1 files changed, 15 insertions(+), 0 deletions(-)
diff --git a/fs/binfmt_elf.c b/fs/binfmt_elf.c
index 41a958a..eb7cca3 100644
--- a/fs/binfmt_elf.c
+++ b/fs/binfmt_elf.c
@@ -1424,6 ...
| Feb 27, 1:06 pm 2008 |
| Theodore Ts'o | 2.6.25-rc3-git1-ext4-1 released
I've just released 2.6.25-rc3-git1-ext4-1. It removes the patches that
have been pulled into mainline by Linus.
As a git tree:
git://git.kernel.org/pub/scm/linux/kernel/git/tytso/ext4.git 2.6.25-rc3-git1-ext4-1
http://git.kernel.org/?p=linux/kernel/git/tytso/ext4.git;a=shortlog;h=2.6.25-rc3-git1-...
As a patchset:
ftp://ftp.kernel.org/pub/linux/kernel/people/tytso/ext4-patches/2.6.25-rc3-git1-ext4-1
- Ted
Akinobu Mita (3):
...
| Feb 27, 12:59 pm 2008 |
| Sam Ravnborg | Re: [PATCH] x86 vdso: fix build locale dependency
Priit's original patch used the LC_ALL trick. It is
me to blame that it was replaced with [:alnum:] :-(
Sam
--
| Feb 27, 1:43 pm 2008 |
| Roland McGrath | [PATCH] x86 vdso: fix build locale dependency
Priit Laes discovered that the sed command processing nm output was
sensitive to locale settings. This was addressed in commit
03994f01e8b72b3d01fd3d09d1cc7c9f421a727c by using [:alnum:] in place of
[a-zA-Z0-9]. But that too is locale-dependent and may not always match
the identifiers it needs to. The better fix is just to run sed et al
with a fixed locale setting in all builds.
Signed-off-by: Roland McGrath <roland@redhat.com>
CC: Priit Laes <plaes@plaes.org>
---
arch/x86/vdso/Makefile ...
| Feb 27, 12:42 pm 2008 |
| Ingo Molnar | Re: [PATCH] x86 vdso: fix build locale dependency
ok. I've queued up Roland's re-fix. We'll eventually converge to
something everyone is happy with ;-)
Ingo
--
| Feb 27, 1:45 pm 2008 |
| Roland McGrath | Re: [PATCH] x86 vdso: fix build locale dependency
Hey, I'm happy with living in the C locale. It's catering to you
troublesome people covering the vast majority of the planet that has
me worrying about pedantic correctness for whatever the least-similar
LC_CTYPE anyone uses might entail. :-)
Thanks,
Roland
--
| Feb 27, 1:52 pm 2008 |
| 張欣樺 | om ↖ 瘋狂大放送買兩套送ㄧ套 3516
2008-2-28
▼
哇塞!!!!一片50
http://sam.yahoo-kiss.com/
全年無休每日下午5點前下單-隔天即可宅配到貨
瘋狂大放送買兩套送ㄧ套
http://sam.yoyo-dvd.com/
3:16:34
祔
| Feb 27, 12:16 pm 2008 |
| Avi Kivity | Re: [PATCH/RFC 1/2] anon-inodes: Remove fd_install() fro ...
The kvm changes are
Acked-by: Avi Kivity <avi@qumranet.com>
--
Any sufficiently difficult bug is indistinguishable from a feature.
--
| Feb 27, 12:20 pm 2008 |
| Davide Libenzi | Re: [PATCH/RFC 1/2] anon-inodes: Remove fd_install() fro ...
It's inside his vfs git tree:
http://git.kernel.org/?p=linux/kernel/git/viro/vfs-2.6.git;a=commit;h=49be4f8114e6ff0e...
I'm fine with both approaches.
- Davide
--
| Feb 27, 1:30 pm 2008 |
| Roland Dreier | [PATCH/RFC 1/2] anon-inodes: Remove fd_install() from an ...
The anonymous inodes interface anon_inode_getfd() calls fd_install()
for the newly created fd, which does not work for some use cases where
the caller must do futher initialization before exposing the file to
userspace. This is also probably not the safest interface, since the
caller must be sure that it is OK if userspace closes the fd before
anon_inode_getfd() even returns.
Therefore, change the anonymous inodes interface so that the caller is
responsible for calling fd_install(), and change ...
| Feb 27, 12:16 pm 2008 |
| Roland Dreier | Re: [PATCH/RFC 1/2] anon-inodes: Remove fd_install() fro ...
> http://git.kernel.org/?p=linux/kernel/git/viro/vfs-2.6.git;a=commit;h=49be4f8114e6ff0e...
>
> I'm fine with both approaches.
Both ways are OK with me too, although Al's change leaves the trap in
the anon_inode_getfd() in that all users have to keep in mind the race
against close() from another thread. Also Al's change moves all
documentation to __anon_inode_getfd() and leaves anon_inode_getfd()
undocumented, which is a little suboptimal.
With Al's change the 2/2 ...
| Feb 27, 2:05 pm 2008 |
| Roland Dreier | Re: [PATCH/RFC 1/2] anon-inodes: Remove fd_install() fro ...
> > The anonymous inodes interface anon_inode_getfd() calls fd_install()
> > for the newly created fd, which does not work for some use cases where
> > the caller must do futher initialization before exposing the file to
> > userspace. This is also probably not the safest interface, since the
> > caller must be sure that it is OK if userspace closes the fd before
> > anon_inode_getfd() even returns.
>
> I believe Al changed the interface to not give out inode* and file*, *and*
> call ...
| Feb 27, 1:14 pm 2008 |
| Davide Libenzi | Re: [PATCH/RFC 1/2] anon-inodes: Remove fd_install() fro ...
[CC-ing Al too]
I believe Al changed the interface to not give out inode* and file*, *and*
call fd_install() inside it. I'd slightly prefer Al version, although I
don't see any major problems in this one too.
- Davide
--
| Feb 27, 12:41 pm 2008 |
| Roland Dreier | [PATCH 2/2] IB/uverbs: Use anonymous inodes instead of p ...
Now that anonymous inodes allow us to control when fd_install() is
called, we can convert ib_uverbs to use them instead of its own
private infinibandeventfs virtual filesystem. This removes a healthy
chunk of code and also deletes the last in-tree user of
get_empty_filp(), which makes Christoph Hellwig happy.
Tested with an app that uses the ib_uverbs event file interfaces.
Signed-off-by: Roland Dreier <rolandd@cisco.com>
---
drivers/infiniband/core/uverbs_main.c | 76 ...
| Feb 27, 12:18 pm 2008 |
| Roland Dreier | Re: [PATCH/RFC 1/2] anon-inodes: Remove fd_install() fro ...
> http://git.kernel.org/?p=linux/kernel/git/viro/vfs-2.6.git;a=commit;h=49be4f8114e6ff0e...
Actually, looking closer at the kvm changes here, I think that
create_vcpu_fd() needs the same treatment as kvm_dev_ioctl_create_vm()
gets in the patch because of the race I mentioned in the changelog
for my patch: otherwise kvm_vcpu_release() could drop the last
reference to vcpu->kvm->filp before the get_file() gets an extra
reference.
I'm beginning to think that moving the ...
| Feb 27, 4:42 pm 2008 |
| Josef Bacik | [PATCH 2/2] fix possible journal overflow issues
Hello,
There are several cases where the running transaction can get buffers added to
its BJ_Metadata list which it never dirtied, which makes its t_nr_buffers
counter end up larger than its t_outstanding_credits counter. This will cause
issues when starting new transactions as while we are logging buffers we
decrement t_outstanding_buffers, so when t_outstanding_buffers goes negative,
we will report that we need less space in the journal than we actually need, so
transactions will be ...
| Feb 27, 11:51 am 2008 |
| Josef Bacik | [PATCH 1/2] fix the way jbd/jbd2 clears the b_modified flag
Hello,
Currently at the start of a journal commit we loop through all of the buffers on
the committing transaction and clear the b_modified flag (the flag that is set
when a transaction modifies the buffer) under the j_list_lock. The problem is
that everywhere else this flag is modified only under the jbd lock buffer flag,
so it will race with a running transaction who could potentially set it, and
have it unset by the committing transaction. This is also a big waste, you can
have ...
| Feb 27, 11:46 am 2008 |
| Bartlomiej Zolnierki ... | Re: [PATCH 0/5] ide-cd: trivial fixes
OTOH md5sums of the resulting _binary_ files matches... ;-)
--
| Feb 27, 3:48 pm 2008 |
| Borislav Petkov | Re: [PATCH 0/5] ide-cd: trivial fixes
huh, are you sure? The fixup-comments patch adds at least one char to the source
file so the md5sums cannot be the same.
--
Regards/Gruß,
Boris.
--
| Feb 27, 3:18 pm 2008 |
| Borislav Petkov | [PATCH 0/5] ide-cd: trivial fixes
Hi Bart,
here are the ide-cd trivial fixes split in an easier to digest format. I
cannot do the md5sum check here since all of the patches change at least one
char but i hope that this'll be redundant here since they're trivially easy
to review :) now.
drivers/ide/ide-cd.c | 591 +++++++++++++++++++++++++-------------------------
1 files changed, 298 insertions(+), 293 deletions(-)
Thanks,
Boris.
--
| Feb 27, 11:20 am 2008 |
| Bartlomiej Zolnierki ... | Re: [PATCH 5/5] ide-cd: fix remaining checkpatch.pl issues
interdiff for the merged version
diff -u b/drivers/ide/ide-cd.c b/drivers/ide/ide-cd.c
--- b/drivers/ide/ide-cd.c
+++ b/drivers/ide/ide-cd.c
@@ -185,8 +185,7 @@
if (valid < 0)
valid = 0;
if (sector < get_capacity(info->disk) &&
- drive->probed_capacity - sector < 4 * 75)
-
+ drive->probed_capacity - sector < 4 * 75)
set_capacity(info->disk, sector);
}
}
@@ -218,7 +217,7 @@
rq->data = sense;
rq->cmd[0] = GPCMD_REQUEST_SENSE;
- rq->cmd[4] = ...
| Feb 27, 2:18 pm 2008 |
| Borislav Petkov | [PATCH 2/5] ide-cd: put all proc-related code at one place
Signed-off-by: Borislav Petkov <petkovbb@gmail.com>
---
drivers/ide/ide-cd.c | 71 ++++++++++++++++++++++++-------------------------
1 files changed, 35 insertions(+), 36 deletions(-)
diff --git a/drivers/ide/ide-cd.c b/drivers/ide/ide-cd.c
index 4d39567..bb7944b 100644
--- a/drivers/ide/ide-cd.c
+++ b/drivers/ide/ide-cd.c
@@ -1695,15 +1695,6 @@ int ide_cdrom_probe_capabilities(ide_drive_t *drive)
return nslots;
}
-#ifdef CONFIG_IDE_PROC_FS
-static void ...
| Feb 27, 11:20 am 2008 |
| Borislav Petkov | [PATCH 1/5] ide-cd: include proper headers
Signed-off-by: Borislav Petkov <petkovbb@gmail.com>
---
drivers/ide/ide-cd.c | 6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/ide/ide-cd.c b/drivers/ide/ide-cd.c
index 8877b7b..4d39567 100644
--- a/drivers/ide/ide-cd.c
+++ b/drivers/ide/ide-cd.c
@@ -41,10 +41,10 @@
#include <scsi/scsi.h> /* For SCSI -> ATAPI command conversion */
-#include <asm/irq.h>
-#include <asm/io.h>
+#include <linux/irq.h>
+#include <linux/io.h>
#include ...
| Feb 27, 11:20 am 2008 |
| Bartlomiej Zolnierki ... | Re: [PATCH 0/5] ide-cd: trivial fixes
Hi,
applied everything
BTW patch #3/5 which accounts for 2/3 of the diffstat passes md5sum check here
--
| Feb 27, 2:18 pm 2008 |
| Bartlomiej Zolnierki ... | Re: [PATCH 4/5] ide-cd: shorten lines longer than 80 columns
IDE is quite consistent with the above style but maybe it is just me being
For this case there is a simple solution: fix ide-cd to use hwif->sg_table
instead of having it to walk rq->bio's and the whole function will vanish. ;-)
[ IOW We are putting way too much time into these coding style fixes and as
the old code is replaced with the new one the coding style improves itself. ]
Thanks,
Bart
--
| Feb 27, 4:01 pm 2008 |
| Borislav Petkov | Re: [PATCH 4/5] ide-cd: shorten lines longer than 80 columns
why do you push the rq->cmd[0] thingy back here. Shouldn't it be aligned
i must say, lines like this one always look ugly, no matter the formatting
--
Regards/Gruß,
Boris.
--
| Feb 27, 3:15 pm 2008 |
| Borislav Petkov | [PATCH 4/5] ide-cd: shorten lines longer than 80 columns
Signed-off-by: Borislav Petkov <petkovbb@gmail.com>
---
drivers/ide/ide-cd.c | 75 +++++++++++++++++++++++++++++++++----------------
1 files changed, 50 insertions(+), 25 deletions(-)
diff --git a/drivers/ide/ide-cd.c b/drivers/ide/ide-cd.c
index bb501a4..84415cd 100644
--- a/drivers/ide/ide-cd.c
+++ b/drivers/ide/ide-cd.c
@@ -279,11 +279,11 @@ static void cdrom_end_request(ide_drive_t *drive, int uptodate)
ide_end_request(drive, uptodate, nsectors);
}
-static void ...
| Feb 27, 11:20 am 2008 |
| Bartlomiej Zolnierki ... | Re: [PATCH 4/5] ide-cd: shorten lines longer than 80 columns
On Thursday 28 February 2008, Bartlomiej Zolnierkiewicz wrote:
Just to clarify: by "these" I meant only ide-cd ones, i.e. we are beautifying
comments for code which is going to be heavily modified soon because of other
changes like ATAPI handling unification...
--
| Feb 27, 4:15 pm 2008 |
| Borislav Petkov | [PATCH 5/5] ide-cd: fix remaining checkpatch.pl issues
Some of them are:
WARNING: braces {} are not necessary for single statement blocks
CHECK: multiple assignments should be avoided
WARNING: printk() should include KERN_ facility level
WARNING: no space between function name and open parenthesis '('
Signed-off-by: Borislav Petkov <petkovbb@gmail.com>
---
drivers/ide/ide-cd.c | 46 ++++++++++++++++++++++------------------------
1 files changed, 22 insertions(+), 24 deletions(-)
diff --git a/drivers/ide/ide-cd.c b/drivers/ide/ide-cd.c
index ...
| Feb 27, 11:20 am 2008 |
| Borislav Petkov | [PATCH 3/5] ide-cd: fixup comments
Signed-off-by: Borislav Petkov <petkovbb@gmail.com>
---
drivers/ide/ide-cd.c | 401 ++++++++++++++++++++++++--------------------------
1 files changed, 192 insertions(+), 209 deletions(-)
diff --git a/drivers/ide/ide-cd.c b/drivers/ide/ide-cd.c
index bb7944b..bb501a4 100644
--- a/drivers/ide/ide-cd.c
+++ b/drivers/ide/ide-cd.c
@@ -39,7 +39,8 @@
#include <linux/mutex.h>
#include <linux/bcd.h>
-#include <scsi/scsi.h> /* For SCSI -> ATAPI command conversion */
+/* For SCSI -> ATAPI ...
| Feb 27, 11:20 am 2008 |
| Bartlomiej Zolnierki ... | Re: [PATCH 3/5] ide-cd: fixup comments
interdiff for the merged version
diff -u b/drivers/ide/ide-cd.c b/drivers/ide/ide-cd.c
--- b/drivers/ide/ide-cd.c
+++ b/drivers/ide/ide-cd.c
@@ -296,7 +296,7 @@
struct request *rq = HWGROUP(drive)->rq;
int stat, err, sense_key;
- /* check for errors. */
+ /* check for errors */
stat = ide_read_status(drive);
if (stat_ret)
@@ -305,7 +305,7 @@
if (OK_STAT(stat, good_stat, BAD_R_STAT))
return 0;
- /* get the IDE error register. */
+ /* get the IDE error register ...
| Feb 27, 2:18 pm 2008 |
| Bartlomiej Zolnierki ... | Re: [PATCH 4/5] ide-cd: shorten lines longer than 80 columns
interdiff for the merged version
diff -u b/drivers/ide/ide-cd.c b/drivers/ide/ide-cd.c
--- b/drivers/ide/ide-cd.c
+++ b/drivers/ide/ide-cd.c
@@ -433,13 +433,13 @@
* sector. If we got here the error is not correctable.
*/
ide_dump_status_no_sense(drive,
- "media error (bad sector)",
- stat);
+ "media error (bad sector)",
+ stat);
do_end_request = 1;
} else if (sense_key == BLANK_CHECK) {
/* disk appears blank ?? */
...
| Feb 27, 2:18 pm 2008 |
| Randy Dunlap | Re: [PATCH, RFC, BAD IDEA] /proc/tty/console
So it omits other consoles (non-tty) intentionally?
or does it include them even though the procfs filename contains "tty"?
Anyway, I'd like to see something like this.
Compare http://www.xenotime.net/linux/patches/consoles-list.patch
---
~Randy
--
| Feb 27, 11:37 am 2008 |
| Randy Dunlap | Re: [PATCH, RFC, BAD IDEA] /proc/tty/console
I don't recall about that, but it would be Bad if correct.
I meant to list *all* consoles. I'm interested in netconsole,
console=lp0, console=ttyUSB0, etc., as well as serial port consoles.
Thanks.
---
~Randy
--
| Feb 27, 11:56 am 2008 |
| Bill Nottingham | Re: [PATCH, RFC, BAD IDEA] /proc/tty/console
It only does consoles that have a tty_driver, as those are the ones I'd
Reading that, unless I'm missing something, you'd lose the device name
distinction (i.e., *which* serial port).
Bill
--
| Feb 27, 11:52 am 2008 |
| Bill Nottingham | [PATCH, RFC, BAD IDEA] /proc/tty/console
I'm not seriously proposing this. But, as far as I can tell, this
information isn't exposed to userspace anywhere, and it's a useful
thing to know. I'm certainly open for better ideas on how to expose
this (sysfs attributes? other?)
....
The attached patch adds /proc/tty/console. The contents of it are
simply a description of the current drivers attached to /dev/console.
For example, a boot with 'console=ttyS3,115200n1 console=tty0' would
yield:
# cat /proc/tty/console
unknown ...
| Feb 27, 11:18 am 2008 |
| SENATE PRESIDENT | NOTIFICATION OF PAYMENT VIA ATM CARD
--
This is to officially inform you that(ATM Card Number;4278763100030014) has
been accredited in your favour.Your Personal Identification Number is 2900.
The ATM Card Value is $6.8MILLION USD Only.
Contact:wallaceatmdesk@hotmail.com With the following,Your Name:Phone
no:Address:Country
--
| Feb 27, 10:44 am 2008 |
| Thomas Gleixner | Re: hpwdt oops in clflush_cache_range
Roland,
does the patch below detect the wreckage ?
Thanks,
tglx
--------------->
Subject: x86: check physical address range in ioremap
From: Thomas Gleixner <tglx@linutronix.de>
Date: Wed, 27 Feb 2008 20:57:40 +0100
Roland Dreier reported in http://lkml.org/lkml/2008/2/27/194
[ 8425.915139] BUG: unable to handle kernel paging request at ffffc20001a0a000
[ 8425.919087] IP: [<ffffffff8021dacc>] clflush_cache_range+0xc/0x25
[ 8425.919087] PGD 1bf80e067 PUD 1bf80f067 PMD 1bb497067 ...
| Feb 27, 1:42 pm 2008 |
| Thomas Gleixner | Re: hpwdt oops in clflush_cache_range
-------------------------------------------------^^^^^^^^^^^^^^^^
The physical address looks strange: 0x47000EE000
Can you provide a full boot log please ?
Thanks,
tglx
--
| Feb 27, 11:14 am 2008 |
| Ingo Molnar | Re: hpwdt oops in clflush_cache_range
(patch is now queued up in x86.git as well)
Ingo
--
| Feb 27, 1:44 pm 2008 |
| Ingo Molnar | Re: hpwdt oops in clflush_cache_range
here's the updated patch.
Ingo
-------------->
Subject: x86: check physical address range in ioremap
From: Thomas Gleixner <tglx@linutronix.de>
Date: Wed, 27 Feb 2008 20:57:40 +0100
Roland Dreier reported in http://lkml.org/lkml/2008/2/27/194
[ 8425.915139] BUG: unable to handle kernel paging request at ffffc20001a0a000
[ 8425.919087] IP: [<ffffffff8021dacc>] clflush_cache_range+0xc/0x25
[ 8425.919087] PGD 1bf80e067 PUD 1bf80f067 PMD 1bb497067 PTE 80000047000ee17b
This is on a ...
| Feb 27, 2:14 pm 2008 |
| Ingo Molnar | Re: hpwdt oops in clflush_cache_range
also note that the driver would have faulted in a similar same way
anyway, the first time it tried to access that ioremap range. It's just
that due to the clflush we took the fault first in ioremap().
via the physical range check we'll do a more graceful exit and the
driver wont crash either. (it will just not work)
Ingo
--
| Feb 27, 1:36 pm 2008 |
| Thomas Gleixner | Re: hpwdt oops in clflush_cache_range
That needs to be:
+ return addr < (1UL << boot_cpu_data.x86_phys_bits);
Where is my brown paperbag ? I know that GCC _is_ stupid, but I never
remember.
tglx
--
| Feb 27, 1:59 pm 2008 |
| Roland Dreier | Re: hpwdt oops in clflush_cache_range
> Can you provide a full boot log please ?
Sure, below.
For this boot I blacklisted the hpwdt module and then loaded it by
hand at the very end, so the oops is the last thing.
[ 0.000000] Linux version 2.6.25-rc3 (rdreier@roland-xeon-1) (gcc version 4.2.3 (Debian 4.2.3-1)) #51 SMP Tue Feb 26 22:59:43 PST 2008
[ 0.000000] Command line: root=/dev/cciss/c0d0p6 ro console=ttyS0,57600
[ 0.000000] BIOS-provided physical RAM map:
[ 0.000000] BIOS-e820: 0000000000000000 - ...
| Feb 27, 11:38 am 2008 |
| Thomas Gleixner | Re: hpwdt oops in clflush_cache_range
This one has 36bit physical address space. You can verify that via
While the physical address of your ioremap is 47000ee000.
2^ 36 == 1000000000
----> 47000ee000
So the fault is not very surprising. Unfortunately we do not check,
whether physaddr is inside the valid physical address space. I whip up
a patch to do that.
Can you please instrument the driver to figure out where this
information comes from ? Or maybe lspci tells already.
Thanks,
tglx
--
| Feb 27, 12:48 pm 2008 |
| Roland Dreier | Re: hpwdt oops in clflush_cache_range
> the ioremap there is trying to remap 0x7b6 bytes at an address of
> 0x240047000ee000 -- either the BIOS data is bogus or the driver is
> getting at it the wrong way.
Looking at the code, it seems that maybe only the low 32 bits of the
address are supposed to be used. With a 32-bit kernel the address
in smbios_entry_point.table_address would be silently truncated to 32
bits, and on my 64-bit kernel, the patch below seems to make things
work... (ie the driver seems happy -- I didn't ...
| Feb 27, 2:35 pm 2008 |
| Roland Dreier | Re: hpwdt oops in clflush_cache_range
> Where is my brown paperbag ? I know that GCC _is_ stupid, but I never
> remember.
Original patch actually worked fine and trapped the problem.
I also instrumented the driver, and the problem is coming from the code:
/*
* Now we will check:
* - SMBIOS checksum must be 0
* - intermediate anchor should be _DMI_
* - intermediate checksum should be 0
*/
if ((bios_checksum(p, length)) &&
(strncmp((char *)eps->intermediate_anchor, "_DMI_",
...
| Feb 27, 2:17 pm 2008 |
| Mingarelli, Thomas | RE: hpwdt oops in clflush_cache_range
Did I read correctly that this was on a Debian OS? Looks like I need to jump in and see what is different about Debian because I haven't seen such an issue on RedHat 5.
Yes, the driver was made specifically for G5 (and newer) systems. I will set a system up here and figure out what's wrong as soon as I am sure it is Debian.
Thanks,
Tom
-----Original Message-----
From: Roland Dreier [mailto:rdreier@cisco.com]
Sent: Wednesday, February 27, 2008 3:18 PM
To: Thomas Gleixner
Cc: Ingo Molnar; ...
| Feb 27, 4:44 pm 2008 |
| Mingarelli, Thomas | RE: hpwdt oops in clflush_cache_range
What generation is the DL380 server? G5 I hope.
Tom
-----Original Message-----
From: Roland Dreier [mailto:rdreier@cisco.com]
Sent: Wednesday, February 27, 2008 11:08 AM
To: linux-kernel@vger.kernel.org
Cc: Ingo Molnar; Mingarelli, Thomas
Subject: hpwdt oops in clflush_cache_range
With an up-to-date git tree (head 7704a8b6) I'm seeing the oops below
when the hpwdt driver gets loaded during boot on an HP DL380 system.
I don't think I've seen any previous reports of this, and I guess ...
| Feb 27, 10:37 am 2008 |
| Roland Dreier | hpwdt oops in clflush_cache_range
With an up-to-date git tree (head 7704a8b6) I'm seeing the oops below
when the hpwdt driver gets loaded during boot on an HP DL380 system.
I don't think I've seen any previous reports of this, and I guess it
doesn't really count as a regression since the hpwdt driver was only
added after 2.6.25-rc2.
I haven't tried to debug this at all yet but any guidance about what
information is useful for what looks to be an issue with c_p_a would
be appreciated.
- R.
BUG: unable to handle kernel ...
| Feb 27, 10:08 am 2008 |
| Jesper Nilsson | [PATCH] CRIS: Correct syscall numbers in unistd.h for ti ...
Last commit for unistd was not correct, it only had a partial update
of syscall numbers for __NR_timerfd_settime and __NR_timerfd_gettime.
Also, NR_syscalls was not incremented for the new syscalls.
Signed-off-by: Jesper Nilsson <jesper.nilsson@axis.com>
---
include/asm-cris/unistd.h | 6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/include/asm-cris/unistd.h b/include/asm-cris/unistd.h
index 007cb16..76398ef 100644
--- a/include/asm-cris/unistd.h
+++ ...
| Feb 27, 9:29 am 2008 |
| Jesper Nilsson | [PATCH] CRIS: Correct usage of __user for copy to and fr ...
Function __copy_user_zeroing in arch/lib/usercopy.c had the wrong
parameter set as __user, and in include/asm-cris/uaccess.h, it was
not set at all for some of the calling functions.
This will cut the number of warnings quite dramatically when using sparse.
While we're here, remove useless CVS log and correct confusing typo.
Signed-off-by: Jesper Nilsson <jesper.nilsson@axis.com>
---
Sorry, forgot the -s switch to git format-patch.
arch/cris/arch-v10/lib/usercopy.c | 2 +-
...
| Feb 27, 8:52 am 2008 |
| Jesper Nilsson | [PATCH] CRIS: Correct usage of __user for copy to and fr ...
Function __copy_user_zeroing in arch/lib/usercopy.c had the wrong
parameter set as __user, and in include/asm-cris/uaccess.h, it was
not set at all for some of the calling functions.
This will cut the number of warnings quite dramatically when using sparse.
While we're here, remove useless CVS log and correct confusing typo.
---
arch/cris/arch-v10/lib/usercopy.c | 2 +-
arch/cris/arch-v32/lib/usercopy.c | 2 +-
include/asm-cris/uaccess.h | 53 ...
| Feb 27, 8:45 am 2008 |
| Jiri Kosina | Re: [PATCH] [RFC] fix missed SIGCONT cases
What happens here is that the proces that was woken-up is spinning on the
siglock even before the actual SIGCONT has been queued. When this lock is
released, the process continues executing, and its SIGCONT handler doesn't
run, even though it executes _just because_ it was woken up by SIGCONT.
Let's take this as an example:
#include <signal.h>
#include <stdio.h>
#include <unistd.h>
#include <string.h>
volatile int sigcont_received = 0;
static void sigcont_handler(int ...
| Feb 27, 3:04 pm 2008 |
| Jiri Kosina | [PATCH] [RFC] fix missed SIGCONT cases
The SIGCONT-handling related comment in handle_stop_signal() states:
* If there is a handler for SIGCONT, we must make
* sure that no thread returns to user mode before
* we post the signal, in case it was the only
* thread eligible to run the signal handler--then
* it must not do anything between resuming and
* running the handler. With the ...
| Feb 27, 8:22 am 2008 |
| Roland McGrath | Re: [PATCH] [RFC] fix missed SIGCONT cases
Have you observed an actual problem? I don't think the "race" you seem to
be concerned about is a problem at all.
The comment refers to the necessary atomicity of posting the signal along
with doing the wakeups. Those are done together with the siglock held.
It does not matter that the siglock was dropped and reacquired before
there. All that matters is that we hold the siglock continuously from
before the wake_up_state calls made in handle_stop_signal through until
after the signal-posting ...
| Feb 27, 2:00 pm 2008 |
| Oliver Schuster | [PATCH] add watchdog driver IT8716 IT8726 IT8712J/K
Hi,
this patch add a hardware watchdog device driver. It supports the
16 bit watchdog timer on superio chip it8712f-j, it 8712f-k, it8716f
and it8726f. Today it was tested under vanilla 2.6.24.3, vanilla
2.6.24.2 and Mandriva with 2.6.24.2 and 2.6.24 kernel.
Regards,
Oliver
| Feb 27, 7:55 am 2008 |
| Thomas Gleixner | Re: [2.6.25-rc3 regression] sysctl table check failed: / ...
No. I noticed my stupidity already. Patch below is queued for Linus.
Thanks,
tglx
------------>
Subject: x86: restore vsyscall64 prochandler
From: Thomas Gleixner <tglx@linutronix.de>
Date: Wed, 27 Feb 2008 09:39:52 +0100
commit ce28b9864b853803320c3f1d8de1b81aa4120b14
x86: fix vsyscall wreckage
removed the prochandler completely. This triggers:
sysctl table check failed: /kernel/vsyscall64 No proc_handler
Restore the sane part of the proc handler.
Signed-off-by: ...
| Feb 27, 10:26 am 2008 |
| Pavel Emelyanov | Re: [2.6.25-rc3 regression] sysctl table check failed: / ...
That's due to commit ce28b9 x86: fix vsyscall wreckage
The proc_handler initialization is simply dropped for this table,
but AFAIS from the commit comment this was done simply to disable
the vsyscall_gtod_data.sysctl_enabled tuning. Did I miss something?
--
| Feb 27, 8:28 am 2008 |
| Ingo Molnar | Re: [2.6.25-rc3 regression] sysctl table check failed: / ...
fix is already in x86.git#testing:
http://people.redhat.com/mingo/x86.git/README
Ingo
--
| Feb 27, 8:18 am 2008 |
| Frans Pop | Re: [2.6.25-rc3 regression] sysctl table check failed: / ...
Thanks. Can confirm that cherry-pick of this fix from that tree fixed it:
commit ed19f1cd69aa82619e2def4e11dfece8f9fe7e31
Author: Thomas Gleixner <tglx@linutronix.de>
Date: Wed Feb 27 09:39:52 2008 +0100
x86: restore vsyscall64 prochandler
--
| Feb 27, 8:57 am 2008 |
| Frans Pop | [2.6.25-rc3 regression] sysctl table check failed: /kern ...
Just tried 2.6.25-rc3 and got the error below. Boot continued normally.
Error was not present in rc2.
System is x86_64, dual core Pentium D, Debian unstable.
Cheers,
FJP
P.S. Yes, I do have VirtualBox working under 2.6.25 now ;-)
[...]
checking if image is initramfs...<7>Switched to high resolution mode on CPU 1
Switched to high resolution mode on CPU 0
it is
Freeing initrd memory: 3765k freed
sysctl table check failed: /kernel/vsyscall64 No proc_handler
Pid: 1, comm: swapper Not ...
| Feb 27, 8:09 am 2008 |
| Sam Ravnborg | Re: [RFC] alpha: vmlinux.lds cleanup - use THREAD_SIZE macro
Reviewed-by: Sam Ravnborg <sam@ravnborg.org>
And I also build tested the patch and checked the
resulting .lds files.
And they were semantically equal.
Sam
--
| Feb 27, 11:57 am 2008 |
| Cyrill Gorcunov | Re: [RFC] alpha: vmlinux.lds cleanup - use THREAD_SIZE macro
[Sam Ravnborg - Wed, Feb 27, 2008 at 07:57:56PM +0100]
| On Tue, Feb 26, 2008 at 10:51:59PM +0300, Cyrill Gorcunov wrote:
| > This patch modifies thread_info.h header to be able to include it
| > into linker script and then we're able to use THREAD_SIZE in
| > vmlinux.lds
| >
| > Signed-off-by: Cyrill Gorcunov <gorcunov@gmail.com>
| Reviewed-by: Sam Ravnborg <sam@ravnborg.org>
|
| And I also build tested the patch and checked the
| resulting .lds files.
| And they were semantically ...
| Feb 27, 12:01 pm 2008 |
| Markus Armbruster | xen: Make hvc0 the preferred console in domU
This makes the Xen console just work. Before, you had to ask for it
on the kernel command line with console=hvc0
Signed-off-by: Markus Armbruster <armbru@redhat.com>
---
diff --git a/arch/x86/xen/enlighten.c b/arch/x86/xen/enlighten.c
index 49e5358..df63185 100644
--- a/arch/x86/xen/enlighten.c
+++ b/arch/x86/xen/enlighten.c
@@ -25,6 +25,7 @@
#include <linux/mm.h>
#include <linux/page-flags.h>
#include <linux/highmem.h>
+#include <linux/console.h>
#include ...
| Feb 27, 6:56 am 2008 |
| Toralf | build #390 issue for v2.6.25-rc3-81-g7704a8b in tda7432.c
--Boundary-01=_LqWxHFaLQfcLiCL
Content-Type: text/plain;
charset="iso-8859-15"
Content-Transfer-Encoding: quoted-printable
Content-Disposition: inline
Hello,
the build with the attached .config failed, make ends with:
=2E..
AR arch/x86/lib/lib.a
LD vmlinux.o
MODPOST vmlinux.o
WARNING: modpost: Found 2 section mismatch(es).
To see full details build your kernel with:
'make CONFIG_DEBUG_SECTION_MISMATCH=3Dy'
GEN .version
CHK include/linux/compile.h
UPD ...
| Feb 27, 6:50 am 2008 |
| Pavel Emelyanov | [PATCH 0/3]Sysctl: clean the code and prepare for secure ...
Many (most of) sysctls do not have a per-container sense. E.g.
kernel.print_fatal_signals, vm.panic_on_oom, net.core.netdev_budget
and so on and so forth. Besides, tuning then from inside a container
is not even secure. On the other hand, hiding them completely from
the container's tasks sometimes causes user-space to stop working.
When developing net sysctl, the common practice was to duplicate
a table and drop the write bits in table->mode, but this approach
was not very elegant, lead to ...
| Feb 27, 6:47 am 2008 |
| Pavel Emelyanov | [PATCH 1/3] Sysctl: merge equal proc_sys_read and proc_s ...
These ->read and ->write callbacks act in a very similar way, so
merge these paths to reduce the number of places to patch later
and shrink the .text size (a bit).
Signed-off-by: Pavel Emelyanov <xemul@openvz.org>
---
fs/proc/proc_sysctl.c | 50 ++++++++++--------------------------------------
1 files changed, 11 insertions(+), 39 deletions(-)
diff --git a/fs/proc/proc_sysctl.c b/fs/proc/proc_sysctl.c
index 614c34b..5e31585 100644
--- a/fs/proc/proc_sysctl.c
+++ ...
| Feb 27, 6:48 am 2008 |
| Pavel Emelyanov | [PATCH 2/3] Sysctl: clean from unneeded extern and forwa ...
The do_sysctl_strategy isn't used outside kernel/sysctl.c, so
this can be static and without a prototype in header.
Besides, move this one and parse_table() above their callers and
drop the forward declarations of the latter call.
One more "besides" - fix two checkpatch warnings: space before
a ( and an extra space at the end of a line.
Signed-off-by: Pavel Emelyanov <xemul@openvz.org>
---
include/linux/sysctl.h | 5 --
kernel/sysctl.c | 144 ...
| Feb 27, 6:51 am 2008 |
| Pavel Emelyanov | [PATCH 3/3] Sysctl: add the ->permissions callback on th ...
When reading from/writing to some table, a root, which this table
came from, may affect this table's permissions, depending on who is
working with the table.
The core hunk is at the bottom of this patch. All the rest is
just pushing the ctl_table_root argument up to the sysctl_perm()
function.
This will be mostly (only?) used in the net sysctls.
Signed-off-by: Pavel Emelyanov <xemul@openvz.org>
---
fs/proc/proc_sysctl.c | 4 ++--
include/linux/sysctl.h | 7 ++++++-
...
| Feb 27, 6:54 am 2008 |
| Peter Zijlstra | [RFC/PATCH] RLIMIT_ARG_MAX
Hi Linus,
Raised by: http://bugzilla.kernel.org/show_bug.cgi?id=10095 , there is
the question of whether we want to separate the env+arg arrays from the
stack proper.
Currently these arrays are considered part of the stack, and
RLIMIT_STACK includes them. However POSIX does not specify it must be
so.
The complaint is that sysconf(_SC_ARG_MAX) returns a hard coded value
(which is not obtained from the kernel) and might, depending on the
RLIMIT_STACK setting, be invalid.
POSIX disallows ...
| Feb 27, 6:37 am 2008 |
| Martin Wilck | idle_notifier_unregister()
Hello Thomas, hello Ingo,
Your commit a72368dd37f6ae333fbab03598e46a995d91decc "x86: remove dead
code and exports" removes the function idle_notifier_unregister().
Please restore this function. I have a driver here which wouldn't unload
cleanly if this function is unavailable.
What's the point in removing the idle_notifier_unregister() function
while keeping idle_notifier_register()? Is the idle_notifier API a
one-way API by design?
Martin
--
Martin Wilck
PRIMERGY System Software ...
| Feb 27, 6:18 am 2008 |
| Andi Kleen | Re: [rfc][patch] x86-64 new smp_call_function design
TLB flushing at least on x86-64 should be already well optimized on its
With cpusets and isolation etc. it is the normal case.
-Andi
--
| Feb 27, 6:04 am 2008 |
| Andi Kleen | Re: [rfc][patch] x86-64 new smp_call_function design
Ah I see sorry. If you want to just speed up vmalloc flushing I think
the easier way would be to just extend the normal TLB flusher for
vmalloc. So alone for this it probably wouldn't be worth it.
The isolation work is not merged yet, but it will essentially need
to turn a lot of the _call_function()s into _call_function_mask()
-Andi
--
| Feb 27, 6:33 am 2008 |
| Nick Piggin | Re: [rfc][patch] x86-64 new smp_call_function design
That's possible, but it is slower and less scalable on my 8-way, and
I suspect it might become even slower than the generic code on larger
Why?
--
| Feb 27, 3:14 pm 2008 |
| Nick Piggin | Re: [rfc][patch] x86-64 new smp_call_function design
A single queue will kill one of the big fundamental scalability
improvements of the call_single. That's the problem.
--
| Feb 27, 6:50 am 2008 |
| Nick Piggin | Re: [rfc][patch] x86-64 new smp_call_function design
*vmalloc* TLB flushing.
void flush_tlb_all(void)
{
on_each_cpu(do_flush_tlb_all, NULL, 1, 1);
}
Of course we could use a new vector for it and speed it up a lot more,
but after my vmalloc improvements I think that would be a waste of a
Oh really? Coming from what callers?
--
| Feb 27, 6:07 am 2008 |
| Ingo Molnar | Re: [rfc][patch] x86-64 new smp_call_function design
looks really interesting!
the two structures are quite similar in size and role - why not have a
type field and handle them largely together? I think we should try to
preserve a single queue and a single vector - that would remove a number
of ugly special-cases from the patch.
Ingo
--
| Feb 27, 6:27 am 2008 |
| Nick Piggin | [rfc][patch] x86-64 new smp_call_function design
Hi,
This isn't finished yet, however I'd just like to ask for comments.
Design a new smp_call_function calling convention. This significantly
improves scalability of smp_call_function_single, and slightly improves
scalability and performance of smp_call_function; especially in the
cases where wait=0.
The non-wait case allocates function call data dynamically, so the
caller is able to return before all other CPUs have copied out the data
into their stack as is the case today.
The ...
| Feb 27, 5:42 am 2008 |
| Ingo Molnar | Re: [rfc][patch] x86-64 new smp_call_function design
hm, indeed. Then how about the other way around: couldnt the normal
all-cpus SMP function call be implemented transparently via using
smp_call_single() calls? The vector duplication is really ugly and feels
wrong.
Ingo
--
| Feb 27, 8:02 am 2008 |
| BuraphaLinux Server | at program breaks with kernel 2.6.24
http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=463669
I have the same problem - it is not debian specific. Did the
semantics of kill() change with the new kernel? I thought as long as
something is setuid, even with capability stuff around the setuid
programs just get _all_ capabilities and would keep working.
I did a good search and found many people with the problem, but no
solutions except going back to 2.6.23.x kernels. I guess you'll flame
me, but at least include a link to the ...
| Feb 27, 5:27 am 2008 |
| Jiri Kosina | Re: at program breaks with kernel 2.6.24
Does this still happen to you with current mainline? If so, what is your
.config? It works for me(TM):
read(0, "/bin/echo \"aaa\"\n", 1024) = 16
write(2, "at> ", 4) = 4
read(0, "", 1024) = 0
write(2, "<EOT>\n", 6) = 6
write(4, "#!/bin/sh\n# atrun uid=1000 gid=1"..., 4076) = 4076
close(4) = 0
munmap(0x7f068f383000, 4096) = 0
fchmod(5, 0700) = 0
close(5) ...
| Feb 27, 6:41 am 2008 |
| Frans Pop | Re: at program breaks with kernel 2.6.24
Would it be this commit that fixed this issue?
commit 094972840f2e7c1c6fc9e1a97d817cc17085378e
Author: Serge E. Hallyn <serue@us.ibm.com>
Date: Sat Feb 23 15:23:33 2008 -0800
file capabilities: simplify signal check
I see stable was CCed on it, so I guess it will be included in the next
point release, but distributions may want to apply it earlier.
--
| Feb 27, 12:36 pm 2008 |
| BuraphaLinux Server | Re: at program breaks with kernel 2.6.24
This is gmail which has broken line wrapping I cannot fix. Anyway, I
did build the new kernel but it still does not work for me. I tried to
strace, but that didn't work for me either. This is as a non-root user
(and same 'at'/'atd' binaries work on 2.6.23.X):
bash-3.2$ at now
warning: commands will be executed using /bin/sh
at> echo "suid is busted"
at> <EOT>
job 4 at Thu Feb 28 02:16:00 2008
Can't signal atd (permission denied)
bash-3.2$ ls -ld $(which at)
-rws--x--x 1 daemon daemon 36468 ...
| Feb 27, 12:47 pm 2008 |
| serge | Re: at program breaks with kernel 2.6.24
Why would we flame you? I'll just apologize as I think it's my fault,
and ask you to please try the newest available kernel where I believe it
should be fixed.
thanks,
-serge
--
| Feb 27, 11:17 am 2008 |
| David Miller | Re: [PATCH] [resend]The kernel gets no IP from some DHCP ...
From: "Wappler Marcel" <Marcel.Wappler@bridgeco.net>
I just haven't gotten around to it because I have been
travelling, seeing doctors, and generally being backlogged.
Please be patient.
--
| Feb 27, 12:13 pm 2008 |
| Wappler Marcel | RE: [PATCH] [resend]The kernel gets no IP from some DHCP ...
My first try went in this direction. But at a second look I thought
that the names ANY (255.255.255.255) and NONE (0.0.0.0) are indirect
leading to confusion. The interpretation of the zero addresses in
the DHCPDISCOVER packet is in the kind of 'no address' and not of
'any addressee'. So the meaning and usage of INADDR_ANY and ZERO
may be totally different in this file.
In my opinion it is necessary to distinguish between INADDR_ANY
and the ZERO address which ist requested to be in the ...
| Feb 27, 6:11 am 2008 |
| Wappler Marcel | [PATCH] [resend]The kernel gets no IP from some DHCP ser ...
I wonder why there is no feedback to the sugested DHCP patch to
linux/net/ipv4/ipconfig.c Am I wrong with the interpretation of
RFC2131 section about the contents of a clients DHCPDISCOVER
packet? If not I would assume that the behaviour of the kernels
DHCP should be changed.
Thanks,
Marcel
the original mail:
http://lkml.org/lkml/2008/2/21/171
====== original patch =========
This patch fixes a DHCP issue of the kernel: some DHCP servers
(i.e. in the Linksys WRT54Gv5) are very strict ...
| Feb 27, 5:23 am 2008 |
| Stephen Hemminger | Re: [PATCH] [resend]The kernel gets no IP from some DHCP ...
On Wed, 27 Feb 2008 14:11:55 +0100
Just delete the lines and the address will be zero because of
earlier memset().
--
| Feb 27, 9:38 am 2008 |
| Patrick McHardy | Re: [PATCH] [resend]The kernel gets no IP from some DHCP ...
Please don't add changelogs to source files, git keeps track of
This should probably use INADDR_ANY.
--
| Feb 27, 5:46 am 2008 |
| Wappler Marcel | RE: [PATCH] [resend]The kernel gets no IP from some DHCP ...
From my personal point of view it is important to document the requirement of the
two addresses to be 0.0.0.0 either through the code itself or through a comment
which states clear the side effect of memset'ting the structure.
Both roads lead to Rome :-)
Marcel
--
Marcel Wappler
Bridgeco AG
CH-8600 Dübendorf
Switzerland
--
| Feb 27, 10:25 am 2008 |
| Peter Zijlstra | Re: [PATCH] sched: don't allow rt_runtime_us to be zero ...
stick in front, drop the other two sched-rt-group patches for which I'll
send you an update somewhere today.
These two patches would be candidates to push to linus..
--
| Feb 27, 8:08 am 2008 |
| Ingo Molnar | Re: [PATCH] sched: don't allow rt_runtime_us to be zero ...
doesnt apply to sched-devel.git - what's the plan here?
Ingo
--
| Feb 27, 8:03 am 2008 |
| Dhaval Giani | [PATCH] sched: don't allow rt_runtime_us to be zero for ...
This patch checks if we can set the rt_runtime_us to 0. If there is a
realtime task in the group, we don't want to set the rt_runtime_us to 0
otherwise bad things will happen.
Signed-off-by: Dhaval Giani <dhaval@linux.vnet.ibm.com>
---
kernel/sched.c | 19 +++++++++++++++++++
1 files changed, 19 insertions(+)
Index: linux-2.6.25-rc3/kernel/sched.c
===================================================================
--- linux-2.6.25-rc3.orig/kernel/sched.c
+++ ...
| Feb 27, 4:08 am 2008 |
| Peter Zijlstra | Feb 27, 7:11 am 2008 | |
| Dhaval Giani | Re: [PATCH] sched: don't allow rt_runtime_us to be zero ...
Belongs to mainline.
--
regards,
Dhaval
--
| Feb 27, 8:10 am 2008 |
| Peter Zijlstra | Re: [PATCH] sched: don't allow rt_runtime_us to be zero ...
This should be a do_each_thread() { } while_each_thread(); iteration
loop;
cgroups are thread oriented, not task.
--
| Feb 27, 2:47 pm 2008 |
| Dhaval Giani | Re: [PATCH] sched: don't allow rt_runtime_us to be zero ...
Well, if it can be done, it shall be done :)
Well, the group is certainly not busy. I will go with invalid as it is
definitly an invalid value when the groups have rt tasks. But if someone
disagrees, I have no issue with it being something else.
Corrected patch as follows,
--
This patch checks if we can set the rt_runtime_us to 0. If there is a
realtime task in the group, we don't want to set the rt_runtime_us as 0
or bad things will happen.
Signed-off-by: Dhaval Giani ...
| Feb 27, 6:24 am 2008 |
| Peter Zijlstra | Re: [PATCH] sched: don't allow rt_runtime_us to be zero ...
May I suggest: rm -rf /
/me runs
--
| Feb 27, 6:40 am 2008 |
| Peter Zijlstra | Re: [PATCH] sched: don't allow rt_runtime_us to be zero ...
I had considered this a: don't do that then, thing. But sure, helping
--
| Feb 27, 5:46 am 2008 |
| Peter Zijlstra | [PATCH] sched: rt-group: fixup schedulability constraint ...
Subject: sched: rt-group: fixup schedulability constraints calculation
div64_64() has a different calling convention than do_div() :/
fix a few untidies while were here; sysctl_sched_rt_period may overflow
due to that multiplication, so cast to u64 first. Also that RUNTIME_INF
juggling makes little sense although its an effective NOP.
Signed-off-by: Peter Zijlstra <a.p.zijlstra@chello.nl>
---
kernel/sched.c | 10 +++-------
1 file changed, 3 insertions(+), 7 deletions(-)
Index: ...
| Feb 27, 4:00 am 2008 |
| Adrian Bunk | Re: undefined reference to fixed_phy_add, from of_add_fi ...
Please always send the .config for such problems.
cu
Adrian
--
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed
--
| Feb 27, 4:07 am 2008 |
| Adrian Bunk | [2.6.25 patch] FIXED_PHY must depend on PHYLIB=y
This patch fixes the following build error introduced by commit
a79d8e93d300adb84cccc38ac396cfb118c238ad and reported by Olaf Hering:
<-- snip -->
...
LD .tmp_vmlinux1
arch/powerpc/sysdev/built-in.o: In function `of_add_fixed_phys':
fsl_soc.c:(.init.text+0xd34): undefined reference to `fixed_phy_add'
make: *** [.tmp_vmlinux1] Error 1
<-- snip -->
Signed-off-by: Adrian Bunk <adrian.bunk@movial.fi>
---
47a94f1d74e448d39f34f0ad37f8b4f69412ee13 diff --git ...
| Feb 27, 8:07 am 2008 |
| Olaf Hering | undefined reference to fixed_phy_add, from of_add_fixed_phys
Hello,
can anyone explain why linking fails?
I dont see whats so special about fixed_phy_add().
olaf@lingonberry:/dev/shm/R/linux-2.6.25-rc3> time env LC_ALL=C make -kj8 O=../O-25 vmlinux
GEN /dev/shm/R/O-25/Makefile
CHK include/linux/version.h
CHK include/linux/utsrelease.h
Using /dev/shm/R/linux-2.6.25-rc3 as source for kernel
CALL /dev/shm/R/linux-2.6.25-rc3/scripts/checksyscalls.sh
CHK include/linux/compile.h
CALL ...
| Feb 27, 3:58 am 2008 |
| Ingo Molnar | Re: [PATCH] [x86] rdc321x: Kconfig options fixes for rdc321x
these many special conditions in the Kconfig space are way too ugly.
(Also, i can see no reason why for example hibernation wouldnt be
possible on rdc321x, it's a pure software concept ...)
Ingo
--
| Feb 27, 3:53 am 2008 |
| Florian Fainelli | [PATCH] [x86] rdc321x: Kconfig options fixes for rdc321x
This patch fixes the various Kconfig option selections
which are unavailable for the RDC321x sub architecture.
Signed-off-by: Florian Fainelli <florian.fainelli@telecomint.eu>
---
diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig
index 4a88cf7..31d0fc9 100644
--- a/arch/x86/Kconfig
+++ b/arch/x86/Kconfig
@@ -123,11 +123,11 @@ config HAVE_SETUP_PER_CPU_AREA
config ARCH_HIBERNATION_POSSIBLE
def_bool y
- depends on !SMP || !X86_VOYAGER
+ depends on !SMP || !(X86_VOYAGER || ...
| Feb 27, 3:36 am 2008 |
| Ingo Molnar | Re: [PATCH] [x86] rdc321x: Kconfig options fixes for rdc321x
no. Just leave those things alone. Obviously, if you dont initiate
hibernation it wont be done - and you dont have to build it in either.
But there's no fundamental reason that it _couldnt_ work - if a suitable
device was attached. Dont put such hardcoded dependencies into the
kernel ...
Ingo
--
| Feb 27, 8:06 am 2008 |
| Florian Fainelli | Re: [PATCH] [x86] rdc321x: Kconfig options fixes for rdc321x
Hi Ingo,
I would have thought an embedded device with only flash memory as rom storage
could not hibertnate.
Maybe we should turn all those special conditions into HAVE_FOO/BAR instead ?
--
| Feb 27, 4:06 am 2008 |
| Kim B. Heino | [PATCH] fix RTNL-locking in tun/tap driver
Current tun/tap driver sets also net device's hw address when asked to
change character device's hw address. This is a good idea, but it
misses RTLN-locking, resulting following error message in
2.6.25-rc3's inetdev_event() function:
RTNL: assertion failed at net/ipv4/devinet.c (1050)
Attached patch fixes this problem.
Signed-off-by: Kim B. Heino <Kim.Heino@bluegiga.com>
--- linux-2.6.25-rc3/drivers/net/tun.c.foo 2008-02-27 10:06:28.000000000 +0200
+++ ...
| Feb 27, 2:38 am 2008 |
| Jens Rottmann | [PATCH re-send] lxfb: extend PLL table to support dotclo ...
Extends the PLL frequency table of the AMD Geode-LX frame buffer
driver to make use of the DIV4 bit, thus adding support for
dotclocks between 6 and 25 MHz. These are needed for small LCDs
(e.g. 320x240). Also inserts some intermediate steps between
pre-existing frequencies.
Signed-off-by: Jens Rottmann <JRottmann@LiPPERT-AT.de>
---
Hi,
in case someone has a feeling of deja-vu, I already posted this identical
patch 3 weeks ago, but got no response whatsoever, so I'm trying again.
Best ...
| Feb 27, 2:28 am 2008 |
| Jon Schindler | [PATCH 1/1] Removed deprecated init_module and cleanup_ ...
From: Jon Schindler <jkschind@gmail.com>
As part of the kernel janitor projected listed at http://kernelnewbies.org/KernelJanitors/Todo/ApiChanges
I have removed some deprecated api calls.
The deprecated init_module and cleanup_module functions have been removed from
the following ...
| Feb 27, 1:38 am 2008 |
| Paul Mundt | [GIT PULL] sh updates for 2.6.25-rc4
Please pull from:
master.kernel.org:/pub/scm/linux/kernel/git/lethal/sh-2.6.git
Which contains:
Adrian McMenamin (2):
maple: remove unused variable
maple: fix device detection
Hideo Saito (1):
sh: Fix up HAS_SR_RB typo in entry-macros.
Julia Lawall (1):
arch/sh/drivers/dma/dma-sh.c: Correct use of ! and &
Magnus Damm (1):
sh: revert dreamcast pci change
Paul Mundt (3):
sh: Rename SH-3 CCR3 reg to avoid synclink_cs clash.
sh: SH5-103 ...
| Feb 27, 1:35 am 2008 |
| Dave Airlie | Re: Reexport init_mm ?
Yes we'll get to it right away...
Oh wait...
Dave.
--
| Feb 27, 2:10 am 2008 |
| drago01 | Reexport init_mm ?
Hi,
init_mm is no longer exported in 2.6.25, because there are no in tree
modules that use it.
But the closed sources nvidia drivers are using it.
Is it possible to reexport this symbol to let the driver work with this kernel?
Please CC me when repyling.
--
| Feb 27, 1:29 am 2008 |
| Jon Schindler | [PATCH 1/1] Removed deprecated init_module and cleanup_ ...
From: Jon Schindler <jkschind@gmail.com>
As part of the kernel janitor projected listed at http://kernelnewbies.org/KernelJanitors/Todo/ApiChanges
I have removed some deprecated api calls.
The deprecated init_module and cleanup_module functions have been removed from
the following ...
| Feb 27, 1:23 am 2008 |
| Adrian Bunk | [2.6 patch] I2C_ELEKTOR must depend on HAS_IOPORT
This patch fixes the following compile error on m32r:
<-- snip -->
...
CC [M] drivers/i2c/busses/i2c-elektor.o
/home/bunk/linux/kernel-2.6/git/linux-2.6/drivers/i2c/busses/i2c-elektor.c: In function 'pcf_isa_setbyte':
/home/bunk/linux/kernel-2.6/git/linux-2.6/drivers/i2c/busses/i2c-elektor.c:80: error: implicit declaration of function 'iowrite8'
/home/bunk/linux/kernel-2.6/git/linux-2.6/drivers/i2c/busses/i2c-elektor.c: In function ...
| Feb 27, 12:37 am 2008 |
| Li Zefan | Feb 27, 12:46 am 2008 | |
| Paul Jackson | Re: [PATCH] cpuset: fix return value of cpuset_populate()
[Resending a patch that Li Zefan just sent, adding the other Paul (Menage)
to the CC list. -pj]
- no need to check err == 0
- the last return value of cgroup_add_file() is ignored
Signed-off-by: Li Zefan <lizf@cn.fujitsu.com>
---
kernel/cpuset.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/kernel/cpuset.c b/kernel/cpuset.c
index 3e296ed..1c5b2d2 100644
--- a/kernel/cpuset.c
+++ b/kernel/cpuset.c
@@ -1482,10 +1482,10 @@ static int cpuset_populate(struct ...
| Feb 27, 12:41 am 2008 |
| Li Zefan | [PATCH] cpuset: fix return value of cpuset_populate()
- no need to check err == 0
- the last return value of cgroup_add_file() is ignored
Signed-off-by: Li Zefan <lizf@cn.fujitsu.com>
---
kernel/cpuset.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/kernel/cpuset.c b/kernel/cpuset.c
index 3e296ed..1c5b2d2 100644
--- a/kernel/cpuset.c
+++ b/kernel/cpuset.c
@@ -1482,10 +1482,10 @@ static int cpuset_populate(struct cgroup_subsys *ss, struct cgroup *cont)
if ((err = cgroup_add_file(cont, ss, &cft_spread_slab)) < ...
| Feb 27, 12:36 am 2008 |
| xawolsrqoypew | (No subject)
--
| Feb 27, 12:07 am 2008 |
| Yinghai Lu | Re: [discuss] Weird cpu mapping on 8-way dual-core machine
core fix is in x86.git#testing
http://git.kernel.org/?p=linux/kernel/git/x86/linux-2.6-x86.git;a=commitdiff;h=ae2627a...
it will make sure that apicid to node mapping is right.
esp don't have SRAT or wrong SRAT, and your system have apicid lifting
YH
--
| Feb 26, 11:21 pm 2008 |
| linux-kernel | Павел Чeснов - кaндидaт на пocт Главы гoрода Баpнаула.
Павел Чeснов - кaндидaт на пocт Главы гoрода Баpнаула.
Благодapю избирaтeлей kрая, проголоcовaвших 4 годa нaзaд зa избирaтельный блok
"В пoддержкy Президентa". B АКСНД борoлся с "дедoм Hазаpoм", pабoтaл в интерeсax
нapoда и вo всex начинаниях пoддеpживaл наpодного гyбepнaтopa - Михaила Cepгeeвичa Евдoкимoвa.
Думаю, что опpавдaл Baшe довeриe! Теперь иду на гoрод. Буду "pавнoудалять" бизнесмeнoв
oт власти, нaводить пopядoк в ЖKХ, доpожнoм хoзяйствe, блaгоуcтройcтвe столицы Aлтая
во ...
| Feb 26, 10:28 pm 2008 |
| Stephen Rothwell | Re: linux-next: Tree for Feb 27
On Wed, 27 Feb 2008 17:03:00 +1100 Stephen Rothwell <sfr@canb.auug.org.au> =
The astute will notice that the pata tree has been renamed to ide as this
better reflects reality (according to Andrew).
--=20
Cheers,
Stephen Rothwell sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/
| Feb 26, 11:09 pm 2008 |
| Stephen Rothwell | linux-next: Tree for Feb 27
Hi all,
I have created today's linux-next tree at
git://git.kernel.org/pub/scm/linux/kernel/git/sfr/linux-next.git.
You can see which trees have been included by looking in the Next/Trees
file in the source. There are also quilt-import.log and merge.log files
in the Next directory. Between each merge, the tree was built with
allmodconfig for both powerpc and x86_64.
There was only one minor merge problem and one build problem.
We are up to 35 trees, more are welcome (even if they are ...
| Feb 26, 11:03 pm 2008 |
| Stephen Rothwell | Re: linux-next: Tree for Feb 27
Hi Jeff,
Excellent. Thanks for that.
--=20
Cheers,
Stephen Rothwell sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/
| Feb 27, 3:54 pm 2008 |
| Stephen Rothwell | Re: linux-next: Tree for Feb 27
Hi Paul,
Added in anticipation, thanks.
--=20
Cheers,
Stephen Rothwell sfr@canb.auug.org.au
| Feb 27, 8:31 am 2008 |
| Theodore Tso | Re: linux-next: Tree for Feb 27
Hi Stephen,
please add:
git://git.kernel.org/pub/scm/linux/kernel/git/tytso/ext4.git next
This contains a subset of the patches in the ext4 patch set which we
are explicitly planning on pushing to Linus at the next merge window.
It actually probably wouldn't hurt to pull the entire quilt series
into linux-next, since we don't export any interfaces that are used by
other linux trees, and that would give us better heads up for
conflicts in patches still in development conflicting ...
| Feb 27, 12:55 pm 2008 |
| Jeff Garzik | Re: linux-next: Tree for Feb 27
Intentionally different. libata-dev.git#NEXT is for linux-next, and
libata-dev.git#ALL is for -mm.
Jeff
--
| Feb 27, 10:30 am 2008 |
| Paul Moore | Re: linux-next: Tree for Feb 27
I keep the labeled networking patches for the upcoming (in this case
2.6.26) kernel here:
* git://git.infradead.org/users/pcmoore/lblnet-2.6_testing
Patches for the current kernel (in this case 2.6.25) live here:
* git://git.infradead.org/users/pcmoore/lblnet-2.6
Both are currently empty.
--
paul moore
linux security @ hp
--
| Feb 27, 7:43 am 2008 |
| Stephen Rothwell | Re: linux-next: Tree for Feb 27
oken-out/
But on the plus side I also have:
blackfin
dlm
libata-dev (same as git-libata-all?)
m68k
tests
--=20
Cheers,
Stephen Rothwell sfr@canb.auug.org.au
| Feb 27, 7:06 am 2008 |
| Paul Moore | Re: linux-next: Tree for Feb 27
Thanks, sorry for not sending mail sooner.
--
paul moore
linux security @ hp
--
| Feb 27, 9:06 am 2008 |
| Andrew Morton | Re: linux-next: Tree for Feb 27
So who's missing now?
I ...
| Feb 27, 12:00 am 2008 |
| Stephen Rothwell | Re: linux-next: Tree for Feb 27
Hi Ted,
Thanks, the less conflicts I have to fix the better. :-) I guess over
time patches will migrate into your next branch or they will appear there
after the next Linus release.
--=20
Cheers,
Stephen Rothwell sfr@canb.auug.org.au
| Feb 27, 4:06 pm 2008 |
| Peter Zijlstra | Re: [PATCH 00/28] Swap over NFS -v16
Humm, and here I sit staring at the screen. Perhaps I should go get my
morning juice, but...
if (mem_reserve_kmalloc_charge(my_res, sizeof(*foo), 0)) {
foo = kmalloc(sizeof(*foo), gfp|__GFP_MEMALLOC)
if (!kmem_is_emergency(foo))
mem_reserve_kmalloc_charge(my_res, -sizeof(*foo), 0)
} else
foo = kmalloc(sizeof(*foo), gfp);
Just doesn't look too pretty..
And needing to always account the allocation seems wrong.. but I'll take
poison and see if that wakes up my ...
| Feb 27, 1:33 am 2008 |
| Pekka J Enberg | Re: [PATCH 00/28] Swap over NFS -v16
Hmm, perhaps this is just hand-waving but why don't you have a
kmalloc_reserve() function in SLUB that does the accounting properly?
Pekka
--
| Feb 27, 1:43 am 2008 |
| Peter Zijlstra | Re: [PATCH 00/28] Swap over NFS -v16
There is an idea.. :-) It would mean preserving page->reserved, but SLUB
has plenty of page flags to pick from. Or maybe I should move the thing
to a page flag anyway. If we do that SLAB would allow something similar,
just look up the page for whatever address you get and look at PG_emerg
or something.
Having this would clean things up. I'll go work on this.
--
| Feb 27, 1:14 am 2008 |
| Peter Zijlstra | Re: [PATCH 00/28] Swap over NFS -v16
Yes, but alas there is no room to store such information in kmalloc().
That is, in a sane way. I think it was Daniel Phillips who suggested
encoding it in the return pointer by flipping the low bit - but that is
Yes, it would require a massive overhaul of quite a few things. I agree,
Like mempools, we could add a wrapper with a mem_reserve and waitqueue
inside, strip __GFP_WAIT, try, see if the reservation allows, and wait
if not.
I haven't yet done such a wrapper because it wasn't ...
| Feb 27, 12:58 am 2008 |
| Pekka Enberg | Re: [PATCH 00/28] Swap over NFS -v16
Hi Peter,
Why can't you add a kmem_is_emergency() to SLUB that looks up the
cache/slab/page (whatever is the smallest unit of the emergency pool
here) for the object and use that?
--
| Feb 27, 1:05 am 2008 |
| Neil Brown | Re: [PATCH 00/28] Swap over NFS -v16
Hi Peter,
Thanks... the tree thing is starting to make sense, and I'm not
confused my __mem_reserve_add any more :-)
I've been having a closer read of some of the code that I skimmed over
before and I have some more questions.
1/ I note there is no way to tell if memory returned by kmalloc is
from the emergency reserve - which contrasts with alloc_page
which does make that information available through page->reserve.
This seems a slightly unfortunate aspect of the interface.
...
| Feb 26, 10:51 pm 2008 |
| Steven Rostedt | 2.6.24.3-rt3
We are pleased to announce the 2.6.24.3-rt3 tree, which can be
downloaded from the location:
http://rt.et.redhat.com/download/
Information on the RT patch can be found at:
http://rt.wiki.kernel.org/index.php/Main_Page
Changes since 2.6.24.2-rt2
- ported to 2.6.24.3
- updates to ftrace (Ingo Molnar and Steven Rostedt)
- root domain kfree fix (Gregory Haskins)
- event trace compile fix (Clark Williams)
to build a 2.6.24.3-rt3 tree, the following patches should be ...
| Feb 26, 10:08 pm 2008 |
| Dave Young | [PATCH] make boot_delay use loops_per_jiffy directly
Make printk boot_delay use loops_per_jiffy directly,
declare preset_lpj as static, and set lpj value to loops_per_jiffy in lpj_setup.
Signed-off-by: Dave Young <hidave.darkstar@gmail.com>
---
init/calibrate.c | 6 +++---
kernel/printk.c | 15 ++++-----------
2 files changed, 7 insertions(+), 14 deletions(-)
diff -upr linux/init/calibrate.c linux.new/init/calibrate.c
--- linux/init/calibrate.c 2008-02-27 10:54:15.000000000 +0800
+++ linux.new/init/calibrate.c 2008-02-27 ...
| Feb 26, 9:43 pm 2008 |
| Paul Menage | [PATCH] Control Groups: Add Paul Menage a maintainer
Control Groups: Add Paul Menage as maintainer
Signed-off-by: Paul Menage <menage@google.com>
---
MAINTAINERS | 6 ++++++
1 file changed, 6 insertions(+)
Index: maintainers-2.6.25-rc3/MAINTAINERS
===================================================================
--- maintainers-2.6.25-rc3.orig/MAINTAINERS
+++ maintainers-2.6.25-rc3/MAINTAINERS
@@ -1132,6 +1132,12 @@ L: accessrunner-general@lists.sourceforg
W: http://accessrunner.sourceforge.net/
S: Maintained
+CONTROL GROUPS ...
| Feb 26, 8:19 pm 2008 |
| Dave Young | [PATCH 2/2] make boot_delay use loops_per_jiffy directly
Make boot_delay use loops_per_jiffy directly, this does not change the
original behaviour if apply the first patch before it.
Signed-off-by: Dave Young <hidave.darkstar@gmail.com>
---
kernel/printk.c | 15 ++++-----------
1 file changed, 4 insertions(+), 11 deletions(-)
diff -upr linux/kernel/printk.c linux.new/kernel/printk.c
--- linux/kernel/printk.c 2008-02-26 16:54:23.000000000 +0800
+++ linux.new/kernel/printk.c 2008-02-26 16:59:02.000000000 +0800
@@ -173,24 +173,14 @@ ...
| Feb 26, 8:20 pm 2008 |
| Dave Young | Re: [PATCH 1/2] preset_lpj and loops_per_jiffy initializ ...
This will make the boot_delay build fail, these two patches should
become one patch indeed, please ignore.
--
| Feb 26, 9:38 pm 2008 |
| Dave Young | [PATCH 1/2] preset_lpj and loops_per_jiffy initialize adjust
Make preset_lpj static.
Give preset lpj value to loops_per_jiffy in lpj_setup.
Signed-off-by: Dave Young <hidave.darkstar@gmail.com>
---
init/calibrate.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff -upr linux/init/calibrate.c linux.new/init/calibrate.c
--- linux/init/calibrate.c 2008-02-27 10:54:15.000000000 +0800
+++ linux.new/init/calibrate.c 2008-02-27 10:54:26.000000000 +0800
@@ -9,10 +9,11 @@
#include <linux/init.h>
#include <linux/timex.h>
-unsigned ...
| Feb 26, 8:18 pm 2008 |
| Oleg Verych | Feb 26, 8:10 pm 2008 | |
| Matthew Wilcox | Re: [PATCH] linux/fs.h - Convert debug functions declare ...
That's very interesting. It's only 64 bytes, but still, it's not
supposed to have any different effect. Could you distill a test case
for the GCC folks and file it in their bugzilla?
--
Intel are signing my paycheques ... these opinions are still mine
"Bill, look, we understand that you're interested in selling us this
operating system, but compare it to ours. We can't possibly take such
a retrograde step."
--
| Feb 26, 9:13 pm 2008 |
| Joe Perches | Re: [PATCH] linux/fs.h - Convert debug functions declare ...
Especially because __simple_attr_check_format is not even used
I'll play around with it.
--
| Feb 26, 9:55 pm 2008 |
| Joe Perches | [PATCH] linux/kernel.h linux/device.h - Convert debug fu ...
When DEBUG is not defined, pr_debug and dev_dbg and some
other local debugging functions are specified as:
"inline __attribute__((format (printf, x, y)))"
This is done to validate printk arguments when not debugging.
Converting these functions to macros or statement expressions
"do { if (0) printk(fmt, ##arg); } while (0)"
or
"({ if (0) printk(fmt, ##arg); 0; })
makes at least gcc 4.2.2 produce smaller objects.
This has the additional benefit of allowing the optimizer to
avoid calling ...
| Feb 26, 8:08 pm 2008 |
| Jan Hubicka | Re: [PATCH] linux/fs.h - Convert debug functions declare ...
It would be nice to have a testcase, but I guess it is because GCC can't
inline variadic functions. The function gets identified as const and
removed as unused by DCE, but this happens later (that is after early
inlining and before real inlining). GCC 4.0.3 didn't have early inliner
so it is probably where the difference is comming from.
One possibility to handle this side case would be to mark const
functions early during early optimization and only refine it using
Kenny's existing IPA ...
| Feb 27, 4:58 pm 2008 |
| Joe Perches | Re: [PATCH] linux/fs.h - Convert debug functions declare ...
$ gcc --version
gcc (GCC) 4.2.2 20071128 (prerelease) (4.2.2-3.1mdv2008.0)
It's definitely odd.
The .o size changes are inconsistent.
Some get bigger, some get smaller.
The versioning ones I understand but I have no idea why
changes in drivers/ or mm/ or net/ exist.
I think it's gcc optimization changes, but dunno...
Any good ideas?
$ git reset --hard
HEAD is now at 7704a8b... Merge branch 'for-linus' of git://oss.sgi.com:8090/xfs/xfs-2.6
$ make mrproper ; make defconfig ; make > ...
| Feb 26, 11:54 pm 2008 |
| Joe Perches | [PATCH] linux/fs.h - Convert debug functions declared in ...
Converting inline __attribute__((format (printf,x,y) functions
to macros or statement expressions produces smaller objects
before:
$ size vmlinux
text data bss dec hex filename
4716770 474560 618496 5809826 58a6a2 vmlinux
after:
$ size vmlinux
text data bss dec hex filename
4716706 474560 618496 5809762 58a662 vmlinux
Signed-off-by: Joe Perches <joe@perches.com>
include/linux/fs.h | 9 ++++-----
1 files changed, 4 insertions(+), 5 ...
| Feb 26, 9:02 pm 2008 |
| David Rientjes | Re: [PATCH] linux/fs.h - Convert debug functions declare ...
allyesconfig should be able to capture any text savings that this patch
My x86_64 defconfig with gcc 4.0.3 had no difference in text size after
applying your patch, yet the same config on gcc 4.1.2 did:
text data bss dec hex filename
5386112 846328 719560 6952000 6a1440 vmlinux.before
5386048 846328 719560 6951936 6a1400 vmlinux.after
--
| Feb 27, 12:38 am 2008 |
| David Rientjes | Re: [PATCH] linux/fs.h - Convert debug functions declare ...
I'm not seeing any change in text size with allyesconfig after applying
this patch with latest git:
text data bss dec hex filename
32696210 5021759 6735572 44453541 2a64ea5 vmlinux.before
32696210 5021759 6735572 44453541 2a64ea5 vmlinux.after
Joe, what version of gcc are you using?
David
--
| Feb 26, 10:44 pm 2008 |
| David Rientjes | Re: [PATCH] linux/fs.h - Convert debug functions declare ...
When I did the same comparisons on my x86_64 defconfig with gcc 4.1.3, I
What's interesting about this is that it doesn't appear to be related to
your change (static inline function to macro definition). It appears to
be simply removing the static inline function.
The only reference to __simple_attr_check_format() in either the x86 or
x86_64 defconfig is via DEFINE_SIMPLE_ATTRIBUTE() in fs/debugfs/file.c.
If you remove the only reference to it:
diff --git a/include/linux/fs.h ...
| Feb 27, 3:58 pm 2008 |
| David Miller | Re: [PATCH] CONNECTOR: make cn_already_initialized static
From: Li Zefan <lizf@cn.fujitsu.com>
Applied, thanks.
--
| Feb 26, 7:25 pm 2008 |
| Evgeniy Polyakov | Re: [PATCH] CONNECTOR: make cn_already_initialized static
Hi.
Thanks for resolving this guys.
--
Evgeniy Polyakov
--
| Feb 27, 3:38 am 2008 |
| Li Zefan | [PATCH] CONNECTOR: make cn_already_initialized static
It is used in connector.c only, so make it static.
Signed-off-by: Li Zefan <lizf@cn.fujitsu.com>
---
drivers/connector/connector.c | 2 +-
include/linux/connector.h | 2 --
2 files changed, 1 insertions(+), 3 deletions(-)
diff --git a/drivers/connector/connector.c b/drivers/connector/connector.c
index fea2d3e..85e2ba7 100644
--- a/drivers/connector/connector.c
+++ b/drivers/connector/connector.c
@@ -47,7 +47,7 @@ static LIST_HEAD(notify_list);
static struct cn_dev cdev;
...
| Feb 26, 7:22 pm 2008 |
| Matthew Wilcox | [PATCHES] semaphore rewrite
Here's a series of twelve patches to introduce down_killable(). I expect
the first ten to be uncontroversial, and easy to apply. The last two
... I'm still testing. More testers would be welcome, particularly
people who have performance test-suites they wouldn't want to see regress.
The way I go about introducing down_killable is to replace all the
carefully hand-tuned assembler with a generic C implementation. One of
the annoying things about this is that the header file is ...
| Feb 26, 5:36 pm 2008 |
| Randy Dunlap | Re: [PATCH] reserve RAM below PHYSICAL_START
---
~Randy
--
| Feb 27, 4:50 pm 2008 |
| Andrea Arcangeli | [PATCH] reserve RAM below PHYSICAL_START
Hello,
this patch allows to prevent linux from using the ram below
PHYSICAL_START.
The "reserved RAM" can be mapped by virtualization software with to
create a 1:1 mapping between guest physical (bus) address and host
physical (bus) address. This will allow pci passthrough with DMA for
the guest with current production hardware that misses VT-d. The only
detail to take care of is the ram marked "reserved RAM failed". The
virtualization software must create for the guest an e820 map ...
| Feb 26, 5:33 pm 2008 |
| Roland Dreier | [GIT PULL] please pull infiniband.git
Linus, please pull from
master.kernel.org:/pub/scm/linux/kernel/git/roland/infiniband.git for-linus
This tree is also available from kernel.org mirrors at:
git://git.kernel.org/pub/scm/linux/kernel/git/roland/infiniband.git for-linus
This will get a couple of small post-2.6.25-rc3 fixes, mostly to the
new nes driver:
Adrian Bunk (3):
RDMA/nes: Fix off-by-one
RDMA/nes: Fix a memory leak in schedule_nes_timer()
RDMA/nes: Fix a check-after-use in ...
| Feb 26, 5:27 pm 2008 |
| Andrew Morton | Re: INFO: possible circular locking in the resume
Something for Gautham and the USB people to scratch their heads over.
--
| Feb 26, 5:17 pm 2008 |
| James Morris | Re: [PATCH -mm 3/4] Audit: start not to use SELinux expo ...
I'm not quite sure what this means, but you should resend the whole
patchset.
- James
--
James Morris
<jmorris@namei.org>
--
| Feb 27, 3:25 pm 2008 |
| Paul Moore | Re: [PATCH -mm 1/4] LSM: Introduce inode_getsecid and ip ...
Same question.
--
paul moore
linux security @ hp
--
| Feb 27, 9:04 am 2008 |
| Ahmed S. Darwish | Re: [PATCH -mm 1/4] LSM: Introduce inode_getsecid and ip ...
Hi Paul,
Yes, this will also lead to consistency in the interface espcially
Both will be changed to *secid = 0 in the comming send. Thanks!
--
"Better to light a candle, than curse the darkness"
Ahmed S. Darwish
Homepage: http://darwish.07.googlepages.com
Blog: http://darwish-07.blogspot.com
--
| Feb 27, 9:45 am 2008 |
| Ahmed S. Darwish | Re: [PATCH -mm 3/4] Audit: start not to use SELinux expo ...
Hi!,
My pleasure. You'll find them consistent in the next send.
[Same release_ctx() consistency point]
Nice spot, will do. 's' will be changed too, context is already
used as 'ctx' in the whole file anyway.
Thanks a lot for such a deep review :). I'll modify spotted problems
as suggested, reorder the patch in a non compilation-breaking order,
and keep you informed.
Modified patches will be sent with the new ones that will complete
the separation not to add too much noise in ...
| Feb 27, 10:11 am 2008 |
| Paul Moore | Re: [PATCH -mm 3/4] Audit: start not to use SELinux expo ...
In the future, such patches should probably also be CC'd to the audit
This is a nit, but you used spaces between the "*" and "In case ..."
where the rest of the files uses tabs. When in doubt, try and stick
This next part isn't your fault, but you're touching the code so I'm
going to point it out and suggest you fix it while you are at it :)
If you look at how kfree()/security_release_secctx() is called in the
above two functions you notice how it is inconsistent: it is only
called ...
| Feb 27, 9:00 am 2008 |
| Hans-Peter Jansen | Re: 2.6.24.2(-rt2?) sched_fair issue
For what is worth, I seem to suffer from the very same problem here in a
different setting: trying to run a SUSE kernel-head i586 build of 2.6.24.1,
which oopses reliable during initrd.
BUG: unable to handle kernel NULL pointer dereference at virtual address 00000040
printing eip: c011f96c *pde = 00000000
Oops: 0000 [#1] SMP
last sysfs file: /block/sde/sde1/dev
Modules linked in: sata_sil24 libata 3w_9xxx sd_mod scsi_mod
Pid: 538, comm: udev Not tainted (2.6.24.1-35.1-default #1)
EIP: ...
| Feb 26, 5:04 pm 2008 |
| Stefan Richter | [PATCH update 2] firewire: fix crash in automatic module ...
"modprobe firewire-ohci; sleep .1; modprobe -r firewire-ohci" used to
result in crashes like this:
BUG: unable to handle kernel paging request at ffffffff8807b455
IP: [<ffffffff8807b455>]
PGD 203067 PUD 207063 PMD 7c170067 PTE 0
Oops: 0010 [1] PREEMPT SMP
CPU 0
Modules linked in: i915 drm cpufreq_ondemand acpi_cpufreq freq_table applesmc input_polldev led_class coretemp hwmon eeprom snd_seq_oss snd_seq_midi_event snd_seq snd_seq_device snd_pcm_oss snd_mixer_oss button ...
| Feb 27, 2:14 pm 2008 |
| H. Peter Anvin | Re: rdmsr_safe_on_cpu hangs?
*msr_safe_*() can only trap #GP's, which would be manifest as oopses if
you used the unsafe versions. If the CPU *hangs* when touching an MSR,
nothing we can do in software will help.
-hpa
--
| Feb 26, 11:51 pm 2008 |
| Bob Copeland | Re: [RFC] CodeStyle: Use spaces when aligning/decorating
Well, no one's saying that you can't configure your editor any way you
want. The tabs=8 is a good cue for the 80-column rule, though.
IMO, CodingStyle used to be a good, funny read and now it's just simply
full of boring pedantic laws.
-Bob
--
| Feb 27, 2:33 pm 2008 |
| Stefan Richter | Re: [PATCH] CodingStyle: multiple updates
Instead, start to encourage newcomers to help us fix bugs.
Thanks.
--
Stefan Richter
-=====-==--- --=- ==-==
http://arcgraph.de/sr/
--
| Feb 26, 5:42 pm 2008 |
| Stefan Richter | Re: [PATCH] CodingStyle: multiple updates
Don't do this.
--
Stefan Richter
-=====-==--- --=- ==-==
http://arcgraph.de/sr/
--
| Feb 26, 5:39 pm 2008 |
| SL Baur | Re: [PATCH] CodingStyle: multiple updates
The proposed two space change is ugly. Can someone NAK it?
-sb (The elisp guy who added the linux c-style)
--
| Feb 26, 5:57 pm 2008 |
| Krzysztof Halasa | Re: [PATCH] CodingStyle: multiple updates
I hope so.
--
Krzysztof Halasa
--
| Feb 27, 4:53 pm 2008 |
| Guennadi Liakhovetski | Re: [PATCH] CodingStyle: multiple updates
I think you do misunderstand something. The "linux" emacs mode as I know
it does for the following example
1: function(arg1,
2: arg2);
in line 2 two TABs and one space. Whereas the proposal in discussion wants
to have there one TAB and nine spaces.
Thanks
Guennadi
---
Guennadi Liakhovetski
--
| Feb 27, 3:02 am 2008 |
| Jan Engelhardt | Re: [PATCH] CodingStyle: multiple updates
Correct. Just did not want to even encourage any newcomers to use
tabs when spacing is needed. Though, some editors unfortunately do
just that - replacing 8 spaces by tabs on a new line when autoindent
is on, like mcedit :-(
--
| Feb 26, 5:02 pm 2008 |
| Richard Knutsson | Re: [PATCH] CodingStyle: multiple updates
Really nitpick, but (since it is already in the patch) wouldn't it be
Thumbs up
thanks
Richard Knutsson
--
| Feb 27, 2:41 pm 2008 |
| Richard Knutsson | Re: [RFC] CodeStyle: Use spaces when aligning/decorating
The problem isn't "should tab be <any number> wide", it is those who
want to force replacement of alignment-spaces with tabs (aka
checkpatch.pl). Also, the 80-rule is not really effective if not using
Unfortunately...
--
| Feb 27, 2:47 pm 2008 |
| Guennadi Liakhovetski | Re: [PATCH] CodingStyle: multiple updates
Then why do we define rules that we know that nobody will (be reasonably
able to) adhere to?
I can see the reasoning behind using spaces instead of tabs in
continuation lines and in in-line indentation like
int x = 1;
void *c = NULL;
or
#define X 1
#define XY 2
although I personally perfer TABs there too. But as long as we do not want
to actually impose that, I don't think we should define that.
Whereas an explicit rule requesting to use TABs and not spaces for ...
| Feb 26, 5:16 pm 2008 |
| SL Baur | Re: [PATCH] CodingStyle: multiple updates
Yes, please don't ever do that. At the very best it's an eyesore.
At the worst it's a typical Richard Stallman misfeature. And pity the
poor programmer who happens to submit a patch containing such
magic when AKPM rains thunderbolts down from heaven to correct
the error. (Andrew sustains an incoming patch load 2 orders of
magnitude higher than I ever had to and it drove me crazy, by all
means cater to his wishes).
-sb
--
| Feb 27, 2:46 pm 2008 |
| Richard Knutsson | Re: [RFC] CodeStyle: Use spaces when aligning/decorating
Not sure about the PI-reference in that context, but the rest IMO looks
good.
--
| Feb 27, 2:02 pm 2008 |
| Randy Dunlap | Re: [PATCH] CodingStyle: multiple updates
I would gladly NAK it, but most recent email from Linus about
coding style is that we are getting too detailed about it,
so unless there is some overwhelming need to change anything in
CodingStyle, I'm for no changes (or maybe even some removals).
---
~Randy
--
| Feb 26, 10:34 pm 2008 |
| Richard Knutsson | Re: [PATCH] CodingStyle: multiple updates
Not sure if it can be counted as an overwhelming need, just actually
defining the variable-wide character to be use "properly". Saw the way
through CodeStyle as the correct way to get the "replace 8-space
alignment to tab" nulled (then fix/change checkpatch.pl).
Actually, I see this as an quite simple question: is tab _the
indention-marker_? If not, then why the refusal of spaces indents (or mix)?
--
| Feb 27, 3:02 pm 2008 |
| Bernd Petrovitsch | Re: [PATCH] CodingStyle: multiple updates
Yes, I`m silly - -ENOCOFFEE;-) CodingStyle/"linux-mode" *does* use TABs
I stand corrected, you are right.
Bernd
--
Firmix Software GmbH http://www.firmix.at/
mobil: +43 664 4416156 fax: +43 1 7890849-55
Embedded Linux Development and Services
--
| Feb 27, 3:17 am 2008 |
| SL Baur | Re: [PATCH] CodingStyle: multiple updates
I agree and a NAK is a vote for not changing anything. Thanks.
-sb
--
| Feb 27, 2:33 pm 2008 |
| Benny Halevy | Re: [RFC] CodeStyle: Use spaces when aligning/decorating
How about this:
-Tabs are 8 characters, and thus indentations are also 8 characters.
-There are heretic movements that try to make indentations 4 (or even 2!)
-characters deep, and that is akin to trying to define the value of PI to
-be 3.
+Tabs are used for logical indentation, e.g., code is indented with
+a number of tabs equal to its nesting level. From there on,
+use space characters for decorative indentation. This method
+is agnostic to the editor's tab-expansion settings.
+That ...
| Feb 26, 5:14 pm 2008 |
| Bernd Petrovitsch | Re: [PATCH] CodingStyle: multiple updates
Unless I'm misunderstanding something completely: Add "indent-tabs-mode:
nil" in a "Local Variables:" section.
But since Linux-style has that since ages (if not ever), that should be
set for am emacs'ens linux-mode anyway.
Bernd
--
Firmix Software GmbH http://www.firmix.at/
mobil: +43 664 4416156 fax: +43 1 7890849-55
Embedded Linux Development and Services
--
| Feb 27, 2:27 am 2008 |
| Ingo Molnar | Re: [PATCH] elfcore-compat fix uid/gid types
Acked-by: Ingo Molnar <mingo@elte.hu>
Ingo
--
| Feb 27, 8:16 am 2008 |
| Ingo Molnar | Re: [PATCH] x86 tls prevent_tail_call
i'm wondering, have you seen this happen in practice? We use
sys_set_thread_area() for every new task started up. I guess we havent
seen problems in the field yet because this early during startup tasks
do not normally receive signals? (or if they do they are fatal and no
user signal context is used.)
btw., gcc 4.2.3 doesnt do it due to CONFIG_FRAME_POINTERS=y here, and
most distros turn on frame pointers.
btw., this whole thing of us having to notice such tail-optimization ...
| Feb 27, 12:26 am 2008 |
| Tomasz Grobelny | Re: [PATCH] x86 tls prevent_tail_call
VMware image from http://student.agh.edu.pl/~grobelny/linux/BUG.tar
demonstrates the problem. I didn't play with compiler options myself but used
http://cvs.pld-linux.org/cgi-bin/cvsweb.cgi/SPECS/kernel-vanilla.spec (rev.
1.129) as basis for my build.
--
Regards,
Tomasz Grobelny
--
| Feb 27, 12:59 pm 2008 |
| Roland McGrath | Re: [PATCH] x86 tls prevent_tail_call
That sounds like a good idea to me.
Thanks,
Roland
--
| Feb 27, 12:38 am 2008 |
| Mark Fasheh | Re: [PATCH 8/9] fs/ocfs2/aops.c: Correct use of ! and &
That looks fine - it's in Ocfs2.git now, thanks.
--Mark
--
Mark Fasheh
Principal Software Developer, Oracle
mark.fasheh@oracle.com
--
| Feb 27, 2:26 pm 2008 |
| John W. Linville | Re: [PATCH 6/9] drivers/net/wireless/iwlwifi/iwl-4965.c: ...
Already merged and sent to davem...
Thanks,
John
--
John W. Linville
linville@tuxdriver.com
--
| Feb 26, 5:59 pm 2008 |
| Mark Pearson | Re: [PATCH 2/9] drivers/acpi/asus_acpi.c: Correct use of ...
Seems an odd way of doing:
led_out ^= 0x01;
It this due to some optimisation?
Cheers, Mark.
--
| Feb 27, 11:29 am 2008 |
| Julia Lawall | Re: [PATCH 2/9] drivers/acpi/asus_acpi.c: Correct use of ...
I spent some time thinking about this one. The original code is ok if
led_out is always either 0x01 or 0x00. But what if it is eg 0xc0? Then
the negation amounts to the negation of a nonzero number, so the result is
0. So the result of the bit and is 0. So the last bit is not flipped.
But I don't know what is the range of led_out. If it is always 1 or 0,
then why bother with the bit and?
julia
--
| Feb 27, 10:41 am 2008 |
| Karol Kozimor | Re: [PATCH 2/9] drivers/acpi/asus_acpi.c: Correct use of ...
IIRC we're just supposed to flip the last bit here, so the original
code is correct.
Best regards,
--
Karol Kozimor
sziwan@hell.org.pl
--
| Feb 27, 10:03 am 2008 |
| Paul Mundt | Re: [PATCH 1/9] arch/sh/drivers/dma/dma-sh.c: Correct us ...
Indeed. Applied, thanks.
--
| Feb 26, 6:29 pm 2008 |
| Stefan Richter | Re: Intel 945GM: 2.6.25-rc3 report (with a possible regr ...
Are you sure that this is a kernel regression, not a xf86-video-i810
regression?
(On Gentoo, switching from X to console works with xf86-video-i810-2.1.1
but results in a black screen with xf86-video-i810-2.2.0.90.)
--
Stefan Richter
-=====-==--- --=- ==-==
http://arcgraph.de/sr/
--
| Feb 26, 5:29 pm 2008 |
| Stefan Richter | Re: Intel 945GM: 2.6.25-rc3 report (with a possible regr ...
Indeed, 2.2.1 fixes this issue for me.
--
Stefan Richter
-=====-==--- --=- ==-==
http://arcgraph.de/sr/
--
| Feb 27, 9:03 am 2008 |
| Frans Pop | Re: Intel 945GM: 2.6.25-rc3 report (with a possible regr ...
Yes, the X.Org developers are making major changes ATM and there have
definitely been regressions because of them.
Best way to find out is to check whether booting with an earlier kernel
solves the problem. If it does, it's most likely a kernel issue. If it
This sounds like that could be a bug I filed recently and which was solved
in 2.2.1: http://bugs.freedesktop.org/show_bug.cgi?id=14481.
Cheers,
FJP
--
| Feb 27, 5:32 am 2008 |
| Pekka J Enberg | Re: [RFC/PATCH] ipg: add jumbo frame support kconfig option
s/sysfs attribute/module parameter/
Sorry, too early in the morning for me.
--
| Feb 27, 12:52 am 2008 |
| Jeff Garzik | Re: [RFC/PATCH] ipg: add jumbo frame support kconfig option
You could do it that way, but really, a non-jumbo default MTU should be
sufficient.
The user must take proactive action to change the MTU to jumbo at that
point... that way its far more likely to get tested, while being
non-default, too.
Jeff
--
| Feb 27, 1:05 am 2008 |
| Pekka J Enberg | Re: [RFC/PATCH] ipg: add jumbo frame support kconfig option
Hi,
Ok, so a sysfs attribute would be sufficient, I suppose? I don't have the
hardware though, so I don't even know if the jumbo frame code actually
works at this point hence the RFC. So I'll wait for someone to test this
before sending a new patch. Thanks for the review!
Pekka
--
| Feb 27, 12:44 am 2008 |
| H. Peter Anvin | Re: (regression) kernel/timeconst.h bugs with HZ=128
<barf>
The real issue is that we don't have any equivalent to the UINTxx_C()
creation macros in Linux, and even though we're using a cast -- which is
totally correct -- makes gcc issue a (spurious) warning.
The right thing would be to create _C() macros and use those in the C
code, i.e. UINT64_C(MSEC_TO_HZ_MUL32).
I'll write up a patch, but probably not today.
-hpa
--
| Feb 26, 5:34 pm 2008 |
| Andrew Morton | Re: (regression) kernel/timeconst.h bugs with HZ=128
(cc's added)
--
| Feb 26, 5:09 pm 2008 |
| Stephen Rothwell | Re: -next build logs
On Tue, 26 Feb 2008 19:15:37 +0100 Stefan Richter <stefanr@s5r6.in-berlin.d=
The build system will now remove the object tree after each build, so
everything should now get built every time. It was doing a "make clean"
but only if the build succeeded.
--=20
Cheers,
Stephen Rothwell sfr@canb.auug.org.au
| Feb 26, 11:06 pm 2008 |
| Tony Battersby | Re: Performance problems with 3ware 9500S-4LP and 2.6.25-rc3
This is not 3ware-specific, but kernel 2.6.24 has new per-device write
throttling that might help with the responsiveness issue:
http://kernelnewbies.org/LinuxChanges#head-92340ffcec39e7c2a09fd933243fb18eda57f1b4
http://lwn.net/Articles/245600/
Also, check to see if the 3ware controller has a background initialize
or verify in progress, since that will obviously slow things down until
it is complete.
Tony
--
| Feb 27, 7:26 am 2008 |
| Andre Noll | Re: Performance problems with 3ware 9500S-4LP and 2.6.25-rc3
?=20
Yes, I do. Performance is poor anyway.
Andre
--=20
The only person who always got his work done by Friday was Robinson Crusoe
| Feb 27, 3:10 am 2008 |
| Chris Snook | Re: Performance problems with 3ware 9500S-4LP and 2.6.25-rc3
Actually, it's normal for pdflush to spawn up to 8 threads when you're
dirtying memory faster than it can be written to disk. Load going to 4
Does the machine become unresponsive during the single-threaded test, or
only when doing the rsync?
-- Chris
--
| Feb 27, 12:55 pm 2008 |
| adam radford | Re: Performance problems with 3ware 9500S-4LP and 2.6.25-rc3
Andre,
Can you try turning down /sys/block/sdX/device/queue_depth to 16 and
see if that improves your responsiveness?
-Adam
--
| Feb 27, 1:06 pm 2008 |
| Andre Noll | Re: Performance problems with 3ware 9500S-4LP and 2.6.25-rc3
The machine becomes sluggish also when I write directly to the raid
array. A simple
dd if=3D/dev/zero of=3Dtmpfile
Single threaded throughput seems to be ok (140M/s). The problem is
that the machine becomes unresponsive.
Andre
--=20
The only person who always got his work done by Friday was Robinson Crusoe
| Feb 27, 3:11 am 2008 |
| Andre Noll | Re: Performance problems with 3ware 9500S-4LP and 2.6.25-rc3
Thanks, this helped a lot. However, there does not seem to be a way
to make the system more responsive, which is really the problem we
are experiencing.
Andre
--=20
The only person who always got his work done by Friday was Robinson Crusoe
| Feb 27, 3:11 am 2008 |
| Andre Noll | Re: Performance problems with 3ware 9500S-4LP and 2.6.25-rc3
Yes, but we tried both 2.6.24 and 2.6.25-rc, so Peter's new
write-throttling code doesn't seem to help much in our situtation. I'll
play a bit with the various /proc/sys/vm/* knobs to see if that makes
That's certainly not the case.
Thanks
Andre
--=20
The only person who always got his work done by Friday was Robinson Crusoe
| Feb 27, 10:05 am 2008 |
| David Brownell | Re: usb detecting only high speed devices only - not det ...
My diagnosis hasn't changed since last time he asked this question:
it's related to IRQ handling, outside the scope of USB. If USB
were getting the OHCI interrupts, it would not issue that message.
Now as to *why* that happens, I don't know. We've certainly had folk
using Philips/NXP EHCI controllers successfully before. Maybe this
board has a hardware problem, like a bad chip or not having wired
up the power lines that OHCI controller uses.
One small experiment would be to try using ...
| Feb 26, 7:17 pm 2008 |
| Andrew Morton | Re: usb detecting only high speed devices only - not det ...
(cc linux-usb)
--
| Feb 26, 5:05 pm 2008 |
| Otavio Salvador | Re: oops when using git gc --auto
In the end, it was a motherboard issue.
Thanks for the help!
--
O T A V I O S A L V A D O R
---------------------------------------------
E-mail: otavio@debian.org UIN: 5906116
GNU/Linux User: 239058 GPG ID: 49A5F855
Home Page: http://otavio.ossystems.com.br
---------------------------------------------
"Microsoft sells you Windows ... Linux gives
you the whole house."
--
| Feb 27, 1:01 pm 2008 |
| Evgeniy Polyakov | Re: [2.6.25 patch] drivers/crypto/hifn_795x.c: fix 64bit ...
Well, if you think it is resonable to pass u64 into function, which is
supposed to sleep no more than several cpu cycles. I do not want to
Absolutely.
--
Evgeniy Polyakov
--
| Feb 27, 8:59 am 2008 |
| Adrian Bunk | Re: [2.6.25 patch] drivers/crypto/hifn_795x.c: fix 64bit ...
include/linux/delay.h:35
cu
Adrian
--
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed
--
| Feb 26, 11:22 pm 2008 |
| Andrew Morton | Re: [2.6.25 patch] drivers/crypto/hifn_795x.c: fix 64bit ...
well found.
Something like this:
--- a/include/linux/delay.h~a
+++ a/include/linux/delay.h
@@ -7,10 +7,12 @@
* Delay routines, using a pre-computed "loops_per_jiffy" value.
*/
-extern unsigned long loops_per_jiffy;
+#include <linux/kernel.h>
#include <asm/delay.h>
+extern unsigned long loops_per_jiffy;
+
/*
* Using udelay() for intervals greater than a few milliseconds can
* risk overflow for high loops_per_jiffy (high bogomips) machines. The
@@ -32,7 +34,11 @@ ...
| Feb 26, 11:47 pm 2008 |
| Andrew Morton | Re: [2.6.25 patch] drivers/crypto/hifn_795x.c: fix 64bit ...
udelay() might be exposed to the same problem. It would be better to fix
ndelay() and udelay() rather than callers. It is reasonable to pass a u64
into ndelay() and to expect the build to not explode.
(Geeze macros suck)
--
| Feb 26, 5:04 pm 2008 |
| Ralf Baechle | Re: 2.6.25-rc3: "__divdi3" [drivers/crypto/hifn_795x.ko] ...
On Tue, Feb 26, 2008 at 01:21:00PM +0100, Martin Michlmayr wrote:
References to __divdi3 / __udivdi3 are becoming a somewhat regular bug.
I've created a patch to add these to the kernel but I'd rather not push
it unless I have to. 64-bit operations but especially divisions are slow
on 32-bit hardware so undefined references serve as an important detector.
Ralf
--
| Feb 27, 7:53 am 2008 |
| David Rientjes | Re: 2.6.25-rc3: "__divdi3" [drivers/crypto/hifn_795x.ko] ...
crypto: use do_div() when registering the rng
Use do_div() instead of the divide operator.
Cc: Patrick McHardy <kaber@trash.net>
Cc: Herbert Xu <herbert@gondor.apana.org.au>
Signed-off-by: David Rientjes <rientjes@google.com>
---
Looks like this was triggered by f881d829, which causes this code to be
compiled for CONFIG_CRYPTO_DEV_HIFN_795X_RNG.
drivers/crypto/hifn_795x.c | 8 +++++---
1 files changed, 5 insertions(+), 3 deletions(-)
diff --git a/drivers/crypto/hifn_795x.c ...
| Feb 26, 8:46 pm 2008 |
| Patrick McHardy | Re: 2.6.25-rc3: "__divdi3" [drivers/crypto/hifn_795x.ko] ...
This is similar to my patch, which didn't fix the problem. Adrian
already fixed it.
--
| Feb 27, 4:29 am 2008 |
| Matthew Garrett | Re: broken suspend in .2.6.25-rc3 on T61p (was Re: new r ...
Stefan told us at FOSDEM that s2ram was being deprecated in OpenSuse, so
I don't think this is the way to go.
--
Matthew Garrett | mjg59@srcf.ucam.org
--
| Feb 27, 6:12 am 2008 |
| Matthew Garrett | Re: broken suspend in .2.6.25-rc3 on T61p (was Re: new r ...
Ah! My apologies, I managed to misunderstand that.
--
Matthew Garrett | mjg59@srcf.ucam.org
--
| Feb 27, 8:55 am 2008 |
| Rafael J. Wysocki | Re: broken suspend in .2.6.25-rc3 on T61p (was Re: new r ...
Well, is that really correct? Stefan??
He probably meant that the s2ram _whitelist_ is going to be deprecated, which
didn't mean s2ram altogether.
s2ram is pretty useful anyway, as it combines many mechanisms that allow us to
bring the video back to life from the user land, so you can use one binary
instead of a bunch of different programs with different command lines etc.
Thanks,
Rafael
--
| Feb 27, 6:23 am 2008 |
| Rafael J. Wysocki | Re: broken suspend in .2.6.25-rc3 on T61p (was Re: new r ...
In theory we should be able to get this kind of information from ACPI, but I've
never seriously looked at that. I'm not sure if anyone has ...
Thanks,
Rafael
--
| Feb 26, 5:12 pm 2008 |
| Stefan Seyfried | Re: broken suspend in .2.6.25-rc3 on T61p (was Re: new r ...
Yes, the current openSUSE basically uses the same setup, but this will change
That's what i like about it and the part i want to keep: do all the
workarounds in one place, ideally with locked VTs and maybe mlock()ed, but get
the workaround options from HAL.
I also had the impression that i had said this quite clearly, but the talk was
short, so the "data compression" of the information might not have been
lossless :-)
Hope this helps to clear up the confusion.
--
Stefan ...
| Feb 27, 8:51 am 2008 |
| Robert Hancock | Re: [PATCH] sata_nv: fix nmi intr or system hanging in r ...
I suspect nv_adma_register_mode failing may be the key. I don't know why
this happens. It could be the timeout needs to be longer but I've tried
increasing it significantly without apparent effect. (Essentially it's
waiting for the status to go to the IDLE state, and then clears the GO
bit and waits for LEGACY to be set. In this case both waits timed out.)
--
| Feb 26, 10:24 pm 2008 |
| Kuan Luo | RE: [PATCH] sata_nv: fix nmi intr or system hanging in r ...
The driver got one error : "nv_adma_check_cpb: CPB 0, flags=0x11". The
code entered ata_port_abort -> ata_qc_complete
-> fill_result_tf->nv_adma_tf_read.
Firstly, nv_adma_register_mode failed, showing the below messages:
timeout waiting for ADMA IDLE, stat=0x440
timeout waiting for ADMA LEGACY, stat=0x440
Then enter ata_tf_read function.
I found the system hung at tf->hob_nsect = ioread8(ioaddr->nsect_addr);
Sometimes the screen showed "
CPU0: Machin check Exception ...
| Feb 26, 9:55 pm 2008 |
| Anders Eriksson | Re: 2.6.25-rc2 + smartd = hang
Just to make sure I didn't goofed up the bisection...
I bisected between v2.6.24 and v2.6.25-rc2. In the midst of the bisection, make
install decided to call the new version 2.6.24-rc7-gXXXX. Is that ok? I figured
rc7+delta was before 24-final, hence outside the bisection? After that event I
got the normal series of good god bad good... So I figured we were on the right
track anyway...
/A
--
| Feb 27, 12:53 am 2008 |
| Karsten Wiese | Re: [BUG] using smp_processor_id() in preemptible as sus ...
Dave, can you give this untested patch a try?
thanks,
Karsten
---
diff --git a/kernel/rcupreempt.c b/kernel/rcupreempt.c
index c7c5209..5a7f8fc 100644
--- a/kernel/rcupreempt.c
+++ b/kernel/rcupreempt.c
@@ -878,18 +878,20 @@ void rcu_offline_cpu(int cpu)
* Otherwise rcu_barrier() will fail
*/
- spin_lock_irqsave(&rdp->lock, flags);
+ local_irq_save(flags);
+
+ spin_lock(&rdp->lock);
rcu_offline_cpu_enqueue(rdp->donelist, rdp->donetail, list, tail);
for (i = ...
| Feb 27, 4:11 pm 2008 |
| Dave Young | Re: [BUG] using smp_processor_id() in preemptible as sus ...
On Wed, Feb 27, 2008 at 12:33 AM, Andrew Morton
# CONFIG_CLASSIC_RCU is not set
2.6.25-rc3 with some bluetooth debug code of mine
--
| Feb 26, 5:39 pm 2008 |
| Dave Young | Re: [BUG] using smp_processor_id() in preemptible as sus ...
On Wed, Feb 27, 2008 at 3:45 AM, Paul E. McKenney
Built ok, but can't even resume now. (dark screen with cursor blinking
on top-left of minitor)
Forgot to tell, I saw this bug as enable PM_DEBUG, maybe it's related
--
| Feb 26, 6:04 pm 2008 |
| Jamie Lokier | Re: Proposal for "proper" durable fsync() and fdatasync()
[Empty message]
| Feb 27, 7:16 am 2008 |
| Steven Whitehouse | Re: [PATCH 1/2] [GFS2] remove gfs2_dev_iops
Hi,
Both patches are now in the -nmw git tree. Sorry for the delay. I've
changed the comment on the second one since that commit ID didn't appear
to match up with the right patch.
Steve.
--
| Feb 27, 11:08 am 2008 |
| Chatre, Reinette | RE: iwl4965 dropping packets and __dev_addr_discard: add ...
You can use the latest iwlwifi driver with kernel 2.6.24 when using the
compat-wireless project (http://linuxwireless.org/en/users/Download).
You can also load the driver with debugging (modprobe iwl4965
debug=0x43fff) to get more info about what happens during module unload.
Reinette
--
| Feb 26, 11:14 pm 2008 |
| David Rientjes | Re: [RFC][PATCH] page reclaim throttle take2
I'd use _THREAD instead of _TASK, but I'd also wait for Balbir's input
because perhaps I missed something in my original analysis that this
config option represents only the maximum number of concurrent reclaim
threads and other heuristics are used in addition to this that determine
the exact number of threads depending on VM strain.
David
--
| Feb 26, 10:47 pm 2008 |
| KOSAKI Motohiro | Re: [RFC][PATCH] page reclaim throttle take2
hm, intersting.
but sysctl parameter is more better, i think.
OK, I'll add it at next post.
--
| Feb 26, 10:04 pm 2008 |
| KAMEZAWA Hiroyuki | Re: [RFC][PATCH] page reclaim throttle take2
On Wed, 27 Feb 2008 13:45:18 +0900
How about adding something like..
==
CONFIG_SIMULTANEOUS_PAGE_RECLAIMERS
int
default 3
depends on DEBUG
help
This value determines the number of threads which can do page reclaim
in a zone simultaneously. If this is too big, performance under heavy memory
pressure will decrease.
If unsure, use default.
==
Then, you can get performance reports from people interested in this
feature in test cycle.
Thanks,
-Kame
--
| Feb 26, 10:00 pm 2008 |
| KAMEZAWA Hiroyuki | Re: [RFC][PATCH] page reclaim throttle take2
On Tue, 26 Feb 2008 22:18:38 +0100
I think it doesn't make sense for fairness.
IMHO, this functionality is an unfair one in nature. While someone is
reclaiming pages, other processes can get a newly reclaimed page without
calling try_to_free_page.
For high-priority processes,
1. avoiding diving into try_to_free_pages if it's congested.
2. just waiting for that someone relcaim pages and grab it ASAP
maybe good for quick work.
Thanks,
-Kame
--
| Feb 26, 5:50 pm 2008 |
| Rik van Riel | Re: [RFC][PATCH] page reclaim throttle take2
On Tue, 26 Feb 2008 23:19:08 -0800 (PST)
The more CPUs there are, the more lock contention you want?
Somehow that seems backwards :)
--
All rights reversed.
--
| Feb 27, 8:30 am 2008 |
| Balbir Singh | Re: [RFC][PATCH] page reclaim throttle take2
I think sysctl should be interesting. The config option provides good
documentation, but it is static in nature (requires reboot to change). I wish we
could have the best of both worlds.
--
Warm Regards,
Balbir Singh
Linux Technology Center
IBM, ISTL
--
| Feb 26, 10:03 pm 2008 |
| KOSAKI Motohiro | Re: [RFC][PATCH] page reclaim throttle take2
I don't think so.
all modern many cpu machine stand on NUMA.
it mean following,
- if cpu increases, then zone increases, too.
if default value increase by #cpus, lock contension dramatically increase
on large numa.
Have I overlooked anything?
and, (but) i afraid to 3 is too small value.
if you have another test result on large machine, please show me.
- kosaki
--
| Feb 26, 9:45 pm 2008 |
| KOSAKI Motohiro | Re: [RFC][PATCH] page reclaim throttle take2
Agghhh, sorry ;-)
Hmmm
may be, we don't need perfectly fair.
because try_to_free_page() is unfair mechanism.
but I will test use wake_up() instead wake_up_all().
it makes so so fair order if no performance regression happend.
Thanks very useful comment.
- kosaki
--
| Feb 26, 9:26 pm 2008 |
| KOSAKI Motohiro | Re: [RFC][PATCH] page reclaim throttle take2
hm,
could you post another patch?
I hope avoid implementless discussion.
and I hope compare by benchmark result.
-kosaki
--
| Feb 27, 12:10 am 2008 |
| Balbir Singh | Re: [RFC][PATCH] page reclaim throttle take2
You mentioned CONFIG_NUM_RECLAIM_THREADS_PER_CPU and not
CONFIG_NUM_RECLAIM_THREADS_PER_NODE. The advantage with syscalls is that even if
we get the thing wrong, the system administrator has an alternative. Please look
through the existing sysctl's and you'll see what I mean. What is wrong with
providing the flexibility that comes with sysctl? We cannot possibly think of
all situations and come up with the right answer for a heuristic. Why not come
up with a default and let everyone use what ...
| Feb 27, 2:01 am 2008 |
| David Rientjes | Re: [RFC][PATCH] page reclaim throttle take2
My suggestion is merely to make the number of concurrent page reclaim
threads be a function of how many online cpus there are. Threads can
easily be added or removed for cpu hotplug events by callback functions.
That's different than allowing users to change the number of threads with
yet another sysctl. Unless there are situations that can be presented
where tuning the number of threads is advantageous to reduce lock
contention, for example, and not simply working around other VM ...
| Feb 27, 12:19 am 2008 |
| David Rientjes | Re: [RFC][PATCH] page reclaim throttle take2
That is why the proposal was made to make this a static configuration
option, such as CONFIG_NUM_RECLAIM_THREADS_PER_NODE, that will handle both
The benchmark that have been posted suggest that memory locality is more
important than lock contention, as I've already mentioned.
David
--
| Feb 27, 1:47 am 2008 |
| KAMEZAWA Hiroyuki | Re: [RFC][PATCH] page reclaim throttle take2
On Tue, 26 Feb 2008 23:19:08 -0800 (PST)
Hmm, but kswapd, which is main worker of page reclaiming, is per-node.
And reclaim is done based on zone.
per-zone/per-node throttling seems to make sense.
I know his environment has 4cpus per node but throttle to 3 was the best
number in his measurement. Then it seems num-per-cpu is excessive.
(At least, ratio(%) is better.)
When zone-reclaiming is improved to be scale well, we'll have to change
this throttle.
BTW, could someone try his patch on ...
| Feb 27, 12:51 am 2008 |
| David Rientjes | Re: [RFC][PATCH] page reclaim throttle take2
We lack node hotplug, so the dependence on the number of system nodes in
the equation is static and can easily be defined at compile-time.
I agree that the maximum number of parallel reclaim threads should be a
function of cpus, so you can easily make it that by adding callback
functions for cpu hotplug events.
Perhaps a better alternative than creating a set of heuristics and setting
a user-defined maximum on the number of concurrent reclaim threads is to
configure the number of ...
| Feb 26, 11:09 pm 2008 |
| KOSAKI Motohiro | Re: [RFC][PATCH] page reclaim throttle take2
MAX_PARALLEL_RECLAIM_TASK is good word?
- kosaki
--
| Feb 26, 10:33 pm 2008 |
| KAMEZAWA Hiroyuki | Re: [RFC][PATCH] page reclaim throttle take2
On Tue, 26 Feb 2008 23:56:39 -0800 (PST)
Hmm, do you know there is already zone-hotplug ? ;)
(Means, onlining new memory in new zone increase the # of zones.
I agree that what is the best is based on benchmark.
I like per-node, now.
I hear that there is also I/O bottle-neck for page reclaiming, at last.
Thanks,
-Kame
--
| Feb 27, 1:09 am 2008 |
| KOSAKI Motohiro | Re: [RFC][PATCH] page reclaim throttle take2
OK, I obey your opinion.
- kosaki
--
| Feb 26, 10:13 pm 2008 |
| Balbir Singh | Re: [RFC][PATCH] page reclaim throttle take2
One more thing, I would request you to add default heuristics (number of
reclaimers), based on the number of cpus in the system. Letting people tuning it
is fine, but defaults should be related to number of cpus, nodes and zones on
the system. Zones can be reaped in parallel per node and cpus allow threads to
run in parallel. So please use that to come up with good defaults, instead of a
number like "3".
--
Warm Regards,
Balbir Singh
Linux Technology Center
IBM, ISTL
--
| Feb 26, 9:27 pm 2008 |
| David Rientjes | Re: [RFC][PATCH] page reclaim throttle take2
I disagree, the config option is indeed static but so is the NUMA topology
of the machine. It represents the maximum number of page reclaim threads
that should be allowed for that specific topology; a maximum should not
need to be redefined with yet another sysctl and should remain independent
of various workloads.
However, I would recommend adding the word "MAX" to the config option.
David
--
| Feb 26, 10:19 pm 2008 |
| Balbir Singh | Re: [RFC][PATCH] page reclaim throttle take2
Things are changing, with memory hot-add remove, CPU hotplug , the topology can
change and is no longer static. One can create fake NUMA nodes on the fly using
a boot option as well.
Since we're talking of parallel reclaims, I think it's a function of CPUs and
Nodes. I'd rather keep it as a sysctl with a good default value based on the
topology. If we end up getting it wrong, the system administrator has a choice.
That is better than expecting him/her to recompile the kernel and boot that. ...
| Feb 26, 10:48 pm 2008 |
| Balbir Singh | Re: [RFC][PATCH] page reclaim throttle take2
Let's forget node hotplug for the moment, but what if someone
1. Changes the machine configuration and adds more nodes, do we expect the
kernel to be recompiled? Or is it easier to update /etc/sysctl.conf?
2. Uses fake NUMA nodes and increases/decreases the number of nodes across
I am afraid it doesn't. Consider as you scale number of CPU's with the same
We are providing a solution with a good default value, allowing the
administrator to change them when our defaults don't work well.
-- ...
| Feb 27, 12:59 am 2008 |
| Peter Zijlstra | Re: [RFC][PATCH] page reclaim throttle take2
I agree with Balbir, just turn it into a sysctl, its easy enough to do,
and those who need it will thank you for it instead of curse you for
hard coding it.
--
| Feb 27, 2:44 am 2008 |
| David Rientjes | Re: [RFC][PATCH] page reclaim throttle take2
That's another argument for not introducing the sysctl; the number of
nodes and zones are a static property of the machine that cannot change
without a reboot (numa=fake, mem=, introducing movable zones, etc). We
don't have node hotplug that can suddenly introduce additional zones from
which to reclaim.
My point was that there doesn't appear to be any use case for tuning this
via a sysctl that isn't simply attempting to workaround some other reclaim
problem when the VM is stressed. If ...
| Feb 27, 12:56 am 2008 |
| KOSAKI Motohiro | Re: [RFC][PATCH] page reclaim throttle take2
sorry, I don't understand yet.
I think my patch is already function of CPUs and Nodes.
per zone limit indicate propotional #cpus and #nodes.
please tell me the topology that per zone limit doesn't works so good.
I think boot option and sysctl should be used only while -mm
for get various feedback.
end up, we should select more better default, and remove sysctl.
- kosaki
--
| Feb 26, 11:52 pm 2008 |
| Greg KH | Re: [stable] Linux 2.6.24.3
My appologies, you are correct, tough keeping track of this while at
conferences...
I'll take care of it on Friday.
thanks,
greg k-h
--
| Feb 27, 3:47 pm 2008 |
| Randy Dunlap | Re: Linux 2.6.24.3
No, but I thought that we had already been thru this...
---
~Randy
--
| Feb 27, 2:49 pm 2008 |
| Greg KH | Re: [stable] Linux 2.6.24.3
Ugh, sorry, too many trees/bugs/patches right now. I'll take care of
this on friday when I get back home...
greg k-h
--
| Feb 27, 3:47 pm 2008 |
| David Miller | Re: Linux 2.6.24.3
From: Greg KH <gregkh@suse.de>
Greg, look more carefully, it's because of the patch us networking
folks asked you yesterday to revert.
--
| Feb 27, 2:59 pm 2008 |
| David Miller | Re: [PATCH] bluetooth: delete timer in l2cap_conn_del()
From: Thomas Gleixner <tglx@linutronix.de>
I'll apply this, thanks Thomas.
--
| Feb 26, 6:43 pm 2008 |
| David Miller | Re: [PATCH] bluetooth: delete timer in l2cap_conn_del()
Marcel/Dave, can you or someone else followup with
the bug reportor to get their dongle working now that
the OOPS problem is fixed?
Let's not lose track of this bug, thanks.
--
| Feb 27, 3:08 pm 2008 |
| Thomas Gleixner | Feb 27, 5:20 am 2008 | |
| Marcel Holtmann | Re: [PATCH] bluetooth: delete timer in l2cap_conn_del()
can you please wait for a confirmation from Quel that this fixes it.
My ACK is based on that he confirms that it fixes it for sure.
Regards
Marcel
--
| Feb 27, 2:55 am 2008 |
| David Miller | Re: [PATCH] bluetooth: delete timer in l2cap_conn_del()
From: Marcel Holtmann <marcel@holtmann.org>
It doesn't hurt to toss this to Linus now, if it's bogus we
have tons of time to revert it.
--
| Feb 27, 12:07 pm 2008 |
| Marcin Slusarz | Re: [PATCH] video: limit stack usage of ir-kbd-i2c.c
That won't work. Variables at beginning of function take only ~600 bytes,
There's "noinline" attribute in linux/compiler.h (compiler-gcc.h actually)
Nice idea.
I'll try 2nd and 4th approaches.
Marcin Slusarz
--
| Feb 27, 3:23 am 2008 |
| Mauro Carvalho Chehab | Re: [PATCH] video: limit stack usage of ir-kbd-i2c.c
On Wed, 27 Feb 2008 11:23:26 +0100
The union will probably solve. This function is very complex, since it needs to
deal with almost all v4l1 v4l2 ioctls (about 80-90). Splitting into small
Cheers,
Mauro
--
| Feb 27, 3:33 am 2008 |
| Mikael Pettersson | Re: [BUG] 2.6.25-rc3 hangs in early boot on Sun Ultra5
David Miller writes:
> From: Mikael Pettersson <mikpe@it.uu.se>
> Date: Tue, 26 Feb 2008 09:55:50 +0100
>
> > Minor update: rc2-git7 has the slow initial console behaviour,
> > but successfully switches to the framebuffer. rc2-git8 however
> > hangs in the console handover. So I'll bisect git7->git8 next.
>
> Between the VT layer registering it's console and the atyfb
> driver initializing we get a crash, and it happens on all
> sparc64 systems. It is caused by this commit and I ...
| Feb 27, 1:27 am 2008 |
| Thomas Gleixner | Re: [BUG] 2.6.25-rc3 hangs in early boot on Sun Ultra5
So it would be correct to set_fs(USER_DS) then do the check and switch
It's queued, AFAIK
Thanks,
tglx
--
| Feb 27, 1:02 am 2008 |
| Thomas Gleixner | Re: [BUG] 2.6.25-rc3 hangs in early boot on Sun Ultra5
I would have preferred not to. The hassle is that we need to figure
out, whether it works or not _before_ any user space program can use
the interfaces. We could omit the check for archs where the
Ok.
Thanks,
tglx
--
| Feb 27, 12:55 pm 2008 |
| David Miller | Re: [BUG] 2.6.25-rc3 hangs in early boot on Sun Ultra5
From: Mikael Pettersson <mikpe@it.uu.se>
Between the VT layer registering it's console and the atyfb
driver initializing we get a crash, and it happens on all
sparc64 systems. It is caused by this commit and I am working
on a fix:
commit a0c1e9073ef7428a14309cba010633a6cd6719ea
Author: Thomas Gleixner <tglx@linutronix.de>
Date: Sat Feb 23 15:23:57 2008 -0800
futex: runtime enable pi and robust functionality
Not all architectures implement futex_atomic_cmpxchg_inatomic(). ...
| Feb 26, 5:49 pm 2008 |
| Mikael Pettersson | Re: [BUG] 2.6.25-rc3 hangs in early boot on Sun Ultra5
David Miller writes:
> From: David Miller <davem@davemloft.net>
> Date: Tue, 26 Feb 2008 16:49:00 -0800 (PST)
>
> [ Thomas, forgot to CC: you earlier, changeset
> a0c1e9073ef7428a14309cba010633a6cd6719ea ("futex: runtime enable pi
> and robust functionality") broke sparc64. ]
>
> > From: Mikael Pettersson <mikpe@it.uu.se>
> > Date: Tue, 26 Feb 2008 09:55:50 +0100
> >
> > > Minor update: rc2-git7 has the slow initial console behaviour,
> > > but successfully switches to the ...
| Feb 27, 12:16 pm 2008 |
| David Miller | Re: [BUG] 2.6.25-rc3 hangs in early boot on Sun Ultra5
From: David Miller <davem@davemloft.net>
Date: Tue, 26 Feb 2008 16:49:00 -0800 (PST)
[ Thomas, forgot to CC: you earlier, changeset
a0c1e9073ef7428a14309cba010633a6cd6719ea ("futex: runtime enable pi
The following patch will let things "work" but the trick being used
here by the FUTEX layer is borderline valid in my opinion.
Basically for 10+ years on sparc64 we've had this check here in the
fault path, which makes sure that if we're processing an exception
table entry we really, truly, ...
| Feb 26, 6:06 pm 2008 |
| David Miller | Re: [BUG] 2.6.25-rc3 hangs in early boot on Sun Ultra5
From: Thomas Gleixner <tglx@linutronix.de>
No, I'm saying it would be better not to take faults purposefully in
the kernel address space. We don't have a usable user address space
setup at this point in the boot, so using USER_DS would be even worse.
I think I'll just add a different version of the sanity check to this
sparc64 code later on, one that will take into consideration this
KERNEL_DS case because I can see how it could be useful in other
Crap, I'll need to push my fix there ...
| Feb 27, 12:05 pm 2008 |
| David Miller | Re: [BUG] 2.6.25-rc3 hangs in early boot on Sun Ultra5
From: Mikael Pettersson <mikpe@it.uu.se>
Thank you for testing.
--
| Feb 27, 12:37 pm 2008 |
| Jiri Kosina | Re: new regression in 2.6.25-rc3: no keyboard/lid acpi e ...
Thanks for bisecting this.
Please, don't forget to CC the author of the commit, whenever you finish
your bisection (this time it is Ingo). Added to CC.
--
Jiri Kosina
SUSE Labs
--
| Feb 27, 4:20 pm 2008 |
| Klaus S. Madsen | Re: new regression in 2.6.25-rc3: no keyboard/lid acpi e ...
Unfortunately this does not remove the segfault. I got a proper
bisection result (82bc03fc158e28c90d7ed9919410776039cb4e14: x86: add PWT
to NOCACHE flags), which I've reported in a new thread, as it really
doesn't have anything to do with the original subject anymore. The
subject of the new thread is:
Regression in 2.6.25-rc3: s2ram segfaults before suspending
--
Kind regards
Klaus S. Madsen
--
| Feb 27, 3:13 pm 2008 |
| Theodore Tso | Re: REGRESSION: X61s suspend/resume broken sometime betw ...
Yes, that was it, thanks!!
- Ted
--
| Feb 27, 4:38 pm 2008 |
| Krzysztof Halasa | Re: [PATCH] 2.6.25-rc2-mm1 - fix mcount GPL bogosity.
Even if it's proven wrong in the end, the defendant may at least be
The GPL itself is the weapon, not the technical measures which can be
Not sure what do you mean. I was under impression that a copyright
holder can enforce GPL :-)
--
Krzysztof Halasa
--
| Feb 26, 5:05 pm 2008 |
| Alan Cox | Re: [PATCH] 2.6.25-rc2-mm1 - fix mcount GPL bogosity.
Nope.
Please stop pedalling complete fiction
--
| Feb 27, 3:31 am 2008 |
| David Schwartz | RE: [PATCH] 2.6.25-rc2-mm1 - fix mcount GPL bogosity.
If they were in fact acting in good faith, they should be found to have been
acting in good faith. If you think this reasonably might result in
I mean you can't enforce or implement the license in code because the GPL
specifically permits modification without exclusion. Someone cannot use the
GPL to force you to use code you do not wish to use. The GPL does not
contain any technical enforcement mechanism and would not permit one because
it would be a "further restriction" (it's a ...
| Feb 26, 5:28 pm 2008 |
| Krzysztof Halasa | Re: [PATCH] 2.6.25-rc2-mm1 - fix mcount GPL bogosity.
Right. Must have been somewhere else.
--
Krzysztof Halasa
--
| Feb 27, 3:55 am 2008 |
| Ingo Molnar | Re: 2.6.25-rc2-mm1 - boot hangs on ia64
yeah, please. If it's caused by sched-devel.git then you should see the
hang there too.
Ingo
--
| Feb 27, 12:11 am 2008 |
| KOSAKI Motohiro | Re: 2.6.25-rc2-mm1 - boot hangs on ia64
How do I know revision of git-sched.patch of 2.6.25-rc2-mm1?
rc2-mm1 + that patch doesn't boot too.
stop at the same point ;)
--
| Feb 26, 6:42 pm 2008 |
| Alan Stern | Re: [linux-pm] Fundamental flaw in system suspend, expos ...
Actually the move is done before the method is called. So this isn't a
problem.
All right, if it doesn't happen now then we don't need to allow for it.
That makes life a little simpler.
Alan Stern
--
| Feb 27, 1:15 pm 2008 |
| Rafael J. Wysocki | Re: [linux-pm] Fundamental flaw in system suspend, expos ...
I'm not sure. The core moves the device to dpm_active only after ->resume()
has run. Thus, if ->resume() registers new children, the ordering of
I'm not sure if we need to do it. It's always been like this, so the current
drivers' ->suspend() and ->resume() don't unregister the device they're called
Yes, it does.
Thanks,
Rafael
--
| Feb 27, 12:50 pm 2008 |
| Alan Stern | Re: [linux-pm] Fundamental flaw in system suspend, expos ...
The name refers to the "suspend" method, not the type of sleep being
carried out. We use the same method for both suspend and hibernation.
All right, we can set it to RESUME_RUNNING before calling the resume
method and then set it to 0 afterwards. The point is that the value
shouldn't remain SUSPEND_DONE while resume runs, because it should be
It will get noticed in device_pm_add() while holding dpm_list_mtx.
The information can be stored in a static private flag
Sure. But it won't ...
| Feb 27, 9:03 am 2008 |
| Benjamin Herrenschmidt | Re: Fundamental flaw in system suspend, exposed by freez ...
.../...
Yup, old problem, I think I've said a long time ago that it's the
reponsibility of bus drivers (such as USB khub) to stop issuing device
additions when suspend is in progress. It might be possible to still do
No, I think the global notifier is plenty for now. Later on, we can
re-add early-suspend, late-resume, or we can finally turn the whole
thing into a recursive call tree where the parents are the ones calling
the children suspend :-) But for now, I think the global notifier ...
| Feb 27, 1:36 pm 2008 |
| Lee Schermerhorn | Re: [patch 5/6] mempolicy: add MPOL_F_RELATIVE_NODES flag
Nice work. Would you consider adding this [with the corrections you
note below] to the memory policy doc under the "interaction with
Just a note here: If you had used the same set of "rebind targets" for
_BIND as you did for _INTERLEAVE, I would expect the same results,
Thoughts:
1) this IS a change in behavior, right? My first inclination is to shy
away from this. However, ...
2) the current interaction of mempolicies with cpusets is not well
documented--until Paul's cpuset.4 man ...
| Feb 27, 8:37 am 2008 |
| Paul Jackson | Re: [patch 5/6] mempolicy: add MPOL_F_RELATIVE_NODES flag
Nice presentation ... thanks.
I agree with your patch to fix the MPOL_PREFERRED | MPOL_F_RELATIVE_NODES case.
--
I won't rest till it's the best ...
Programmer, Linux Scalability
Paul Jackson <pj@sgi.com> 1.940.382.4214
--
| Feb 26, 7:30 pm 2008 |
| David Rientjes | Re: [patch 5/6] mempolicy: add MPOL_F_RELATIVE_NODES flag
I'll fold the following patch into my next posting that corrects this
error as follows:
MPOL_PREFERRED | MPOL_F_RELATIVE_NODES
--------------------------------------
mems nodemask result rebind result
1-3 0 1 0 0
1-3 2 3 4-7 6
1-3 5 3 0-7 5
---
mm/mempolicy.c | 3 +--
1 files changed, 1 insertions(+), 2 deletions(-)
diff --git a/mm/mempolicy.c b/mm/mempolicy.c
--- a/mm/mempolicy.c
+++ b/mm/mempolicy.c
@@ -1809,8 +1809,7 @@ static void ...
| Feb 26, 6:31 pm 2008 |
| David Rientjes | Re: [patch 1/6] mempolicy: convert MPOL constants to enum
It was already a 16-bit value, that is unchanged, so no space savings is
intended.
It is not possible to use the enum here because an additional unsigned
short member to hold the mode flags is added to this struct later. The
increase in size of an int compared to an unsigned short would make the
entire struct bigger; the alignment requirement of the union no longer
prevents that. After this patchset, it is 24 bytes in size while using
unsigned short compared to 32 bytes while using ...
| Feb 27, 12:59 pm 2008 |
| David Rientjes | Re: [patch 5/6] mempolicy: add MPOL_F_RELATIVE_NODES flag
Here's some examples of the functional changes between the default
actions of the various mempolicy modes and the new behavior with
MPOL_F_STATIC_NODES or MPOL_F_RELATIVE_NODES.
To read this, the logical order follows from the left-most column to the
right-most:
- "mems" is the task's mems_allowed as constrained by its attached
cpuset,
- "nodemask" is the mask passed with the set_mempolicy() or mbind() call
for that particular policy,
- the first "result" is the nodemask ...
| Feb 26, 6:17 pm 2008 |
| Christoph Lameter | Re: [patch 1/6] mempolicy: convert MPOL constants to enum
The point here is to have a 16 bit value? There are no space savins due to
the alignment requirement of the union. Isnt it possible to use the enum
here? If not then what is the point of the enum?
--
| Feb 27, 12:35 pm 2008 |
| Paul Jackson | Re: [patch 5/6] mempolicy: add MPOL_F_RELATIVE_NODES flag
We should strive to minimize change in existing behaviour, especially
on points where either way could be arguably a reasonable choice in
some situations, and neither way is a clearly inescapable bug in other
situations.
One almost always breaks someone, somewhere with such changes. You
need a compelling reason to do that, not just a "on this hand, on that
hand" design choice.
--
I won't rest till it's the best ...
Programmer, Linux Scalability
...
| Feb 27, 10:09 am 2008 |
| Serge E. Hallyn | Re: [RFC, PATCH 1/2] sched: change the fairness model of ...
Cool, this is precisely what I'd expect and was hoping to see.
thanks,
--
| Feb 27, 1:23 pm 2008 |
| Adrian Bunk | Re: [PATCH] Add rdc321x defconfig file
Sounds like the academic masturbation of trying to find an optimal
solution to a non-existing problem instead of fixing real issues.
The fact that most testers have a PC plus Toralfs randconfigs has
already catched virtually all compile issues visible on a PC in the
past during -rc.
If you want to attack real problems then write a script that sends the
names of all people who signed-off patches touching include/linux/ or
include/asm-generic/ without having tested the compilation of at ...
| Feb 26, 11:49 pm 2008 |
| Sam Ravnborg | Re: [PATCH] Add rdc321x defconfig file
If I get into kconfig hacking again I will try to look into fixing
kconfig so we can have all Kconfig files in one hirachy.
This would gives us useful information such as dependencies on
unknow symbols and the like.
Statistics as you describe could be relevant to find bad
Kconfig design but I see this much more as a check thing
for bad design than something to make it easier to reach
more configs with 100 randconfigs.
Anyway - this is just vapourware until someone starts
to hack on ...
| Feb 27, 11:31 am 2008 |
| Lennart Sorensen | Re: Dell OptiPlex 320 - Core 2 Duo
Multi processor requires acpi, so your acpi=off will disable all but the
first CPU.
Is the system really so broken that you have to tell the kernel to
disable everything?
--
Len Sorensen
--
| Feb 27, 7:32 am 2008 |
| Xavier Bestel | Re: Dell OptiPlex 320 - Core 2 Duo
On Wed, 2008-02-27 at 11:54 +0000, Nuno Tavares wrote:
FYI, DELL often changes its hardware for the same model number.
Xav
--
| Feb 27, 6:09 am 2008 |
| Nuno Tavares | Dell OptiPlex 320 - Core 2 Duo
Greetings to all,
I recently stumbled across a Dell OptiPlex 320 which brings a nasty
assembly of hardware. Besides the many issues reported (system/bios time
de-sync, SATA controller detection, etc), this particular model doesn't
seem to correctly recognize the CPU, which I'm not even sure what it is
(I haven't seen anyone else complaining about it). As far as I could
investigate, it looks like a weird P4 1.8Ghz, dual core.
However, /proc/cpuinfo only reports 1 processor, 1.8Ghz. I'm saying ...
| Feb 27, 4:54 am 2008 |
| Marcel Holtmann | Re: [Bluez-devel] forcing SCO connection patch
using HCI_OP_SETUP_SYNC_CONN doesn't mean eSCO. It is perfectly fine
to request SCO links via that command. The difference here is
Inside the kernel it is not called BlueZ :) It simply is the Bluetooth
subsystem and in case the HCI core.
Regards
Marcel
--
| Feb 27, 8:21 am 2008 |
| Louis JANG | Re: [Bluez-devel] forcing SCO connection patch
Marcel Holtmann
| Feb 27, 5:21 am 2008 |
| Marcel Holtmann | Re: [Bluez-devel] forcing SCO connection patch
so the patch is fine, but the description of what this patch is doing,
why it is doing it this way and what it fixes is fully missing. Please
update it with a proper description.
Regards
Marcel
--
| Feb 27, 2:57 am 2008 |
| Louis JANG | Re: [Bluez-devel] forcing SCO connection patch
Marcel Holtmann
| Feb 26, 6:58 pm 2008 |
| Haavard Skinnemoen | Re: 2.6.25-rc3: Reported regressions from 2.6.24
On Mon, 25 Feb 2008 02:41:40 +0100
Actually, that patch doesn't fix the real problem -- it only makes the
Oops output a bit more sensible.
Ben, did you manage to reproduce it with that patch applied?
Haavard
--
| Feb 27, 8:50 am 2008 |
| Christoph Lameter | Re: [2.6 patch] mm/allocpercpu.c: make 4 functions static
Acked-by: Christoph Lameter <clameter@sgi.com>
--
| Feb 27, 12:17 pm 2008 |
| Grant Likely | Re: [PATCH] [POWERPC] [v2] Xilinx: hwicap: cleanup
On Sun, Feb 24, 2008 at 4:34 PM, Stephen Neuendorffer
Acked-by: Grant Likely <grant.likely@secretlab.ca>
Josh, can you please pick this up?
Thanks,
g.
--
Grant Likely, B.Sc., P.Eng.
Secret Lab Technologies Ltd.
--
| Feb 27, 11:20 am 2008 |
| Ingo Molnar | Re: Linux 2.6.25-rc3
the commits are upstream already:
commit 1ce70c4fac3c3954bd48c035f448793867592bc0
commit db342d216ba9e060d8c5501eefc1d0a789c9e711
commit cbc34973709eb41b369c304c075cf2069f847012
so they should be in the latest git snapshots.
Ingo
--
| Feb 27, 9:16 am 2008 |
| Kyle McMartin | Re: Linux 2.6.25-rc3
Ah, davej has already updated to -git1. Excellent.
Thanks!
Kyle
--
| Feb 27, 9:39 am 2008 |
| Kyle McMartin | Re: Linux 2.6.25-rc3
great. I really just added it to fix Fedora's configs. I'll drop it from
there once it hits -git snapshots.
cheers, Kyle
--
| Feb 27, 9:12 am 2008 |
| Alexander van Heukelum | Re: [PATCH] reserve_early end-of-conventional-memory to ...
Hi Andi,
Can you provide the complete 'raw' e820 info? This is at least
not complete, and also might be after the sanitation. Do you
mean that (1) there is usable RAM somewhere between 0xa0000
and 0xd2000? Or that (2) this second line should be RAM, not
reserved?
Case (1) would surpise me, because I expect the VGA adapter
(which I assume is there...) to occupy 0xa0000 to 0xc0000 for
the framebuffer. Also, your case would be a lot stronger if
there were a line that explicitly indicated ...
| Feb 27, 1:01 pm 2008 |
| H. Peter Anvin | Re: [PATCH] reserve_early end-of-conventional-memory to ...
It doesn't waste any memory at all.
It arguably wastes some *address space*, but that's an entirely
different thing.
Unless you have chipset-specific drivers to enable memory in the
640-1024K memory area, there is nothing there.
-hpa
--
| Feb 27, 9:44 am 2008 |
| Andi Kleen | Re: [PATCH] reserve_early end-of-conventional-memory to 1MB
So you've basically wasted a lot of memory with no concrete breakage
known ...Please reconsider.
-Andi
--
| Feb 27, 7:26 am 2008 |
| Andi Kleen | Re: [PATCH] reserve_early end-of-conventional-memory to ...
Just to give some perspective of this:
On my laptop here
BIOS-e820: 000000000009dc00 - 00000000000a0000 (reserved)
BIOS-e820: 00000000000d2000 - 0000000000100000 (reserved)
This means it reserves only ~193KB in the 640k-1MB area
With this patch it will reserve 384KB instead. This means 191KB
are lost. While that doesn't sound too much it worth as much as
382 patches that reduce kernel code size by 512bytes or
worth 3820 patches that reduce kernel code by 100 bytes in terms
of memory ...
| Feb 27, 7:38 am 2008 |
| Andi Kleen | Re: [PATCH] Fix alignment of early reservation for EBDA
It's not needed, the e820 maps are always correct for modern systems in
The i386 kernel did this always, but I intentionally removed it from the
64bit kernel because all the modern BIOS seem to correctly report holes
in this area. Only didn't do it on i386 because there were some concerns
of very old systems not doing this correctly.
My suspicion is that modern Windows systems rely on this, that is why
BIOSes typically get it correct now.
I think it should be only undone if you have a ...
| Feb 27, 7:25 am 2008 |
| Pekka Paalanen | Re: [RFC] mmiotrace full patch, preview 1
On Tue, 26 Feb 2008 10:20:08 -0700
The last thing in kmmio.c is:
static int kmmio_die_notifier(struct notifier_block *nb, unsigned long val,
void *args)
{
struct die_args *arg = args;
if (val == DIE_DEBUG)
if (post_kmmio_handler(arg->err, arg->regs) == 1)
return NOTIFY_STOP;
return NOTIFY_DONE;
}
so post_kmmio_handler() is not the die_notifier callback, and the handler
is limited to debug calls, which I assume can only come from
single-stepping. The variable ...
| Feb 27, 1:28 pm 2008 |
| serge | Re: Fw: [PATCH 1/1] file capabilities: simplify signal check
Oh, sorry, I got lost in the set of patches in the message. To be
clear, my little 4-patch uid-ns-signal patchset can simply be updated
to make the cap_task_kill() uid check into if (task_user_equiv(current, p)
But Eric if you simply drop cap_task_kill() (don't make it return 0,
just drop the function and go back to not setting task_kill in the
capability_security_ops) I'll ack that. Else I'll write the patch
thursday. At this point the only thing that will be denied by
cap_task_kill() but ...
| Feb 26, 9:33 pm 2008 |
| serge | Re: Fw: [PATCH 1/1] file capabilities: simplify signal check
... and owned by the same uid, since the case of owned by a different
Yes, although it might be a good idea to be stricter when
issecure(SECURE_NOROOT), which will become meaningful when Andrew
Yes, the only difference right now is that some of the euid/uid/suid
combos aren't allowed for in cap_task_kill(). If we're not going to
be stricter with SECURE_NOROOT, then I plan to try to remove
cap_task_kill() and just apologize for the huge mess it caused.
--
| Feb 26, 9:18 pm 2008 |
| Kevin Winchester | Re: broken suspend to ram with velocity driver
I haven't done too much looking at what the tool on that site does,
but I was under the impression that I should be able to do:
echo mem > /sys/power/state
and then bring the system back up and have it work. If that is
not expected to work, then I won't bother trying it again. My
goal in all this is to help test the kernel, and provide feedback
and testing for features that are expected to work. If this is
expected to work, then I would rather provide testing for patches
to the kernel ...
| Feb 26, 5:28 pm 2008 |
| Rafael J. Wysocki | Re: broken suspend to ram with velocity driver
That depends on the hardware configuration, really. On some systems
# echo mem > /sys/power/state
works out of the box, but on some of them we need to run some real mode
quirks from the user space to bring the graphics card back on line. That's
what s2ram is needed for.
Now, if you manage to find the combination of s2ram options appropriate for
your system, so that it can suspend and resume successfully, it will be very
helpful if you periodically test this functionality on new kernels ...
| Feb 27, 6:06 am 2008 |
| Kevin Winchester | Re: broken suspend to ram with velocity driver
And here is the trace from the kernel with the revert and patch:
Feb 26 20:42:14 alekhine kernel: [ 278.487844] PM: Syncing filesystems ... done.
Feb 26 20:42:40 alekhine kernel: [ 278.523599] Freezing user space processes ... (elapsed 0.00 seconds) done.
Feb 26 20:42:40 alekhine kernel: [ 278.525885] Freezing remaining freezable tasks ... (elapsed 0.00 seconds) done.
Feb 26 20:42:40 alekhine kernel: [ 278.526196] ACPI: Preparing to enter system sleep state S3
Feb 26 20:42:40 alekhine ...
| Feb 26, 5:48 pm 2008 |
| Rafael J. Wysocki | Re: broken suspend to ram with velocity driver
You can try the s2ram program from suspend.sf.net
(http://suspend.sf.net/s2ram-support.html).
Thanks,
Rafael
--
| Feb 27, 5:59 am 2008 |
| Matthew Garrett | Re: broken suspend to ram with velocity driver
Not if you want video to come back on most hardware - the kernel has no
idea how to reinitialise your graphics card. s2ram and similar tools
attempt to deal with this by reprogramming it from userspace. On the
other hand, if it did work on the same hardware with earlier kernels,
then that's a bug.
--
Matthew Garrett | mjg59@srcf.ucam.org
--
| Feb 27, 6:08 am 2008 |
| Rafael J. Wysocki | Re: broken suspend to ram with velocity driver
Please try s2ram first and if that doesn't work for you, we can debug it a bit
further.
Thanks,
Rafael
--
| Feb 27, 6:00 am 2008 |
| Kevin Winchester | Re: broken suspend to ram with velocity driver
To suspend to ram, I do Ctrl-Alt-1 to switch from the GDM login screen to
the console, and then:
/etc/init.d/gdm stop
echo mem > /sys/power/state
I have also tried it from X in the past (using the Ubuntu quit menu option),
with just about the same result, as I recall. This time I figured I would
try to make it easier for the suspend code and try it from the console.
Should I have been doing something else?
--
Kevin Winchester
--
| Feb 26, 5:36 pm 2008 |
| Pavel Machek | Re: boot_delay broken ?
If nohz=off highres=off notsc fixes it, it is probably timers :-).
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
--
| Feb 27, 2:19 am 2008 |
| Dave Young | Re: boot_delay broken ?
I think it's enough now.
I tested boot_delay yestoday, and found the result is different with
before version.
Even with lpj preset the delay is very slow, 5-10 seconds for every printk.
Maybe this is what davej said.
--
| Feb 26, 7:01 pm 2008 |
| Paul Menage | Re: [PATCH 05/10] CGroup API files: Update cpusets to us ...
Thanks, I'll zap that.
Paul
--
| Feb 26, 6:09 pm 2008 |
| Li Zefan | Re: [PATCH 05/10] CGroup API files: Update cpusets to us ...
redundant 'break'
--
| Feb 26, 5:54 pm 2008 |
| Paul Menage | Re: [PATCH 00/10] CGroup API files: Various cleanup to C ...
Sounds like a good plan - I'll get on to it ...
Paul
--
| Feb 26, 6:09 pm 2008 |
| John W. Linville | Re: [PATCH] Fix the bcm43xx driver breakage in 2.6.24/25.
I can't say I really like Alexey's patches, but I guess they are OK.
I think I like the "b43_pci_bridge as a module" option a little better,
but as Michael illustrated there are problems with that approach too.
I'll apply the patches.
John
--
John W. Linville
linville@tuxdriver.com
--
| Feb 27, 1:15 pm 2008 |
| Michael Buesch | Re: [PATCH] Fix the bcm43xx driver breakage in 2.6.24/25.
Well, I do like "b43_pci_bridge as a module" more than this inter-dependency
crap. Yeah, I don't like "b43_pci_bridge as a module" a lot, but certainly
more than Alexey's patch.
--
Greetings Michael.
--
| Feb 27, 2:58 pm 2008 |
| nickcheng | RE: arcmsr & areca-1660 - strange behaviour under heavy load
Hi Nikola,
Please put support@areca.com.tw in the loop.
I am sure Areca support, Kevin, has taken over your case.
If you like, please let him know your configuration and operations to
synchronize both sides.
Thank you for your patience and sorry for your inconvenience,
-----Original Message-----
From: Zan Lynx [mailto:zlynx@acm.org]
Sent: Wednesday, February 27, 2008 5:04 AM
To: Nikola Ciprich
Cc: Andrew Morton; linux-kernel@vger.kernel.org; linux-scsi@vger.kernel.org;
Nick Cheng; Erich ...
| Feb 26, 6:53 pm 2008 |
| Max Krasnyanskiy | Re: [RFC] Genirq and CPU isolation
Thomas,
Any chance I can get your feed back on this ?
Max
--
| Feb 27, 1:41 pm 2008 |
| Andrew Morton | Re: [patch 2.6.25-rc2-git] gpio: <linux/gpio.h> and "no ...
On Fri, 22 Feb 2008 17:12:17 -0800
For what reason?
--
| Feb 27, 4:48 pm 2008 |
| Andrew Morton | Re: [PATCH] Prevent the loop in timespec_add_ns() to be ...
On Fri, 22 Feb 2008 22:40:45 +0100
It's pretty sad that we need to turn this into a loop just because of the
__udivdi3() thing.
otoh, it's rarely occurring, and it could be that the number of times it
loops is usually 1 (if it wasn't zero), so perhaps a loop is faster than a
divide anyway.
This code is probably too large to be inlined.
I queued this patch as needed-in-2.6.25, to-be-merged-via-Thomas.
--
| Feb 27, 4:43 pm 2008 |
| Andrew Morton | Re: [PATCH] char: fix sparse shadowed variable warnings ...
On Fri, 22 Feb 2008 10:14:15 -0800
Unrelated to your change, but...
We prefer min_t over casts like this (not sure why, but let's be consistent)
The reason for this cast is that all this code is using `int' for the
transfer count (arguably wrong - should use size_t, but that propagates all
the way to tty_operations.write) but cyclades has
#define SERIAL_XMIT_SIZE (min(PAGE_SIZE, 4096))
which is unsigned on most architectures.
A possibly-sane fix for all of this is to use min_t ...
| Feb 27, 4:34 pm 2008 |
| Harvey Harrison | Re: [PATCH] char: fix sparse shadowed variable warnings ...
I'll trace this through and get you a patch.
Harvey
--
| Feb 27, 4:40 pm 2008 |
| Andrew Morton | Re: [PATCH] char: fix sparse variable shadowing and int ...
On Wed, 27 Feb 2008 15:38:07 -0800
Fix sparse, I'd say. Probably hard to do, but that warning really
isn't useful.
--
| Feb 27, 4:58 pm 2008 |
| Andrew Morton | Re: [PATCH] char: fix sparse variable shadowing and int ...
On Fri, 22 Feb 2008 09:46:59 -0800
Please try to make the patch titles big-endian. This one could have been
char: rocket.c: fix sparse variable shadowing and int as NULL pointer
or even
Apart from things like that.
Probably this code is cleaner than the old version so let's do it, but it
seems that we need a general fix.
--
| Feb 27, 4:29 pm 2008 |
| Harvey Harrison | Re: [PATCH] char: fix sparse variable shadowing and int ...
Well, we can at least get rid of the warnings when min/max are nested.
I sent you a patch earlier today that uses different temp variables in
min/max/min_t/max_t to avoid this. min/min and max/max nesting will
always see this. I also introduced clamp()/clamp_t() in that patch
min3()? No _good_ ideas I'm afraid.
Cheers,
Harvey
--
| Feb 27, 4:38 pm 2008 |
| Alexey Zaytsev | Re: bcm43xx regression in 2.6.24 (with patch)
On Wed, Feb 27, 2008 at 1:47 AM, John W. Linville
Is there any reason the ssb driver should claim the bcm43xx pci ids in
the first place? I have very little understanding what the Sonic Silicon
Backplane really is, but I see that the b44 driver claims its PCI ids
directly. I also think I understand why the b43/b43legacy drivers can't
claim the ids directly: because the driver-device matching is done not
with the pci bus methods, but with the ssb bus methods, and it would
be impossible to ...
| Feb 26, 5:23 pm 2008 |
| Michael Buesch | Re: bcm43xx regression in 2.6.24 (with patch)
There are several reasons to not do a seperate module.
First one being: People won't load it and complain about a regression.
Yeah, stupid stuff like that happens all the time. That's the reason we
SELECT the ssb code instead of using DEPENDS ON. People will otherwise not
enable it and report regressions.
And please don't say this won't happen. It _did_ happen when b44-PCI was
a seperate kconfig option. People reported regressions, although there were none.
Second one being: It's overkill ...
| Feb 26, 5:43 pm 2008 |
| Alexey Zaytsev | Re: bcm43xx regression in 2.6.24 (with patch)
I mean, not to make it a separate config option, of course it should
be hidden and
autoselected, but a separate module with maybe a symbol both b43/b43legacy
If compiled statically, which I think is the right thing for embedded systems,
it should not take much additional space when separated from the ssb code.
--
| Feb 26, 5:53 pm 2008 |
| Michael Buesch | Re: bcm43xx regression in 2.6.24 (with patch)
See the comment in b43_pci_bridge.c
--
Greetings Michael.
--
| Feb 26, 5:27 pm 2008 |
| Alexey Zaytsev | Feb 26, 5:32 pm 2008 | |
| Serge E. Hallyn | Re: [PATCH 2.6.25-rc2 3/9] Kconfig: Improve init/Kconfig ...
Thanks, Nick.
Acked-by: Serge Hallyn <serue@us.ibm.com>
--
| Feb 27, 4:08 pm 2008 |
| Nick Andrew | [PATCH 2.6.25-rc2 3/9] Kconfig: Improve init/Kconfig hel ...
Modify the help descriptions of init/Kconfig for clarity, accuracy and consistency.
Kernel config options affected:
- NAMESPACES
- UTS_NS
- IPC_NS
- USER_NS
- PID_NS
Add a brief description of what namespaces are and when you would
want to use them.
For the *_NS options, add a tiny bit of detail about what it is,
and ensure each config option has an answer hint: Y for namespaces
"if you will be using a container system", Y for the *_NS options
except for the two labeled ...
| Feb 27, 4:00 pm 2008 |
| Christoph Lameter | Re: [PATCH] alloc_percpu() fails to allocate percpu data
Any decision made on what to do about this one? Mike or I can
repost the per cpu allocator against mm? The fix by Eric could be used
in the interim for 2.6.24?
--
| Feb 27, 12:59 pm 2008 |
| Christoph Lameter | Re: [PATCH] alloc_percpu() fails to allocate percpu data
Well I tried it when slub went first in and it did not go well. The issue
is that x86 detects the cache line size on bootup. Thus cache_line_size().
Most of the other arch have compile time cache line sizes. Thus
L1_CACHE_BYTES. So L1_CACHE_BYTES is the maximum value that
cache_line_size() can take.
What I was attempting to do is to make x86 have one compile time cache
line size L1_CACHE_BYTES. That raised objections because space was wasted.
--
| Feb 27, 2:56 pm 2008 |
| Christoph Lameter | Re: [PATCH] alloc_percpu() fails to allocate percpu data
SLAB_HWCACHE_ALIGN *is* effectively a maybe align flag given the above
code.
If we all agree then we could change this to have must have semantics? It
has the potential of enlarging objects for small caches.
SLAB_HWCACHE_ALIGN has an effect that varies according to the alignment
requirements of the architecture that the kernel is build on. We may be in
for some surprises if we change this.
--
| Feb 27, 12:44 pm 2008 |
| Andrew Morton | Re: [PATCH] alloc_percpu() fails to allocate percpu data
On Wed, 27 Feb 2008 11:59:32 -0800 (PST)
I suppose I'll merge Eric's patch when I've tested it fully (well, as fully
as I test stuff).
It'd be nice to get that cache_line_size()/L1_CACHE_BYTES/L1_CACHE_ALIGN()
mess sorted out. If it's a mess - I _think_ it is?
--
| Feb 27, 1:24 pm 2008 |
| Christoph Lameter | Re: [PATCH] MM: Fix macro argument substitution in PageH ...
Acked-by: Christoph Lameter <clameter@sgi.com>
--
| Feb 27, 4:10 pm 2008 |
| Roman Zippel | Re: Kconfig configuration restore bug [Was: x86: vSMP se ...
Hi,
The basic problem is that this is a recursive dependency - PCI depends on
the choice and the choice depends on PCI. IMO X86_VSMP cannot depend on
PCI.
I'm looking into why this hasn't been picked up by the dependency check...
bye, Roman
--
| Feb 26, 7:59 pm 2008 |
| Mike Galbraith | Re: regression: CD burning (k3b) went broke
Bugger, went splat... forgot preformat for patchlet insert. <quiltuple
checks>
Fix CD burning regression introduced by
6b00769fe1502b4ad97bb327ef7ac971b208bfb5. raw_data_len must be updated
to reflect residual data upon IO completion because it is used by
blk_complete_sghdr_rq() to set hdr->resid which eventually becomes
visible to userland.
Signed-off-by: Mike Galbraith <efault@gmx.de>
diff --git a/drivers/scsi/scsi_lib.c b/drivers/scsi/scsi_lib.c
index ba21d97..7a6f784 ...
| Feb 27, 12:07 am 2008 |
| Mike Galbraith | Re: regression: CD burning (k3b) went broke
Yeah, blk_complete_sghdr_rq() used to do hdr->resid = irq->data_len,
which is modified down lower. How/where that hdr->resid percolates back
up, and turns into a retry/nogo, I don't know.
-Mike
--
| Feb 26, 7:58 pm 2008 |
| Jeff Garzik | Re: regression: CD burning (k3b) went broke
I would love to get an answer as to what data_len (and of course
raw_data_len) should be set to AFTER the command completes, which is
what is going on here.
I can see the above being correct -- scsi_get_resid() returns the length
of the left-over data after the command is processed -- but I am mainly
curious why setting [raw_]data_len matters after I/O completion.
Jeff
--
| Feb 26, 5:46 pm 2008 |
| Mike Galbraith | Re: regression: CD burning (k3b) went broke
Yeah, it fixes the problem. (wrt recap, if I could write it, it would
be a changelog;)
-Mike
--
| Feb 26, 7:24 pm 2008 |
| Mike Galbraith | Re: regression: CD burning (k3b) went broke
Hm. After rummaging around some more in both kernel and userland, I
think this patchlet is not only functional, but (random accident)
technically correct. What the heck, let's see if it flies...
snippet from userland:
/*
* Return the residual DMA count for last command.
* If this count is < 0, then a DMA overrun occured.
*/
EXPORT int
scg_getresid(scgp)
SCSI *scgp;
{
return (scgp->scmd->resid);
}
This function is used all over the place in cdrecord to determine
transfer ...
| Feb 26, 11:00 pm 2008 |
| Ilpo Järvinen | Re: WARNING: at net/ipv4/tcp_input.c:2054 tcp_mark_head_lost()
Are you able to reproduce this in any way? I did in the past a debug patch
that verifies TCP's write queue state by the hard way, ie., by bruteforce
walking often enough to catch inconsistencies early enough to find out
the root cause. I'll try to find that for you after I first go through
the 2.6.24.2's code once again (but I'm pretty busy at this moment, so
Usually it's very insignificant to see them, unless you have them in very
large quantities (it usually triggers for the same ...
| Feb 27, 2:29 am 2008 |
| Guillaume Chazarain | Re: WARNING: at net/ipv4/tcp_input.c:2054 tcp_mark_head_lost()
SGkgSWxwbywKCk9uIFdlZCwgRmViIDI3LCAyMDA4IGF0IDEwOjI5IEFNLCBJbHBvIErDpHJ2aW5l
bgo8aWxwby5qYXJ2aW5lbkBoZWxzaW5raS5maT4gd3JvdGU6Cj4gSSBkaWQgaW4gdGhlIHBhc3Qg
YSBkZWJ1ZyBwYXRjaAo+ICB0aGF0IHZlcmlmaWVzIFRDUCdzIHdyaXRlIHF1ZXVlIHN0YXRlIGJ5
IHRoZSBoYXJkIHdheSwgaWUuLCBieSBicnV0ZWZvcmNlCj4gIHdhbGtpbmcgb2Z0ZW4gZW5vdWdo
IHRvIGNhdGNoIGluY29uc2lzdGVuY2llcyBlYXJseSBlbm91Z2ggdG8gZmluZCBvdXQKPiAgdGhl
IHJvb3QgY2F1c2UuCgpBcmUgeW91IHRhbGtpbmcgYWJvdXQgdGhpcyBvbmU6Cmh0dHA6Ly9tYXJj
LmluZm8vP2w9bGludXgtbmV0ZGV2Jm09MTE5NDgy ...
| Feb 27, 11:56 am 2008 |
| Ilpo Järvinen | Re: WARNING: at net/ipv4/tcp_input.c:2054 tcp_mark_head_lost()
On Wed, 27 Feb 2008, Guillaume Chazarain wrote:
> On Wed, Feb 27, 2008 at 10:29 AM, Ilpo J
| Feb 27, 12:29 pm 2008 |
| Stefan Richter | Re: [PATCH 1/2] firewire: endianess fix
Could you remove the OHCI1394_HCControl_postedWriteEnable flag from
fw-ohci.c::ohci_enable() and test without and with the endianess patch?
--
Stefan Richter
-=====-==--- --=- ==-==
http://arcgraph.de/sr/
--
| Feb 27, 1:08 pm 2008 |
| Jarod Wilson | Re: [PATCH 1/2] firewire: endianess fix
Works just fine with the Apple UniNorth controller in my powerbook in cursory
testing. Tested with multiple sbp2 hard disks, plugging and unplugging,
Forgot to check that it survived bus resets. Will try to double-check that
tonight. I don't have any other ppc systems w/firewire controllers handy at
the moment to try other controllers, but can probably manage to get one set
up soon...
--
Jarod Wilson
jwilson@redhat.com
--
| Feb 27, 12:58 pm 2008 |
| Jarod Wilson | Re: [PATCH 1/2] firewire: endianess fix
Sure, added to the todo list along with making sure things survive bus resets.
--
Jarod Wilson
jwilson@redhat.com
--
| Feb 27, 1:21 pm 2008 |
| Dave Hansen | Re: [RFC][PATCH] make /proc/pid/pagemap work with huge p ...
I'm just worried that once we establish the format, we can't really
change it. We have enough room in the pseudo-pte now, but what happens
when the next group of people pop up that want something else from this
interface. Right now we have normal memory, swap, and hugetlb pages.
What if people want migration ptes marked next? I'm not sure those fit
into what you have here.
Is there any way to do unions of bitfields? It seems a bit silly that
we have this bitfield, and then subdivide ...
| Feb 27, 10:44 am 2008 |
| Valdis.Kletnieks | profile-likely patch (was Re: [RFC PATCH 0/8]: uninline ...
This is a multipart MIME message.
--==_Exmh_1204139192_52520
Content-Type: text/plain; charset=us-ascii
I think it exploded again, for some other reason...
I just gave it a try just for grins-n-giggles. The resulting kernel got loaded
by grub, the screen cleared, and about 5 seconds later it rebooted. Never got
as far as putting up penguin icons. Tried again with netconsole, early_printk=vga,
and initcall_debug, and it *still* didn't live long enough to produce anything
resembling ...
| Feb 27, 12:08 pm 2008 |
| Christoph Lameter | Re: [2.6 patch] mm/slub.c: remove unneeded NULL check
Well we still need to check for the freelist being empty otherwise the
counter for remote frees does not work as intended. The check was
introduced at the time when page->end did not yet exist. At that time the
NULL check made sense.
From: Christoph Lameter <clameter@sgi.com>
Subject: Fix check for remote frees
The check for remote frees must check is_end() instead of != NULL.
We execute the !is_end() section rarely so move the check in there. Just do it
once by relying on tail ...
| Feb 27, 12:55 pm 2008 |
| Anton Blanchard | Re: [PATCH] x86: add the debugfs interface for the syspr ...
I dream of being a card carrying member of the club but apparently
Or their own profiling infrastructure!
OK I'm done being a pain, time to be constructive. It's becoming clear
we have some work to do in order to make oprofile easier to use. I've
been involved with the project from the early days, and it's hard to be
objective when it comes to usability issues.
Off the top of my head, there are a number of reasons I think it makes
sense to use the existing oprofile kernel code instead ...
| Feb 27, 7:05 am 2008 |
| Christoph Lameter | Re: [patch] my mmu notifiers
Correct. If you find such places then we can avoid the invalidates there.
--
| Feb 27, 3:56 pm 2008 |
| Christoph Lameter | Re: [PATCH] mmu notifiers #v7
Ok so it somehow works slowly with GRU and you are happy with it. What
Would it not be better to have a solution that fits all instead of hacking
something in now and then having to modify it later?
Hmmm.. There were earlier discussions of changing the anon vma lock to a
rw lock because of contention issues in large systems. Maybe we can just
generally switch the locks taken while walking rmaps to semaphores? That
would still require to put the invalidate outside of the pte ...
| Feb 27, 4:06 pm 2008 |
| Christoph Lameter | Re: [patch] my mmu notifiers
What is so novel about introducing functionality step by step?
--
| Feb 27, 3:55 pm 2008 |
| Peter Zijlstra | Feb 27, 1:04 pm 2008 | |
| Andrea Arcangeli | Re: [kvm-devel] [PATCH] mmu notifiers #v7
As far as GRU is concerned, performance is the same as with your patch
If RDMA/IB folks needed to block in invalidate_range, I guess they
need to do so on top of tmpfs too, and that never worked with your
The whole point is that your solution fits only GRU and KVM too.
XPMEM in your patch works in a hacked mode limited to anonymous memory
only, Robin already received incoming mail asking to allow xpmem to
work on more than anonymous memory, so your solution-that-fits-all
doesn't actually ...
| Feb 27, 4:43 pm 2008 |
| Andrea Arcangeli | [PATCH] mmu notifiers #v7
Hello,
I hope this will can be considered final for .25 and be merged. Risk
is zero, the only discussion here is to make an API that will last
forever, functionality-wise all these patches provides zero risk and
zero overhead when MMU_NOTIFIER=n. This last patch covers KVM and GRU
and hopefully all other non-blocking users optimally, and the below
API will hopefully last forever (but even if it lasts just for .25 and
.26 is changed that's fine with us, it's a kernel _internal_ API
anyway, ...
| Feb 27, 12:26 pm 2008 |
| Andrea Arcangeli | [PATCH] KVM swapping with mmu notifiers #v7
Same as before but one one hand ported to #v7 API and on the other
hand ported to latest kvm.git.
Signed-off-by: Andrea Arcangeli <andrea@qumranet.com>
diff --git a/arch/x86/kvm/Kconfig b/arch/x86/kvm/Kconfig
index 41962e7..e1287ab 100644
--- a/arch/x86/kvm/Kconfig
+++ b/arch/x86/kvm/Kconfig
@@ -21,6 +21,7 @@ config KVM
tristate "Kernel-based Virtual Machine (KVM) support"
depends on HAVE_KVM && EXPERIMENTAL
select PREEMPT_NOTIFIERS
+ select MMU_NOTIFIER
select ANON_INODES
...
| Feb 27, 3:06 pm 2008 |
| Christoph Lameter | Re: [patch] my mmu notifiers
The skeletons shows how to do most of it using a spinlock and a
counter.
--
| Feb 27, 3:50 pm 2008 |
| Cornelia Huck | Re: [PCI] duplicate sysfs symbols getting registered in ...
On Wed, 27 Feb 2008 13:33:13 +0100 (CET),
Hm, dev->kobj.parent may be NULL in cleanup_device_parent(). Does this
one help?
---
drivers/base/core.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
--- linux-2.6.orig/drivers/base/core.c
+++ linux-2.6/drivers/base/core.c
@@ -621,7 +621,8 @@ static struct kobject *get_device_parent
static void cleanup_glue_dir(struct device *dev, struct kobject *glue_dir)
{
/* see if we live in a "glue" directory */
- if (!dev->class || ...
| Feb 27, 6:21 am 2008 |
| Guennadi Liakhovetski | Re: [PCI] duplicate sysfs symbols getting registered in ...
Yes, this one does. But Greg's original idea, that disabling
CONFIG_SYSFS_DEPRECATED would eliminate one of the warnings doesn't hold,
all three of them are still there (after your patches):
kobject (c7c84700): tried to init an initialized object, something is seriously wrong.
Pid: 1, comm: swapper Not tainted 2.6.25-rc2-testpm-dirty #40
[<c01ea105>] kobject_init+0x75/0x80
[<c025093e>] device_initialize+0x1e/0x90
[<c02510bb>] device_register+0xb/0x20
[<c01f3df8>] ...
| Feb 27, 6:46 am 2008 |
| Guennadi Liakhovetski | Re: [PCI] duplicate sysfs symbols getting registered in ...
Ok, result #1: kernel panic
http://home.arcor.de/g.liakhovetski/ap400/imga0045.jpg. If necessary, can
try a serial console, but that would be more difficult.
Testing further.
Thanks
Guennadi
---
Guennadi Liakhovetski
--
| Feb 27, 4:24 am 2008 |
| Cornelia Huck | Re: [PCI] duplicate sysfs symbols getting registered in ...
On Wed, 27 Feb 2008 14:46:05 +0100 (CET),
I'm afraid I can't help there, as this looks PCI-related...
Greg: Attached are the fixes against your tree with proper description
and s-o-b.
Driver core: Fix cleanup when failing device_add().
-Don't call cleanup_device_parent() if we didn't call setup_parent().
-dev->kobj.parent may be NULL when cleanup_device_parent() is called,
so we need to handle glue_dir == NULL in cleanup_glue_dir().
Signed-off-by: Cornelia Huck ...
| Feb 27, 7:38 am 2008 |
| Cornelia Huck | Re: [PCI] duplicate sysfs symbols getting registered in ...
On Wed, 27 Feb 2008 12:24:54 +0100 (CET),
Looking at device_add(): Does the following patch make the oops go away?
---
drivers/base/core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- linux-2.6.orig/drivers/base/core.c
+++ linux-2.6/drivers/base/core.c
@@ -780,7 +780,7 @@ int device_add(struct device *dev)
dev = get_device(dev);
if (!dev || !strlen(dev->bus_id)) {
error = -EINVAL;
- goto Error;
+ goto Done;
}
pr_debug("device: '%s': %s\n", ...
| Feb 27, 4:47 am 2008 |
| Guennadi Liakhovetski | Re: [PCI] duplicate sysfs symbols getting registered in ...
No, didn't help, same 3 stack dumps, only offsets / addresses a bit
different (CONFIG_SYSFS_DEPRECATED enabled):
kobject (c7c35900): tried to init an initialized object, something is
seriously wrong.
Pid: 1, comm: swapper Not tainted 2.6.25-rc2-testpm-dirty #37
[<c01ea0c5>] kobject_init+0x75/0x80
[<c025072e>] device_initialize+0x1e/0x90
[<c0250f7b>] device_register+0xb/0x20
[<c01f3db8>] pci_bus_add_devices+0x98/0x140
[<c030add7>] ? pcibios_scan_root+0x27/0xa0
[<c03f69d0>] ...
| Feb 27, 4:39 am 2008 |
| Guennadi Liakhovetski | Re: [PCI] duplicate sysfs symbols getting registered in ...
You mean the kernel panic without CONFIG_SYSFS_DEPRECATED? No,
unfortunately is doesn't.
Thanks
---
Guennadi Liakhovetski
--
| Feb 27, 5:33 am 2008 |
| Guennadi Liakhovetski | Re: [PCI] duplicate sysfs symbols getting registered in ...
I also put the config at
http://home.arcor.de/g.liakhovetski/ap400/config-2.6.25-gregkh-0, the
panic is produced by just disabling CONFIG_SYSFS_DEPRECATED.
Thanks
Guennadi
---
Guennadi Liakhovetski
--
| Feb 27, 4:27 am 2008 |
| Tomasz Chmielewski | Re: very poor ext3 write performance on big filesystems?
A follow-up to this thread.
Using small optimizations like playing with /proc/sys/vm/* didn't help
much, increasing "commit=" ext3 mount option helped only a tiny bit.
What *did* help a lot was... disabling the internal bitmap of the RAID-5
array. "rm -rf" doesn't "pause" for several seconds any more.
If md and dm supported barriers, it would be even better I guess (I
could enable write cache with some degree of confidence).
This is "iostat sda -d 10" output without the internal ...
| Feb 27, 4:20 am 2008 |
| Tomasz Chmielewski | Re: very poor ext3 write performance on big filesystems?
Also, using anticipatory IO scheduler seems to be the best option for an
array with lots of seeks and random reads and writes (quite
surprisingly, closely followed by NOOP - both were behaving much better
than deadline or CFQ).
Here are some numbers I posted to BackupPC mailing list:
http://thread.gmane.org/gmane.comp.sysutils.backup.backuppc.general/14009
--
Tomasz Chmielewski
http://wpkg.org
--
| Feb 27, 1:25 pm 2008 |
| Andreas Dilger | Re: very poor ext3 write performance on big filesystems?
I'm CCing the linux-raid mailing list, since I suspect they will be
interested in this result.
I would suspect that the "journal guided RAID recovery" mechanism
developed by U.Wisconsin may significantly benefit this workload
because the filesystem journal is already recording all of these
block numbers and the MD bitmap mechanism is pure overhead.
Cheers, Andreas
--
Andreas Dilger
Sr. Staff Engineer, Lustre Group
Sun Microsystems of Canada, Inc.
--
| Feb 27, 1:03 pm 2008 |
| Robert Fitzsimons | Re: 2.6.25-rc[12] Video4Linux Bttv Regression
Ok, I found the cause of the oops. Some of radio tuner code was
expecting a struct bttv_fh to be allocated but this wasn't done in
radio_open. So it would dereference an invalid data structure, causing
a hang for me and an oops for Bongani. I also had to add support for
the radio tuner to some shared functions. Patches to follow.
Robert
--
| Feb 26, 6:42 pm 2008 |
| Bongani Hlope | Re: [PATCH] bttv: Re-enabling radio support requires the ...
Thanx Robert
I have applied both your patches and my radio works, but my TV doesn't work
anymore (no picture or sound). But when I exit the radio program I get this
oops:
BUG: unable to handle kernel NULL pointer dereference at 0000000000000010
IP: [<ffffffff8030cd72>] kref_get+0xc/0x29
PGD 72230067 PUD 6dbd1067 PMD 0
Oops: 0000 [1] PREEMPT SMP
CPU 1
Modules linked in: snd_seq_dummy snd_seq_oss snd_seq_midi_event snd_seq
binfmt_misc loop nls_cp437 vfat fat nls_iso8859_1 ntfs thermal ...
| Feb 27, 2:45 pm 2008 |
| Robert Fitzsimons | [PATCH] bttv: Re-enable radio tuner support for VIDIOCGF ...
Signed-off-by: Robert Fitzsimons <robfitz@273k.net>
---
drivers/media/video/bt8xx/bttv-driver.c | 5 +++--
1 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/media/video/bt8xx/bttv-driver.c b/drivers/media/video/bt8xx/bttv-driver.c
index 5404fcc..817a961 100644
--- a/drivers/media/video/bt8xx/bttv-driver.c
+++ b/drivers/media/video/bt8xx/bttv-driver.c
@@ -1990,7 +1990,7 @@ static int bttv_g_frequency(struct file *file, void *priv,
if (0 != err)
return err;
...
| Feb 26, 6:44 pm 2008 |
| Robert Fitzsimons | [PATCH] bttv: Re-enabling radio support requires the use ...
A number of the radio tuner ioctl functions are shared with the TV
tuner, these functions require a struct bttv_fh data structure to be
allocated and initialized.
Signed-off-by: Robert Fitzsimons <robfitz@273k.net>
---
drivers/media/video/bt8xx/bttv-driver.c | 21 ++++++++++++++++-----
1 files changed, 16 insertions(+), 5 deletions(-)
Mauro, the radio_open function may want to do more initialisation then
the amount I copied from bttv_open.
diff --git ...
| Feb 26, 6:47 pm 2008 |
| Mauro Carvalho Chehab | Re: [PATCH] bttv: Re-enabling radio support requires the ...
On Wed, 27 Feb 2008 01:47:29 +0000
Maybe, but the proper way would be to use just one open for both radio and
video, like cx88. This driver violates V4L2 API, since the spec says that
opening /dev/radio will select radio, by default, but it is possible to listen
video also on that interface (the opposite is valid also for /dev/video).
I'll apply the fixes, for now. The better would be if you could try to use the
same approach present on cx88.
Cheers,
Mauro
--
| Feb 27, 2:52 am 2008 |
| Adrian Bunk | [2.6 patch] unexport journal_update_superblock
cu
Adrian
<-- snip -->
This patch removes the unused EXPORT_SYMBOL(journal_update_superblock).
Signed-off-by: Adrian Bunk <bunk@kernel.org>
---
66cbc7390d66cdeb83a3f81d7ec1ea71d6f6e2c8 foobar
diff --git a/fs/jbd/journal.c b/fs/jbd/journal.c
index 3943a89..5c2ebb7 100644
--- a/fs/jbd/journal.c
+++ b/fs/jbd/journal.c
@@ -68,7 +68,6 @@ EXPORT_SYMBOL(journal_set_features);
EXPORT_SYMBOL(journal_create);
EXPORT_SYMBOL(journal_load);
...
| Feb 27, 2:20 pm 2008 |
| Adrian Bunk | Re: [2.6 patch] fs/jbd/journal.c: cleanups
Yes, I do test compilations of all of my patches.
But I don't have an overview of all development trees for all
cu
Adrian
--
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed
--
| Feb 27, 12:39 pm 2008 |
| Andrew Morton | Re: Linux 2.6.24.1 - kernel does not boot; IRQ trouble?
You reported this regression nearly a month ago and apart from me flailing
around nobody has bothered to do the slightest thing about it.
If you can identify the offending commit (see
http://www.kernel.org/doc/local/git-quick.html) we'll get it working again
and I really don't care how many commits we have to revert to do it.
--
| Feb 26, 7:52 pm 2008 |
| Chris Rankin | Re: Linux 2.6.24.1 - kernel does not boot; IRQ trouble?
I'm not sure about a complete git installation, but I should at least be able to find the last
working 2.6.23-gitX or 2.6.24-rcX-gitY tree. (Assuming that these are the intermediate steps
between 2.6.23 and 2.6.24.)
Cheers,
Chris
__________________________________________________________
Sent from Yahoo! Mail.
A Smarter Inbox. http://uk.docs.yahoo.com/nowyoucan.html
--
| Feb 27, 1:39 am 2008 |
| Chris Rankin | Re: Linux 2.6.24.1 - kernel does not boot; IRQ trouble?
It's a bug introduced in 2.6.24; that ACPI fails to allocate IRQs correctly for PCI devices, which
makes the kernel hang at boot-time:
PCI: Using ACPI for IRQ routing
PCI: If a device doesn't work, try "pci=routeirq". If it helps, post a report
BUG: NMI Watchdog detected LOCKUP on CPU0, eip c0102b07, registers:
Modules linked in:
Pid: 0, comm: swapper Not tainted (2.6.24.1 #1)
EIP: 0060:[<c0102b07>] EFLAGS: 00000246 CPU: 0
EIP is at default_idle+0x2f/0x43
EAX: 00000000 EBX: c0102ad8 ECX: ...
| Feb 26, 5:55 pm 2008 |
| Chris Clayton | Re: 2.6.25-rc2 regression in rt61pci wireless driver
Yes, that's correct. The patch doesn't apply cleanly to -rc3 and,
That would be very helpful.
--
Beauty is in the eye of the beerholder.
--
| Feb 27, 10:45 am 2008 |
| John W. Linville | Re: 2.6.25-rc2 regression in rt61pci wireless driver
And it currently isn't queued for 2.6.25 at all.
Chris, can you cherry-pick this from the wireless-2.6.26 tree and
give it a test on your 2.6.25-rc3 tree? If it resolves a problem
then I'll queue it to Dave for 2.6.25 (which will probably provoke
a net-2.6.26 and wireless-2.6.26 rebase).
Let me know...
John
--
John W. Linville
linville@tuxdriver.com
--
| Feb 27, 8:51 am 2008 |
| Stefano Brivio | Re: 2.6.25-rc2 regression in rt61pci wireless driver
On Tue, 26 Feb 2008 22:36:19 +0000
Known and fixed. The fix isn't in 2.6.25-rc3 yet, though.
Fix:
commit 32720eae675d08990e97bffbf71a31382599cc8a
Author: Stefano Brivio <stefano.brivio@polimi.it>
Date: Tue Jan 29 20:29:16 2008 +0100
rc80211-pid: fix rate adjustment
--
Ciao
Stefano
--
| Feb 27, 12:26 am 2008 |
| John W. Linville | Re: 2.6.25-rc2 regression in rt61pci wireless driver
That might be easier said than done. It looks like that patch depends
on the big cfg80211 API change queued for 2.6.26.
Stefano offered to rebase that on 2.6.25. Stefano, could you post
that as part of this thread?
Thanks,
John
--
John W. Linville
linville@tuxdriver.com
--
| Feb 27, 10:25 am 2008 |
| Patrick McHardy | Re: nf_conntrack fix smp_processor_id() in preemptible code
Already done, should hit upstream soon.
--
| Feb 27, 9:47 am 2008 |
| Tilman Schmidt | nf_conntrack fix smp_processor_id() in preemptible code ...
Bad news: With 2.6.25-rc3, that bug has made it into mainline.
Good news: Your patch fixes it there, too.
So I suggest you forward it there as soon as possible.
Thanks,
Tilman
--=20
Tilman Schmidt E-Mail: tilman@imap.cc
Bonn, Germany
Diese Nachricht besteht zu 100% aus wiederverwerteten Bits.
Unge=F6ffnet mindestens haltbar bis: (siehe R=FCckseite)
| Feb 27, 9:37 am 2008 |
| Nigel Cunningham | Re: [2.6.25-rc1] jerky mouse cursor and randoooom key repeats
Hi.
I saw it this morning with 2.6.23.14. It was find for ages, and seems to
be okay again now. Not sure what triggered it though.
nigel@laptop:/usr/src/redhat/BUILD/kernel-2.6.23/build-2.6.23.x86_64$
grep SCHED .config
CONFIG_IOSCHED_NOOP=y
CONFIG_IOSCHED_AS=y
CONFIG_IOSCHED_DEADLINE=y
CONFIG_IOSCHED_CFQ=y
CONFIG_DEFAULT_IOSCHED="cfq"
CONFIG_SCHED_SMT=y
CONFIG_SCHED_MC=y
# CONFIG_NET_SCHED is not set
CONFIG_USB_EHCI_TT_NEWSCHED=y
CONFIG_SCHED_DEBUG=y
CONFIG_SCHEDSTATS=y
(Old ...
| Feb 26, 5:08 pm 2008 |
| Christoph Lameter | Re: Linux 2.6.25-rc2
Right. The alloc fastpath assumes that the object is not modified while it
is allocated...
Du! This shoots my nice scheme in the foot and there does not seem to be
an easy way to fix it. This means we also need to revert the
page->end patch. Useless if we do not have the cmpxchg_local.
--
| Feb 27, 4:32 pm 2008 |
| Christoph Lameter | Re: Linux 2.6.25-rc2
Yes but that is only for used for statistics which can be racy. Note that
the VM event statistics also can be racy.
--
| Feb 27, 4:32 pm 2008 |
| Christoph Lameter | Re: Linux 2.6.25-rc2
Urgh.... That sounds way too complicated. Do you have an experimental
patch that would allow us to see the impact?
--
| Feb 27, 4:34 pm 2008 |
| Christoph Lameter | Re: NULL pointer in kmem_cache_alloc with 2.6.25-rc1
Yeah that would determine if its the fastpath code. Note that the new
fastpath code may expose bugs that so far have been tolerated by the slab
allocators. If a store of a NULL to the first word of an object occurs
then this will be tolerated in 2.6.24 because slub will take it as the end
of the object list and just forget about the remaining objects. The
fastpath code will terminate with a NULL pointer deref.
Enabling full debugging may get rid of the race due to the slowdown. It
could ...
| Feb 27, 3:15 pm 2008 |
| Christoph Lameter | Re: [patch 2/6] mmu_notifier: Callbacks to invalidate ad ...
Could you be specific? This refers to page migration? Hmmm... Guess we
There are 3 different drivers that can already use it but the code is
complex and not easy to review. Skeletons are easy to allow people to get
That can be done in a variety of ways:
1. Change VM locking
2. Not handle file backed mappings (XPmem could work mostly in such a
config)
3. Keep the refcount elevated until pages are freed in another execution
context.
--
| Feb 27, 3:35 pm 2008 |
| Andrea Arcangeli | Re: [patch 2/6] mmu_notifier: Callbacks to invalidate ad ...
I don't rely on the pte locking in #v7, exactly to satisfy GRU
Calls are still in atomic context until we change the i_mmap_lock to a
mutex under a CONFIG_XPMEM, or unless we boost mm_users, drop the lock
and restart the loop at every different mm. In any case those changes
should be under CONFIG_XPMEM IMHO given desktop users definitely don't
need this (regular non-blocking mmu notifiers in my patch are all what
GRU will perform the same with #v7 or V8.
--
| Feb 27, 4:57 pm 2008 |
| Christoph Lameter | Re: [patch 2/6] mmu_notifier: Callbacks to invalidate ad ...
How would that work? You rely on the pte locking. Thus calls are all in an
atomic context. I think we need a general scheme that allows sleeping when
references are invalidates. Even the GRU has performance issues when using
the KVM patch.
--
| Feb 27, 3:23 pm 2008 |
| Christoph Lameter | Re: [patch 2/6] mmu_notifier: Callbacks to invalidate ad ...
The patch has to satisfy RDMA, XPMEM, GRU and KVM. I keep hearing that we
have a KVM only solution that works 100% (which makes me just switch
ignore the rest of the argument because 100% solutions usually do not
Ok so you are now getting away from keeping the refcount elevated? That
It would have helped if you would have repeated my answers that you had
already gotten before. You knew I was on vacation....
--
| Feb 27, 3:39 pm 2008 |
| Jack Steiner | Re: [patch 2/6] mmu_notifier: Callbacks to invalidate ad ...
I posted the full GRU driver late last week. It is a lot of
code & somewhat difficult to understand w/o access to full chip
specs (sorry). The code is fairly well commented & the
parts related to TLB management should be understandable.
--
| Feb 27, 3:42 pm 2008 |
| Christoph Lameter | Re: [patch 5/6] mmu_notifier: Support for drivers with r ...
truncate is handled by the range invalidates. This is special code to deal
The situation that you are imagining has already been dealt with by the
earlier patches. This is only to allow sleeping while unmapping individual
pages.
--
| Feb 27, 3:43 pm 2008 |
| Russell King | Re: [2.6 patch] the long overdue pcmcia_ioctl.c removal
I've objected to it in the past because one of the machines I use
every week requires the ioctls to be able to work - the rootfs is on
a CF card and it uses an initrd to work out - at run time - whether
it's supposed to be running off the CF card or some other internal
memory.
Unfortunately, the project closed down, and I didn't have a chance
(nor the bandwidth) to take a copy of the CVS, which means I've *NO*
possibility to rebuild userspace - which effectively means I can't
change ...
| Feb 27, 1:44 pm 2008 |
| Adrian Bunk | Re: [2.6 patch] the long overdue pcmcia_ioctl.c removal
This removal has bells and whistles and printk() since 2005...
Dominik, what exactly is the problem why we can't remove it now?
cu
Adrian
--
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed
--
| Feb 27, 11:13 am 2008 |
| Konrad Rzeszutek | Re: [PATH] Add iSCSI iBFT support (v0.4.8)
James,
This patch has the fixes you mentioned in the earlier code review (0.4.7).
Could you take a look at this patch and see if it meets your expectations,
please?
Thanks.
--
| Feb 26, 5:55 pm 2008 |
| Kevin Coffman | Re: 2.6.24-sha1: RIP [<ffffffff802596c8>] iov_iter_advan ...
Hi Nick,
With this patch, I'm getting "bad data" errors while running the
connectathon tests from a Solaris NFS client to my Linux server. (The
failing test writes a "big" file (1MB) and reads it back, verifying
the data read back is correct.) Let me know if I can provide more
details.
K.C.
--
| Feb 27, 10:41 am 2008 |
| Christoph Lameter | Re: [ofa-general] Re: Demand paging for memory regions
That is a special case of the proposed solution. You could mlock the
regions of interest. Those can then only be migrated but not swapped out.
However, I think we need some limit on the number of pages one can mlock.
Otherwise the VM can get into a situation where reclaim is not possible
because the majority of memory is either mlocked or pinned by I/O etc.
--
| Feb 27, 3:11 pm 2008 |
| Takashi Sato | Re: [RFC] ext3 freeze feature ver 0.2
Hi,
I agree.
Because the original xfs_freeze doesn't have the timeout feature,
I think my freeze ioctl had better not do the timeout in case of
specifying 1 as ioctl's parameter.
So I have modified my freeze ioctl not to set the timeout in case of
specifying 1 or 0 as below.
(I have attached the modified patch in this mail.)
int ioctl(int fd, int FIFREEZE, long *timeval)
fd: The file descriptor of the mountpoint
FIFREEZE: The request code for the freeze
timeval: The ...
| Feb 27, 1:31 am 2008 |
| Alan Cox | Re: 2.6.24-git: kmap_atomic() WARN_ON()
Definitely - older PATA controllers are unbuffered. A PIO_0 transfer is
running at ISA speed with IRQs off. Guaranteed to give Ingo's RT a blip.
Alan
--
| Feb 26, 5:02 pm 2008 |
| akepner | Re: [PATCH 1/3 v2] dma/doc: document dma_{un}map_{single ...
Sure. I'm going to send another revision in the next day or so.
(Only comsmetic changes wrt the previous version.)
I'll cc you.
--
Arthur
--
| Feb 26, 5:07 pm 2008 |
| Benjamin Herrenschmidt | Re: [PATCH 1/3 v2] dma/doc: document dma_{un}map_{single ...
Hi !
For some reason I only got some of your patches... care to resend the
whole serie with me on CC ?
We need to add similar attributes for PowerPC to support relaxed
ordering on some mappings. We started internally adding flags to the
direction, like you initially did, but it looks like that's not the
direction the wind is blowing so ..
Cheers,
Ben.
--
| Feb 26, 5:03 pm 2008 |
| Sripathi Kodi | Re: [PATCH] RUSAGE_THREAD
Michael,
Please take a look at the following patch to getrusage.2. This is the first
time I have edited a manpage, so I hope I have done it correctly!
Also, the RUSAGE_THREAD patch is currently in -mm, but not in mainline
yet. Hoping that it will make it, I have put a line in the patch that it is
supported from 2.6.25 onwards.
Thanks,
Sripathi.
PS: I fixed spelling error in Ulrich's mail id in the CC list.
Signed-off-by: Sripathi Kodi <sripathik@in.ibm.com>
--- ...
| Feb 27, 4:41 am 2008 |
| Ingo Molnar | Re: include/linux/pcounter.h
sorry - that bit of the thread didnt seem to make it to lkml. I just saw
this incomplete discussion with a denial and with no resolution.
And you did the right thing anyway by thinking in terms of a generic
piece of infrastructure instead of hiding it away into say
include/net/pcounter.h (which nobody could have objected against).
I sometimes think that the forced isolation of subsystems (rather
strongly enforced both by -mm and by linux-next) and their hiding away
on non-lkml lists ...
| Feb 27, 12:36 am 2008 |
| Yinghai Lu | Re: 2.6.24 git2/mm1: cpu_to_node mapping to non-existant ...
x86.git#testing should be solid with numa and nodes without memory.
YH
--
| Feb 27, 10:25 am 2008 |
| Yinghai Lu | Re: 2.6.24 git2/mm1: cpu_to_node mapping to non-existant ...
did it fail with x86.git#testing?
YH
--
| Feb 26, 11:29 pm 2008 |
| Mike Travis | Re: 2.6.24 git2/mm1: cpu_to_node mapping to non-existant ...
Hi,
My problem is that I haven't been able to set up a NUMA box where some of the nodes
have no memory. The one box we have, the serial port doesn't work and it's in a lab
far, far away. Everything else, it works fine.
Mike
--
| Feb 27, 7:37 am 2008 |
| Jason Baron | Re: [patch 1/7] Immediate Values - Architecture Independ ...
yes. this is how stop_machine is implemented...and I believe is consistent with
the way in which your algorithm disables irqs. The logic to me, is we don't
want any cpus to see the kernel text in an inconsistent state via an irq.
-Jason
--
| Feb 27, 10:01 am 2008 |
| Mathieu Desnoyers | Re: [patch 1/7] Immediate Values - Architecture Independ ...
Why do we now have to declare this static ? Can we pass it as a pointer
Hrm, the semantic of STOPMACHINE_RUN is a bit weird :
- The CPU where the do_stop thread runs will first execute (alone) the
callback.
- Then, all the other CPUs will execute the callback concurrently.
Given that you use a "started" boolean in the callback, which is ok as
long as there is no concurrent modification (correct given the current
semantic, but fragile), I would tend to document that the first time ...
| Feb 27, 12:05 pm 2008 |
| Jason Baron | Re: [patch 1/7] Immediate Values - Architecture Independ ...
this patch results in the subsequent 3 way deadlock that I described in the
previous mail. smp_call_function() can not be used with a function that
attempts to rendezvous cpus in the manner being done here. The patch I posted
in the previous mail addresses these limitations on smp_call_functions(). trace
of the lockup using this patch is shown below.
thanks,
-Jason
NMI Watchdog detected LOCKUP on CPU 2
CPU 2
Modules linked in: toggle_tester ipt_MASQUERADE iptable_nat nf_nat ...
| Feb 27, 9:44 am 2008 |
| Bjorn Helgaas | Re: a7839e96 (PNP: increase max resources) breaks my ALS ...
I guess it's time to get back to this problem.
I don't want to make PNP insert resources only at the root. That
would avoid the ALSA problem because the enclosing PCI resource is
allocated first, but it also precludes us from dealing with lots of
valid ACPI information. ACPI can describe layers of bridges and
devices behind them. It don't think we should throw away that
information just to solve this problem.
And I don't really want to add IORESOURCE_INSERT. It's probably a
useful ...
| Feb 27, 10:43 am 2008 |
| Norbert Preining | Re: Huawei E220 and usb storage
But where do I get this firmware update? I searched the huawei web site,
registered, bid couldn't find anything... any hints?
Best wishes
Norbert
-------------------------------------------------------------------------------
Dr. Norbert Preining <preining@logic.at> Vienna University of Technology
Debian Developer <preining@debian.org> Debian TeX Group
gpg DSA: 0x09C5B094 fp: 14DF 2E6C 0307 BE6D AD76 A9C0 D2BF 4AA3 09C5 ...
| Feb 27, 1:49 am 2008 |
| Chris | Re: epoll design problems with common fork/exec patterns
To clarify, the key appears to be file* plus the user-space integer that
I think fork(2) should not be in the above list. fork(2) duplicates the
kernel's fd, but the user-space integer that represents the fd remains
the same, so you will get EEXIST if you try to add the fd that was
duplicated by fork.
Chris
--
| Feb 26, 6:30 pm 2008 |
| Davide Libenzi | Re: epoll design problems with common fork/exec patterns
Good catch, fork(2) should not be there.
- Davide
| Feb 27, 12:35 pm 2008 |
| Dmitri Monakhov | Re: [PATCH] mm: fix blkdev size calculation in generic_w ...
In fact original issue (wich was reported by me) stil exist
# uname -a
Linux ts52 2.6.25-rc3 #8 SMP Wed Feb 27 11:41:29 MSK 2008 x86_64 x86_64 x86_64
GNU/Linux
# blockdev --getsz /dev/sda7
208782
# blockdev --getbsz /dev/sda7
4096
# dd if=/dev/zero of=/dev/sda7 bs=1k seek=104390 count=1
dd: writing `/dev/sda7': Input/output error
1+0 records in
0+0 records out
0 bytes (0 B) copied, 0.000918887 seconds, 0.0 kB/s
Issue from the bug was triggered in
__generic_make_request()
...
| Feb 27, 3:13 am 2008 |
| previous day | today | next day |
|---|---|---|
| February 26, 2008 | February 27, 2008 | February 28, 2008 |
