Re: [PATCH/RFC 1/2] anon-inodes: Remove fd_install() from anon_inode_getfd()

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Roland Dreier
Date: Wednesday, February 27, 2008 - 1:14 pm

> > The anonymous inodes interface anon_inode_getfd() calls fd_install()
 > > for the newly created fd, which does not work for some use cases where
 > > the caller must do futher initialization before exposing the file to
 > > userspace.  This is also probably not the safest interface, since the
 > > caller must be sure that it is OK if userspace closes the fd before
 > > anon_inode_getfd() even returns.
 > 
 > I believe Al changed the interface to not give out inode* and file*, *and* 
 > call fd_install() inside it. I'd slightly prefer Al version, although I 
 > don't see any major problems in this one too.

Any pointer to that patch?  A web search for "viro" and
"anon_inode_getfd" doesn't turn up anything likely looking.

 - R.
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
Re: [PATCH/RFC 1/2] anon-inodes: Remove fd_install() from ..., Roland Dreier, (Wed Feb 27, 1:14 pm)
Re: [PATCH/RFC 1/2] anon-inodes: Remove fd_install() from ..., Christoph Hellwig, (Thu Mar 6, 8:14 am)
Re: [PATCH/RFC 1/2] anon-inodes: Remove fd_install() from ..., Christoph Hellwig, (Mon Mar 17, 3:40 am)