login
Login
/
Register
Search
Search this site:
Forums
News
Blogs
Features
Site
Home
»
Mailing list archives
»
linux-kernel
»
2008
»
February
»
27
Re: [PATCH 2/9] drivers/acpi/asus_acpi.c: Correct use of ! and &
view
thread
Previous message: [
thread
] [
date
] [author]
Next message: [
thread
] [
date
] [author]
[view in full thread]
From: Karol Kozimor
Subject:
Re: [PATCH 2/9] drivers/acpi/asus_acpi.c: Correct use of ! and &
Date: Wednesday, February 27, 2008 - 10:03 am
On 26-02-2008, at 21:42, Julia Lawall wrote:
quoted text
> if (invert) /* invert target value */ > - led_out = !led_out & 0x1; > + led_out = !(led_out & 0x1); > > if (!write_acpi_int(hotk->handle, ledname, led_out, NULL)) > printk(KERN_WARNING "Asus ACPI: LED (%s) write failed\n",
IIRC we're just supposed to flip the last bit here, so the original code is correct. Best regards, -- Karol Kozimor
sziwan@hell.org.pl
--
unsubscribe notice
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to
majordomo@vger.kernel.org
More majordomo info at
http://vger.kernel.org/majordomo-info.html
Please read the FAQ at
http://www.tux.org/lkml/
Previous message: [
thread
] [
date
] [author]
Next message: [
thread
] [
date
] [author]
Messages in current thread:
[PATCH 2/9] drivers/acpi/asus_acpi.c: Correct use of ! and &
, Julia Lawall
, (Tue Feb 26, 1:42 pm)
Re: [PATCH 2/9] drivers/acpi/asus_acpi.c: Correct use of ! ...
, Karol Kozimor
, (Wed Feb 27, 10:03 am)
Re: [PATCH 2/9] drivers/acpi/asus_acpi.c: Correct use of ! ...
, Julia Lawall
, (Wed Feb 27, 10:41 am)
Re: [PATCH 2/9] drivers/acpi/asus_acpi.c: Correct use of ! ...
, Mark Pearson
, (Wed Feb 27, 11:29 am)
Re: [PATCH 2/9] drivers/acpi/asus_acpi.c: Correct use of ! ...
, Andrew Morton
, (Thu Feb 28, 10:55 pm)
Re: [PATCH 2/9] drivers/acpi/asus_acpi.c: Correct use of ! ...
, Matthew Wilcox
, (Thu Feb 28, 11:10 pm)
Re: [PATCH 2/9] drivers/acpi/asus_acpi.c: Correct use of ! ...
, Matthew Wilcox
, (Thu Feb 28, 11:14 pm)
Re: [PATCH 2/9] drivers/acpi/asus_acpi.c: Correct use of ! ...
, Andrew Morton
, (Thu Feb 28, 11:19 pm)
Re: [PATCH 2/9] drivers/acpi/asus_acpi.c: Correct use of ! ...
, Julia Lawall
, (Fri Feb 29, 4:01 am)
Re: [PATCH 2/9] drivers/acpi/asus_acpi.c: Correct use of ! ...
, Andrew Morton
, (Fri Feb 29, 4:08 am)
Re: [PATCH 2/9] drivers/acpi/asus_acpi.c: Correct use of ! ...
, Mark Pearson
, (Fri Feb 29, 11:06 am)
Re: [PATCH 2/9] drivers/acpi/asus_acpi.c: Correct use of ! ...
, Andrew Morton
, (Fri Feb 29, 2:33 pm)
Navigation
Create content
Mailing list archives
Recent posts
Popular discussions
linux-kernel
:
David Howells
Re: [PATCH 5/5]bluetooth:hci_bcsp Fix operation on 'bcsp->msgq_txseq' may be un...
Francis Moreau
Re: Disk geometry from /sys
Eberhard Moenkeberg
Re: OT: character encodings (was: Linux 2.6.20-rc4)
Rafael J. Wysocki
[Bug #11551] Semi-repeatable hard lockup on 2.6.27-rc6
Mike Galbraith
Re: [ANNOUNCE/RFC] Really Fair Scheduler
git
:
Mark Junker
git on MacOSX and files with decomposed utf-8 file names
Pat Thoyts
[PATCH] git-gui: use themed tk widgets with Tk 8.5
Michael Witten
Re: 'git gc --aggressive' effectively unusable
Petko Manolov
git and binary files
Lynn Lin
Re: clearcase migration to git
git-commits-head
:
Linux Kernel Mailing List
[ARM] unconditionally define __virt_to_phys and __phys_to_virt
Linux Kernel Mailing List
ACPICA: Fix to allow zero-length ASL field declarations
Linux Kernel Mailing List
tracing: Simplify trace_option_write()
Linux Kernel Mailing List
ARM: Add Versatile Express SMP support
Linux Kernel Mailing List
ixgbe: fix automatic LRO/RSC settings for low latency
linux-netdev
:
David Miller
Re: [PATCH 32/53] netns xfrm: finding policy in netns
William Allen Simpson
[net-next-2.6 PATCH v8 0/7] TCPCT part 1: cookie option exchange
David Miller
Re: [PATCH] IPv6: preferred lifetime of address not getting updated
Eric Dumazet
Re: [PATCH net-next-2.6] net: Introduce skb_orphan_try()
Mark McLoughlin
Re: [PATCH 2/3] virtio: fix delayed xmit of packet and freeing of old packets.
openbsd-misc
:
Samuel Baldwin
Re: Forum engine
Robert
disklabel - cylinder rounding
nixlists
Re: Which laptops do the developers use?
Marcin
Re: 4.6 reboots x336 ibm server(s)
L. V. Lammert
OT, .. but has anyone seen a crontab editor
Colocation donated by:
Syndicate