Home » Mailing list archives » linux-kernel » 2008 » February » 26

Re: [patch 1/6] mempolicy: convert MPOL constants to enum

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: Paul Jackson <pj@...>
To: David Rientjes <rientjes@...>
Cc: <akpm@...>, <clameter@...>, <Lee.Schermerhorn@...>, <ak@...>, <linux-kernel@...>
Subject: Re: [patch 1/6] mempolicy: convert MPOL constants to enum
Date: Tuesday, February 26, 2008 - 12:02 am

David wrote:

Eh ... each bit of added clarity to the code reduces
errors.

Looking around the kernel, it really seems to me to be
a common coding to explicitly spell out enum values
when for some reason they actually matter.

Like most coding mechanisms, nothing guarantees anything.

It just nicely represents one particular detail, that
the values of these MPOL_* terms are not arbitrary.

-- 
                  I won't rest till it's the best ...
                  Programmer, Linux Scalability
                  Paul Jackson <pj@sgi.com> 1.940.382.4214
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
[patch 1/6] mempolicy: convert MPOL constants to enum, David Rientjes, (Mon Feb 25, 11:35 am)
Re: [patch 1/6] mempolicy: convert MPOL constants to enum, Christoph Lameter, (Wed Feb 27, 3:35 pm)
Re: [patch 1/6] mempolicy: convert MPOL constants to enum, David Rientjes, (Wed Feb 27, 3:59 pm)
Re: [patch 1/6] mempolicy: convert MPOL constants to enum, Paul Jackson, (Mon Feb 25, 11:20 pm)
Re: [patch 1/6] mempolicy: convert MPOL constants to enum, David Rientjes, (Mon Feb 25, 11:35 pm)
Re: [patch 1/6] mempolicy: convert MPOL constants to enum, Paul Jackson, (Tue Feb 26, 12:02 am)
Re: [patch 1/6] mempolicy: convert MPOL constants to enum, David Rientjes, (Tue Feb 26, 12:21 am)
Re: [patch 1/6] mempolicy: convert MPOL constants to enum, Paul Jackson, (Tue Feb 26, 12:46 am)
[patch 2/6] mempolicy: support optional mode flags, David Rientjes, (Mon Feb 25, 11:35 am)
[patch 3/6] mempolicy: add MPOL_F_STATIC_NODES flag, David Rientjes, (Mon Feb 25, 11:35 am)
Re: [patch 3/6] mempolicy: add MPOL_F_STATIC_NODES flag, Paul Jackson, (Tue Feb 26, 1:56 pm)
Re: [patch 3/6] mempolicy: add MPOL_F_STATIC_NODES flag, David Rientjes, (Tue Feb 26, 5:02 pm)
Re: [patch 3/6] mempolicy: add MPOL_F_STATIC_NODES flag, Paul Jackson, (Tue Feb 26, 5:39 pm)
Re: [patch 3/6] mempolicy: add MPOL_F_STATIC_NODES flag, Lee Schermerhorn, (Tue Feb 26, 5:32 pm)
Re: [patch 3/6] mempolicy: add MPOL_F_STATIC_NODES flag, David Rientjes, (Tue Feb 26, 5:54 pm)
Re: [patch 3/6] mempolicy: add MPOL_F_STATIC_NODES flag, Paul Jackson, (Tue Feb 26, 6:08 pm)
Re: [patch 3/6] mempolicy: add MPOL_F_STATIC_NODES flag, Paul Jackson, (Tue Feb 26, 1:46 am)
Re: [patch 3/6] mempolicy: add MPOL_F_STATIC_NODES flag, David Rientjes, (Tue Feb 26, 2:53 am)
[patch 4/6] mempolicy: add bitmap_onto() and bitmap_fold() o..., David Rientjes, (Mon Feb 25, 11:35 am)
[patch 5/6] mempolicy: add MPOL_F_RELATIVE_NODES flag, David Rientjes, (Mon Feb 25, 11:35 am)
Re: [patch 5/6] mempolicy: add MPOL_F_RELATIVE_NODES flag, David Rientjes, (Tue Feb 26, 9:17 pm)
Re: [patch 5/6] mempolicy: add MPOL_F_RELATIVE_NODES flag, Lee Schermerhorn, (Wed Feb 27, 11:37 am)
Re: [patch 5/6] mempolicy: add MPOL_F_RELATIVE_NODES flag, David Rientjes, (Thu Feb 28, 5:08 pm)
Re: [patch 5/6] mempolicy: add MPOL_F_RELATIVE_NODES flag, Paul Jackson, (Wed Feb 27, 1:09 pm)
Re: [patch 5/6] mempolicy: add MPOL_F_RELATIVE_NODES flag, Paul Jackson, (Tue Feb 26, 10:30 pm)
Re: [patch 5/6] mempolicy: add MPOL_F_RELATIVE_NODES flag, David Rientjes, (Tue Feb 26, 9:31 pm)
Re: [patch 5/6] mempolicy: add MPOL_F_RELATIVE_NODES flag, Paul Jackson, (Tue Feb 26, 1:44 pm)
Re: [patch 5/6] mempolicy: add MPOL_F_RELATIVE_NODES flag, Lee Schermerhorn, (Tue Feb 26, 5:27 pm)
Re: [patch 5/6] mempolicy: add MPOL_F_RELATIVE_NODES flag, David Rientjes, (Tue Feb 26, 5:17 pm)
Re: [patch 5/6] mempolicy: add MPOL_F_RELATIVE_NODES flag, Paul Jackson, (Tue Feb 26, 5:30 pm)
Re: [patch 5/6] mempolicy: add MPOL_F_RELATIVE_NODES flag, Paul Jackson, (Tue Feb 26, 2:12 am)
Re: [patch 5/6] mempolicy: add MPOL_F_RELATIVE_NODES flag, David Rientjes, (Tue Feb 26, 2:45 am)
[patch 6/6] mempolicy: update NUMA memory policy documentation, David Rientjes, (Mon Feb 25, 11:35 am)
Re: [patch 6/6] mempolicy: update NUMA memory policy documen..., Paul Jackson, (Tue Feb 26, 1:34 pm)
Re: [patch 6/6] mempolicy: update NUMA memory policy documen..., David Rientjes, (Tue Feb 26, 5:23 pm)