James,
Thanks for the reply. We will resubmit the patch to rollback it to our
original implementation.
Regards.
Bo Yang
-----Original Message-----
From: James Bottomley [mailto:James.Bottomley@HansenPartnership.com]
Sent: Friday, February 22, 2008 11:36 AM
To: Yang, Bo
Cc: Matthew Wilcox; linux-scsi@vger.kernel.org; akpm@osdl.org;
linux-kernel@vger.kernel.org; Patro, Sumant; Kolli, Neela
Subject: RE: [PATCH 1/1] scsi: megaraid_sas - Fix random failure of
DCDBcmds with sense info
On Fri, 2008-02-22 at 09:17 -0700, Yang, Bo wrote:
OK, read the thread; Matthew is right. What you propose would pretty
much destroy compat ioctl handling within the driver. You need a compat
handler for MEGASAS_IOC_FW.
With your current patch you'd get a failure both from a 64 bit binary
running on x86-64 and if someone ran the x86 binary on ia64.
The driver already uses the compat infrastructure, it shouldn't be too
hard to add this in the correct manner.
James
--