login
Header Space

 
 

[PATCH] de2104x: remove BUG_ON() when changing media type

Score:
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: Grant Grundler <grundler@...>
Cc: <jgarzik@...>, Linux Kernel <linux-kernel@...>, <netdev@...>
Date: Monday, February 25, 2008 - 1:45 pm

When the chip dies (probably because of a bug somewhere in the driver), 
de_stop_rxtx() fails and changing the media type crashes the whole machine. 
Replace BUG_ON() in de_set_media() with a warning.

Signed-off-by: Ondrej Zary <linux@rainbow-software.org>

--- linux-2.6.24-orig/drivers/net/tulip/de2104x.c	2008-02-25 18:27:34.000000000 +0100
+++ linux-2.6.24-pentium/drivers/net/tulip/de2104x.c	2008-02-25 18:34:56.000000000 +0100
@@ -910,7 +910,8 @@
 	unsigned media = de->media_type;
 	u32 macmode = dr32(MacMode);
 
-	BUG_ON(de_is_running(de));
+	if (de_is_running(de))
+		printk(KERN_WARNING "%s: chip is running while changing media!\n", de->dev->name);
 
 	if (de->de21040)
 		dw32(CSR11, FULL_DUPLEX_MAGIC);


-- 
Ondrej Zary
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
Compex FreedomLine 32 PnP-PCI2 broken with de2104x, Ondrej Zary, (Sat Jan 26, 4:58 pm)
Re: Compex FreedomLine 32 PnP-PCI2 broken with de2104x, Ondrej Zary, (Wed Jan 30, 4:23 pm)
Re: Compex FreedomLine 32 PnP-PCI2 broken with de2104x, Grant Grundler, (Sun Feb 17, 11:21 pm)
Re: Compex FreedomLine 32 PnP-PCI2 broken with de2104x, Jeff Garzik, (Mon Feb 25, 3:28 am)
Re: Compex FreedomLine 32 PnP-PCI2 broken with de2104x, Ondrej Zary, (Mon Feb 25, 5:31 pm)
Re: Compex FreedomLine 32 PnP-PCI2 broken with de2104x, Ondrej Zary, (Mon Feb 18, 12:40 pm)
Re: Compex FreedomLine 32 PnP-PCI2 broken with de2104x, Grant Grundler, (Mon Feb 25, 3:15 am)
[PATCH] de2104x: remove BUG_ON() when changing media type, Ondrej Zary, (Mon Feb 25, 1:45 pm)
Re: Compex FreedomLine 32 PnP-PCI2 broken with de2104x, Jeff Garzik, (Mon Feb 25, 3:30 am)
Re: Compex FreedomLine 32 PnP-PCI2 broken with de2104x, Grant Grundler, (Tue Feb 26, 3:48 am)
speck-geostationary