Hi
Commit 6c231bd5eb07ce546517019f334652b9ecfc329a

generate this warning:
drivers/misc/thinkpad_acpi.c: In function 'tpacpi_input_send_tabletsw':

include/linux/input.h:1290: warning: 'state' is used uninitialized in

this function

drivers/misc/thinkpad_acpi.c:1191: note: 'state' was declared here

drivers/misc/thinkpad_acpi.c: In function 'hotkey_tablet_mode_show':

drivers/misc/thinkpad_acpi.c:1723: warning: 's' is used uninitialized

in this function
I assume typo  here thinkpad_acpi.c:10724 hotkey_get_tablet_mode

where status should be maybe 's' and local 's' shouldn't be defined at

all -  just guess?
Zdenek

--

I can't seem to get these warnings in Debian gcc 4.2.3-1.  But the code is

broken alright.  I will send in a fix in a short while, as it will take a

small while to make sure there is nothing else wrong before I send in the

fix.   I have to figure out how the heck that got past the testing in the

first place, as well...
--

  "One disk to rule them all, One disk to find them. One disk to bring

  them all and in the darkness grind them. In the Land of Redmond

  where the shadows lie." -- The Silicon Valley Tarot

  Henrique Holschuh

--

Try gcc-4.3  (or gcc-snapshot) - makes much better/deeper code analysis.
Zdenek

--

Erk.  Looks like I tested one branch and did a git-send-email on the other

or something equally pathetic.  Sorry about that.
I will check the entire thing over line by line and send a fix.
--

  "One disk to rule them all, One disk to find them. One disk to bring

  them all and in the darkness grind them. In the Land of Redmond

  where the shadows lie." -- The Silicon Valley Tarot

  Henrique Holschuh

--