Home » Mailing list archives » linux-kernel » 2008 » February » 24

Re: [PATCH] Fix alignment of early reservation for EBDA

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: Alexander van Heukelum <heukelum@...>
To: Ingo Molnar <mingo@...>
Cc: Andi Kleen <ak@...>, Thomas Gleixner <tglx@...>, LKML <linux-kernel@...>, Alexander van Heukelum <heukelum@...>
Subject: Re: [PATCH] Fix alignment of early reservation for EBDA
Date: Sunday, February 24, 2008 - 4:53 pm

On Sun, 24 Feb 2008 20:41:21 +0100, "Ingo Molnar" <mingo@elte.hu> said:

It's 1024 bytes below, but yes, the EBDA starts there. Then the first
two
bytes of the EBDA contain the value 0x0001, which means that its size is
1kb, so the BIOS is correct.


Correct. I thought it was new code, but looking more closely, the
behaviour
has indeed not changed recently (note to self: git log -p somefile.c
does
not indicate in any way that code was moved from some other place.)


No regressions, it's just cosmetic.


Not really: ebda_addr is just a local variable. If the system needs to
find the start of the EBDA, it will just have to look at the 16 bit
value
at address 0x40E again.


The patch is exactly trying to do that. The code that was there seemed
to
imply that the author wanted to allocate whole pages, in such a way that
the allocation contained the whole EBDA. I think that is what it does
after this patch.

Greetings,
    Alexander
-- 
  Alexander van Heukelum
  heukelum@fastmail.fm

-- 
http://www.fastmail.fm - And now for something completely different…

--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
[PATCH] Fix alignment of early reservation for EBDA, Alexander van Heukelum, (Sun Feb 24, 1:46 pm)
Re: [PATCH] Fix alignment of early reservation for EBDA, H. Peter Anvin, (Sun Feb 24, 10:18 pm)
Re: [PATCH] Fix alignment of early reservation for EBDA, Alexander van Heukelum, (Mon Feb 25, 12:54 pm)
Re: [PATCH] Fix alignment of early reservation for EBDA, Andi Kleen, (Wed Feb 27, 10:25 am)
Re: [PATCH] Fix alignment of early reservation for EBDA, Ingo Molnar, (Mon Feb 25, 1:01 pm)
[PATCH] reserve_early end-of-conventional-memory to 1MB, Alexander van Heukelum, (Mon Feb 25, 2:07 pm)
Re: [PATCH] reserve_early end-of-conventional-memory to 1MB, H. Peter Anvin, (Mon Feb 25, 2:13 pm)
Re: [PATCH] reserve_early end-of-conventional-memory to 1MB, Alexander van Heukelum, (Mon Feb 25, 3:46 pm)
Re: [PATCH] reserve_early end-of-conventional-memory to 1MB, H. Peter Anvin, (Mon Feb 25, 5:17 pm)
Re: [PATCH] reserve_early end-of-conventional-memory to 1MB, Ingo Molnar, (Tue Feb 26, 5:30 am)
Re: [PATCH] reserve_early end-of-conventional-memory to 1MB ..., Andi Kleen, (Wed Feb 27, 10:38 am)
Re: [PATCH] reserve_early end-of-conventional-memory to 1MB ..., H. Peter Anvin, (Wed Feb 27, 12:44 pm)
Re: [PATCH] reserve_early end-of-conventional-memory to 1MB ..., Alexander van Heukelum, (Wed Feb 27, 4:01 pm)
Re: [PATCH] reserve_early end-of-conventional-memory to 1MB, Andi Kleen, (Wed Feb 27, 10:26 am)
[PATCH] reserve end-of-conventional-memory to 1MB on 32-bit, Alexander van Heukelum, (Thu Feb 28, 9:13 am)
[RFC] use realmode code to reserve end-of-conventional-memor..., Alexander van Heukelum, (Thu Feb 28, 9:28 am)
Re: [RFC] use realmode code to reserve end-of-conventional-m..., Ian Campbell, (Thu Feb 28, 5:12 pm)
Re: [RFC] use realmode code to reserve end-of-conventional-m..., H. Peter Anvin, (Thu Feb 28, 5:14 pm)
Re: [RFC] use realmode code to reserve end-of-conventional-m..., Ian Campbell, (Thu Feb 28, 7:16 pm)
Re: [RFC] use realmode code to reserve end-of-conventional-m..., Jeremy Fitzhardinge, (Tue Mar 4, 1:44 pm)
Re: [RFC] use realmode code to reserve end-of-conventional-m..., Eduardo Habkost, (Wed Mar 5, 11:59 am)
Re: [RFC] use realmode code to reserve end-of-conventional-m..., Jeremy Fitzhardinge, (Wed Mar 5, 12:38 pm)
Re: [RFC] use realmode code to reserve end-of-conventional-m..., H. Peter Anvin, (Wed Mar 5, 1:27 pm)
Re: [RFC] use realmode code to reserve end-of-conventional-m..., H. Peter Anvin, (Wed Mar 5, 12:08 pm)
Re: [RFC] use realmode code to reserve end-of-conventional-m..., Eduardo Habkost, (Wed Mar 5, 12:53 pm)
Re: [RFC] use realmode code to reserve end-of-conventional-m..., H. Peter Anvin, (Wed Mar 5, 1:28 pm)
Re: [RFC] use realmode code to reserve end-of-conventional-m..., Jeremy Fitzhardinge, (Wed Mar 5, 1:28 pm)
Re: [RFC] use realmode code to reserve end-of-conventional-m..., H. Peter Anvin, (Wed Mar 5, 1:38 pm)
Re: [RFC] use realmode code to reserve end-of-conventional-m..., Ingo Molnar, (Fri Feb 29, 4:00 pm)
Re: [RFC] use realmode code to reserve end-of-conventional-m..., Mark McLoughlin, (Tue Mar 4, 7:41 am)
Re: [RFC] use realmode code to reserve end-of-conventional-m..., Ingo Molnar, (Tue Mar 4, 10:33 am)
Re: [RFC] use realmode code to reserve end-of-conventional-m..., Jeremy Fitzhardinge, (Tue Mar 4, 11:13 am)
Re: [RFC] use realmode code to reserve end-of-conventional-m..., Ingo Molnar, (Tue Mar 4, 11:25 am)
Re: [RFC] use realmode code to reserve end-of-conventional-m..., Jeremy Fitzhardinge, (Tue Mar 4, 12:02 pm)
Re: [RFC] use realmode code to reserve end-of-conventional-m..., Ingo Molnar, (Tue Mar 4, 12:15 pm)
Re: [RFC] use realmode code to reserve end-of-conventional-m..., Mark McLoughlin, (Tue Mar 4, 12:15 pm)
Re: [RFC] use realmode code to reserve end-of-conventional-m..., Ingo Molnar, (Tue Mar 4, 12:23 pm)
Re: [RFC] use realmode code to reserve end-of-conventional-m..., Ian Campbell, (Tue Mar 4, 11:12 am)
Re: [PATCH] reserve end-of-conventional-memory to 1MB on 32-..., Ian Campbell, (Thu Feb 28, 5:09 pm)
Re: [PATCH] reserve end-of-conventional-memory to 1MB on 32-..., Alexander van Heukelum, (Fri Feb 29, 7:49 am)
Re: [PATCH] reserve end-of-conventional-memory to 1MB on 32-..., Mark McLoughlin, (Fri Feb 29, 1:14 pm)
Re: [PATCH] reserve end-of-conventional-memory to 1MB on 32-..., Alexander van Heukelum, (Fri Feb 29, 2:38 pm)
Re: [PATCH] reserve end-of-conventional-memory to 1MB on 32-..., H. Peter Anvin, (Fri Feb 29, 2:44 pm)
Re: [PATCH] reserve end-of-conventional-memory to 1MB on 32-..., Alexander van Heukelum, (Fri Feb 29, 2:56 pm)
Re: [PATCH] reserve end-of-conventional-memory to 1MB on 32-..., Mark McLoughlin, (Fri Feb 29, 6:06 pm)
Re: [PATCH] reserve end-of-conventional-memory to 1MB on 32-..., Alexander van Heukelum, (Sat Mar 1, 12:09 pm)
Re: [PATCH] reserve end-of-conventional-memory to 1MB on 64-..., Alexander van Heukelum, (Sat Mar 1, 12:12 pm)
Re: [PATCH] reserve end-of-conventional-memory to 1MB on 32-..., Mark McLoughlin, (Tue Mar 4, 7:44 am)
Re: [PATCH] reserve end-of-conventional-memory to 1MB on 32-..., Jeremy Fitzhardinge, (Tue Mar 4, 11:18 am)
Re: [PATCH] reserve end-of-conventional-memory to 1MB on 32-..., Alexander van Heukelum, (Tue Mar 4, 12:51 pm)
Re: [PATCH] reserve end-of-conventional-memory to 1MB on 32-..., Jeremy Fitzhardinge, (Tue Mar 4, 1:11 pm)
Re: [PATCH] reserve end-of-conventional-memory to 1MB, 32-bi..., Alexander van Heukelum, (Tue Mar 4, 2:57 pm)
Re: [PATCH] reserve end-of-conventional-memory to 1MB, 64-bi..., Alexander van Heukelum, (Tue Mar 4, 3:12 pm)
Re: [PATCH] reserve end-of-conventional-memory to 1MB on 32-..., H. Peter Anvin, (Tue Mar 4, 1:05 pm)
Re: [PATCH] reserve end-of-conventional-memory to 1MB on 32-..., Ingo Molnar, (Tue Mar 4, 10:49 am)
Re: [PATCH] reserve end-of-conventional-memory to 1MB on 32-..., Mark McLoughlin, (Tue Mar 4, 11:16 am)
Re: [PATCH] reserve end-of-conventional-memory to 1MB on 32-..., Ingo Molnar, (Tue Mar 4, 11:24 am)
Re: [PATCH] reserve end-of-conventional-memory to 1MB on 32-..., Alexander van Heukelum, (Tue Mar 4, 9:31 am)
Re: [PATCH] reserve end-of-conventional-memory to 1MB on 32-..., Alexander van Heukelum, (Fri Feb 29, 6:26 pm)
Re: [PATCH] Fix alignment of early reservation for EBDA, Andi Kleen, (Sun Feb 24, 3:27 pm)
Re: [PATCH] Fix alignment of early reservation for EBDA, Ingo Molnar, (Sun Feb 24, 3:41 pm)
Re: [PATCH] Fix alignment of early reservation for EBDA, Alexander van Heukelum, (Sun Feb 24, 4:53 pm)