On Sun, 24 Feb 2008, David Newall wrote:It would be, if it weren't artificially so, for violates several kernel coding standards, one being that the "case" labels indent with the switch, not under it (the other being the placement of braces). No, that's not it at all. We don't indent 'case' because it matches with the 'switch', not because of any room issues. It's not at all inconsistent. It's just making clear how the parts of the function group together. Indenting a case-statement an extra level is as stupid as indenting "else" one extra level from the "if ()" it goes together with. Do you think that would be sane? The fact that the 'case' thing is technically parsed as a separate statement in C doesn't change anything. Linus --
| Alan Cox | [PATCH 00/76] Queued TTY Patches |
| Linus Torvalds | Linux 2.6.27-rc8 |
| Greg Kroah-Hartman | [PATCH 005/196] Chinese: add translation of SubmittingDrivers |
| Borislav Petkov | 2.6.23-rc1: no setup signature found... |
git: | |
| Kyle Moffett | Using GIT to store /etc (Or: How to make GIT store all file permission bits) |
| Johannes Sixt | [PATCH 01/40] Add compat/regex.[ch] and compat/fnmatch.[ch]. |
| Junio C Hamano | Re: Considering teaching plumbing to users harmful |
| Michael J Gruber | Re: RFC: grafts generalised |
| Markus Wernig | host to host ipsec link |
| Richard Stallman | Real men don't attack straw men |
| GVG GVG | ssh_exchange_identification: Connection closed by remote host |
| Stuart Henderson | Re: Server just freeze with no reason |
| David Miller | [GIT]: Networking |
| David Miller | Re: [PATCH] pkt_sched: Destroy gen estimators under rtnl_lock(). |
| Denys Fedoryshchenko | packetloss, on e1000e worse than r8169? |
| Thomas Jarosch | Re: TCP connection stalls under 2.6.24.7 |
