On Fri, Feb 22, 2008 at 12:16:45PM +1030, David Newall wrote:
quoted text > Krzysztof Halasa wrote:
> > Linus Torvalds <torvalds@linux-foundation.org> writes:
> >> I'm personally of the opinion that a lot of checkpatch "fixes" are
> >> anything but. That mainly concerns fixing overlong lines
> >>
> >
> > Perhaps we should increase line length limit, 132 should be fine.
> > Especially useful with long printk() lines and long arithmetic
> > expressions.
> >
>
>
> Yes; or even longer. 80 characters might have made sense on a screen
> when the alternative was 80 characters on a punched card, but on a
> modern computer it's very restrictive. That's especially true with the
> deep indents that you quickly get in C
... if your style is lousy. I agree that situation with printks is
not normal in that respect and I certainly have no love for the
checkpatch nonsense, but pressure to keep the fucking nesting depth
low is a Good Thing(tm).
--
unsubscribe notice To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to
majordomo@vger.kernel.org
More majordomo info at
http://vger.kernel.org/majordomo-info.html
Please read the FAQ at
http://www.tux.org/lkml/
Messages in current thread:
Re: Merging of completely unreviewed drivers , Al Viro , (Thu Feb 21, 7:06 pm)