[PATCH 03/11] cpufreq: fix kobject reference count handling

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: <linux-kernel@...>
Cc: Balaji Rao <balajirrao@...>, Dave Jones <davej@...>, Yi Yang <yi.y.yang@...>, Alan Stern <stern@...>, Frans Pop <elendil@...>, Yinghai Lu <yhlu.kernel@...>, Ingo Molnar <mingo@...>, Greg Kroah-Hartman <gregkh@...>
Date: Thursday, February 21, 2008 - 7:47 pm

From: Balaji Rao <balajirrao@gmail.com>

The cpufreq core should not take an extra kobject reference count for no
reason, and then refuse to release it.  This has been reported as
keeping machines from properly powering down all the way.


Signed-off-by: Balaji Rao <balajirrao@gmail.com>
Cc: Dave Jones <davej@codemonkey.org.uk>
Cc: Yi Yang <yi.y.yang@intel.com>
Cc: Alan Stern <stern@rowland.harvard.edu>
Cc: Frans Pop <elendil@planet.nl>
Cc: Yinghai Lu <yhlu.kernel@gmail.com>
Cc: Ingo Molnar <mingo@elte.hu>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
---
 drivers/cpufreq/cpufreq.c |    8 --------
 1 files changed, 0 insertions(+), 8 deletions(-)

diff --git a/drivers/cpufreq/cpufreq.c b/drivers/cpufreq/cpufreq.c
index 64926aa..89a29cd 100644
--- a/drivers/cpufreq/cpufreq.c
+++ b/drivers/cpufreq/cpufreq.c
@@ -1006,14 +1006,6 @@ static int __cpufreq_remove_dev (struct sys_device * sys_dev)
 	}
 #endif
 
-
-	if (!kobject_get(&data->kobj)) {
-		spin_unlock_irqrestore(&cpufreq_driver_lock, flags);
-		cpufreq_debug_enable_ratelimit();
-		unlock_policy_rwsem_write(cpu);
-		return -EFAULT;
-	}
-
 #ifdef CONFIG_SMP
 
 #ifdef CONFIG_HOTPLUG_CPU
-- 
1.5.4

--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[PATCH 11/11] modules: do not try to add sysfs attributes if..., Greg Kroah-Hartman, (Thu Feb 21, 7:48 pm)
[PATCH 10/11] POWERPC: fix typo in pseries/power.c, Greg Kroah-Hartman, (Thu Feb 21, 7:48 pm)
[PATCH 09/11] PM: Remove unbalanced mutex_unlock() from dpm_..., Greg Kroah-Hartman, (Thu Feb 21, 7:48 pm)
[PATCH 08/11] UIO: fix Greg's stupid changes, Greg Kroah-Hartman, (Thu Feb 21, 7:48 pm)
[PATCH 07/11] stable_kernel_rules: fix must already be in ma..., Greg Kroah-Hartman, (Thu Feb 21, 7:48 pm)
[PATCH 06/11] ide: mark "ide=reverse" option as obsolete, Greg Kroah-Hartman, (Thu Feb 21, 7:48 pm)
[PATCH 05/11] Driver core: Fix error handling in bus_add_dri..., Greg Kroah-Hartman, (Thu Feb 21, 7:48 pm)
[PATCH 04/11] driver-core: fix kernel-doc function parameters, Greg Kroah-Hartman, (Thu Feb 21, 7:48 pm)
[PATCH 03/11] cpufreq: fix kobject reference count handling, Greg Kroah-Hartman, (Thu Feb 21, 7:47 pm)
[PATCH 02/11] slabinfo: fall back from /sys/kernel/slab to /..., Greg Kroah-Hartman, (Thu Feb 21, 7:47 pm)
[PATCH 01/11] Fix broken utf-8 encodings in ja_JP translatio..., Greg Kroah-Hartman, (Thu Feb 21, 7:47 pm)