Re: Merging of completely unreviewed drivers

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: Jeff Garzik <jeff@...>
Cc: Arjan van de Ven <arjan@...>, Roland Dreier <rdreier@...>, Linus Torvalds <torvalds@...>, Glenn Streiff <gstreiff@...>, Faisal Latif <flatif@...>, <linux-kernel@...>, <general@...>, Andrew Morton <akpm@...>, Greg Kroah-Hartman <greg@...>
Date: Thursday, February 21, 2008 - 7:40 pm

On Thu, Feb 21, 2008 at 05:33:10PM -0500, Jeff Garzik wrote:

I was not talking about checkpatch warnings.

I'm talking about checkpatch errors for code like
						if ((page_count!=0)&&(page_count<<12)-(region->offset&(4096-1))>=region->length)

I have to accept that Linus prefers to have the driver merged first and 
let janitors make the code readable in subsequent patches, but if GNU 
indent wasn't unable to properly cope with the fact that this driver has 
over 2000 lines that are over 80 characters long I'd simply run this 
driver through scripts/Lindent .


cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed

--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
Merging of completely unreviewed drivers, Adrian Bunk, (Thu Feb 21, 5:01 pm)
Re: Merging of completely unreviewed drivers, Arjan van de Ven, (Thu Feb 21, 6:08 pm)
Re: Merging of completely unreviewed drivers, Pavel Machek, (Fri Feb 22, 2:40 pm)
Re: Merging of completely unreviewed drivers, Jeff Garzik, (Thu Feb 21, 6:33 pm)
Re: Merging of completely unreviewed drivers, Adrian Bunk, (Thu Feb 21, 7:40 pm)
Re: Merging of completely unreviewed drivers, Greg KH, (Thu Feb 21, 5:30 pm)
Re: Merging of completely unreviewed drivers, Adrian Bunk, (Thu Feb 21, 9:06 pm)
Re: Merging of completely unreviewed drivers, Linus Torvalds, (Thu Feb 21, 5:14 pm)
Re: Merging of completely unreviewed drivers, Ingo Molnar, (Fri Feb 22, 2:54 pm)
Re: Merging of completely unreviewed drivers, Jeff Garzik, (Fri Feb 22, 3:20 pm)
Re: Merging of completely unreviewed drivers, Greg KH, (Fri Feb 22, 3:44 pm)
Re: Merging of completely unreviewed drivers, Krzysztof Halasa, (Thu Feb 21, 7:38 pm)
Re: Merging of completely unreviewed drivers, David Newall, (Thu Feb 21, 9:46 pm)
Re: [ofa-general] Re: Merging of completely unreviewed drivers, John W. Linville, (Fri Feb 22, 11:48 am)
Re: [ofa-general] Re: Merging of completely unreviewed drivers, John W. Linville, (Fri Feb 22, 12:48 pm)
Re: Merging of completely unreviewed drivers, Al Viro, (Thu Feb 21, 10:06 pm)
Re: Merging of completely unreviewed drivers, Linus Torvalds, (Thu Feb 21, 11:13 pm)
Re: Merging of completely unreviewed drivers, Krzysztof Halasa, (Fri Feb 22, 6:37 pm)
Re: Merging of completely unreviewed drivers, Ray Lee, (Fri Feb 22, 2:37 am)
Re: Merging of completely unreviewed drivers, Jan Engelhardt, (Sat Feb 23, 11:31 am)
Re: Merging of completely unreviewed drivers, David Newall, (Sat Feb 23, 11:22 pm)
Re: Merging of completely unreviewed drivers, Krzysztof Halasa, (Thu Feb 21, 10:23 pm)
Re: Merging of completely unreviewed drivers, Al Viro, (Thu Feb 21, 11:13 pm)
Re: Merging of completely unreviewed drivers, Krzysztof Halasa, (Fri Feb 22, 6:28 pm)
Re: Merging of completely unreviewed drivers, Jörn, (Sun Feb 24, 3:47 am)
Re: Merging of completely unreviewed drivers, Krzysztof Halasa, (Sun Feb 24, 10:47 am)
Re: Merging of completely unreviewed drivers, Alan Cox, (Thu Feb 21, 7:31 pm)
Re: Merging of completely unreviewed drivers, Adrian Bunk, (Thu Feb 21, 8:29 pm)
Re: Merging of completely unreviewed drivers, Jeff Garzik, (Thu Feb 21, 7:41 pm)
Re: Merging of completely unreviewed drivers, Krzysztof Halasa, (Thu Feb 21, 8:05 pm)
Re: Merging of completely unreviewed drivers, Pavel Machek, (Fri Feb 22, 2:45 pm)
Re: Merging of completely unreviewed drivers, Krzysztof Halasa, (Fri Feb 22, 6:44 pm)
Re: Merging of completely unreviewed drivers, Pavel Machek, (Sat Feb 23, 5:43 am)
Re: Merging of completely unreviewed drivers, Krzysztof Halasa, (Sat Feb 23, 9:58 am)
Re: Merging of completely unreviewed drivers, David Newall, (Sat Feb 23, 8:38 am)
Re: Merging of completely unreviewed drivers, Linus Torvalds, (Sat Feb 23, 1:33 pm)
Re: Merging of completely unreviewed drivers, David Newall, (Sat Feb 23, 11:26 pm)
Re: Merging of completely unreviewed drivers, Linus Torvalds, (Sun Feb 24, 12:47 am)
Re: Merging of completely unreviewed drivers, Pavel Machek, (Sat Feb 23, 11:25 am)
Re: Merging of completely unreviewed drivers, David Newall, (Sat Feb 23, 11:18 pm)
Re: Merging of completely unreviewed drivers, Alan Cox, (Fri Feb 22, 6:04 am)
Re: Merging of completely unreviewed drivers, Jeff Garzik, (Thu Feb 21, 8:44 pm)
Re: Merging of completely unreviewed drivers, Krzysztof Halasa, (Thu Feb 21, 10:02 pm)
Re: Merging of completely unreviewed drivers, Alexey Dobriyan, (Thu Feb 21, 6:33 pm)
Re: Merging of completely unreviewed drivers, Greg KH, (Thu Feb 21, 6:43 pm)
Re: Merging of completely unreviewed drivers, Jan Engelhardt, (Thu Feb 21, 7:31 pm)
Re: Merging of completely unreviewed drivers, Alexey Dobriyan, (Thu Feb 21, 6:58 pm)
Re: Merging of completely unreviewed drivers, Jeff Garzik, (Thu Feb 21, 6:57 pm)
Re: Merging of completely unreviewed drivers, Roland Dreier, (Thu Feb 21, 5:09 pm)