login
Login
/
Register
Search
Forums
News
Blogs
Features
Site
Home
»
Mailing list archives
»
linux-kernel
»
2008
»
February
»
21
Re: Merging of completely unreviewed drivers
view
thread
!MAILaRCHIVE_VOTE_RePLACE
Previous message: [
thread
] [
date
] [
author
]
Next message: [
thread
] [
date
] [
author
]
[view in full thread]
From:
Jan Engelhardt <jengelh@...>
To: Greg KH <greg@...>
Cc: Alexey Dobriyan <adobriyan@...>, Linus Torvalds <torvalds@...>, Adrian Bunk <bunk@...>, Roland Dreier <rdreier@...>, Glenn Streiff <gstreiff@...>, Faisal Latif <flatif@...>, <linux-kernel@...>, <general@...>, Andrew Morton <akpm@...>
Subject:
Re: Merging of completely unreviewed drivers
Date: Thursday, February 21, 2008 - 7:31 pm
On Feb 21 2008 14:43, Greg KH wrote:
quoted text
>On Fri, Feb 22, 2008 at 01:33:03AM +0300, Alexey Dobriyan wrote: >> On Thu, Feb 21, 2008 at 01:14:55PM -0800, Linus Torvalds wrote: >> > Quite frankly, I've several times been *this* close (holds up fingers so >> > you can't even see between them) to just remove checkpatch entirely. >> >> Agrh! What stopped you?! >> >> > I'm personally of the opinion that a lot of checkpatch "fixes" are >> > anything but. That mainly concerns fixing overlong lines (where the >> > "fixed" version is usually worse than the original), but it's been true >> > for some other warnings too. >> >> Speaking of driver, could authors please comment all those barrier() >> calls and remove trailing "return;" at the end of void functions. > >Why don't you make a patch to checkpatch.pl for those types of things? >:)
checkpatch would never allow a patch to patch checkpatch. --
unsubscribe notice
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to
majordomo@vger.kernel.org
More majordomo info at
http://vger.kernel.org/majordomo-info.html
Please read the FAQ at
http://www.tux.org/lkml/
Previous message: [
thread
] [
date
] [
author
]
Next message: [
thread
] [
date
] [
author
]
Messages in current thread:
[2.6 patch] infiniband/hw/nes/nes_verbs.c: fix off-by-one
, Adrian Bunk
, (Tue Feb 19, 6:59 pm)
Re: [ofa-general] [2.6 patch] infiniband/hw/nes/nes_verbs.c:...
, Roland Dreier
, (Wed Feb 20, 12:23 am)
Re: [ofa-general] [2.6 patch] infiniband/hw/nes/nes_verbs.c:...
, Adrian Bunk
, (Wed Feb 20, 1:57 am)
Re: [ofa-general] [2.6 patch] infiniband/hw/nes/nes_verbs.c:...
, Roland Dreier
, (Wed Feb 20, 7:21 pm)
RE: [ofa-general] [2.6 patch] infiniband/hw/nes/nes_verbs.c:...
, Glenn Streiff
, (Wed Feb 20, 7:27 pm)
RE: [ofa-general] [2.6 patch] infiniband/hw/nes/nes_verbs.c:...
, Glenn Streiff
, (Thu Feb 21, 8:39 am)
Re: [ofa-general] [2.6 patch] infiniband/hw/nes/nes_verbs.c:...
, Adrian Bunk
, (Thu Feb 21, 11:49 am)
Re: [ofa-general] [2.6 patch] infiniband/hw/nes/nes_verbs.c:...
, Roland Dreier
, (Thu Feb 21, 4:28 pm)
Merging of completely unreviewed drivers
, Adrian Bunk
, (Thu Feb 21, 5:01 pm)
Re: Merging of completely unreviewed drivers
, Arjan van de Ven
, (Thu Feb 21, 6:08 pm)
Re: Merging of completely unreviewed drivers
, Pavel Machek
, (Fri Feb 22, 2:40 pm)
Re: Merging of completely unreviewed drivers
, Jeff Garzik
, (Thu Feb 21, 6:33 pm)
Re: Merging of completely unreviewed drivers
, Adrian Bunk
, (Thu Feb 21, 7:40 pm)
Re: Merging of completely unreviewed drivers
, Greg KH
, (Thu Feb 21, 5:30 pm)
Re: Merging of completely unreviewed drivers
, Adrian Bunk
, (Thu Feb 21, 9:06 pm)
Re: Merging of completely unreviewed drivers
, Linus Torvalds
, (Thu Feb 21, 5:14 pm)
Re: Merging of completely unreviewed drivers
, Ingo Molnar
, (Fri Feb 22, 2:54 pm)
Re: Merging of completely unreviewed drivers
, Jeff Garzik
, (Fri Feb 22, 3:20 pm)
Re: Merging of completely unreviewed drivers
, Greg KH
, (Fri Feb 22, 3:44 pm)
Re: [ofa-general] Re: Merging of completely unreviewed drivers
, Bart Van Assche
, (Fri Feb 22, 3:11 pm)
Re: Merging of completely unreviewed drivers
, Krzysztof Halasa
, (Thu Feb 21, 7:38 pm)
Re: Merging of completely unreviewed drivers
, David Newall
, (Thu Feb 21, 9:46 pm)
Re: [ofa-general] Re: Merging of completely unreviewed drivers
, Bart Van Assche
, (Fri Feb 22, 8:29 am)
Re: [ofa-general] Re: Merging of completely unreviewed drivers
, David Newall
, (Fri Feb 22, 10:25 am)
Re: [ofa-general] Re: Merging of completely unreviewed drivers
, John W. Linville
, (Fri Feb 22, 11:48 am)
Re: [ofa-general] Re: Merging of completely unreviewed drivers
, Peter Zijlstra
, (Fri Feb 22, 11:17 am)
Re: [ofa-general] Re: Merging of completely unreviewed drivers
, Krzysztof Halasa
, (Fri Feb 22, 6:59 pm)
Re: [ofa-general] Re: Merging of completely unreviewed drivers
, Al Viro
, (Fri Feb 22, 7:14 pm)
Re: [ofa-general] Re: Merging of completely unreviewed drivers
, John W. Linville
, (Fri Feb 22, 12:48 pm)
Re: Merging of completely unreviewed drivers
, Al Viro
, (Thu Feb 21, 10:06 pm)
Re: Merging of completely unreviewed drivers
, Linus Torvalds
, (Thu Feb 21, 11:13 pm)
Re: Merging of completely unreviewed drivers
, Krzysztof Halasa
, (Fri Feb 22, 6:37 pm)
Re: Merging of completely unreviewed drivers
, Ray Lee
, (Fri Feb 22, 2:37 am)
Re: Merging of completely unreviewed drivers
, Jan Engelhardt
, (Sat Feb 23, 11:31 am)
Re: Merging of completely unreviewed drivers
, David Newall
, (Sat Feb 23, 11:22 pm)
Re: [ofa-general] Re: Merging of completely unreviewed drivers
, Junio C Hamano
, (Fri Feb 22, 2:29 am)
Re: [ofa-general] Re: Merging of completely unreviewed drivers
, Adrian Bunk
, (Fri Feb 22, 5:02 am)
Re: Merging of completely unreviewed drivers
, Krzysztof Halasa
, (Thu Feb 21, 10:23 pm)
Re: Merging of completely unreviewed drivers
, Al Viro
, (Thu Feb 21, 11:13 pm)
Re: Merging of completely unreviewed drivers
, Krzysztof Halasa
, (Fri Feb 22, 6:28 pm)
Re: Merging of completely unreviewed drivers
, Jörn
, (Sun Feb 24, 3:47 am)
Re: Merging of completely unreviewed drivers
, Krzysztof Halasa
, (Sun Feb 24, 10:47 am)
Re: Merging of completely unreviewed drivers
, Alan Cox
, (Thu Feb 21, 7:31 pm)
Re: Merging of completely unreviewed drivers
, Adrian Bunk
, (Thu Feb 21, 8:29 pm)
Re: Merging of completely unreviewed drivers
, Jeff Garzik
, (Thu Feb 21, 7:41 pm)
Re: Merging of completely unreviewed drivers
, Krzysztof Halasa
, (Thu Feb 21, 8:05 pm)
Re: Merging of completely unreviewed drivers
, Pavel Machek
, (Fri Feb 22, 2:45 pm)
Re: Merging of completely unreviewed drivers
, Krzysztof Halasa
, (Fri Feb 22, 6:44 pm)
Re: Merging of completely unreviewed drivers
, Pavel Machek
, (Sat Feb 23, 5:43 am)
Re: Merging of completely unreviewed drivers
, Krzysztof Halasa
, (Sat Feb 23, 9:58 am)
Re: Merging of completely unreviewed drivers
, David Newall
, (Sat Feb 23, 8:38 am)
Re: Merging of completely unreviewed drivers
, Linus Torvalds
, (Sat Feb 23, 1:33 pm)
Re: Merging of completely unreviewed drivers
, David Newall
, (Sat Feb 23, 11:26 pm)
Re: Merging of completely unreviewed drivers
, Linus Torvalds
, (Sun Feb 24, 12:47 am)
Re: Merging of completely unreviewed drivers
, Pavel Machek
, (Sat Feb 23, 11:25 am)
Re: Merging of completely unreviewed drivers
, David Newall
, (Sat Feb 23, 11:18 pm)
Re: Merging of completely unreviewed drivers
, Alan Cox
, (Fri Feb 22, 6:04 am)
Re: Merging of completely unreviewed drivers
, Jeff Garzik
, (Thu Feb 21, 8:44 pm)
Re: Merging of completely unreviewed drivers
, Krzysztof Halasa
, (Thu Feb 21, 10:02 pm)
Re: Merging of completely unreviewed drivers
, Alexey Dobriyan
, (Thu Feb 21, 6:33 pm)
Re: Merging of completely unreviewed drivers
, Greg KH
, (Thu Feb 21, 6:43 pm)
Re: Merging of completely unreviewed drivers
, Jan Engelhardt
, (Thu Feb 21, 7:31 pm)
Re: Merging of completely unreviewed drivers
, Alexey Dobriyan
, (Thu Feb 21, 6:58 pm)
Re: Merging of completely unreviewed drivers
, Jeff Garzik
, (Thu Feb 21, 6:57 pm)
Re: Merging of completely unreviewed drivers
, Roland Dreier
, (Thu Feb 21, 5:09 pm)
Navigation
Create content
Mailing list archives
Recent posts
Popular discussions
linux-kernel
:
Tony Lindgren
[PATCH 26/90] ARM: OMAP: abstract debug card setup (smc, leds)
Greg Kroah-Hartman
[PATCH 001/196] Chinese: Add the known_regression URI to the HOWTO
Vladislav Bolkhovitin
Re: Integration of SCST in the mainstream Linux kernel
Jesper Juhl
Re: Dual-Licensing Linux Kernel with GPL V2 and GPL V3
git
:
linux-netdev
:
Gerrit Renker
[PATCH 27/37] dccp: Integration of dynamic feature activation - part 2 (server side)
Jarek Poplawski
[PATCH] pkt_sched: Destroy gen estimators under rtnl_lock().
David Miller
[GIT]: Networking
Frans Pop
svc: failed to register lockdv1 RPC service (errno 97).
openbsd-misc
:
Colocation donated by:
Who's online
There are currently
1 user
and
865 guests
online.
Online users
zeekec
Syndicate