Re: Merging of completely unreviewed drivers

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: Adrian Bunk <bunk@...>
Cc: Roland Dreier <rdreier@...>, Linus Torvalds <torvalds@...>, Glenn Streiff <gstreiff@...>, Faisal Latif <flatif@...>, <linux-kernel@...>, <general@...>, Andrew Morton <akpm@...>
Date: Thursday, February 21, 2008 - 5:30 pm

On Thu, Feb 21, 2008 at 11:01:24PM +0200, Adrian Bunk wrote:


That was not a joke, I ment it.  Do you have proof that the majority of
patches going into the kernel tree are not reviewed by at least 2
people?  Now they might not be 2 people that you personally like/agree
with, but that's a totally different topic...

And I'm with Linus on this one, it's much easier to work on driver fixes
together with others, when they are in the kernel tree.

Although I do like the checkpatch.pl script, it has helped me in making
it easier to clean up some vendor-provided drivers recently, finding
some obvious coding style issues that I had missed the first pass
through.

thanks,

greg k-h
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
Merging of completely unreviewed drivers, Adrian Bunk, (Thu Feb 21, 5:01 pm)
Re: Merging of completely unreviewed drivers, Arjan van de Ven, (Thu Feb 21, 6:08 pm)
Re: Merging of completely unreviewed drivers, Pavel Machek, (Fri Feb 22, 2:40 pm)
Re: Merging of completely unreviewed drivers, Jeff Garzik, (Thu Feb 21, 6:33 pm)
Re: Merging of completely unreviewed drivers, Adrian Bunk, (Thu Feb 21, 7:40 pm)
Re: Merging of completely unreviewed drivers, Greg KH, (Thu Feb 21, 5:30 pm)
Re: Merging of completely unreviewed drivers, Adrian Bunk, (Thu Feb 21, 9:06 pm)
Re: Merging of completely unreviewed drivers, Linus Torvalds, (Thu Feb 21, 5:14 pm)
Re: Merging of completely unreviewed drivers, Ingo Molnar, (Fri Feb 22, 2:54 pm)
Re: Merging of completely unreviewed drivers, Jeff Garzik, (Fri Feb 22, 3:20 pm)
Re: Merging of completely unreviewed drivers, Greg KH, (Fri Feb 22, 3:44 pm)
Re: Merging of completely unreviewed drivers, Krzysztof Halasa, (Thu Feb 21, 7:38 pm)
Re: Merging of completely unreviewed drivers, David Newall, (Thu Feb 21, 9:46 pm)
Re: [ofa-general] Re: Merging of completely unreviewed drivers, John W. Linville, (Fri Feb 22, 11:48 am)
Re: [ofa-general] Re: Merging of completely unreviewed drivers, John W. Linville, (Fri Feb 22, 12:48 pm)
Re: Merging of completely unreviewed drivers, Al Viro, (Thu Feb 21, 10:06 pm)
Re: Merging of completely unreviewed drivers, Linus Torvalds, (Thu Feb 21, 11:13 pm)
Re: Merging of completely unreviewed drivers, Krzysztof Halasa, (Fri Feb 22, 6:37 pm)
Re: Merging of completely unreviewed drivers, Ray Lee, (Fri Feb 22, 2:37 am)
Re: Merging of completely unreviewed drivers, Jan Engelhardt, (Sat Feb 23, 11:31 am)
Re: Merging of completely unreviewed drivers, David Newall, (Sat Feb 23, 11:22 pm)
Re: Merging of completely unreviewed drivers, Krzysztof Halasa, (Thu Feb 21, 10:23 pm)
Re: Merging of completely unreviewed drivers, Al Viro, (Thu Feb 21, 11:13 pm)
Re: Merging of completely unreviewed drivers, Krzysztof Halasa, (Fri Feb 22, 6:28 pm)
Re: Merging of completely unreviewed drivers, Jörn, (Sun Feb 24, 3:47 am)
Re: Merging of completely unreviewed drivers, Krzysztof Halasa, (Sun Feb 24, 10:47 am)
Re: Merging of completely unreviewed drivers, Alan Cox, (Thu Feb 21, 7:31 pm)
Re: Merging of completely unreviewed drivers, Adrian Bunk, (Thu Feb 21, 8:29 pm)
Re: Merging of completely unreviewed drivers, Jeff Garzik, (Thu Feb 21, 7:41 pm)
Re: Merging of completely unreviewed drivers, Krzysztof Halasa, (Thu Feb 21, 8:05 pm)
Re: Merging of completely unreviewed drivers, Pavel Machek, (Fri Feb 22, 2:45 pm)
Re: Merging of completely unreviewed drivers, Krzysztof Halasa, (Fri Feb 22, 6:44 pm)
Re: Merging of completely unreviewed drivers, Pavel Machek, (Sat Feb 23, 5:43 am)
Re: Merging of completely unreviewed drivers, Krzysztof Halasa, (Sat Feb 23, 9:58 am)
Re: Merging of completely unreviewed drivers, David Newall, (Sat Feb 23, 8:38 am)
Re: Merging of completely unreviewed drivers, Linus Torvalds, (Sat Feb 23, 1:33 pm)
Re: Merging of completely unreviewed drivers, David Newall, (Sat Feb 23, 11:26 pm)
Re: Merging of completely unreviewed drivers, Linus Torvalds, (Sun Feb 24, 12:47 am)
Re: Merging of completely unreviewed drivers, Pavel Machek, (Sat Feb 23, 11:25 am)
Re: Merging of completely unreviewed drivers, David Newall, (Sat Feb 23, 11:18 pm)
Re: Merging of completely unreviewed drivers, Alan Cox, (Fri Feb 22, 6:04 am)
Re: Merging of completely unreviewed drivers, Jeff Garzik, (Thu Feb 21, 8:44 pm)
Re: Merging of completely unreviewed drivers, Krzysztof Halasa, (Thu Feb 21, 10:02 pm)
Re: Merging of completely unreviewed drivers, Alexey Dobriyan, (Thu Feb 21, 6:33 pm)
Re: Merging of completely unreviewed drivers, Greg KH, (Thu Feb 21, 6:43 pm)
Re: Merging of completely unreviewed drivers, Jan Engelhardt, (Thu Feb 21, 7:31 pm)
Re: Merging of completely unreviewed drivers, Alexey Dobriyan, (Thu Feb 21, 6:58 pm)
Re: Merging of completely unreviewed drivers, Jeff Garzik, (Thu Feb 21, 6:57 pm)
Re: Merging of completely unreviewed drivers, Roland Dreier, (Thu Feb 21, 5:09 pm)