Re: [PATCH 0/2] onlining cpus can break lockdep

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: Ingo Molnar <mingo@...>
Cc: <linux-kernel@...>, <akpm@...>, <glommer@...>, <pzijlstr@...>, <arjan@...>, Peter Zijlstra <a.p.zijlstra@...>
Date: Thursday, February 21, 2008 - 5:17 pm

Ingo Molnar wrote:

Sure. To make it clearer where the problem is, I also added the attached 
patch to my testing.

Trace is: (note the call to do_fork_idle)

INFO: trying to register non-static key.
the code is fine but needs lockdep annotation.
turning off the locking correctness validator.
key: ffff81003bdf9d18, name: c_idle.work
Pid: 11, comm: events/1 Not tainted 2.6.25-rc2 #129

Call Trace:
  [<ffffffff8104f757>] static_obj+0x5d/0x74
  [<ffffffff81052218>] __lock_acquire+0x8b5/0xc3e
  [<ffffffff81042e7f>] run_workqueue+0x84/0x1df
  [<ffffffff810529ef>] lock_acquire+0x91/0xbc
  [<ffffffff81042e90>] run_workqueue+0x95/0x1df
  [<ffffffff81291746>] do_fork_idle+0x0/0x20
  [<ffffffff81042ed4>] run_workqueue+0xd9/0x1df
  [<ffffffff81043951>] worker_thread+0x90/0x9b
  [<ffffffff8104632a>] autoremove_wake_function+0x0/0x2e
  [<ffffffff810438c1>] worker_thread+0x0/0x9b
  [<ffffffff8104620c>] kthread+0x47/0x73
  [<ffffffff812986c9>] trace_hardirqs_on_thunk+0x35/0x3a
  [<ffffffff8100d0e8>] child_rip+0xa/0x12
  [<ffffffff8100c67c>] restore_args+0x0/0x34
  [<ffffffff81046095>] kthreadd+0x14a/0x16f
  [<ffffffff81046095>] kthreadd+0x14a/0x16f
  [<ffffffff810461c5>] kthread+0x0/0x73
  [<ffffffff8100d0de>] child_rip+0x0/0x12
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[PATCH 0/2] onlining cpus can break lockdep, Glauber Costa, (Thu Feb 21, 4:40 pm)
Re: [PATCH 0/2] onlining cpus can break lockdep, Ingo Molnar, (Thu Feb 21, 5:12 pm)
Re: [PATCH 0/2] onlining cpus can break lockdep, Glauber Costa, (Thu Feb 21, 5:17 pm)
[PATCH 1/2] turn c_idle into a pointer, Glauber Costa, (Thu Feb 21, 4:40 pm)