Re: Merging of completely unreviewed drivers

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Roland Dreier
Date: Thursday, February 21, 2008 - 2:09 pm

> Is it really intended to merge drivers without _any_ kind of review?
 > 
 > This driver even lacks a basic "please fix the > 250 checkpatch errors" [1]
 > and similar low hanging fruits that could easily be spotted and then 
 > fixed by the submitter within a short amount of time.

Just to be clear, this driver was reviewed.  Many issues were found,
and many were fixed while others are being worked on.

It's a judgement call when to merge things, but in this case given the
good engagement from the vendor, I didn't see anything to be gained by
delaying the merge.

 - R.
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
Merging of completely unreviewed drivers, Adrian Bunk, (Thu Feb 21, 2:01 pm)
Re: Merging of completely unreviewed drivers, Roland Dreier, (Thu Feb 21, 2:09 pm)
Re: Merging of completely unreviewed drivers, Linus Torvalds, (Thu Feb 21, 2:14 pm)
Re: Merging of completely unreviewed drivers, Greg KH, (Thu Feb 21, 2:30 pm)
Re: Merging of completely unreviewed drivers, Arjan van de Ven, (Thu Feb 21, 3:08 pm)
Re: Merging of completely unreviewed drivers, Alexey Dobriyan, (Thu Feb 21, 3:33 pm)
Re: Merging of completely unreviewed drivers, Jeff Garzik, (Thu Feb 21, 3:33 pm)
Re: Merging of completely unreviewed drivers, Greg KH, (Thu Feb 21, 3:43 pm)
Re: Merging of completely unreviewed drivers, Jeff Garzik, (Thu Feb 21, 3:57 pm)
Re: Merging of completely unreviewed drivers, Alexey Dobriyan, (Thu Feb 21, 3:58 pm)
Re: Merging of completely unreviewed drivers, Jan Engelhardt, (Thu Feb 21, 4:31 pm)
Re: Merging of completely unreviewed drivers, Alan Cox, (Thu Feb 21, 4:31 pm)
Re: Merging of completely unreviewed drivers, Krzysztof Halasa, (Thu Feb 21, 4:38 pm)
Re: Merging of completely unreviewed drivers, Adrian Bunk, (Thu Feb 21, 4:40 pm)
Re: Merging of completely unreviewed drivers, Jeff Garzik, (Thu Feb 21, 4:41 pm)
Re: Merging of completely unreviewed drivers, Krzysztof Halasa, (Thu Feb 21, 5:05 pm)
Re: Merging of completely unreviewed drivers, Adrian Bunk, (Thu Feb 21, 5:29 pm)
Re: Merging of completely unreviewed drivers, Jeff Garzik, (Thu Feb 21, 5:44 pm)
Re: Merging of completely unreviewed drivers, Adrian Bunk, (Thu Feb 21, 6:06 pm)
Re: Merging of completely unreviewed drivers, David Newall, (Thu Feb 21, 6:46 pm)
Re: Merging of completely unreviewed drivers, Krzysztof Halasa, (Thu Feb 21, 7:02 pm)
Re: Merging of completely unreviewed drivers, Al Viro, (Thu Feb 21, 7:06 pm)
Re: Merging of completely unreviewed drivers, Krzysztof Halasa, (Thu Feb 21, 7:23 pm)
Re: Merging of completely unreviewed drivers, Al Viro, (Thu Feb 21, 8:13 pm)
Re: Merging of completely unreviewed drivers, Linus Torvalds, (Thu Feb 21, 8:13 pm)
Re: Merging of completely unreviewed drivers, Ray Lee, (Thu Feb 21, 11:37 pm)
Re: Merging of completely unreviewed drivers, Alan Cox, (Fri Feb 22, 3:04 am)
Re: Merging of completely unreviewed drivers, Pavel Machek, (Fri Feb 22, 11:40 am)
Re: Merging of completely unreviewed drivers, Pavel Machek, (Fri Feb 22, 11:45 am)
Re: Merging of completely unreviewed drivers, Ingo Molnar, (Fri Feb 22, 11:54 am)
Re: Merging of completely unreviewed drivers, Jeff Garzik, (Fri Feb 22, 12:20 pm)
Re: Merging of completely unreviewed drivers, Greg KH, (Fri Feb 22, 12:44 pm)
Re: Merging of completely unreviewed drivers, Krzysztof Halasa, (Fri Feb 22, 3:28 pm)
Re: Merging of completely unreviewed drivers, Krzysztof Halasa, (Fri Feb 22, 3:37 pm)
Re: Merging of completely unreviewed drivers, Krzysztof Halasa, (Fri Feb 22, 3:44 pm)
Re: Merging of completely unreviewed drivers, Pavel Machek, (Sat Feb 23, 2:43 am)
Re: Merging of completely unreviewed drivers, David Newall, (Sat Feb 23, 5:38 am)
Re: Merging of completely unreviewed drivers, Krzysztof Halasa, (Sat Feb 23, 6:58 am)
Re: Merging of completely unreviewed drivers, Pavel Machek, (Sat Feb 23, 8:25 am)
Re: Merging of completely unreviewed drivers, Jan Engelhardt, (Sat Feb 23, 8:31 am)
Re: Merging of completely unreviewed drivers, Linus Torvalds, (Sat Feb 23, 10:33 am)
Re: Merging of completely unreviewed drivers, David Newall, (Sat Feb 23, 8:18 pm)
Re: Merging of completely unreviewed drivers, David Newall, (Sat Feb 23, 8:22 pm)
Re: Merging of completely unreviewed drivers, David Newall, (Sat Feb 23, 8:26 pm)
Re: Merging of completely unreviewed drivers, Linus Torvalds, (Sat Feb 23, 9:47 pm)
Re: Merging of completely unreviewed drivers, Jörn, (Sun Feb 24, 12:47 am)
Re: Merging of completely unreviewed drivers, Krzysztof Halasa, (Sun Feb 24, 7:47 am)