Home » Mailing list archives » linux-kernel » 2008 » February » 21

[PATCH 0/2] onlining cpus can break lockdep

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: Glauber Costa <gcosta@...>
To: <linux-kernel@...>
Cc: <akpm@...>, <glommer@...>, <mingo@...>, <pzijlstr@...>, <arjan@...>
Subject: [PATCH 0/2] onlining cpus can break lockdep
Date: Thursday, February 21, 2008 - 4:40 pm

Hi,

While testing with hotplugging cpus today, I've came across a stack
trace generated by lockdep. The reason for that is that
do_boot_cpu() in smpboot_64.c ends up initializing a struct work_struct
variable in the stack.

These patches fix this by making it static. a per-cpu variable is choosen,
since, to the best of my knowledge, nothing prevents two cpus going up
at the same time, and so a single static c_idle won't do.

I separated it in two patches to better isolate the change. The first patch
just paves the way, by turning access to c_idle into pointer dereferences.
The second one does the real work.

Thanks


--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
[PATCH 0/2] onlining cpus can break lockdep, Glauber Costa, (Thu Feb 21, 4:40 pm)
Re: [PATCH 0/2] onlining cpus can break lockdep, Ingo Molnar, (Thu Feb 21, 5:12 pm)
Re: [PATCH 0/2] onlining cpus can break lockdep, Glauber Costa, (Thu Feb 21, 5:17 pm)
[PATCH 1/2] turn c_idle into a pointer, Glauber Costa, (Thu Feb 21, 4:40 pm)
[PATCH 2/2] make work have a static address in do_boot_cpu(), Glauber Costa, (Thu Feb 21, 4:40 pm)
Re: [PATCH 2/2] make work have a static address in do_boot_c..., Peter Zijlstra, (Thu Feb 21, 6:12 pm)
Re: [PATCH 2/2] make work have a static address in do_boot_c..., Glauber Costa, (Thu Feb 21, 6:57 pm)
Re: [PATCH 2/2] make work have a static address in do_boot_c..., Ingo Molnar, (Fri Feb 22, 5:46 am)