Re: [PATCH 2/2] xen pvfb: Para-virtual framebuffer, keyboard and pointer driver

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: Markus Armbruster <armbru@...>
Cc: <linux-kernel@...>, <xen-devel@...>, <linux-fbdev-devel@...>, <dmitry.torokhov@...>, <virtualization@...>, <linux-input@...>, <adaplas@...>, <akpm@...>, <jayakumar.lkml@...>
Date: Thursday, February 21, 2008 - 4:31 pm

Markus Armbruster wrote:

Unless they're actually inter-dependent, could you post this as two 
separate patches?  I don't know anything about these parts of the 
kernel, so it would be nice to make it very obvious which changes are fb 
vs mouse/keyboard.

(I guess input/* vs video/* should make it obvious, but it looks like 
input has a config dependency on fb, so I'll avoid making too many 
presumptions...)

(Couple of comments below)

    J


This is happy if dev->info is only partially initialized?


Does this free kdb and ptr?


--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[PATCH 2/2] xen pvfb: Para-virtual framebuffer, keyboard and..., Markus Armbruster, (Thu Feb 21, 5:43 am)
Re: [PATCH 2/2] xen pvfb: Para-virtual framebuffer, keyboard..., Jeremy Fitzhardinge, (Thu Feb 21, 4:31 pm)
Re: [PATCH 2/2] xen pvfb: Para-virtual framebuffer, keyboard..., Markus Armbruster, (Fri Feb 22, 2:31 am)
Re: [PATCH 2/2] xen pvfb: Para-virtual framebuffer, keyboard..., Jeremy Fitzhardinge, (Fri Feb 22, 6:31 pm)