Re: [PATCH] x86: cleanup - use PAGE_SIZE instead of numeric constant in boot code

view
thread

!MAILaRCHIVE_VOTE_RePLACE

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

[view in full thread]

From: Cyrill Gorcunov <gorcunov@...>

To: H. Peter Anvin <hpa@...>

Cc: Ingo Molnar <mingo@...>, Thomas Gleixner <tglx@...>, LKML <linux-kernel@...>

Subject: Re: [PATCH] x86: cleanup - use PAGE_SIZE instead of numeric constant in boot code

Date: Thursday, February 21, 2008 - 4:00 pm

[H. Peter Anvin - Thu, Feb 21, 2008 at 11:59:28AM -0800]
quoted text> Cyrill Gorcunov wrote:
>> [H. Peter Anvin - Thu, Feb 21, 2008 at 11:52:56AM -0800]
>>> Cyrill Gorcunov wrote:
>>>> This patch replaces 4096 numeric constant with PAGE_SIZE macro.
>>>> Signed-off-by: Cyrill Gorcunov <gorcunov@gmail.com>
>>>> ---
>>>> Text segments of old and new files *are* the same so
>>>> it wouldn't break current kernel.
>>> NAK.
>>>
>>> This is NOT PAGE_SIZE (even though the two values are coincidentally the 
>>> same, for historical reasons.)
>>>
>>> 	-hpa
>>>
>> hmm, why the comment on boot_param structure definition calls
>> it "zeropage"? Anyway really thanks for review and catched this.
>
> Historical reasons... it used to be a "magic page" -- that's long since 
> gone.
>
> 	-hpa
>

Thanks Peter, my fault.

		- Cyrill -
--
unsubscribe noticeTo unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:

[PATCH] x86: cleanup - use PAGE_SIZE instead of numeric cons..., Cyrill Gorcunov, (Thu Feb 21, 3:50 pm)

Re: [PATCH] x86: cleanup - use PAGE_SIZE instead of numeric ..., H. Peter Anvin, (Thu Feb 21, 3:52 pm)

Re: [PATCH] x86: cleanup - use PAGE_SIZE instead of numeric ..., Cyrill Gorcunov, (Thu Feb 21, 3:56 pm)

Re: [PATCH] x86: cleanup - use PAGE_SIZE instead of numeric ..., H. Peter Anvin, (Thu Feb 21, 3:59 pm)

Re: [PATCH] x86: cleanup - use PAGE_SIZE instead of numeric ..., Cyrill Gorcunov, (Thu Feb 21, 4:00 pm)

Re: [PATCH] x86: cleanup - use PAGE_SIZE instead of numeric ..., H. Peter Anvin, (Thu Feb 21, 4:05 pm)

Navigation

Popular discussions


linux-kernel:

Greg KH	[GIT PATCH] driver core patches against 2.6.24
debian developer	Re: Dual-Licensing Linux Kernel with GPL V2 and GPL V3
Adrian Bunk	Re: LSM conversion to static interface
git:

linux-netdev:
Gerrit Renker	[PATCH 26/37] dccp: Integration of dynamic feature activation - part 1 (socket set...
Jarek Poplawski	Re: [PATCH] pkt_sched: Destroy gen estimators under rtnl_lock().
Frans Pop	svc: failed to register lockdv1 RPC service (errno 97).
Linus Torvalds	Re: [GIT]: Networking
openbsd-misc:

Colocation donated by:

Online users

Syndicate