Re: [PATCH] x86: cleanup - use PAGE_SIZE instead of numeric constant in boot code

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

To: Cyrill Gorcunov <gorcunov@...>

Cc: Ingo Molnar <mingo@...>, Thomas Gleixner <tglx@...>, LKML <linux-kernel@...>

Subject: Re: [PATCH] x86: cleanup - use PAGE_SIZE instead of numeric constant in boot code

Date: Thursday, February 21, 2008 - 3:59 pm

Cyrill Gorcunov wrote:
quoted text> [H. Peter Anvin - Thu, Feb 21, 2008 at 11:52:56AM -0800]
>> Cyrill Gorcunov wrote:
>>> This patch replaces 4096 numeric constant with PAGE_SIZE macro.
>>> Signed-off-by: Cyrill Gorcunov <gorcunov@gmail.com>
>>> ---
>>> Text segments of old and new files *are* the same so
>>> it wouldn't break current kernel.
>> NAK.
>>
>> This is NOT PAGE_SIZE (even though the two values are coincidentally the 
>> same, for historical reasons.)
>>
>> 	-hpa
>>
> 
> hmm, why the comment on boot_param structure definition calls
> it "zeropage"? Anyway really thanks for review and catched this.
> 

Historical reasons... it used to be a "magic page" -- that's long since 
gone.

	-hpa
--
unsubscribe noticeTo unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:

[PATCH] x86: cleanup - use PAGE_SIZE instead of numeric cons..., Cyrill Gorcunov, (Thu Feb 21, 3:50 pm)

Re: [PATCH] x86: cleanup - use PAGE_SIZE instead of numeric ..., H. Peter Anvin, (Thu Feb 21, 3:52 pm)

Re: [PATCH] x86: cleanup - use PAGE_SIZE instead of numeric ..., Cyrill Gorcunov, (Thu Feb 21, 3:56 pm)

Re: [PATCH] x86: cleanup - use PAGE_SIZE instead of numeric ..., H. Peter Anvin, (Thu Feb 21, 3:59 pm)

Re: [PATCH] x86: cleanup - use PAGE_SIZE instead of numeric ..., Cyrill Gorcunov, (Thu Feb 21, 4:00 pm)

Re: [PATCH] x86: cleanup - use PAGE_SIZE instead of numeric ..., H. Peter Anvin, (Thu Feb 21, 4:05 pm)


linux-kernel:
Greg KH	Re: Dual-Licensing Linux Kernel with GPL V2 and GPL V3
Greg Kroah-Hartman	[PATCH 006/196] Chinese: add translation of oops-tracing.txt
Luciano Rocha	usb hdd problems with 2.6.27.2
Roland Dreier	Re: Integration of SCST in the mainstream Linux kernel
git:

linux-netdev:

Gerrit Renker	[PATCH 15/37] dccp: Set per-connection CCIDs via socket options
David Miller	[GIT]: Networking
Natalie Protasevich	[BUG] New Kernel Bugs
openbsd-misc:

Re: [PATCH] x86: cleanup - use PAGE_SIZE instead of numeric constant in boot code

Online users