login
Login
/
Register
Search
Forums
News
Blogs
Features
Site
Home
»
Mailing list archives
»
linux-kernel
»
2008
»
February
»
21
Re: [PATCH] x86: cleanup - use PAGE_SIZE instead of numeric constant in boot code
view
thread
!MAILaRCHIVE_VOTE_RePLACE
Previous message: [
thread
] [
date
] [
author
]
Next message: [
thread
] [
date
] [
author
]
[view in full thread]
From:
Cyrill Gorcunov <gorcunov@...>
To: H. Peter Anvin <hpa@...>
Cc: Ingo Molnar <mingo@...>, Thomas Gleixner <tglx@...>, LKML <linux-kernel@...>
Subject:
Re: [PATCH] x86: cleanup - use PAGE_SIZE instead of numeric constant in boot code
Date: Thursday, February 21, 2008 - 3:56 pm
[H. Peter Anvin - Thu, Feb 21, 2008 at 11:52:56AM -0800]
quoted text
> Cyrill Gorcunov wrote: >> This patch replaces 4096 numeric constant with PAGE_SIZE macro. >> Signed-off-by: Cyrill Gorcunov <gorcunov@gmail.com> >> --- >> Text segments of old and new files *are* the same so >> it wouldn't break current kernel. > > NAK. > > This is NOT PAGE_SIZE (even though the two values are coincidentally the > same, for historical reasons.) > > -hpa >
hmm, why the comment on boot_param structure definition calls it "zeropage"? Anyway really thanks for review and catched this. - Cyrill - --
unsubscribe notice
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to
majordomo@vger.kernel.org
More majordomo info at
http://vger.kernel.org/majordomo-info.html
Please read the FAQ at
http://www.tux.org/lkml/
Previous message: [
thread
] [
date
] [
author
]
Next message: [
thread
] [
date
] [
author
]
Messages in current thread:
[PATCH] x86: cleanup - use PAGE_SIZE instead of numeric cons...
, Cyrill Gorcunov
, (Thu Feb 21, 3:50 pm)
Re: [PATCH] x86: cleanup - use PAGE_SIZE instead of numeric ...
, H. Peter Anvin
, (Thu Feb 21, 3:52 pm)
Re: [PATCH] x86: cleanup - use PAGE_SIZE instead of numeric ...
, Cyrill Gorcunov
, (Thu Feb 21, 3:56 pm)
Re: [PATCH] x86: cleanup - use PAGE_SIZE instead of numeric ...
, H. Peter Anvin
, (Thu Feb 21, 3:59 pm)
Re: [PATCH] x86: cleanup - use PAGE_SIZE instead of numeric ...
, Cyrill Gorcunov
, (Thu Feb 21, 4:00 pm)
Re: [PATCH] x86: cleanup - use PAGE_SIZE instead of numeric ...
, H. Peter Anvin
, (Thu Feb 21, 4:05 pm)
Navigation
Create content
Mailing list archives
Recent posts
Popular discussions
linux-kernel
:
Srivatsa Vaddagiri
containers (was Re: -mm merge plans for 2.6.23)
Greg KH
[GIT PATCH] driver core patches against 2.6.24
Tarkan Erimer
Re: Dual-Licensing Linux Kernel with GPL V2 and GPL V3
Benjamin Herrenschmidt
Re: [PATCH] Remove process freezer from suspend to RAM pathway
git
:
linux-netdev
:
Jarek Poplawski
[PATCH take 2] pkt_sched: Protect gen estimators under est_lock.
David Miller
[GIT]: Networking
Gerhard Pircher
3c59x: shared interrupt problem
Gerrit Renker
[PATCH 27/37] dccp: Integration of dynamic feature activation - part 2 (server side)
openbsd-misc
:
Colocation donated by:
Who's online
There are currently
4 users
and
830 guests
online.
Online users
strcmp
maheshdm
sethchen7712
samualwatson12
Syndicate